On Thu, Nov 22, 2018 at 06:49:53PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 18:19, Greg Kroah-Hartman wrote: > > On Tue, Nov 20, 2018 at 10:34:16PM +0800, Gao Xiang wrote: > >> `trace_erofs_readpage' should be placed in .readpage() > >> rather than in the internal `z_erofs_do_read_page'. > > Why? What happens with the code today? > trace_erofs_readpage is used to trace .readpage() interface (it represents > sync read) > hook rather than its internal implementation z_erofs_do_read_page (which both > .readpage() > and .readpages() uses it). Chen Gong places the tracepoint to a wrong place > by mistake. > And we found it by our internal test using this tracepoint.
Ok, you should put this in the changelog text when you redo this series. thanks, greg k-h _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
