[PATCH 36/36] staging: unisys: include: channel.h: Fix #define formatting

2017-03-17 Thread David Kershner
Sell The amount of whitespace used between the and the is dependent on what is needed to make the surrounding #define directives as uniform as possible. Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/include/channel.h | 22 +++--- 1 file

[PATCH 14/36] staging: unisys: include: Change out-of-date references

2017-03-17 Thread David Kershner
From: David Binder Replace references to virtpci to visornic in iochannel.h. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/iochannel.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 11/36] staging: unisys: include: Remove unused visorchannel #defines

2017-03-17 Thread David Kershner
From: David Binder Removes unused #defines pertaining to visorchannel UUIDs. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/channel.h | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/staging/unisys

[PATCH 03/36] staging: unisys: visorbus: removed unused structure pci_id

2017-03-17 Thread David Kershner
From: Sameer Wadgaonkar Removed unused structure pci_id from controlvmchannel.h Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/controlvmchannel.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers

[PATCH 23/36] staging: unisys: include: remove irrelevant comments

2017-03-17 Thread David Kershner
From: Jon Frisch This patch removes comments that are no longer relevant in channel.h. Signed-off-by: Jon Frisch Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/channel.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging

[PATCH 07/44] staging: unisys: visorbus: add error handling to boottotool_show

2017-03-28 Thread David Kershner
Don't just drop the error from visorchannel_read on the floor, report it. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/staging/u

[PATCH 00/44] staging: unisys: Add additional error handling to the s-Par drivers

2017-03-28 Thread David Kershner
This series primarily concentrates on adding additional error handling so that the s-Par drivers can correctly handle the errors at a centralized location instead of doing it inconsistently scattered throughout the source tree. David Kershner (43): staging: unisys: visorbus

[PATCH 02/44] staging: unisys: visorbus: add error handling to handle_command

2017-03-28 Thread David Kershner
Add error handling to the function handle_command. Since handle_command now returns errors, we need to process them correctly in process_controlvm_event. Note: It is invalid to have a controlvm test message in the event queue, so return -EINVAL if one is discovered. Signed-off-by: David

[PATCH 06/44] staging: unisys: visorbus: add error handling to toolaction_show

2017-03-28 Thread David Kershner
Don't just drop the error from visorchannel_read on the floor, report it. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/u

[PATCH 05/44] staging: unisys: visorbus: add error handling around kobject_uevent

2017-03-28 Thread David Kershner
The function kobject_uevent_env can return an error, pass that error to the caller so it can be handled correctly. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 26 +++ 1 file changed, 16 insertions(+), 10

[PATCH 01/44] staging: unisys: visorbus: parahotplug_process_message add error handling

2017-03-28 Thread David Kershner
Add error handling to the parahotplug_process_message function so that it returns the proper error. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a

[PATCH 11/44] staging: unisys: visorbus: move bus_device_info_init to visorbus_main.c

2017-03-28 Thread David Kershner
The function bus_device_info_init was defined in visorbus_private.h. The only file that uses it is visorbus_main.c so move the function into the .c file instead. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c| 16

[PATCH 04/44] staging: unisys: visorbus: add error handling for parahotplug_request_kickoff

2017-03-28 Thread David Kershner
The function kobject_uevent_env returns an error we shouldn't just drop it on the floor but we should report it back to the caller. Since it now returns an error, need to add proper error handling to parahotplug_process_message. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim

[PATCH 12/44] staging: unisys: visorbus: remove invalid comment, we are one driver.

2017-03-28 Thread David Kershner
Removed a comment that was describing the relationship between the visorchipset driver and the visorbus driver. Since they are now one driver the comment no longer makes sense. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c

[PATCH 17/44] staging: unisys: visorbus: remaining_steps convert ret to err

2017-03-28 Thread David Kershner
The ret variable was only returning an error, so changing it to err to be more consistent across the file. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 10/44] staging: unisys: visorbus: add error handling to remaining_steps_show

2017-03-28 Thread David Kershner
Don't just drop the error from visorchannel_read on the floor, report it. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/u

[PATCH 20/44] staging: unisys: visornic: add error handling for visorchannel_signalinsert/remove

2017-03-28 Thread David Kershner
Since signalinsert/remove now return valid error codes, we need to check them when we call them in visornic. The error codes need to propagate out to the calling functions. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visornic/visornic_main.c

[PATCH 08/44] staging: unisys: visorbus: add error handling to error_show

2017-03-28 Thread David Kershner
Don't just drop the error from visorchannel_read on the floor, report it. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/u

[PATCH 22/44] staging: unisys: visorbus: consolidate bus_responder and device_responder

2017-03-28 Thread David Kershner
With all the code churn, bus_responder and device_responder have become identical, consolidate them to the same function. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 50 ++- 1 file changed, 18 insertions

[PATCH 16/44] staging: unisys: visorbus: textid_store convert ret to err

2017-03-28 Thread David Kershner
The ret variable was only returning an error, so changing it to err to be more consistent across the file. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 18/44] staging: unisys: visorbus: add error handling to chipset_bus_create

2017-03-28 Thread David Kershner
The function chipset_bus_create should return an error. If an error is returned, it is assumed the response has not been sent by bus_create. Correctly handle when the error has been returned in visorchipset. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging

[PATCH 14/44] staging: unisys: visorbus: boottotool convert ret to err

2017-03-28 Thread David Kershner
The ret variable was only returning an error, so changing it to err to be more consistent across the file. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 15/44] staging: unisys: visorbus: error_store convert ret to err

2017-03-28 Thread David Kershner
The ret variable was only returning an error, so changing it to err to be more consistent across the file. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 26/44] staging: unisys: visorbus: add error handling for dev_start_periodic_work

2017-03-28 Thread David Kershner
Report errors if we have a problem in dev_start_periodic_work. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorbus

[PATCH 21/44] staging: unisys: visorbus: add error handling for chipset_device_create

2017-03-28 Thread David Kershner
Adds error handling to the chipset_device_create message. If it returns a failure, it is assumed it has not signaled the s-Par firmware of the failure and the caller must do that. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus

[PATCH 23/44] staging: unisys: visorbus: move vbuschannel_print_devinfo from .h to .c file

2017-03-28 Thread David Kershner
Move vbuschannel_print_devinfo from vbuchannel.h to visorbus_main.c since it is only referenced in visorbus_main.c. Since it is in a .c file, get rid of the inline for it. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/vbuschannel.h | 35

[PATCH 24/44] staging: unisys: visorbus: get rid of shouting SPAR_VBUS_CHANNEL_CLIENT_OK macro

2017-03-28 Thread David Kershner
The macro SPAR_VBUS_CHANNEL_CLIENT_OK was noisy and only used in one place so get rid of it. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/vbuschannel.h | 8 drivers/staging/unisys/visorbus/visorbus_main.c | 8 +++- 2 files

[PATCH 19/44] staging: unisys: visorbus: add __packed to structures in controlvmchannel.h

2017-03-28 Thread David Kershner
From: Sameer Wadgaonkar Added the __packed keyword to all structures in controlvmchannel.h to ensure alignment and size in memory. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/controlvmchannel.h | 58

[PATCH 25/44] staging: unisys: remove client from spar_check_channel

2017-03-28 Thread David Kershner
We only have one version of spar_check_channel, get rid of the client at the end and help save space. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/include/channel.h | 12 +-- drivers/staging/unisys/include/iochannel.h

[PATCH 30/44] staging: unisys: visorbus: get rid of unused parameter forcematch

2017-03-28 Thread David Kershner
The forcematch parameter was not being used, so get rid of it. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b

[PATCH 28/44] staging: unisys: visorbus: fix error handling in create_bus_instance

2017-03-28 Thread David Kershner
The function get_vbus_header_info returns errors that were being handled incorrectly. Fix the error handling in create_bus_instance. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 39 ++ 1 file changed, 14

[PATCH 29/44] staging: unisys: visorbus: get rid of create_bus_type.

2017-03-28 Thread David Kershner
Create bus_type was just calling register_bustype. Since we control how many times we call create_bus_type it was extraneous keeping a counter if the bus was already registered, so the functions were no longer needed. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers

[PATCH 32/44] staging: unisys: visorbus: cleanup error handling in visorbus_uevent

2017-03-28 Thread David Kershner
The add_uevent_var returns an error. Don't overwrite the error with -ENOMEM, just pass the error code back up. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

[PATCH 31/44] staging: unisys: visorbus: get rid of unused parameter forcenomatch

2017-03-28 Thread David Kershner
The forcenomatch parameter was not being used, so get rid of it. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b

[PATCH 37/44] staging: unisys: visorbus: add error handling to chipset_device_pause/resume

2017-03-28 Thread David Kershner
If there is an error in chipset_device_pause/resume don't try to respond, error out and let the calling functions respond to this error just like any other error they encounter. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_m

[PATCH 40/44] staging: unisys: visorbus: remove useless ifdef

2017-03-28 Thread David Kershner
We shouldn't be checking if VMCALL_CONTROLVM_ADDR is defined, remove it. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/vmcallinterface.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/unisys/vis

[PATCH 33/44] staging: unisys: visorbus: check for err from dev_set_name

2017-03-28 Thread David Kershner
The function dev_set_name can return an error, don't just ignore it. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/vis

[PATCH 35/44] staging: unisys: visorbus: don't unregister if we failed to register

2017-03-28 Thread David Kershner
If we fail to register the visordriver, don't call unregister, just return with the error. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/dr

[PATCH 39/44] staging: unisys: visorbus: consolidate if statements

2017-03-28 Thread David Kershner
We had several if statements inside of if statements that should be consolidated into an if statement with an && to clean up the code some more. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchannel.c | 18 ++

[PATCH 43/44] staging: unisys: visorbus: move unisys_vmcall into visorchipset

2017-03-28 Thread David Kershner
The only one using unisys_vmcall was visorchipset.c, it can be moved into the visorchipset file directly instead of being in a header file. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c| 21 +++- drivers

[PATCH 44/44] staging: unisys: visorbus: Have unisys_vmcall return Linux error instead of VMCALL error

2017-03-28 Thread David Kershner
ve to drop it but we can send it up the stack. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c| 33 +++- drivers/staging/unisys/visorbus/vmcallinterface.h | 10 - 2 files changed, 32 insertions(+), 11 dele

[PATCH 42/44] staging: unisys: visorbus: Update vmcallinterface comment

2017-03-28 Thread David Kershner
The comment at the beginning of the vmcallinterface.h file references IO Virtualization. It should be more specific that it is referencing s-Par Virtualization. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/vmcallinterface.h | 6 +++--- 1

[PATCH 34/44] staging: unisys: visorbus: don't ignore visorchannel_read error

2017-03-28 Thread David Kershner
Don't override the visorchannel_read_error, just return the error that it generates. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/dr

[PATCH 13/44] staging: unisys: visorbus: convert ret to err to be consistent

2017-03-28 Thread David Kershner
The ret variable was only returning an error, so changing it to err to be more consistent across the file. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 41/44] staging: unisys: visorbus: get rid of ISSUE_IO_VMCALL

2017-03-28 Thread David Kershner
The macro ISSUE_IO_VMCALL was a wrapper around the function unisys_vmcall. It doesn't need to exist and was just being noisy, so get rid of it. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c| 2 +- drivers/staging/u

[PATCH 09/44] staging: unisys: visorbus: add error handling textid_show

2017-03-28 Thread David Kershner
Don't just drop the error from visorchannel_read on the floor, report it. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/st

[PATCH 27/44] staging: unisys: visorbus: add error handling visorbus_enable_channel_interrupt

2017-03-28 Thread David Kershner
Add error handling to visorbus_enable_channel_interrupt. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/include/visorbus.h | 2 +- drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions

[PATCH 03/44] staging: unisys: visorbus: add error handling to controlvm_periodic_work

2017-03-28 Thread David Kershner
The function controlvm_periodic_work should handle errors appropriately. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 67 +-- 1 file changed, 32 insertions(+), 35 deletions(-) diff --git a/drivers/staging

[PATCH 38/44] staging: unisys: visorbus: get rid of braces around single statements

2017-03-28 Thread David Kershner
Remove braces around single line if statements, they are not needed. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorbus

[PATCH 36/44] staging: unisys: visorbus: add error handling to initiate_chipset_device_pause_resume

2017-03-28 Thread David Kershner
Clean up the function to remove some if statments that should be done in the calling function. Signed-off-by: David Kershner Reviewed-by: Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 74 +++--- 1 file changed, 32 insertions(+), 42 deletions(-) diff

[PATCH] staging: unisys: visorbus: fix kernel BUG discovered by day0 testing

2017-03-30 Thread David Kershner
rivers: visorhba, visornic, or visorinput. This reverts commit 5b6f9b95f7ae ("staging: unisys: visorbus: get rid of create_bus_type.") Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 32 ++--- 1 file ch

[PATCH v2] staging: unisys: visorbus: fix kernel BUG discovered by day0 testing

2017-03-31 Thread David Kershner
rivers: visorhba, visornic, or visorinput. Checked to see if we have called bus_register, if not do not call driver_register. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- - Changes from v1 - Made changes suggested by GregKH. Instead of reverting patch, just added the check fo

[PATCH v3] staging: unisys: visorbus: fix kernel BUG discovered by day0 testing

2017-03-31 Thread David Kershner
rivers: visorhba, visornic, or visorinput. Checked to see if we have called bus_register, if not do not call driver_register. Signed-off-by: David Kershner Reviewed-by: Tim Sell Reviewed-by: David Binder --- - Changes from v1 - Made changes suggested by GregKH. Instead of reverting patch, just

[PATCH 01/25] staging: unisys: visorbus: combine response functions into a single one

2017-04-18 Thread David Kershner
There are several different controlvm response functions, consolidate them to one so we can simplify error handling. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 53 +++ 1 file changed, 22 insertions(+), 31 deletions

[PATCH 02/25] staging: unisys: visornic: remove keyword inline from function

2017-04-18 Thread David Kershner
Functions in c files don't need to be inlined, get rid of the keyword. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visornic/visornic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visornic/visornic_main

[PATCH 04/25] staging: unisys: visorbus: fixed indentation

2017-04-18 Thread David Kershner
Moved the brace to the left to fix the indentation issue. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging

[PATCH 06/25] staging: unisys: visorbus: add timeout to controlvm_periodic_work

2017-04-18 Thread David Kershner
Limit the amount that gets pulled from the queue on each try so we don't get stuck in an infinite loop if something has gone wrong with the s-Par firmware. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 3 ++- 1 file chang

[PATCH 00/25] staging: unisys: Remove POSTCODEs and allow boot with CONFIG_VMAP_STACK set to y

2017-04-18 Thread David Kershner
The following patch series removes the POSTCODE macros from the codebase, replacing them with dev_err where needed. It also fixes a problem with the drivers that were preventing them from working when CONFIG_VMAP_STACK was set to y. David Kershner (23): staging: unisys: visorbus: combine

[PATCH 05/25] staging: unisys: visorbus: update comment

2017-04-18 Thread David Kershner
Comment was outdated and did not reflect what was actually happening. Update the comment to reflect reality. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git

[PATCH 03/25] staging; unisys: visorbus: replace uint32 with int

2017-04-18 Thread David Kershner
Shouldn't use uint32 in the kernel, it can be replaced with int here. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset

[PATCH 07/25] staging: unisys: visorbus: handle visorchannel_write errors in code

2017-04-18 Thread David Kershner
Catch and report back errors when visorchannel_write fails. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchannel.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/staging/unisys/visorbus

[PATCH 08/25] staging: unisys: visorbus: remove NORETRY

2017-04-18 Thread David Kershner
Allow retry when allocating memory. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus

[PATCH 09/25] staging: unisys: visorbus: remove POSTCODE from create_visor_device

2017-04-18 Thread David Kershner
Remove POSTCODES from create_visor_device, when we fail log an error with dev_err. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/unisys

[PATCH 11/25] staging: unisys: visorbus: remove POSTCODE in create_bus_instance

2017-04-18 Thread David Kershner
Remove postcodes from create_bus_instance. If there is an error log it with dev_err. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/unisys

[PATCH 10/25] staging: unisys: visorbus: remove POSTCODE from chispet_init

2017-04-18 Thread David Kershner
Get rid of the postcodes from the function chipset_init. They were being noisy, so don't replace them with errors. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/u

[PATCH 17/25] staging: unisys: visorbus: remove POSTCODEs from bus_create

2017-04-18 Thread David Kershner
Removed the POSTCODEs from the function bus_create. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b

[PATCH 16/25] staging: unisys: visorbus: get rid of POSTCODEs in save_crash_msg

2017-04-18 Thread David Kershner
Replace POSTCODES in save_crash_msg with dev_err handling. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 24 +-- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/unisys/visorbus

[PATCH 13/25] staging: unisys: visorbus: remove noisy postcode in bus_destroy

2017-04-18 Thread David Kershner
Since kzalloc will display error the postcode becomes redundant, it can be removed. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b

[PATCH 12/25] staging: unisys: visorbus: remove noisy postcodes

2017-04-18 Thread David Kershner
Get rid of postcodes from visorbus_main.c that are just informational. They were not logging errors, we don't need to replace them with anything. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 21 +- 1 file chang

[PATCH 21/25] staging: unisys: visorbus: refactor setup_crash_devices_work_queue

2017-04-18 Thread David Kershner
The if statement was sending us down the happy path with the error path in the else. This can be simplified by having the if be the error and just falling through with the good path. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 11

[PATCH 15/25] staging: unisys: visorbus: remove postcodes in visorbus_init

2017-04-18 Thread David Kershner
Remove the POSTCODES in visorbus_init. Since there are no more POSTCODES in visorbus_main.c we can remove the reference to the vmcallinterface header file. No need for vmcallinterface in visorbus_main.c Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus

[PATCH 18/25] staging: unisys: visorbus: remove POSTCODE from bus_configure

2017-04-18 Thread David Kershner
Remove the POSTCODE logging from bus_configure, replace it with an error message if we fail dumping the errno. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff

[PATCH 20/25] staging: unisys: visorbus: get rid of POSTCODES in my_device_changestate

2017-04-18 Thread David Kershner
Replace POSTCODEs with dev_err in the function my_device_changestate. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b

[PATCH 22/25] staging: unisys: visorbus: remove postcodes in setup_crash_devices_work_queue

2017-04-18 Thread David Kershner
Replace postcodes with dev_err in the function setup_crash_device_work_queue. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 33 --- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/drivers/staging/unisys

[PATCH 14/25] staging: unisys: visorbus: remove noisy postcode from visorchipset_exit

2017-04-18 Thread David Kershner
The postcodes in visorchipset_exit were not displaying errors, they can just be removed. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c

[PATCH 19/25] staging: unisys: visorbus: remove POSTCODE from my_device_create

2017-04-18 Thread David Kershner
Replace the POSTCODEs with dev_err in my_device_create. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 24 +++ 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c

[PATCH 24/25] staging: unisys: visorbus: fix s-Par to boot with option CONFIG_VMAP_STACK set to y

2017-04-18 Thread David Kershner
n stack in issue_vmcall_io_controlvm_addr() to vmcall_controlvm_addr struct. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchipset.c | 33 ++- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/staging/unisys/visorbus/viso

[PATCH 23/25] staging: unisys: visorbus: remove POSTCODE from visorchipset_init

2017-04-18 Thread David Kershner
Remove POSTCODEs from visorchipset_init and replace them with dev_err when needed. Since there are no more POSTCODEs in the code, we can get rid of the data in the header file as well. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c

[PATCH 25/25] staging: unisys: visorhba: fix s-Par to boot with option CONFIG_VMAP_STACK set to y

2017-04-18 Thread David Kershner
xstat() to heap memory. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/visorhba/visorhba_main.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisy

[PATCH 00/25] staging: unisys: visorbus: Change function names to be consistent with namespace

2017-05-19 Thread David Kershner
The s-Par visorbus driver had several functions with extremely generic names. This series attempts to clean up the names by making them more unique. This series also addresses other miscellaneous feedback. Jon Frisch (1): staging: unisys: visorbus: rename typ to cr_type Sameer Wadgaonkar (24):

[PATCH 02/25] staging: unisys: visorbus: renamed functions bus_create, bus_destroy and bus_configure to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed the functions bus_create() to visorbus_create(), bus_destroy() to visorbus_destroy() and bus_configure() to visorbus_configure Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus

[PATCH 05/25] staging: unisys: visorbus: renamed functions like *_bus_instance to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed functions * create_bus_instance() to visorbus_create_instance() * remove_bus_instance() to visorbus_remove_instance() Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus

[PATCH 03/25] staging: unisys: visorbus: renamed functions like bus_*_response to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed functions bus_create_response() to visorbus_create_response() and bus_destroy_response() to visorbus_destroy_response(). Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus

[PATCH 13/25] staging: unisys: visorbus: renamed #defines in visorchipset.c to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed #defines * UNISYS_SPAR_LEAF_ID to UNISYS_VISOR_LEAF_ID * UNISYS_SPAR_ID_EBX to UNISYS_VISOR_ID_EBX * UNISYS_SPAR_ID_ECX to UNISYS_VISOR_ID_ECX * UNISYS_SPAR_ID_EDX to UNISYS_VISOR_ID_EDX Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner

[PATCH 11/25] staging: unisys: visorbus: renamed structures in vbuschannel.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed structures * ultra_vbus_deviceinfo to visor_vbus_deviceinfo * spar_vbus_headerinfo to visor_vbus_headerinfo * spar_vbus_channel_protocol to visor_vbus_channel Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus

[PATCH 16/25] staging: unisys: visorbus: renamed enum in controlvmchannel.h to match driver namespace

2017-05-19 Thread David Kershner
-off-by: David Kershner --- drivers/staging/unisys/visorbus/controlvmchannel.h | 8 drivers/staging/unisys/visorbus/visorchipset.c | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/unisys/visorbus/controlvmchannel.h b/drivers/staging/unisys

[PATCH 10/25] staging: unisys: visorbus: renamed #defines in vbuschannel.h to match driver namespace

2017-05-19 Thread David Kershner
: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/vbuschannel.h | 9 - drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/staging/unisys/visorbus/vbuschannel.h b/drivers

[PATCH 09/25] staging: unisys: visorbus: renamed functions like my_device_* to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed functions * my_device_create() to visorbus_device_create() * my_device_changestate() to visorbus_device_changestate() * my_device_destroy() to visorbus_device_destroy() Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys

[PATCH 12/25] staging: unisys: visorbus: renamed #define in visorchannel.c to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed SPAR_CONSOLEVIDEO_CHANNEL_PROTOCOL_GUID to VISOR_CONSOLEVIDEO_CHANNEL_GUID and renamed const spar_video_guid to visor_video_guid Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchannel.c | 8 1

[PATCH 04/25] staging: unisys: visorbus: renamed functions like device_*_response to match driver namespace

2017-05-19 Thread David Kershner
() Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c| 8 drivers/staging/unisys/visorbus/visorbus_private.h | 8 drivers/staging/unisys/visorbus/visorchipset.c | 9

[PATCH 14/25] staging: unisys: visorbus: renamed #defines in controlvmchannel.h to match driver namespace

2017-05-19 Thread David Kershner
VISOR_CONTROLVM_CHANNEL_VERSIONID * SPAR_CONTROLVM_CHANNEL_OK_CLIENT to VISOR_CONTROLVM_CHANNEL_OK_CLIENT Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/controlvmchannel.h | 19 +++ drivers/staging/unisys/visorbus

[PATCH 01/25] staging: unisys: visorbus: rename typ to cr_type

2017-05-19 Thread David Kershner
From: Jon Frisch This patch renames enum crash_obj_type typ to cr_type. Signed-off-by: Jon Frisch Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorbus

[PATCH 06/25] staging: unisys: visorbus: renamed functions like chipset_bus_* to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed functions * chipset_bus_create() to visorchipset_bus_create() * chipset_bus_destroy() to visorchipset_bus_destroy() Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus

[PATCH 08/25] staging: unisys: visorbus: renamed function initiate_chipset_device_pause_resume to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed function initiate_chipset_device_pause_resume() to visorchipset_initiate_device_pause_resume(). Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c | 11

[PATCH 07/25] staging: unisys: visorbus: renamed functions like chipset_device_* to match driver namespace

2017-05-19 Thread David Kershner
Wadgaonkar Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c| 12 ++-- drivers/staging/unisys/visorbus/visorbus_private.h | 8 drivers/staging/unisys/visorbus/visorchipset.c | 14 +++--- 3 files

[PATCH 20/25] staging: unisys: include: renamed function spar_check_channel in channel.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed function spar_check_channel() to visor_check_channel(). Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/include/channel.h | 12 ++-- drivers/staging/unisys/include/iochannel.h | 4

[PATCH 25/25] staging: unisys: visorbus: remove channel_addr check in handle_command

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Removed a check for physaddr=0 in handle_command() function in visorchipset.c. Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchipset.c | 3 --- 1 file changed, 3 deletions

[PATCH 18/25] staging: unisys: visorinput: renamed structures in ultrainputreport.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed structures * ultra_inputactivity to visor_inputactivity * ultra_inputreport to visor_inputreport Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/visorinput/ultrainputreport.h | 6 +++--- drivers/staging/unisys

[PATCH 19/25] staging: unisys: visorinput: removed enum in ultrainputreport.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Removed enum ultra_inputaction in ultrainputreport.h and changed elements to #defnes. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/visorinput/ultrainputreport.h | 43 + drivers/staging/unisys/visorinput

[PATCH 21/25] staging: unisys: include: renamed #defines in channel.h to match driver namespace

2017-05-19 Thread David Kershner
VISOR_VHBA_CHANNEL_UUID_STR * SPAR_VNIC_CHANNEL_PROTOCOL_UUID to VISOR_VNIC_CHANNEL_UUID * SPAR_VNIC_CHANNEL_PROTOCOL_UUID_STR to VISOR_VNIC_CHANNEL_UUID_STR * SPAR_SIOVM_UUID to VISOR_SIOVM_UUID Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner

<    1   2   3   4   5   6   7   8   9   10   >