Wadgaonkar
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c| 12 ++--
drivers/staging/unisys/visorbus/visorbus_private.h | 8
drivers/staging/unisys/visorbus/visorchipset.c | 14 +++---
3 files
From: Sameer Wadgaonkar
Renamed function spar_check_channel() to visor_check_channel().
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/channel.h | 12 ++--
drivers/staging/unisys/include/iochannel.h | 4
From: Sameer Wadgaonkar
Removed a check for physaddr=0 in handle_command() function in
visorchipset.c.
Signed-off-by: Sameer Wadgaonkar
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 3 ---
1 file changed, 3 deletions
From: Sameer Wadgaonkar
Renamed structures
* ultra_inputactivity to visor_inputactivity
* ultra_inputreport to visor_inputreport
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorinput/ultrainputreport.h | 6 +++---
drivers/staging/unisys
From: Sameer Wadgaonkar
Removed enum ultra_inputaction in ultrainputreport.h and changed
elements to #defnes.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorinput/ultrainputreport.h | 43 +
drivers/staging/unisys/visorinput
VISOR_VHBA_CHANNEL_UUID_STR
* SPAR_VNIC_CHANNEL_PROTOCOL_UUID to VISOR_VNIC_CHANNEL_UUID
* SPAR_VNIC_CHANNEL_PROTOCOL_UUID_STR to
VISOR_VNIC_CHANNEL_UUID_STR
* SPAR_SIOVM_UUID to VISOR_SIOVM_UUID
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
From: Sameer Wadgaonkar
Renamed structure spar_io_channel_protocol to visor_io_channel and
changed "visor bus" to "visorbus" in a comment in visornic_main.c
and visorhba_main.c.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
---
drivers/staging/unisys
From: Sameer Wadgaonkar
Added a comment to explain polling frequency variation logic in
controlvm_periodic_logic() in visorchipset.c.
Signed-off-by: Sameer Wadgaonkar
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 5
: Sameer Wadgaonkar
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/controlvmchannel.h | 25 +---
drivers/staging/unisys/visorbus/visorchipset.c | 99 ++
2 files changed, 59 insertions(+), 65 deletions(-)
diff --git a/drivers/staging/unisys/visorbus
* SPAR_VHBA_CHANNEL_OK_CLIENT to VISOR_VHBA_CHANNEL_OK_CLIENT
* SPAR_VNIC_CHANNEL_OK_CLIENT to VISOR_VNIC_CHANNEL_OK_CLIENT
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/iochannel.h | 28 +++
1 file changed, 14 insertions(+), 14 deletions
VISOR_MOUSE_CHANNEL_UUID
* SPAR_MOUSE_CHANNEL_PROTOCOL_UUID_STR to
VISOR_MOUSE_CHANNEL_UUID_STR
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
---
drivers/staging/unisys/Documentation/overview.txt | 6 ++--
drivers/staging/unisys/visorinput/visorinput.c| 27 +++-
2
From: Michael Kelley
Date: Tue, 30 May 2017 10:43:04 -0700
> Add direct #include statements for declarations of csum_tcpudp_magic()
> and csum_ipv6_magic(). While the needed #include's are picked up
> indirectly for the x86 architecture, they aren't on other
> architectures, resulting in compile
From: Joe Perches
Date: Wed, 31 May 2017 15:59:31 -0700
> On Wed, 2017-05-31 at 13:59 -0400, David Miller wrote:
>> From: Michael Kelley
>> Date: Tue, 30 May 2017 10:43:04 -0700
>>
>> > Add direct #include statements for declarations of csum_tcpudp_magic()
>>
clude folder.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
MAINTAINERS | 1 +
drivers/staging/unisys/visorbus/Makefile | 2 --
drivers/staging/unisys/visorbus/controlvmchannel.h
This patchset moves drivers/staging/unisys/include to
include/linux/visorbus, and moves drivers/staging/unisys/visorbus to
drivers/virt/visorbus.
David Kershner (3):
include: linux: visorbus: Add visorbus to include/linux directory
Documentation: Move visorbus documentation from staging to
This patch moves visorbus from drivers/staging/visorbus to
drivers/virt.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
MAINTAINERS | 1 +
drivers/staging/unisys/Kconfig | 1 -
drivers/staging/unisys
This patch simply does a git mv of the
drivers/staging/unisys/Documentation directory to Documentation. It also
renames overview.txt to visorbus.txt and renames sysfs-platform-visorchipset
to the correct name sysfs-bus-visorbus.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
.../ABI
From: Stephen Hemminger
Date: Wed, 7 Jun 2017 15:53:46 -0700
> These are bugfixes for netvsc driver in 4.12.
Looks good, series applied, thanks.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listin
From: Stephen Hemminger
Date: Thu, 8 Jun 2017 16:21:17 -0700
> These are all small optimizations found during development of later features.
Applied with the spelling error pointed out by Sergei fixed.
___
devel mailing list
de...@linuxdriverproject.o
From: Arnd Bergmann
Date: Thu, 22 Jun 2017 00:16:37 +0200
> This structure member is hidden behind CONFIG_SYSFS, and we
> get a build error when that is disabled:
>
> drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_channels':
> drivers/net/hyperv/netvsc_drv.c:754:49: error: 'struct net_
From: Dexuan Cui
Date: Mon, 9 Nov 2015 02:39:24 +
>> Throughput on a single TCP flow for a 40G NIC can be tricky to tune.
> Why is a single TCP flow trickier than multiple TCP flows?
> IMO it should be easier to analyze the issue of a single TCP flow?
Because a single TCP flow can only use o
From: Dexuan Cui
Date: Mon, 9 Nov 2015 03:11:35 +
>> -Original Message-
>> From: David Miller [mailto:da...@davemloft.net]
>> Sent: Monday, November 9, 2015 10:53
>> To: Dexuan Cui
>> Cc: eric.duma...@gmail.com; d...@cumulusnetworks.com; Simon Xi
From: Vitaly Kuznetsov
Date: Fri, 27 Nov 2015 11:39:55 +0100
> There are several issues in hv_netvsc driver with regards to link status
> change handling:
> - RNDIS_STATUS_NETWORK_CHANGE results in calling userspace helper doing
> '/etc/init.d/network restart' and this is inappropriate and brok
From: "K. Y. Srinivasan"
Date: Sat, 28 Nov 2015 12:20:36 -0800
> +#elseif defined(CONFIG_WLAN) || IS_ENABLED(CONFIG_AX25)
The correct CPP directive is "#elif".
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/
From: "K. Y. Srinivasan"
Date: Tue, 1 Dec 2015 16:42:58 -0800
> In an attempt to avoid having to allocate memory on the send path, the netvsc
> driver was requesting additional head room so that both rndis header and the
> netvsc packet (the state that had to persist) could be placed in the skb.
FOR MORE INFORMATION CONTACT: (unitednationdiplomaticenvoy2...@diplomats.com)
David Finch
Head of Law and Legal Services
Kingston College
D: 020 8268 3017
Visit Our Website
http://www.kingston-college.ac.uk
__
This message
From: Haiyang Zhang
Date: Thu, 10 Dec 2015 12:19:35 -0800
> In commit 2a04ae8acb14 ("hv_netvsc: remove locking in netvsc_send()"), the
> locking for MSD (Multi-Send Data) field was removed. This could cause a
> race condition between RNDIS control messages and data packets processing,
> because t
From: Haiyang Zhang
Date: Wed, 16 Dec 2015 19:20:44 +
> In our test, we have bisected and found the following patch introduced big
> overhead into skb_flow_dissect_flow_keys(), and caused performance
> regression:
> commit: d34af823
> net: Add VLAN ID to flow_keys
NEVER _EVER_ work around
From: Dexuan Cui
Date: Thu, 24 Dec 2015 06:14:36 -0800
> +#define HV_RINGBUFFER_READ_FLAG_RAW (1 << 0)
> +#define HV_RINGBUFFER_READ_FLAG_HVSOCK (1 << 1)
Please use BIT().
___
devel mailing list
de...@linuxdriverproject.org
http:
From: Vitaly Kuznetsov
Date: Thu, 7 Jan 2016 10:33:09 +0100
> Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add
> VLAN ID to flow_keys")) introduced a performance regression in netvsc
> driver. Is problem is, however, not the above mentioned commit but the
> fact that net
Gotos in visorbus_match are not needed.
Signed-off-by: David Kershner
Signed-off-by: Timothy Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
Fixup the visordriver_probe function. Rearrange the function to avoid
needing gotos and removed unnecessary wmb().
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c | 32 ++---
1 file changed, 12 insertions(+), 20 deletions(-)
diff --git a
This patch fixes the gotos in visorbus_init
Signed-off-by: David Kershner
Signed-off-by: Timothy Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/unisys/visorbus
major and
minor device numbers for character devices created for a each visorbus
device, using visorbus_registerdevnode(). This functionality is not
currently used, so it has been removed by this cset.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/Documentation
Away is ambiguous when specifying error vs success. Make return labels
more meaningful by marking them as error paths.
Signed-off-by: David Kershner
Signed-off-by: Timothy Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 16
1 file changed, 8 insertions(+), 8
visordriver_prove_device so gotos are no longer
needed.
David Kershner (4):
staging: unisys: visorbus: Fix up visordriver_probe
staging: unisys: visorbus: fix up gotos in visorbus_init
staging: unisys: visorbus: Remove gotos in visorbus_match
staging: unisys: visorbus: rename create_visor_device
Clean up the goto in parser_init_byte_stream and make the goto section
the error case.
Signed-off-by: David Kershner
Signed-off-by: Timothy Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 39 +-
1 file changed, 14 insertions(+), 25 deletions(-)
diff --git a
Don't use the abmiguous cleanup, make it more meaningful.
Signed-off-by: David Kershner
Signed-off-by: Timothy Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchip
Get rid of the gotos in initialize_controlvm_payload_info. The check in
the error path if payload was valid was never called so get rid of that
as well.
Signed-off-by: David Kershner
Signed-off-by: Timothy Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 30
If visorbus has registered yet just reschedule and exit. The rest of
the function doesn't need to reschedule so just move it up to the
initial check.
Signed-off-by: David Kershner
Signed-off-by: Timothy Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 14 +-
1 file ch
Cleaned up bus_epilogs vague gotos and in the process discovered
some error paths that could unlock a non locked semaphore.
Signed-off-by: David Kershner
Signed-off-by: Timothy Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 18 --
1 file changed, 12 insertions(+), 6
This patch series clean up the gotos in visorbus/visorchipset.c
v2 changes:
- added patch cleanup goto in setup_crash_device_work_queue
- added comment body to controlvm_payload_info patch
- added comment body to parser_init_byte_stream patch
David Kershner (7):
staging: unisys: visorbus
Change the goto label "cleanup" to something more useful like
out_respond.
Signed-off-by: David Kershner
Signed-off-by: Timothy Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisy
Rename it to what it does instead of the default ambiguous
cleanup.
Signed-off-by: David Kershner
Signed-off-by: Timothy Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/visorbus
This patch fixes the gotos in visorbus_init
Signed-off-by: David Kershner
Signed-off-by: Timothy Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/unisys/visorbus
Fixup the visordriver_probe function. Rearrange the function to avoid
needing gotos and removed unnecessary wmb().
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c | 32 ++---
1 file changed, 12 insertions(+), 20 deletions(-)
diff --git a
Away is ambiguous when specifying error vs success. Make return labels
more meaningful by marking them as error paths.
Signed-off-by: David Kershner
Signed-off-by: Timothy Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 18 +-
1 file changed, 9 insertions(+), 9
Gotos in visorbus_match are not needed.
Signed-off-by: David Kershner
Signed-off-by: Timothy Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
patchset since the
functions they patch no longer exist.
- Reworked the function visordriver_prove_device so gotos are no longer
needed.
David Kershner (4):
staging: unisys: visorbus: Fix up visordriver_probe
staging: unisys: visorbus: fix up gotos in visorbus_init
staging: unisys: visorbus
major and
minor device numbers for character devices created for a each visorbus
device, using visorbus_registerdevnode(). This functionality is not
currently used, so it has been removed by this cset.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/Documentation
Hi
On Mon, Mar 21, 2016 at 8:51 AM, Daniel Vetter wrote:
> Just a bit of wording polish plus mentioning that it can fail and must
> be restarted.
>
> Requested by Sumit.
>
> v2: Fix them typos (Hans).
>
> Cc: Chris Wilson
> Cc: Tiago Vignatti
> Cc: Stéphane M
Two things wrong with this submission:
1) You need to provide an initial "[PATCH net-next 0/3] ..." header posting
explaining at a high level what this patch series is about and how it is
implemented and why.
2) The net-next tree is closed at this time because we are in the merge window,
Hey
On Mon, Mar 21, 2016 at 6:14 PM, Daniel Vetter wrote:
> On Mon, Mar 21, 2016 at 01:26:58PM +0100, David Herrmann wrote:
>> Hi
>>
>> On Mon, Mar 21, 2016 at 8:51 AM, Daniel Vetter
>> wrote:
>> > Just a bit of wording polish plus mentioning that it
Hi
On Wed, Mar 23, 2016 at 12:56 PM, Chris Wilson wrote:
> On Wed, Mar 23, 2016 at 12:30:42PM +0100, David Herrmann wrote:
>> My question was rather about why we do this? Semantics for EINTR are
>> well defined, and with SA_RESTART (default on linux) user-space can
>> ignore
From: Haiyang Zhang
Date: Wed, 23 Mar 2016 14:54:48 -0700
> Reorder the code in netvsc_sc_open(), so num_sc_offered is only decremented
> after vmbus_open() is called. This avoid pontential race of removing device
> before all channels are setup.
>
> Signed-off-by: Haiyang Zhang
> Reviewed-by:
From: Alexander Curtin
The variable name "s" doesn't indicate the purpose of the string, which
is to store the id collected from the visorchannel_zoneid function. This
just replaces the name with "zoneid".
Signed-off-by: Alexander Curtin
Signed-off-by: David Kersh
the pointer.
Signed-off-by: Alexander Curtin
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c | 65 +
1 file changed, 33 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/
From: Alexander Curtin
In the case of client_bus_info_show, the variable 'p' was used to
indicate the position in the output buffer. This was changed to 'pos' to
indicate that it kept track of the current position in the output
buffer.
Signed-off-by: Alexander Curtin
Replaced vague variable names with more meaningful ones in several different
areas.
Resent due to distribution list being wrong.
Alexander Curtin (5):
staging: unisys: visorbus: replaced vague variable name in
typeguid_show
staging: unisys: visorbus: replaced vague variable name in
zo
From: Alexander Curtin
The variable name "s" doesn't indicate the purpose of the string, which
is to store the id collected from the visorchannel_id function. This
just replaces the name with "typeid".
Signed-off-by: Alexander Curtin
Signed-off-by: David Kershner
--
From: Alexander Curtin
The argument for ULTRA_CHANNELCLI_STRING is supposed to be
an integer representing the channel state. 'state' is a more
descriptive variable name for this.
Signed-off-by: Alexander Curtin
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/cha
Remove the double negative condition ( x != 0).
Erik Arfvidson (2):
staging: unisys: remove channel.h double negative comparison
staging: unisys: remove visorinput.c double negative comparison
drivers/staging/unisys/include/channel.h | 6 +++---
drivers/staging/unisys/visorinput/visor
From: Erik Arfvidson
This patch removes the double negative comparisons for function
readb.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/channel.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging
From: Erik Arfvidson
This patch simply removes the double negative comparison for
test_bit since test_bit already preforms this check.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorinput/visorinput.c | 2 +-
1 file changed, 1 insertion(+), 1
Hi
On Mon, Mar 28, 2016 at 9:42 PM, Tiago Vignatti
wrote:
> Do we have an agreement here after all? David? I need to know whether this
> fixup is okay to go cause I'll need to submit to Chrome OS then.
Sure it is fine. The code is already there, we cannot change it.
T
ributes are not referenced anywhere, and there are no plans to
use them.
Signed-off-by: Alexander Curtin
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/include/visorbus.h
b/drivers/staging
From: Alexander Curtin
The 'visor_device.devnodes' field was used for displaying driver version
information through the devmajorminor sysfs attribute, which has recently
been removed, rendering the field unnecessary.
Signed-off-by: Alexander Curtin
Signed-off-by: David Kershner
--
From: Alexander Curtin
The visor_device.type field was included when preparing to remove
the device_info struct. However, it's not used at all, and was already
redundant by the existence of the 'visor_device.channel_type_guid'
field.
Signed-off-by: Alexander Curtin
Signe
nel->nbytes.
Signed-off-by: Alexander Curtin
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/include/visorbus.h
b/drivers/staging/unisys/include/visorbus.h
index cbc6d8f..3788d16 100644
Several fields in visor_device are no longer used due to the rework that has
been done on them. This series removes those fields.
Alexander Curtin (5):
staging: unisys: removed unused switch/port info from visorbus.h
staging: unisys: include: removed unused 'visor_device.description'
staging
correctly identify the driver, it is not
needed.
Signed-off-by: Alexander Curtin
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/include/visorbus.h
b/drivers/staging/unisys/include/visorbus.h
Don't need to have a wmb() in visordriver_remove_device. Also removed
an unnecessary check for drv being null.
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/st
From: Tim Sell
The use of poll_count is a vestige from long-ago testing, which is no
longer needed. It is removed by this patch.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a
-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 68 +++---
1 file changed, 40 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus/visorchipset.c
index afcd291..0583b51 100644
--- a
The away flag is ambiguous, rename it to out and appropriately
call the correct goto.
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 36 ++
1 file changed, 13 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/unisys/visorbus
visor_copy_fragsinfo_from_skb() was
returning a negative to indicate error, yet it was declared to return an
unsigned value! So obviously that needed correcting too.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visornic/visornic_main.c | 8 +++-
1 file changed, 3
From: Tim Sell
Fix as recommended by checkpatch.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging
The paths in bus_epilog should match device_epilog.
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 19 +++
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys
This series cleans up some more gotos in the the visorbus driver.
David Kershner (3):
staging: unisys: visorbus: visorchipset_init clean up gotos
staging: unisys: visorbus: device_epilog: clean up gotos
staging: unisys: visorbus: make bus_epilog match device_epilog
drivers/staging/unisys
From: David Binder
Removes size member from the visorchannel struct, since it was
a duplicate of the nbytes member.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchannel.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff
From: Tim Sell
Fix 'CHECK: Alignment should match open parenthesis' as recommended by
checkpatch.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visornic/visornic_main.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
di
This series fixes checkpatch warnings in the unisys visorbus and
visornic drivers.
Tim Sell (4):
staging: unisys: visorbus: 'unsigned' --> 'unsigned int'
staging: unisys: visorbus: CHECK: Alignment should match open
parenthesis
staging: unisys: visornic: CHECK: Alignment should match op
From: Tim Sell
Fix 'CHECK: Alignment should match open parenthesis' as recommended by
checkpatch.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 80 +++---
1 file changed, 45 insertions(+), 35 deletion
.
Signed-off-by: Alexander Curtin
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/include/visorbus.h
b/drivers/staging/unisys/include/visorbus.h
index 3788d16..db59d97 100644
--- a/drivers/staging
From: Tim Sell
These comments were mistakenly carried forward by a previous copy/paste.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorinput/visorinput.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys
and to decrease the chance that such bugs will be introduced
again. The main-path logic now falls thru down the left-side of the page,
with a common error-exit point to handle error conditions.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visornic/visornic_mai
This is the resend of the patch covert BUG_ON to dev_err() message.
changes since v1:
- Updated patch to return an actual error instead of -1
Tim Sell (1):
staging: unisys: visornic: convert BUG_ON to dev_err() message
drivers/staging/unisys/visornic/visornic_main.c | 8 +++-
1 file cha
visor_copy_fragsinfo_from_skb() was
returning a negative to indicate error, yet it was declared to return an
unsigned value! So obviously that needed correcting too.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visornic/visornic_main.c | 8 +++-
1 file changed, 3
From: Erik Arfvidson
Display string size that is guaranteed to be no longer the 99 characters.
Don't use a magic number throughout the code, define it once and use it
throughout.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_m
From: David Binder
Unisys drivers no longer utilize procfs. Therefore, the documentation
for our procfs entries is no longer needed.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
.../staging/unisys/Documentation/proc-entries.txt | 93 --
drivers/staging
From: Dexuan Cui
Date: Thu, 7 Apr 2016 18:36:51 -0700
> +struct vmpipe_proto_header {
> + u32 pkt_type;
> + u32 data_size;
> +} __packed;
There is no reason to specify __packed here.
The types are strongly sized to word aligned quantities.
No holes are possible in this structure, nor i
From: Tim Sell
The build_date and build_time fields are not used, and have been removed.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/include/visorbus.h
b
For 'struct visor_driver' and 'struct visor_device':
* unused members have been removed
* kernel-doc comments have been added
Alexander Curtin (2):
staging: unisys: include: Added kernel-doc for struct visor_driver
staging: unisys: include: Added kerneldoc comments to visor_device
Tim Sel
From: Alexander Curtin
This adds kerneldoc style comments to the visor_driver struct since
it's shared between multiple modules.
Signed-off-by: Alexander Curtin
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h
From: Alexander Curtin
The visor_device struct is used between multiple drivers, so this
adds kerneldoc comments to the fields.
Signed-off-by: Alexander Curtin
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/visorbus.h | 45
From: David Binder
Initializes previously uninitialized variables that were flagged
as being problematic by Smatch.
Signed-off-by: David Binder
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
visorchipset_guest_groupw
remove unused chipsets_events:
check_chipset_events()
clear_chipset_events()
visorchipset_holdchipsetready
remove sysfs documentation dealing with chipsetready
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
---
.../Documentation/ABI/sysfs-platform
From: Haiyang Zhang
Date: Thu, 21 Apr 2016 16:13:01 -0700
> RNDIS_STATUS_NETWORK_CHANGE event is handled as two "half events" --
> media disconnect & connect. The second half should be added to the list
> head, not to the tail. So all events are processed in normal order.
>
> Signed-off-by: Haiy
From: Erik Arfvidson
The following struct members were never used:
putfile_active_buffer::pnext
putfile_request::file_request_number
putfile_request::data_sequence_number
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchipset.c | 6
-by: Alexander Curtin
Signed-off-by: Tim Sell
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/iochannel.h | 42 -
drivers/staging/unisys/visorhba/visorhba_main.c | 26 ---
2 files changed, 22 insertions(+),
701 - 800 of 1855 matches
Mail list logo
