Don't need to have a wmb() in visordriver_remove_device. Also removed
an unnecessary check for drv being null.

Signed-off-by: David Kershner <david.kersh...@unisys.com>
---
 drivers/staging/unisys/visorbus/visorbus_main.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c 
b/drivers/staging/unisys/visorbus/visorbus_main.c
index 1fcb177..547be8b 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -613,20 +613,12 @@ visordriver_remove_device(struct device *xdev)
        drv = to_visor_driver(xdev->driver);
        down(&dev->visordriver_callback_lock);
        dev->being_removed = true;
-       /*
-        * ensure that the dev->being_removed flag is set before we start the
-        * actual removal
-        */
-       wmb();
-       if (drv) {
-               if (drv->remove)
-                       drv->remove(dev);
-       }
+       if (drv->remove)
+               drv->remove(dev);
        up(&dev->visordriver_callback_lock);
        dev_stop_periodic_work(dev);
 
        put_device(&dev->device);
-
        return 0;
 }
 
-- 
1.9.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to