RE

2020-02-14 Thread David Abula
Hallo, Schönen Tag, Bitte nehmen Sie meine aufrichtigen Glückwünsche an und ich weiß, dass diese Botschaft Sie überraschen kann, aber ich rate Ihnen, sie mit gutem Verständnis zu lesen. Ich bin Rechtsanwalt David Abula aus Togo. Daher gibt es einen bestimmten Betrag von 11,7 Mio. USD, der von

Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-04-14 Thread David Sterba
On Mon, Apr 13, 2020 at 05:15:49PM -0400, Waiman Long wrote: > fs/btrfs/ioctl.c | 2 +- > diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c > index 40b729dce91c..eab3f8510426 100644 > --- a/fs/btrfs/ioctl.c > +++ b/fs/btrfs/ioctl.c > @@ -2691,7 +2691,7 @@ static int b

Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-04-14 Thread David Howells
> followed by some editing of the kfree_sensitive() kerneldoc and the > use of memzero_explicit() instead of memset(). > > Suggested-by: Joe Perches > Signed-off-by: Waiman Long Since this changes a lot of crypto stuff, does it make sense for it to go via the crypto tree? Ack

Re: [PATCH 00/37] net: manually convert files to ReST format - part 2

2020-04-30 Thread David Miller
From: Mauro Carvalho Chehab Date: Thu, 30 Apr 2020 18:03:55 +0200 > That's the second part of my work to convert the networking > text files into ReST. it is based on today's linux-next (next-20200430). > > The full series (including those ones) are at: > > https://git.linuxtv.org/mchehab

Re: [PATCH net,v3] hyperv: Fix the carrier status setting

2014-02-13 Thread David Miller
From: Haiyang Zhang Date: Wed, 12 Feb 2014 16:54:27 -0800 > Without this patch, the "cat /sys/class/net/ethN/operstate" shows > "unknown", and "ethtool ethN" shows "Link detected: yes", when VM > boots up with or without vNIC connected. > > This patch fixed the problem. > > Signed-off-by: Haiya

Re: [PATCH 0/3] Drivers: net: hyperv: Cleanup the hyper-V networking code

2014-02-17 Thread David Miller
From: "K. Y. Srinivasan" Date: Sun, 16 Feb 2014 16:38:03 -0800 > Get rid of some unnecessary code and some general cleanup. > > K. Y. Srinivasan (3): > Drivers: net: hyperv: Get rid of the rndis_filter_packet structure > Drivers: net: hyperv: Cleanup the receive path > Drivers: net: hyperv

Re: [PATCH net-next] hyperv: Add latest NetVSP versions to auto negotiation

2014-02-19 Thread David Miller
From: Haiyang Zhang Date: Tue, 18 Feb 2014 12:28:54 -0800 > + u32 ver_list[] = {NVSP_PROTOCOL_VERSION_1, NVSP_PROTOCOL_VERSION_2, > + NVSP_PROTOCOL_VERSION_4, NVSP_PROTOCOL_VERSION_5}; Please put a space after "{" and before "}". > + int i, num_ver = 4; /* number of differen

Re: [PATCH net-next,v2] hyperv: Add latest NetVSP versions to auto negotiation

2014-02-19 Thread David Miller
From: Haiyang Zhang Date: Wed, 19 Feb 2014 15:49:45 -0800 > It auto negotiates the highest NetVSP version supported by both guest and > host. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied, thanks. ___ devel mailing list d

[PATCH] Staging: comedi: Fix coding style issue in poc.c This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl

2014-02-23 Thread David Roddick
--- drivers/staging/comedi/drivers/poc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/poc.c b/drivers/staging/comedi/drivers/poc.c index 2ae4ee1..22c7392 100644 --- a/drivers/staging/comedi/drivers/poc.c +++ b/drivers/staging/comedi/dr

[PATCH] Staging: comedi: Fix coding style issue in poc.c This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl

2014-02-23 Thread David Roddick
--- drivers/staging/comedi/drivers/poc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/poc.c b/drivers/staging/comedi/drivers/poc.c index 2ae4ee1..22c7392 100644 --- a/drivers/staging/comedi/drivers/poc.c +++ b/drivers/staging/comedi/dr

[PATCH] Staging: comedi: Fix coding style issue in poc.c This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl

2014-02-23 Thread David Roddick
Signed-off-by: David Roddick --- drivers/staging/comedi/drivers/poc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/poc.c b/drivers/staging/comedi/drivers/poc.c index 2ae4ee1..22c7392 100644 --- a/drivers/staging/comedi/drivers/poc.c

[PATCH] Staging: comedi: Fix coding style issue in poc.c

2014-02-24 Thread David Roddick
This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl Signed-off-by: David Roddick --- drivers/staging/comedi/drivers/poc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/poc.c b/drivers

[PATCH] Staging: comedi: fix coding style issues in poc.c

2014-02-24 Thread David Roddick
Removed unnecessary spaces after function pointer names and corrected multi-line wrap alignment Signed-off-by: David Roddick --- drivers/staging/comedi/drivers/poc.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/comedi/drivers/poc.c b

Re: [PATCH net-next,v2] hyperv: Move state setting for link query

2014-03-05 Thread David Miller
From: Haiyang Zhang Date: Tue, 4 Mar 2014 14:11:06 -0800 > It moves the state setting for query into rndis_filter_receive_response(). > All callbacks including query-complete and status-callback are synchronized > by channel->inbound_lock. This prevents pentential race between them. > > Signed-

Re: [PATCH 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-06 Thread David Miller
From: "K. Y. Srinivasan" Date: Thu, 6 Mar 2014 03:13:05 -0800 > @@ -140,21 +140,125 @@ static void netvsc_xmit_completion(void *context) > dev_kfree_skb_any(skb); > } > > +static u32 fill_pg_buf(struct page *page, u32 offset, u32 len, > + struct hv_page_buffe

Re: [PATCH 2/6] Drivers: net: hyperv: Cleanup the send path

2014-03-06 Thread David Miller
From: "K. Y. Srinivasan" Date: Thu, 6 Mar 2014 03:13:06 -0800 > In preparation for enabling offloads, cleanup the send path. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang > --- > drivers/net/hyperv/hyperv_net.h |7 +--- > drivers/net/hyperv/netvsc_drv.c | 87

Re: [PATCH 4/6] Drivers: net: hyperv: Enable receive side IP checksum offload

2014-03-06 Thread David Miller
From: "K. Y. Srinivasan" Date: Thu, 6 Mar 2014 03:13:08 -0800 > + /* > + * We only look at the IP checksum here. > + * Should we be dropping the packet if checksum > + * failed? How do we deal with other checksums - TCP/UDP? > + */

Re: [PATCH 3/6] Drivers: net: hyperv: Enable offloads on the host

2014-03-06 Thread David Miller
From: "K. Y. Srinivasan" Date: Thu, 6 Mar 2014 03:13:07 -0800 > + /* > + * can't put_rndis_request, since we may still receive a > + * send-completion. > + */ Please fix the formatting of this comment. > + /* > + * Turn on the offload

Re: [PATCH 5/6] Drivers: net: hyperv: Enable send side checksum offload

2014-03-06 Thread David Miller
From: "K. Y. Srinivasan" Date: Thu, 6 Mar 2014 03:13:09 -0800 > +bool get_net_transport_info(struct sk_buff *skb, bool *is_v4, > + bool *is_tcp, bool *is_udp, u32 *trans_off) > +{ Returning so many values like this is awkward, at best. Why not return a well defined

Re: [PATCH 6/6] Drivers: net: hyperv: Enable large send offload

2014-03-06 Thread David Miller
From: "K. Y. Srinivasan" Date: Thu, 6 Mar 2014 03:13:10 -0800 > + ppi = init_ppi_data(rndis_msg, NDIS_LSO_PPI_SIZE, > + TCP_LARGESEND_PKTINFO); This is not indented properly, "TCP_LARGESEND_PKTINFO);" should start at the first column after the openning parenthesi

Re: [PATCH 5/6] Drivers: net: hyperv: Enable send side checksum offload

2014-03-06 Thread David Miller
From: KY Srinivasan Date: Thu, 6 Mar 2014 20:29:13 + > > >> -Original Message----- >> From: David Miller [mailto:da...@davemloft.net] >> Sent: Friday, March 7, 2014 1:04 AM >> To: KY Srinivasan >> Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.

Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-07 Thread David Miller
From: "K. Y. Srinivasan" Date: Thu, 6 Mar 2014 21:32:36 -0800 > +static u32 fill_pg_buf(struct page *page, u32 offset, u32 len, > + struct hv_page_buffer *pb) > +{ > + int j = 0; > + > + /* Deal with compund pages by ignoring unused part > + * of the page. > +

Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-07 Thread David Miller
From: KY Srinivasan Date: Sat, 8 Mar 2014 04:12:01 + > > >> -Original Message----- >> From: David Miller [mailto:da...@davemloft.net] >> Sent: Saturday, March 8, 2014 3:18 AM >> To: KY Srinivasan >> Cc: net...@vger.kernel.org;

Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-08 Thread David Miller
From: KY Srinivasan Date: Sat, 8 Mar 2014 10:27:54 + > "len" would have gotten decremented prior to the check and in the > case we are talking about, "len" would be zero and so j would not > get incremented. You are correct, this is the part of the logic in this case which I missed. Thanks.

Re: [PATCH V3 0/6] Drivers: net: hyperv: Enable various offloads

2014-03-10 Thread David Miller
From: "K. Y. Srinivasan" Date: Sat, 8 Mar 2014 19:22:42 -0800 > This patch set enables both checksum as well as segmentation offload. > As part of this effort I have enabled scatter gather I/O a well. > > In version 2 of these patches, I addressed comments from David Mill

Re: [PATCH net-next] hyperv: Change the receive buffer size for legacy hosts

2014-03-10 Thread David Miller
From: Haiyang Zhang Date: Sun, 9 Mar 2014 16:10:59 -0700 > Due to a bug in the Hyper-V host verion 2008R2, we need to use a slightly > smaller > receive buffer size, otherwise the buffer will not be accepted by the legacy > hosts. > > Signed-off-by: Haiyang Zhang Applied. __

Re: [PATCH net-next,v2,1/1] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-17 Thread David Miller
From: Haiyang Zhang Date: Sat, 15 Mar 2014 10:18:07 -0700 > - if (netif_queue_stopped(ndev) && !net_device->start_remove && > - (hv_ringbuf_avail_percent(&device->channel->outbound) > - > RING_AVAIL_PERCENT_HIWATER || > - num

Re: [PATCH net-next,v3] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-19 Thread David Miller
From: Haiyang Zhang Date: Tue, 18 Mar 2014 15:15:22 -0700 > +struct ndis_obj_header { > + u8 type; > + u8 rev; > + u16 size; > +} __packed; > + > + > +/* ndis_recv_scale_cap/cap_flag */ One empty line is sufficient, we don't need two of them here. > +extern u8 netvsc_hash_key[]; We

Re: [PATCH net-next,v3] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-19 Thread David Miller
From: Sergei Shtylyov Date: Thu, 20 Mar 2014 00:56:05 +0300 > Hello. > > On 03/19/2014 11:40 PM, David Miller wrote: > >>> +extern u8 netvsc_hash_key[]; > >> We no longer use extern in header file function declarations. > >Wait, this is

RE: [PATCH] staging: octeon-usb: prevent memory corruption

2014-03-20 Thread David Laight
ng EdgeRouter Lite > to USB stick root file system with SLAB, SLOB and SLUB kernels. Wouldn't it be simpler to just round up the existing allocation? (With a comment that some DMA controllers write whole words.) David ___ devel mailing lis

Re: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-21 Thread David Miller
From: Haiyang Zhang Date: Thu, 20 Mar 2014 15:28:41 -0700 > This feature allows multiple channels to be used by each virtual NIC. > It is available on Hyper-V host 2012 R2. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied, thanks. __

Re: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-21 Thread David Miller
From: David Miller Date: Fri, 21 Mar 2014 14:49:57 -0400 (EDT) > From: Haiyang Zhang > Date: Thu, 20 Mar 2014 15:28:41 -0700 > >> This feature allows multiple channels to be used by each virtual NIC. >> It is available on Hyper-V host 2012 R2. >> >> Signed-o

Re: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-21 Thread David Miller
From: Haiyang Zhang Date: Fri, 21 Mar 2014 19:12:43 + > Could it be merged into net-next tree? You submitted a patch against net-next, that means you are implicitly stating that all dependencies are in place in _that_ tree and that you tested it in _that_ tree. If the situation is otherwise

Re: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-25 Thread David Miller
From: Haiyang Zhang Date: Tue, 25 Mar 2014 20:37:43 + > Do we know when the dependency (commit: 8a7206a89f) will be merged > into net-next tree? You're really not very patient, to say the least. It's done now and I'm working to integrate your patch. That patch has been in under review stat

Re: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-25 Thread David Miller
From: David Miller Date: Tue, 25 Mar 2014 20:43:43 -0400 (EDT) > From: Haiyang Zhang > Date: Tue, 25 Mar 2014 20:37:43 + > >> Do we know when the dependency (commit: 8a7206a89f) will be merged >> into net-next tree? > > You're really not very patient, to s

Re: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-04-03 Thread David Miller
From: Haiyang Zhang Date: Thu, 3 Apr 2014 09:05:34 -0700 > This feature allows multiple channels to be used by each virtual NIC. > It is available on Hyper-V host 2012 R2. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan I announced on netdev the other day that the merge wind

Re: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-04-07 Thread David Miller
The net-next tree is not open yet, I will announce when it is and you can submit net-next targetted patches. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum issues

2014-04-09 Thread David Miller
From: "K. Y. Srinivasan" Date: Tue, 8 Apr 2014 12:46:11 -0700 > } else if (net_trans_info & INFO_UDP) { > - csum_info->transmit.udp_checksum = 1; > + /* UDP checksum offload is not supported on ws2008r2. > + * Furthermore, on ws2012 and ws2012r2, there

Re: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum issues

2014-04-09 Thread David Miller
From: KY Srinivasan Date: Wed, 9 Apr 2014 18:08:47 + > Thanks Dave. I will COW the SKB before changing the checksum > value. I do have a question though. I looked at a bunch of hardware > drivers and they modify the header information, specially checksum > field and I could not see where the

Re: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum issues

2014-04-09 Thread David Miller
From: KY Srinivasan Date: Wed, 9 Apr 2014 18:39:57 + > > >> -Original Message----- >> From: David Miller [mailto:da...@davemloft.net] >> Sent: Wednesday, April 9, 2014 11:37 AM >> To: KY Srinivasan >> Cc: net...@vger.kernel.org;

RE: [PATCH 2/3] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0

2014-04-10 Thread David Laight
ptr[0] << 8 | ptr[1]; Or, if 'ptr' can't be misaligned, just reading a BE short. If the compiler doesn't inline memcpy() the above code is horrid. Are there MD inline functions for reading misaligned 16/32 bit date with specific endianness? David ___

Re: [PATCH net, V1 0/3] Fix issues with Heper-V network offload code

2014-04-11 Thread David Miller
Please apply. > > In this version, I have addressed the comment from David Miller with reagards > to COWing the skb prior to modifying the header (patch 3/3). This looks a lot better, series applied, thanks. ___ devel mailing list de

Re: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-04-17 Thread David Miller
From: Haiyang Zhang Date: Thu, 17 Apr 2014 17:25:31 + > Is the net-next tree open now? No, it is not. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-04-21 Thread David Miller
From: Haiyang Zhang Date: Mon, 21 Apr 2014 10:20:28 -0700 > This feature allows multiple channels to be used by each virtual NIC. > It is available on Hyper-V host 2012 R2. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied, th anks. _

Re: [PATCH net-next,1/2] hyperv: Remove recv_pkt_list and lock

2014-04-21 Thread David Miller
From: Haiyang Zhang Date: Mon, 21 Apr 2014 12:26:15 -0700 > @@ -401,8 +401,6 @@ static void rndis_filter_receive_data(struct rndis_device > *dev, > pkt->total_data_buflen = rndis_pkt->data_len; > pkt->data = (void *)((unsigned long)pkt->data + data_offset); > > - pkt->is_data_p

Re: [PATCH net-next,v2,1/2] hyperv: Remove recv_pkt_list and lock

2014-04-23 Thread David Miller
From: Haiyang Zhang Date: Mon, 21 Apr 2014 14:54:43 -0700 > Removed recv_pkt_list and lock, and updated related code, so that > the locking overhead is reduced especially when multiple channels > are in use. > > The recv_pkt_list isn't actually necessary because the packets are > processed seque

Re: [PATCH net-next,v2,2/2] hyperv: Simplify the send_completion variables

2014-04-23 Thread David Miller
From: Haiyang Zhang Date: Mon, 21 Apr 2014 14:54:44 -0700 > The union contains only one member now, so we use the variables in it > directly. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Also applied, thanks. ___ devel mailing l

Re: [PATCH net-next 1/1] hyperv: Enable sendbuf mechanism on the send path

2014-04-23 Thread David Miller
From: "K. Y. Srinivasan" Date: Tue, 22 Apr 2014 11:03:32 -0700 > + skb = (struct sk_buff *) > + packet->send_completion_tid; As in netvsc_xmit_completion() this must be coded as: skb = (struct sk_buff *) (unsigned long)packet->send_completio

Re: [PATCH] Staging: octeon-usb: fixed a macro coding style issue

2014-04-25 Thread David Daney
On 04/25/2014 07:21 AM, Greg KH wrote: On Fri, Apr 25, 2014 at 10:48:22AM -0300, Nicolas Del Piano wrote: Fixed a coding style error, macros with complex values should be enclosed in parentheses. Signed-off-by: Nicolas Del Piano --- drivers/staging/octeon-usb/octeon-hcd.c |2 +- 1 file

Re: [PATCH V1 net-next 1/1] hyperv: Properly handle checksum offload

2014-04-28 Thread David Miller
From: "K. Y. Srinivasan" Date: Fri, 25 Apr 2014 20:55:23 -0700 > @@ -467,6 +467,9 @@ static int netvsc_start_xmit(struct sk_buff *skb, struct > net_device *net) > if (skb_is_gso(skb)) > goto do_lso; > > + if (skb->ip_summed != CHECKSUM_PARTIAL) > + goto do_s

[PATCH 28/38] Annotate hardware config module parameters in drivers/staging/media/

2017-04-05 Thread David Howells
some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/staging/media/. Suggested-by: Alan Cox Signed-off-by: David Howells cc: Mauro Carvalho Chehab cc: Greg Kroah-Hartman cc: linux-me...@vger.kernel.o

[PATCH 29/38] Annotate hardware config module parameters in drivers/staging/speakup/

2017-04-05 Thread David Howells
some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/staging/speakup/. Suggested-by: Alan Cox Signed-off-by: David Howells cc: Greg Kroah-Hartman cc: spea...@linux-speakup.org cc: de...@driverdev.osuos

[PATCH 30/38] Annotate hardware config module parameters in drivers/staging/vme/

2017-04-05 Thread David Howells
some drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/staging/vme/. Suggested-by: Alan Cox Signed-off-by: David Howells cc: Martyn Welch cc: Manohar Vanga cc: Greg Kroah-Hartman c

Re: [PATCH net-next 1/1] netvsc: Initialize all channel related state prior to opening the channel

2017-04-08 Thread David Miller
From: k...@exchange.microsoft.com Date: Thu, 6 Apr 2017 14:59:21 -0700 > From: K. Y. Srinivasan > > Prior to opening the channel we should have all the state setup to handle > interrupts. The current code does not do that; fix the bug. This bug > can result in faults in the interrupt path. >

Re: [PATCH 07/12] fs: btrfs: Use ktime_get_real_ts for root ctime

2017-04-12 Thread David Sterba
are used for vfs inode times as well. These can be > transitioned to using timespec64 when btrfs internally > changes to use timespec64 as well. > > Signed-off-by: Deepa Dinamani > Acked-by: David Sterba > Reviewed-by: Arnd Bergmann I'm going

RE: [PATCH 16/22] xen-blkfront: Make use of the new sg_map helper function

2017-04-18 Thread David Laight
* questionable error path out of here, > + * we WARN. > + */ > + WARN(1, "Non-mappable memory used in sg!"); > + return 1; > + } ... Perhaps add a flag to mark failure as 'unexpecte

[PATCH 01/25] staging: unisys: visorbus: combine response functions into a single one

2017-04-18 Thread David Kershner
There are several different controlvm response functions, consolidate them to one so we can simplify error handling. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 53 +++ 1 file changed, 22 insertions(+), 31 deletions

[PATCH 02/25] staging: unisys: visornic: remove keyword inline from function

2017-04-18 Thread David Kershner
Functions in c files don't need to be inlined, get rid of the keyword. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visornic/visornic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visornic/visornic_main

[PATCH 04/25] staging: unisys: visorbus: fixed indentation

2017-04-18 Thread David Kershner
Moved the brace to the left to fix the indentation issue. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging

[PATCH 06/25] staging: unisys: visorbus: add timeout to controlvm_periodic_work

2017-04-18 Thread David Kershner
Limit the amount that gets pulled from the queue on each try so we don't get stuck in an infinite loop if something has gone wrong with the s-Par firmware. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 3 ++- 1 file chang

[PATCH 00/25] staging: unisys: Remove POSTCODEs and allow boot with CONFIG_VMAP_STACK set to y

2017-04-18 Thread David Kershner
The following patch series removes the POSTCODE macros from the codebase, replacing them with dev_err where needed. It also fixes a problem with the drivers that were preventing them from working when CONFIG_VMAP_STACK was set to y. David Kershner (23): staging: unisys: visorbus: combine

[PATCH 05/25] staging: unisys: visorbus: update comment

2017-04-18 Thread David Kershner
Comment was outdated and did not reflect what was actually happening. Update the comment to reflect reality. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git

[PATCH 03/25] staging; unisys: visorbus: replace uint32 with int

2017-04-18 Thread David Kershner
Shouldn't use uint32 in the kernel, it can be replaced with int here. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset

[PATCH 07/25] staging: unisys: visorbus: handle visorchannel_write errors in code

2017-04-18 Thread David Kershner
Catch and report back errors when visorchannel_write fails. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchannel.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/staging/unisys/visorbus

[PATCH 08/25] staging: unisys: visorbus: remove NORETRY

2017-04-18 Thread David Kershner
Allow retry when allocating memory. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus

[PATCH 09/25] staging: unisys: visorbus: remove POSTCODE from create_visor_device

2017-04-18 Thread David Kershner
Remove POSTCODES from create_visor_device, when we fail log an error with dev_err. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/unisys

[PATCH 11/25] staging: unisys: visorbus: remove POSTCODE in create_bus_instance

2017-04-18 Thread David Kershner
Remove postcodes from create_bus_instance. If there is an error log it with dev_err. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/unisys

[PATCH 10/25] staging: unisys: visorbus: remove POSTCODE from chispet_init

2017-04-18 Thread David Kershner
Get rid of the postcodes from the function chipset_init. They were being noisy, so don't replace them with errors. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/u

[PATCH 17/25] staging: unisys: visorbus: remove POSTCODEs from bus_create

2017-04-18 Thread David Kershner
Removed the POSTCODEs from the function bus_create. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b

[PATCH 16/25] staging: unisys: visorbus: get rid of POSTCODEs in save_crash_msg

2017-04-18 Thread David Kershner
Replace POSTCODES in save_crash_msg with dev_err handling. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 24 +-- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/unisys/visorbus

[PATCH 13/25] staging: unisys: visorbus: remove noisy postcode in bus_destroy

2017-04-18 Thread David Kershner
Since kzalloc will display error the postcode becomes redundant, it can be removed. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b

[PATCH 12/25] staging: unisys: visorbus: remove noisy postcodes

2017-04-18 Thread David Kershner
Get rid of postcodes from visorbus_main.c that are just informational. They were not logging errors, we don't need to replace them with anything. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 21 +- 1 file chang

[PATCH 21/25] staging: unisys: visorbus: refactor setup_crash_devices_work_queue

2017-04-18 Thread David Kershner
The if statement was sending us down the happy path with the error path in the else. This can be simplified by having the if be the error and just falling through with the good path. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 11

[PATCH 15/25] staging: unisys: visorbus: remove postcodes in visorbus_init

2017-04-18 Thread David Kershner
Remove the POSTCODES in visorbus_init. Since there are no more POSTCODES in visorbus_main.c we can remove the reference to the vmcallinterface header file. No need for vmcallinterface in visorbus_main.c Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus

[PATCH 18/25] staging: unisys: visorbus: remove POSTCODE from bus_configure

2017-04-18 Thread David Kershner
Remove the POSTCODE logging from bus_configure, replace it with an error message if we fail dumping the errno. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff

[PATCH 20/25] staging: unisys: visorbus: get rid of POSTCODES in my_device_changestate

2017-04-18 Thread David Kershner
Replace POSTCODEs with dev_err in the function my_device_changestate. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b

[PATCH 22/25] staging: unisys: visorbus: remove postcodes in setup_crash_devices_work_queue

2017-04-18 Thread David Kershner
Replace postcodes with dev_err in the function setup_crash_device_work_queue. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 33 --- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/drivers/staging/unisys

[PATCH 14/25] staging: unisys: visorbus: remove noisy postcode from visorchipset_exit

2017-04-18 Thread David Kershner
The postcodes in visorchipset_exit were not displaying errors, they can just be removed. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c

[PATCH 19/25] staging: unisys: visorbus: remove POSTCODE from my_device_create

2017-04-18 Thread David Kershner
Replace the POSTCODEs with dev_err in my_device_create. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 24 +++ 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c

[PATCH 24/25] staging: unisys: visorbus: fix s-Par to boot with option CONFIG_VMAP_STACK set to y

2017-04-18 Thread David Kershner
n stack in issue_vmcall_io_controlvm_addr() to vmcall_controlvm_addr struct. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchipset.c | 33 ++- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/staging/unisys/visorbus/viso

[PATCH 23/25] staging: unisys: visorbus: remove POSTCODE from visorchipset_init

2017-04-18 Thread David Kershner
Remove POSTCODEs from visorchipset_init and replace them with dev_err when needed. Since there are no more POSTCODEs in the code, we can get rid of the data in the header file as well. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c

[PATCH 25/25] staging: unisys: visorhba: fix s-Par to boot with option CONFIG_VMAP_STACK set to y

2017-04-18 Thread David Kershner
xstat() to heap memory. Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/visorhba/visorhba_main.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisy

Re: [PATCH net-next 1/1] netvsc: Deal with rescinded channels correctly

2017-04-21 Thread David Miller
From: k...@exchange.microsoft.com Date: Wed, 19 Apr 2017 13:53:49 -0700 > From: K. Y. Srinivasan > > We will not be able to send packets over a channel that has been > rescinded. Make necessary adjustments so we can properly cleanup > even when the channel is rescinded. This issue can be trigerr

linux-4.12-rc1/drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_include/string_support.h:76: cart before the horse ?

2017-05-14 Thread David Binderman
++ix) /*Nothing else to do*/; Regards David Binderman ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

linux-4.12-rc1/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2966: cart before the horse ?

2017-05-14 Thread David Binderman
Hello there, linux-4.12-rc1/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2966]: (style) Array index 'i' is used before limits check. Source code is while (szLine[i] != '{' && i < strlen(szLine))

[PATCH 00/25] staging: unisys: visorbus: Change function names to be consistent with namespace

2017-05-19 Thread David Kershner
The s-Par visorbus driver had several functions with extremely generic names. This series attempts to clean up the names by making them more unique. This series also addresses other miscellaneous feedback. Jon Frisch (1): staging: unisys: visorbus: rename typ to cr_type Sameer Wadgaonkar (24):

[PATCH 02/25] staging: unisys: visorbus: renamed functions bus_create, bus_destroy and bus_configure to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed the functions bus_create() to visorbus_create(), bus_destroy() to visorbus_destroy() and bus_configure() to visorbus_configure Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus

[PATCH 05/25] staging: unisys: visorbus: renamed functions like *_bus_instance to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed functions * create_bus_instance() to visorbus_create_instance() * remove_bus_instance() to visorbus_remove_instance() Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus

[PATCH 03/25] staging: unisys: visorbus: renamed functions like bus_*_response to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed functions bus_create_response() to visorbus_create_response() and bus_destroy_response() to visorbus_destroy_response(). Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus

[PATCH 13/25] staging: unisys: visorbus: renamed #defines in visorchipset.c to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed #defines * UNISYS_SPAR_LEAF_ID to UNISYS_VISOR_LEAF_ID * UNISYS_SPAR_ID_EBX to UNISYS_VISOR_ID_EBX * UNISYS_SPAR_ID_ECX to UNISYS_VISOR_ID_ECX * UNISYS_SPAR_ID_EDX to UNISYS_VISOR_ID_EDX Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner

[PATCH 11/25] staging: unisys: visorbus: renamed structures in vbuschannel.h to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed structures * ultra_vbus_deviceinfo to visor_vbus_deviceinfo * spar_vbus_headerinfo to visor_vbus_headerinfo * spar_vbus_channel_protocol to visor_vbus_channel Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus

[PATCH 16/25] staging: unisys: visorbus: renamed enum in controlvmchannel.h to match driver namespace

2017-05-19 Thread David Kershner
-off-by: David Kershner --- drivers/staging/unisys/visorbus/controlvmchannel.h | 8 drivers/staging/unisys/visorbus/visorchipset.c | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/unisys/visorbus/controlvmchannel.h b/drivers/staging/unisys

[PATCH 10/25] staging: unisys: visorbus: renamed #defines in vbuschannel.h to match driver namespace

2017-05-19 Thread David Kershner
: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/vbuschannel.h | 9 - drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/staging/unisys/visorbus/vbuschannel.h b/drivers

[PATCH 09/25] staging: unisys: visorbus: renamed functions like my_device_* to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed functions * my_device_create() to visorbus_device_create() * my_device_changestate() to visorbus_device_changestate() * my_device_destroy() to visorbus_device_destroy() Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys

[PATCH 12/25] staging: unisys: visorbus: renamed #define in visorchannel.c to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed SPAR_CONSOLEVIDEO_CHANNEL_PROTOCOL_GUID to VISOR_CONSOLEVIDEO_CHANNEL_GUID and renamed const spar_video_guid to visor_video_guid Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchannel.c | 8 1

[PATCH 04/25] staging: unisys: visorbus: renamed functions like device_*_response to match driver namespace

2017-05-19 Thread David Kershner
() Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c| 8 drivers/staging/unisys/visorbus/visorbus_private.h | 8 drivers/staging/unisys/visorbus/visorchipset.c | 9

[PATCH 14/25] staging: unisys: visorbus: renamed #defines in controlvmchannel.h to match driver namespace

2017-05-19 Thread David Kershner
VISOR_CONTROLVM_CHANNEL_VERSIONID * SPAR_CONTROLVM_CHANNEL_OK_CLIENT to VISOR_CONTROLVM_CHANNEL_OK_CLIENT Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/controlvmchannel.h | 19 +++ drivers/staging/unisys/visorbus

[PATCH 01/25] staging: unisys: visorbus: rename typ to cr_type

2017-05-19 Thread David Kershner
From: Jon Frisch This patch renames enum crash_obj_type typ to cr_type. Signed-off-by: Jon Frisch Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorbus

[PATCH 06/25] staging: unisys: visorbus: renamed functions like chipset_bus_* to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed functions * chipset_bus_create() to visorchipset_bus_create() * chipset_bus_destroy() to visorchipset_bus_destroy() Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus

[PATCH 08/25] staging: unisys: visorbus: renamed function initiate_chipset_device_pause_resume to match driver namespace

2017-05-19 Thread David Kershner
From: Sameer Wadgaonkar Renamed function initiate_chipset_device_pause_resume() to visorchipset_initiate_device_pause_resume(). Signed-off-by: Sameer Wadgaonkar Reported-by: Greg Kroah-Hartman Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c | 11

<    2   3   4   5   6   7   8   9   10   11   >