[PATCH 2/7] staging: unisys: visorbus: relocate error-check from isr to registration

2017-01-09 Thread David Kershner
From: Tim Sell It just makes more sense to do the NULL-pointer check when the function is called to enable interrupts, rather than on *every* interrupt. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c | 10 -- 1 file changed

[PATCH 3/7] staging: unisys: visorbus: Replace parser_param_start with parser_name_get

2017-01-09 Thread David Kershner
Replace the general CONTROLVM string parser setup which only handled the name string with a specific name string retrieval function. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchipset.c | 53 +-- 1 file changed, 15

[PATCH 4/7] staging: unisys: visorbus: Remove duplicate invocation of init_rcv_bufs()

2017-01-09 Thread David Kershner
From: David Binder Removes the invocation to init_rcv_bufs() in visornic_resume() because that function is already called in visornic_enable_with_timeout(). Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/visornic/visornic_main.c | 2 -- 1 file changed, 2

[PATCH 5/7] staging: unisys: visornic: Reorder logic in visornic_enable_with_timeout()

2017-01-09 Thread David Kershner
From: David Binder Moves the call to napi_enable() before the call to init_rcv_bufs(), ensuring that messages are not put into the receive queue until the guest is ready to receive interrupts. Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/visornic

[PATCH 6/7] staging: unisys: visornic: Remove errant -EIO returns

2017-01-09 Thread David Kershner
From: David Binder Remove errant -EIOs that prevent us from calling either netif_start_queue() or napi_disable(). Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/visornic/visornic_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 7/7] staging: unisys: remove redundant unlocks of visornic_devdata.priv_lock

2017-01-09 Thread David Kershner
becoming corrupted. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visornic/visornic_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c index 3a638ca

[PATCH 1/7] staging: unisys: visorbus: Remove unused enum members

2017-01-09 Thread David Kershner
Visorchipset used to parse CONTROLVM messages with a variety of string information. All but the name string have been removed, but the code to handle this information remained. This patch removes the other values and handlers. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner

[PATCH] staging: ks7010: Fix brace style issue in ks_wlan_net.c

2017-01-14 Thread David Wittman
This change fixes a checkpatch error for "that open brace { should be on the previous line" as well as a related spacing warning. Signed-off-by: David Wittman --- drivers/staging/ks7010/ks_wlan_net.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/stag

Re: [PATCH net-next] net: Remove usage of net_device last_rx member

2017-01-18 Thread David Miller
From: Tobias Klauser Date: Wed, 18 Jan 2017 17:45:01 +0100 > The network stack no longer uses the last_rx member of struct net_device > since the bonding driver switched to use its own private last_rx in > commit 9f242738376d ("bonding: use last_arp_rx in slave_last_rx()"). > > However, some dri

[PATCH 10/10] staging: unisys: visorbus: Clarify reason for device pointer checks

2017-02-01 Thread David Kershner
From: David Binder Clarifies why the pointers returned from visorbus_get_device_by_id() in visorbus are validated. The check is performed in order to be extra careful, for the sake of added security, that the s-Par backend is providing us with a valid device. Signed-off-by: David Binder Signed

[PATCH 02/10] staging: unisys: visorbus: Remove unused struct in visorchannel.c

2017-02-01 Thread David Kershner
From: David Binder Removes struct safe_uis_queue, which is within struct visorchannel. The struct is not used anywhere in the s-Par drivers. Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchannel.c | 6 -- 1 file changed, 6 deletions

[PATCH 05/10] staging: unisys: visorbus: Clarify reason for pointer check in bus_destroy()

2017-02-01 Thread David Kershner
From: David Binder Clarifies why the pointer returned from visorbus_get_device_by_id() in bus_destroy() is validated. The check is performed in order to be extra careful, for the sake of added security, that the s-Par backend is providing us with a valid bus/device pair. Signed-off-by: David

[PATCH 03/10] staging: unisys: visorbus: Check controlvm message payload size

2017-02-01 Thread David Kershner
From: David Binder Checks the controlvm message's payload size before copying it into a parser_context struct's name region. Signed-off-by: David Binder Signed-off-by: David Kershner Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/visorchipset.c | 4 1 fi

[PATCH 06/10] staging: unisys: visornic: prevent hang doing 'modprobe -r visornic'

2017-02-01 Thread David Kershner
n an operational network. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visornic/visornic_main.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_

[PATCH 01/10] staging: unisys: include: fix improper use of dma_data_direction

2017-02-01 Thread David Kershner
, and so using the standard version creates an unnecessary dependency between the kernel and s-Par. Signed-off-by: Steven Matthews Signed-off-by: David Kershner --- drivers/staging/unisys/include/iochannel.h | 11 +++-- drivers/staging/unisys/visorhba/visorhba_main.c | 22

[PATCH 09/10] staging: unisys: visorbus: Clarify reason for bus pointer checks

2017-02-01 Thread David Kershner
From: David Binder Clarifies why the pointers returned from visorbus_get_device_by_id() in visorbus are validated. The check is performed in order to be extra careful, for the sake of added security, that the s-Par backend is providing us with a valid bus. Signed-off-by: David Binder Reported

[PATCH 08/10] staging: unisys: visorbus: get rid of unused payload info

2017-02-01 Thread David Kershner
We no longer send payloads back to the s-Par firmware, we can get rid of the initialize and destroy functions since they weren't actually being used just created and destroyed. Signed-off-by: David Kershner Reviewed-by: David Binder --- drivers/staging/unisys/visorbus/visorchipset.c

[PATCH 04/10] staging: unisys: visorbus: Consolidate kobject functions

2017-02-01 Thread David Kershner
From: David Binder Simplifies kobject usage in visorchipset.c by combining pairs of functions that are better expressed combined. Signed-off-by: David Binder Signed-off-by: David Kershner Reported-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/visorchipset.c | 76

[PATCH 00/10] staging: unisys: additional error handling and channel cleanups.

2017-02-01 Thread David Kershner
also introduces some changes being made to the functions that invoke the uevents that occur on chipset_ready/selftest/notready messages from the s-Par firmware. This simplifies the functions so that we can tackle more challenging changes in later patches. David Binder (6): staging: unisys

[PATCH 07/10] staging: unisys: visorbus: remove putfile data structures

2017-02-01 Thread David Kershner
There were several unused data structures dealing with putfile that are no longer being used. So get rid of them. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 54 +--- 1 file changed, 54 deletions(-) diff --git a

Re: [PATCHv1] net-next: treewide use is_vlan_dev() helper function.

2017-02-06 Thread David Miller
From: Parav Pandit Date: Sat, 4 Feb 2017 11:00:49 -0600 > This patch makes use of is_vlan_dev() function instead of flag > comparison which is exactly done by is_vlan_dev() helper function. > > Signed-off-by: Parav Pandit > Reviewed-by: Daniel Jurgens Applied. ___

staging/dgap/dgap.c:981: bad if test ?

2015-01-22 Thread David Binderman
David Binderman ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: staging/dgap/dgap.c:981: bad if test ?

2015-01-22 Thread David Binderman
!= PORTS ||     module_type != MODEM) { I used the static analyser cppcheck to find these two bugs, but you might be able to find similar problems by using gcc compiler flag -Wlogical-op. Regards David Binderman > Date: Thu, 22 Jan 2015 13:14

RE: staging/dgap/dgap.c:981: bad if test ?

2015-01-22 Thread David Binderman
Hello there, > On Thu, Jan 22, 2015 at 10:20:44AM +0000, David Binderman wrote: >> I used the static analyser cppcheck to find these two bugs, but >> you might be able to find similar problems by using gcc compiler >> flag -Wlogical-o

Re: [PATCH v2] net: hyperv: else branch not necessary

2015-01-27 Thread David Miller
From: Nicholas Mc Guire Date: Sun, 25 Jan 2015 19:08:37 +0100 > As the if completes with a unconditional goto the else branch > is not needed here. > > Signed-off-by: Nicholas Mc Guire > --- > > v2: added missing subsystem string in subject line - patch unchanged The feedback you were given w

Re: [PATCH net] hyperv: Fix the error processing in netvsc_send()

2015-01-31 Thread David Miller
From: Haiyang Zhang Date: Thu, 29 Jan 2015 12:34:49 -0800 > The existing code frees the skb in EAGAIN case, in which the skb will be > retried from upper layer and used again. > Also, the existing code doesn't free send buffer slot in error case, because > there is no completion message for unsen

Re: [Xen-devel] [Patch v4 01/23] ACPICA: Resources: Provide common part for struct acpi_resource_address structures.

2015-02-05 Thread David Vrabel
- new->start_addr = address64.minimum; > - new->length = address64.address_length; > + new->start_addr = address64.address.minimum; > + new->length = address64.address.address_length; > list_add_tail(&new->list, &mem_device->res_list); >

Re: [PATCH] hyperv: fix sparse warnings

2015-02-05 Thread David Miller
From: Lad Prabhakar Date: Thu, 5 Feb 2015 15:06:33 + > From: "Lad, Prabhakar" > > this patch fixes following sparse warnings: > > netvsc.c:688:5: warning: symbol 'netvsc_copy_to_send_buf' was not declared. > Should it be static? > rndis_filter.c:627:5: warning: symbol 'rndis_filter_set_o

Re: [PATCH] staging: slicoss: slicoss: Removed variables that is never used

2015-02-11 Thread David Matlack
On Sat, Jan 31, 2015 at 7:13 AM, Rickard Strandqvist wrote: > Variable was assigned a value that was never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > ---

Re: [PATCH net-next] hyperv: Implement netvsc_get_channels() ethool op

2015-02-28 Thread David Miller
From: Andrew Schwartzmeyer Date: Thu, 26 Feb 2015 16:27:14 -0800 > This adds support for reporting the actual and maximum combined channels > count of the hv_netvsc driver via 'ethtool --show-channels'. > > This required adding 'max_chn' to 'struct netvsc_device', and assigning > it 'rsscap.num_

Re: [PATCH V3 0/2 net-next] hyperv: Enable batched notification

2015-03-17 Thread David Miller
From: "K. Y. Srinivasan" Date: Tue, 17 Mar 2015 09:02:25 -0700 > Take into consideration the xmit_more flag in skb to decide if we should > notify the host as we place packets in VMBUS. > > The VMBUS API that would give us this control is already in Greg's tree, in > this > patch-set, that API

Re: [PATCH V3 0/2 net-next] hyperv: Enable batched notification

2015-03-17 Thread David Miller
From: KY Srinivasan Date: Tue, 17 Mar 2015 20:07:10 + > I pulled down the net-next tree and the issue is with the first patch: > 0001-Drivers-hv-vmbus-Export-the-vmbus_sendpacket_pagebuf.patch > > The net-next tree is not current with Greg's tree and this patch is on code > that > is in Gre

Re: [PATCH net-next] hv_netvsc: Implement batching in send buffer

2015-03-29 Thread David Miller
From: Haiyang Zhang Date: Thu, 26 Mar 2015 09:03:37 -0700 > With this patch, we can send out multiple RNDIS data packets in one send > buffer > slot and one VMBus message. It reduces the overhead associated with VMBus > messages. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasa

Re: [PATCH net-next] hv_netvsc: remove vmbus_are_subchannels_present() in rndis_filter_device_add()

2015-03-29 Thread David Miller
From: Haiyang Zhang Date: Thu, 26 Mar 2015 16:20:58 -0700 > The vmbus_are_subchannels_present() also involves opening the channels, which > may be too early at this point. Checking for subchannels is not necessary > here. > So this patch removes it. Subchannels will be opened when offer messages

Re: [PATCH net-next 0/2] hv_netvsc: Eliminate memory allocation in the send path

2015-03-31 Thread David Miller
From: "K. Y. Srinivasan" Date: Sun, 29 Mar 2015 21:07:58 -0700 > The network protocol used to communicate with the host is the remote ndis > (rndis) > protocol. We need to decorate each outgoing packet with a rndis header and > additional rndis state (rndis per-packet state). To manage this stat

[patch] android, lmk: avoid setting TIF_MEMDIE if process has already exited

2015-04-02 Thread David Rientjes
lid before setting TIF_MEMDIE by way of mark_tsk_oom_victim(). Cc: "Arve Hjønnevåg" Cc: Riley Andrews Acked-by: Michal Hocko Signed-off-by: David Rientjes --- drivers/staging/android/lowmemorykiller.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --

Re: [PATCH net-next] hv_netvsc: Fix VF register on vlan devices

2016-06-03 Thread David Miller
From: Haiyang Zhang Date: Thu, 2 Jun 2016 12:02:04 -0700 > Added a condition to avoid vlan devices with same MAC registering > as VF. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied. ___ devel mailing list de...@linuxdriver

[PATCH v3 00/30] Fixed issues raised by tglx, then move visorbus to drivers/virt

2016-06-04 Thread David Kershner
: Remove reference to unused STANDALONE_CLIENT David Binder (13): staging: unisys: visorbus: remove unused module parameters staging: unisys: visorbus: remove unused struct staging: unisys: visorbus: modify format string to match argument staging: unisys: visornic: Correct comment spelling

[PATCH v3 01/30] staging: unisys: visorbus change -1 return values

2016-06-04 Thread David Kershner
From: Erik Arfvidson This patch removes the vague -1 return values from the write_vbus channel functions. Nobody was checking the return values and the value stored into the vbus info is not critical to the functioning of the device. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner

[PATCH v3 02/30] staging: unisys: visorchipset change -1 return value

2016-06-04 Thread David Kershner
From: Erik Arfvidson This patch changes the vague -1 return value to -EINVAL It also modifies the caller of parahotplug_request_complete to check the return value and return appropriate result. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers

[PATCH v3 06/30] staging: unisys: visorbus: modify format string to match argument

2016-06-04 Thread David Kershner
From: David Binder Modifies the format string of snprintf to expect an unsigned int instead of a signed one, per the supplied argument. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 2 +- 1 file changed

[PATCH v3 04/30] staging: unisys: visorbus: remove unused module parameters

2016-06-04 Thread David Kershner
From: David Binder Removes unused module parameters from visorbus_main.c, in response to findings by SonarQube. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 9 + 1 file changed, 1 insertion

[PATCH v3 11/30] staging: unisys: visorbus: use kernel timer instead of workqueue

2016-06-04 Thread David Kershner
, because none of them ever perform any operations that would be invalid in atomic context. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/include/visorbus.h | 10 +++-- drivers/staging/unisys/visorbus/visorbus_main.c | 54 +++-- 2 files

[PATCH v3 16/30] staging: unisys: Remove reference to unused STANDALONE_CLIENT

2016-06-04 Thread David Kershner
From: Bryan Thompson The STANDALONE_CLIENT define is no longer used by Unisys driver code. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/visorbus.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging

[PATCH v3 15/30] staging: unisys: visorbus: Remove unused functions

2016-06-04 Thread David Kershner
From: Bryan Thompson Remove visorbus_clear_channel, visorchannel_signalqueue_slots_avail, visorchannel_signalqueue_max_slots, visorchannel_clear, and visorchannel_debug which are no longer called by any driver. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH v3 07/30] staging: unisys: visornic: Correct comment spelling mistake

2016-06-04 Thread David Kershner
From: David Binder Fixes a comment spelling mistake in visornic. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visornic/visornic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys

[PATCH v3 10/30] staging: unisys: visorinput: remove unnecessary locking

2016-06-04 Thread David Kershner
red state in devdata->interrupts_enabled. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorinput/visorinput.c | 57 +- 1 file changed, 47 insertions(+), 10 deletions(-) diff --git a/drivers/staging/unisys/visorinput/visorinput.c b/d

[PATCH v3 12/30] staging: unisys: visorbus: remove periodic_work.h/.c

2016-06-04 Thread David Kershner
From: Tim Sell These files were made no-longer-necessary by recent commits. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/include/periodic_work.h | 40 - drivers/staging/unisys/visorbus/Makefile| 1 - drivers/staging/unisys/visorbus

[PATCH v3 09/30] staging: unisys: visorbus: removed unused periodic_test_workqueue

2016-06-04 Thread David Kershner
From: Tim Sell periodic_test_workqueue was an unused relic from the past, and was removed. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/unisys

[PATCH v3 05/30] staging: unisys: visorbus: remove unused struct

2016-06-04 Thread David Kershner
From: David Binder Removes unused struct definition, channel_size_info, in response to findings by SonarQube. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 6 -- 1 file changed, 6 deletions(-) diff

[PATCH v3 03/30] staging: unisys: iovmcall_gnuc.h change -1 return values

2016-06-04 Thread David Kershner
From: Erik Arfvidson This patch changes the vague -1 return values to -EPERM. This operation is not supported is a good alternative to -1 because the return is basically telling the caller that the processor doesn't support vmcall operations. Signed-off-by: Erik Arfvidson Signed-off-by:

[PATCH v3 14/30] staging: unisys: visorbus: Remove unnecessary EXPORT_SYMBOL statements

2016-06-04 Thread David Kershner
Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 1 - drivers/staging/unisys/visorbus/visorchannel.c | 17 - drivers/staging/unisys/visorbus/visorchipset.c | 2 -- 3 files changed, 20 deletions(-) diff --git a/drivers

[PATCH v3 22/30] staging: unisys: visorbus: Move visorbus-unique functions to private header

2016-06-04 Thread David Kershner
From: David Binder Moves function prototypes that are unique to visorbus from include/visorbus.h to visorbus/visorbus_private.h. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/visorbus.h | 25

[PATCH v3 17/30] staging: unisys: visorbus: remove unused parameter from function

2016-06-04 Thread David Kershner
From: Tim Sell The off parameter to visorchannel_create_guts() was never used, so it was removed. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchannel.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v3 08/30] staging: unisys: include: Remove thread-related enum members

2016-06-04 Thread David Kershner
From: David Binder Code relating to ktheads was previously removed from s-Par driver code. This patch cleans up lingering remnants of kthreads by removing thread- related enum types. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys

[PATCH v3 23/30] staging: unisys: visorbus: rectify kerneldoc comment for struct

2016-06-04 Thread David Kershner
From: David Binder Fixes the kerneldoc comment for struct visor_device - the struct members were not listed with the appropriate @ prefix. Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/include/visorbus.h | 34 +++ 1 file

[PATCH v3 13/30] staging: unisys: visorbus: Make visordriver_callback_lock a mutex

2016-06-04 Thread David Kershner
From: Bryan Thompson visordriver_callback_lock is just a binary semaphore that logically makes more sense as a mutex. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/visorbus.h | 2 +- drivers/staging/unisys

[PATCH v3 28/30] include: linux: visorbus: Add visorbus to include/linux directory

2016-06-04 Thread David Kershner
folders. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/MAINTAINERS| 2 +- drivers/staging/unisys/visorbus/Makefile | 2 -- drivers/staging/unisys/visorbus/controlvmchannel.h| 2 +- drivers

[PATCH v3 29/30] Documentation: Move visorbus documentation from staging to Documentation/

2016-06-04 Thread David Kershner
This patch simple does a git mv of the drivers/staging/unisys/Documentation directory to Documentation. Renames overview.txt to visorbus.txt and renames sysfs-platform-visorchipset to the correct name sysfs-bus-visorbus. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- .../ABI/stable

[PATCH v3 26/30] staging: unisys: visorbus: fix visorbus_private.h comments

2016-06-04 Thread David Kershner
From: Tim Sell This patch ONLY touches comment lines, i.e., NO executable code is affected. Comments were fixed in visorbus_private.h: * Minor typos were corrected. * Useless comments were removed. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus

[PATCH v3 18/30] staging: unisys: visorbus: fix commenting in vbusdevinfo.h

2016-06-04 Thread David Kershner
From: David Binder This patch ONLY touches comment lines, i.e., NO executable code is affected. * All functions worthy of documenting now use standard kerneldoc formatting. * Multi-line comments were tweaked so as to use appropriate conventions. * Minor typos were corrected. Signed-off-by

[PATCH v3 30/30] drivers: Add visorbus to the drivers directory

2016-06-04 Thread David Kershner
visorbus is currently located at drivers/staging/visorbus, this patch moves it to drivers/virt. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/Kconfig| 3 +-- drivers/staging/unisys/Makefile

[PATCH v3 27/30] staging: unisys: Move vbushelper.h to visorbus directory

2016-06-04 Thread David Kershner
Only visorbus needs this header file so move it to visorbus directory. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/{include => visorbus}/vbushelper.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename drivers/staging/unisys/{include => vi

[PATCH v3 20/30] staging: unisys: visorbus: fix visorchannel.c comments

2016-06-04 Thread David Kershner
From: David Binder This patch ONLY touches comment lines, i.e., NO executable code is affected. Comments were fixed in visorchannel.c: * All functions worthy of documenting now use standard kerneldoc formatting. * Multi-line comments were tweaked so as to use appropriate conventions. * Minor

[PATCH v3 21/30] staging: unisys: visorbus: Rectify commenting in visorchipset.c

2016-06-04 Thread David Kershner
From: David Binder Adds kerneldoc formatting to appropriate functions. Other multi-line comments now use proper formatting. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 292 - 1

[PATCH v3 19/30] staging: unisys: visorbus: fix commenting in visorbus_main.c

2016-06-04 Thread David Kershner
From: David Binder This patch ONLY touches comment lines, i.e., NO executable code is affected. * All functions worthy of documenting now use standard kerneldoc formatting. * Improper uses of kerneldoc formatting were converted to standard multi-line comments. * Multi-line comments were

[PATCH v3 25/30] staging: unisys: visorbus: Rename function to follow existing convention

2016-06-04 Thread David Kershner
From: David Binder Renames visorchipset_device_pause_response to device_pause_response, thereby following the convention that other responder functions follow. Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c| 4 ++-- drivers

[PATCH v3 24/30] staging: unisys: visorbus: Remove notifier-related code from visorbus

2016-06-04 Thread David Kershner
From: David Binder When this functionality was first implemented, visorchipset and visorbus were separate drivers, which necessitated a registration mechanism for them to communicate. More-recently, visorchipset and visorbus were combined into a single driver, and now exist as separate source

Re: [PATCH net-next v2 0/5] hv_netvsc: cleanup after untangling the pointer mess

2016-06-05 Thread David Miller
From: Vitaly Kuznetsov Date: Fri, 3 Jun 2016 17:50:57 +0200 > Changes since v1: > - resend when net-next is open [David Miller] > - rebased to current net-next. > > After we made traveling through our internal structures explicit it became > obvious that some functions t

Re: [PATCH net-next v2] netvsc: get rid of completion timeouts

2016-06-08 Thread David Miller
From: Vitaly Kuznetsov Date: Wed, 8 Jun 2016 19:17:41 +0200 > I'm hitting 5 second timeout in rndis_filter_set_rss_param() while setting > RSS parameters for the device. When this happens we end up returning > -ETIMEDOUT from the function and rndis_filter_device_add() falls back to > setting >

[PATCH v4 02/29] staging: unisys: visorbus: check parahotplug_request_complete_result

2016-06-08 Thread David Kershner
From: Erik Arfvidson This patch modifies the caller of parahotplug_request_complete() to check the return value and return appropriate result. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 5 - 1

[PATCH v4 00/29] Fixed issues raised by tglx, then move visorbus to drivers/virt

2016-06-08 Thread David Kershner
unused STANDALONE_CLIENT David Binder (13): staging: unisys: visorbus: remove unused module parameters staging: unisys: visorbus: remove unused struct staging: unisys: visorbus: modify format string to match argument staging: unisys: visornic: Correct comment spelling mistake staging

[PATCH v4 03/29] staging: unisys: visorbus: remove unused module parameters

2016-06-08 Thread David Kershner
From: David Binder Removes unused module parameters from visorbus_main.c, in response to findings by SonarQube. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 9 + 1 file changed, 1 insertion

[PATCH v4 06/29] staging: unisys: visornic: Correct comment spelling mistake

2016-06-08 Thread David Kershner
From: David Binder Fixes a comment spelling mistake in visornic. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visornic/visornic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys

[PATCH v4 04/29] staging: unisys: visorbus: remove unused struct

2016-06-08 Thread David Kershner
From: David Binder Removes unused struct definition, channel_size_info, in response to findings by SonarQube. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 6 -- 1 file changed, 6 deletions(-) diff

[PATCH v4 01/29] staging: unisys: visorbus: remove return values for write_vbus functions

2016-06-08 Thread David Kershner
From: Erik Arfvidson This patch removes the return values from the write_vbus_* channel functions. Nobody was checking the return values and the value stored into the vbus info is not critical to the functioning of the device. Signed-off-by: Erik Arfvidson Signed-off-by: David Kershner

[PATCH v4 05/29] staging: unisys: visorbus: modify format string to match argument

2016-06-08 Thread David Kershner
From: David Binder Modifies the format string of snprintf to expect an unsigned int instead of a signed one, per the supplied argument. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 2 +- 1 file changed

[PATCH v4 07/29] staging: unisys: include: Remove thread-related enum members

2016-06-08 Thread David Kershner
From: David Binder Code relating to ktheads was previously removed from s-Par driver code. This patch cleans up lingering remnants of kthreads by removing thread- related enum types. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys

[PATCH v4 10/29] staging: unisys: visorbus: use kernel timer instead of workqueue

2016-06-08 Thread David Kershner
, because none of them ever perform any operations that would be invalid in atomic context. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/include/visorbus.h | 10 +++-- drivers/staging/unisys/visorbus/visorbus_main.c | 54 +++-- 2 files

[PATCH v4 13/29] staging: unisys: visorbus: Remove unnecessary EXPORT_SYMBOL statements

2016-06-08 Thread David Kershner
Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 1 - drivers/staging/unisys/visorbus/visorchannel.c | 17 - drivers/staging/unisys/visorbus/visorchipset.c | 2 -- 3 files changed, 20 deletions(-) diff --git a/drivers

[PATCH v4 09/29] staging: unisys: visorinput: remove unnecessary locking

2016-06-08 Thread David Kershner
red state in devdata->interrupts_enabled. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorinput/visorinput.c | 57 +- 1 file changed, 47 insertions(+), 10 deletions(-) diff --git a/drivers/staging/unisys/visorinput/visorinput.c b/d

[PATCH v4 08/29] staging: unisys: visorbus: removed unused periodic_test_workqueue

2016-06-08 Thread David Kershner
From: Tim Sell periodic_test_workqueue was an unused relic from the past, and was removed. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/unisys

[PATCH v4 24/29] staging: unisys: visorbus: Rename function to follow existing convention

2016-06-08 Thread David Kershner
From: David Binder Renames visorchipset_device_pause_response to device_pause_response, thereby following the convention that other responder functions follow. Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c| 4 ++-- drivers

[PATCH v4 14/29] staging: unisys: visorbus: Remove unused functions

2016-06-08 Thread David Kershner
From: Bryan Thompson Remove visorbus_clear_channel, visorchannel_signalqueue_slots_avail, visorchannel_signalqueue_max_slots, visorchannel_clear, and visorchannel_debug which are no longer called by any driver. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH v4 11/29] staging: unisys: visorbus: remove periodic_work.h/.c

2016-06-08 Thread David Kershner
From: Tim Sell These files were made no-longer-necessary by recent commits. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/include/periodic_work.h | 40 - drivers/staging/unisys/visorbus/Makefile| 1 - drivers/staging/unisys/visorbus

[PATCH v4 17/29] staging: unisys: visorbus: fix commenting in vbusdevinfo.h

2016-06-08 Thread David Kershner
From: David Binder This patch ONLY touches comment lines, i.e., NO executable code is affected. * All functions worthy of documenting now use standard kerneldoc formatting. * Multi-line comments were tweaked so as to use appropriate conventions. * Minor typos were corrected. Signed-off-by

[PATCH v4 25/29] staging: unisys: visorbus: fix visorbus_private.h comments

2016-06-08 Thread David Kershner
From: Tim Sell This patch ONLY touches comment lines, i.e., NO executable code is affected. Comments were fixed in visorbus_private.h: * Minor typos were corrected. * Useless comments were removed. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus

[PATCH v4 18/29] staging: unisys: visorbus: fix commenting in visorbus_main.c

2016-06-08 Thread David Kershner
From: David Binder This patch ONLY touches comment lines, i.e., NO executable code is affected. * All functions worthy of documenting now use standard kerneldoc formatting. * Improper uses of kerneldoc formatting were converted to standard multi-line comments. * Multi-line comments were

[PATCH v4 23/29] staging: unisys: visorbus: Remove notifier-related code from visorbus

2016-06-08 Thread David Kershner
From: David Binder When this functionality was first implemented, visorchipset and visorbus were separate drivers, which necessitated a registration mechanism for them to communicate. More-recently, visorchipset and visorbus were combined into a single driver, and now exist as separate source

[PATCH v4 20/29] staging: unisys: visorbus: Rectify commenting in visorchipset.c

2016-06-08 Thread David Kershner
From: David Binder Adds kerneldoc formatting to appropriate functions. Other multi-line comments now use proper formatting. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/visorbus/visorchipset.c | 292 - 1

[PATCH v4 21/29] staging: unisys: visorbus: Move visorbus-unique functions to private header

2016-06-08 Thread David Kershner
From: David Binder Moves function prototypes that are unique to visorbus from include/visorbus.h to visorbus/visorbus_private.h. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/visorbus.h | 25

[PATCH v4 22/29] staging: unisys: visorbus: rectify kerneldoc comment for struct

2016-06-08 Thread David Kershner
From: David Binder Fixes the kerneldoc comment for struct visor_device - the struct members were not listed with the appropriate @ prefix. Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/include/visorbus.h | 34 +++ 1 file

[PATCH v4 26/29] staging: unisys: Move vbushelper.h to visorbus directory

2016-06-08 Thread David Kershner
Only visorbus needs this header file so move it to visorbus directory. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/{include => visorbus}/vbushelper.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename drivers/staging/unisys/{include => vi

[PATCH v4 16/29] staging: unisys: visorbus: remove unused parameter from function

2016-06-08 Thread David Kershner
From: Tim Sell The off parameter to visorchannel_create_guts() was never used, so it was removed. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchannel.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v4 19/29] staging: unisys: visorbus: fix visorchannel.c comments

2016-06-08 Thread David Kershner
From: David Binder This patch ONLY touches comment lines, i.e., NO executable code is affected. Comments were fixed in visorchannel.c: * All functions worthy of documenting now use standard kerneldoc formatting. * Multi-line comments were tweaked so as to use appropriate conventions. * Minor

[PATCH v4 12/29] staging: unisys: visorbus: Make visordriver_callback_lock a mutex

2016-06-08 Thread David Kershner
From: Bryan Thompson visordriver_callback_lock is just a binary semaphore that logically makes more sense as a mutex. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/visorbus.h | 2 +- drivers/staging/unisys

[PATCH v4 15/29] staging: unisys: Remove reference to unused STANDALONE_CLIENT

2016-06-08 Thread David Kershner
From: Bryan Thompson The STANDALONE_CLIENT define is no longer used by Unisys driver code. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/visorbus.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging

[PATCH v4 29/29] drivers: Add visorbus to the drivers/virt directory

2016-06-08 Thread David Kershner
visorbus is currently located at drivers/staging/visorbus, this patch moves it to drivers/virt. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/Kconfig| 3 +-- drivers/staging/unisys/Makefile

[PATCH v4 28/29] Documentation: Move visorbus documentation from staging to Documentation/

2016-06-08 Thread David Kershner
This patch simple does a git mv of the drivers/staging/unisys/Documentation directory to Documentation. Renames overview.txt to visorbus.txt and renames sysfs-platform-visorchipset to the correct name sysfs-bus-visorbus. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- .../ABI/stable

[PATCH v4 27/29] include: linux: visorbus: Add visorbus to include/linux directory

2016-06-08 Thread David Kershner
folders. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/MAINTAINERS| 2 +- drivers/staging/unisys/visorbus/Makefile | 2 -- drivers/staging/unisys/visorbus/controlvmchannel.h| 2 +- drivers

<    6   7   8   9   10   11   12   13   14   15   >