rect check logic
Signed-off-by: Alan Cox
---
drivers/staging/et131x/et131x.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 6413500..cc600df 100644
--- a/drivers/staging/et131x/et131x.c
+++
lementation that it can't. It used to fail.
This seems to be a ton of unneccessary churn that will end up just having
to be reversed again some day in the future.
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverpro
> +
> + return err;
> +}
> +
> static const struct tegra_ehci_soc_config tegra30_soc_config = {
> .has_hostpc = true,
> };
> @@ -431,6 +505,11 @@ static int tegra_ehci_probe(struct platform_device *pdev)
> goto cleanup_hcd_create;
> }
ted with the current console.
* Invoked by ioctl().
*
* Locking: called without locks. Calls the ldisc wrongly with
* unsafe methods,
*/
from which I deduce that with everyone using X nobody ever bothered to
fix it. So before you look too hard at the speakup code you might want to
review the in
wake_up(&mhcd.waitq);
> +
> + return ret;
> +}
> +
> +/**
> + * Dequeues an URB.
> + */
> +static int mausb_urb_dequeue(struct usb_hcd *hcd, struct urb *urb, int
> status)
> +{
> + int ret = 0;
> + struct mausb_host_ep*ep = usb_to_ma_endpoint(urb->ep);
> + struct mausb_urb*maurb = usb_urb_to_mausb_urb(urb);
> + unsigned long irq_flags;
> +
> + /* For debugging - we want to know who initiated URB dequeue. */
> + dump_stack();
Debugging things like this should be removed before a patch is submitted.
That's enough for now. Obviously there are a lot of issues in this
driver which need to be fixed up.
Alan Stern
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
gt; >
> > Endianness bug.
> >
>
> Could you elaborate?
> It was my understanding that this buffer was host-endian.
> Is this an unacceptable way to clear the buffer?
I don't understand Oliver's objection here. The buffer is
little-endian, just as it is for real hubs. The code seems correct.
Alan Stern
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, 12 Nov 2014, Sean O. Stalley wrote:
> On Tue, Nov 11, 2014 at 10:54:30AM -0500, Alan Stern wrote:
> > On Mon, 10 Nov 2014, Stephanie Wallick wrote:
> >
> > > +static struct mausb_hcd mhcd;
> >
> > Only one statically-allocated structure? What if s
ot sure why we can't make our hcd a platform device,
> especially since dummy_hcd & the usbip's hcd are both platform devices.
A platform device is the right way to go.
Alan Stern
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
lp would
> be appreciated.
> Also patch 2/2 doesn't correct any cosmetic changes reported by checkpatch.pl
> as explained in TODO step 6.
Please don't. Right now we know what work is to be done and tested.
Alan
_
gt; For this reason I'm tempted to postpone applying this patch at least
> until the other drivers are available.
Yes - unless someone has a different controller and that sensor on a
board so can test it that way ?
Alan
___
devel mailing
On Wed, 2017-11-22 at 00:31 -0500, Sinan Kaya wrote:
> pci_get_bus_and_slot() is restrictive such that it assumes domain=0
> as
> where a PCI device is present. This restricts the device drivers to
> be
> reused for other domain numbers.
The ISP v2 will always been in
On Wed, 22 Nov 2017 12:20:47 +
Alan Cox wrote:
> On Wed, 2017-11-22 at 00:31 -0500, Sinan Kaya wrote:
> > pci_get_bus_and_slot() is restrictive such that it assumes domain=0
> > as
> > where a PCI device is present. This restricts the device drivers to
> > be
case of ov2680, we don't seem to use the timestamp at
> all, so I just remove it.
>
> Signed-off-by: Arnd Bergmann
Reviewed-by: Alan Cox
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, 27 Nov 2017 12:44:50 +
Jeremy Sowden wrote:
> Changed the types of some arrays from int16_t to s16W
Which are the same type, except int16_t is the standard form.
No point.
Alan
___
devel mailing list
de...@linuxdriverproject.org
h
the
> zeroes afterwards.
Where they are only used once in the tree it might be even cleaner to
just do
static struct foo = FOO_DEFAULT_BAR;
foo.x = 12;
foo.bar = &foo;
etc in the code.
Alan
___
devel mailing list
de...@linuxdri
> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_pipe_public.h
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_pipe_public.h
> @@ -152,14 +152,6 @@ struct ia_css_pipe_config {
> };
>
Thani you that's a really
Dear sir ,
I KELLY ALAN purchasing and sales manager of CFM INTERNATIONAL .Our
Company specialised in Supplying computer hardware and Electronic .We
want to extend our supplier list because of concurrency in prices on the
international market. We are seeking a supplier with whom we can to
Dear sir ,
I KELLY ALAN purchasing and sales manager of CFM INTERNATIONAL .Our
Company specialised in Supplying computer hardware and Electronic .We
want to extend our supplier list because of concurrency in prices on the
international market. We are seeking a supplier with whom we can to
Dear sir ,
I KELLY ALAN purchasing and sales manager of CFM INTERNATIONAL .Our
Company specialised in Supplying computer hardware and Electronic .We
want to extend our supplier list because of concurrency in prices on the
international market. We are seeking a supplier with whom we can to
On Wed, 2017-03-01 at 11:25 +0100, Julia Lawall wrote:
> In both of the cited files (only one is shown), buffer is allocated
> using
> devm_kzalloc, so the kfree is not appropriate.
>
Thanks I'll get these fixed up.
Alan
___
deve
On Mon, 2017-03-13 at 15:34 +0300, Dan Carpenter wrote:
> md_type is an enum. On my tests, GCC treats it as unsigned but
> according to the C standard it's an implementation dependant thing so
> we
> should check for negatives.
Can do but the kernel assumes GNU C everywhere else
s for same reason with kzalloc)
This is true but please don't apply this. There are about five other
layers of indirection for memory allocators that want removing first so
that the driver just uses the correct kmalloc/kzalloc/kv* functions
> + if (IS_ENABLED(CONFI_PM)) {
I think not.
Please actually test build both ways at the very least.
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
size should always cover the four strings.
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
rn (although clearly this path never happens in the real
world since that bug is in lots of product 8)).
Added to my queue.
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> "i", /* ion */
> ^~~
NAK
I've sent a patch to sort this out properly we shouldn't be using
string arrays for single char values to start with...
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdri
> > 2 --
> > 1 file changed, 2 deletions(-)
>
> Ugh, Alan, what's going on here, I thought you fixed this?
I sent you a patch that removed the arrays entirely and turned it into
a single string as well as removing the define. Not quite sure what
happened but I've
ise - but it should also have
something in the commit message.
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
where there are ISP2400/ISP2401 ifdefs ?
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> Maybe it would be good to improve the names at the same time?
Its scheduled for deletion - please don't bother.
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
s an interface for the emulated OS but makes no
effort to emulate it as if it was a real hardware. If you think of it as
a funky emulator interface all is good. If you think about it as
"hardware" you've got the wrong model and chunks of Goldfish make less
sense.
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, 2015-04-17 at 11:20 +0300, Dan Carpenter wrote:
> Actually, my patch seems like a good idea to me but it's one of those
> things that someone should probably test. Unless someone can test
> goldfish on a 32 bit system with 64 bit dma addresses
No such "sy
On Fri, 2015-04-17 at 16:59 +0300, Dan Carpenter wrote:
> On Fri, Apr 17, 2015 at 02:31:49PM +0100, Alan Cox wrote:
> > On Fri, 2015-04-17 at 11:20 +0300, Dan Carpenter wrote:
> > > Actually, my patch seems like a good idea to me but it's one of those
> > > things t
it. Given
its unlikely anyone even has hardware I doubt that will happen.
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ely).
Nothing wrong with removing all those semi-colons or the submission,
it's just you are patching something going away!
Thanks for the patch though - and better luck next time 8)
Alan
___
devel mailing list
de...@linuxdriverproject.
On Fri, 2015-05-01 at 09:41 +0200, gre...@linuxfoundation.org wrote:
> On Thu, Apr 30, 2015 at 11:25:48PM +0100, One Thousand Gnomes wrote:
> > On Thu, 30 Apr 2015 16:14:06 +0200
> > "gre...@linuxfoundation.org" wrote:
> >
> > > On Thu, Apr 23,
2o.h, which I'm
> guessing is implemented in the staging i2o core.
They are separate drivers. dpt_i2o intentionally shares some API bits
but they stand alone.
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linux
On Mon, 2014-02-24 at 16:54 -0800, Greg Kroah-Hartman wrote:
> On Sat, Feb 22, 2014 at 12:33:36PM +0800, Zhao, Gang wrote:
> > On Fri, 2014-02-21 at 20:35:50 +0800, Dan Carpenter wrote:
> > > On Fri, Feb 21, 2014 at 08:22:21PM +0800, Zhao, Gang wrote:
> > >> > If we add your patch and the reviewer
c_pending;
> + struct list_head async_completed;
> + wait_queue_head_t wait; /* wake up if a request completed */
> + unsigned int discsignr;
> + struct pid *disc_pid;
> + const struct cred *cred;
> + void __user *disccontext;
> + unsigned long
-off-by: Valentina Manea
> ---
> Changes since v1:
> * add commit description
> * move struct dev_state definition back to usb/core/devio.c
For the changes to the USB core:
Acked-by: Alan Stern
___
devel mailing list
de.
ontrollers write whole words.)
No doubt it would be simpler. The problem is that octeon-hcd doesn't
make these allocations; they are carried out by other parts of the
kernel.
Alan Stern
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
d.c file.
> So remove the enable_isp_irq() function and add
> disable_isp_irq function only.
All 3 added to my tree - thanks
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> I'm pretty sure we want this code to be built as a module, so maybe a
> Kconfig change would resolve the issue instead?
>
> Alan, any thoughts?
It's a tiny chunk of platform helper code. It probably ultimately
belongs in arch/x86 somewhere or folded into the driver.
);
You should check the tty c_cflag after the call rather than rely on an
error code. Strictly speaking tty_set_termios should error if no tty bits
are changed by the request but it never has on Linux. Instead check the
tty gave you the result you wanted.
Alan
_
On Thu, 11 May 2017 09:29:14 +0100
Okash Khawaja wrote:
> Hi Alan,
>
> On Wed, May 10, 2017 at 08:41:51PM +0100, Alan Cox wrote:
> > > + if (!(tmp_termios.c_cflag & CRTSCTS)) {
> > > + tmp_termios.c_cflag |= CRTSCTS;
> > > +
On Fri, 12 May 2017 20:35:18 +0100
Okash Khawaja wrote:
> On Thu, May 11, 2017 at 02:33:14PM +0100, Alan Cox wrote:
> > On Thu, 11 May 2017 09:29:14 +0100
> > Okash Khawaja wrote:
> >
> > > Hi Alan,
> > >
> > > On Wed, May 10, 2017 at 08:41:
t;pad)
> return -EINVAL;
> /* only raw8 grbg is supported by TPG */
The TODO fille for this driver specifically says not to send formatting
patches at this point.
There is no point making trivial spacing changes in code that needs
lots of real
eview mailbox. After this, my queue is empty, the driver is
> > all
> > yours!
>
> Thanks!
>
> Alan, please let me know if you prefer if I don't apply any of
> such patches, otherwise I should be merging them tomorrow ;)
I will assume you've merged them
to send the needed patches to DPDK and
to X.org both of whom will I am sure be delighted to get it fixed in
their codebase.
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, 29 May 2017 02:06:41 +0800
Chen Guanqiao wrote:
> Fix "symbol 'xxx' was not declared. Should it be static?" sparse warnings.
>
> Signed-off-by: Chen Guanqiao
> ---
Reviewed-by: Alan Cox
_
el
> would try to get permission to add the firmware to linux-firmware.
I spent 6 months trying, but even though you can go to your product
vendors website and download it I've not been able to 8(.
>
> Anyways I will send out the patches I've curren
hub.com/01org/libxcam/wiki/Tests
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ype as "0" but as
"undefined".
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> Yes I will free it using dma_free_coherent. Why should devm_kzalloc
> be
> replaced with dma_alloc_coherent ? I was trying to replace _pa()
Why keep allocating and freeing a buffer rather than having a single
buffer allocated once (as it is in the old drive
}
>
> -static struct acpi_device_id gc0310_acpi_match[] = {
> +static const struct acpi_device_id gc0310_acpi_match[] = {
> {"XXGC0310"},
> {},
> };
(All four)
Acked-by: Alan Cox
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, 2017-07-07 at 17:20 +0530, Hari Prasath wrote:
> kmemdup can be used to replace kmalloc followed by a memcpy.This was
> pointed out by the coccinelle tool.
And kstrdup could do the job even better I think ?
Alan
___
devel mailing l
e to actually manage the counts properly. The core tty code is
telling you that the tty is not in a valid state. While this is of
itself a good API to have, the underlying reference miscounting ought
IMHO to be fixed as well.
Also you don't need a new TTY_KOPENED flag as f
d putting the ldisc and the speakup tty
driver as different modules.
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
user then it needs another flag, but I think that flag should be in
port->flags as it is a property of the physical interface.
(Take a look at tty_port_open for example)
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
that following these patches.
If the ldisc is just unregistered when the module implementing it is
unloaded then the ref counts on the ldisc module should do everything
needed if the above isn't correctly handled, and if it is will still be
cleaner.
Alan
__
e
tty_port, except any that are used internally within the struct tty
level code. The main reason for this is to make the object lifetimes and
locking simpler - because the tty_port lasts for the time the hardware is
present.
Alan
___
> The patch is untested but I can work on this if that fits in with the
> plans for tty.
I think this is the right direction.
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/dri
On Mon, 2017-08-07 at 21:44 +0800, Geliang Tang wrote:
> Use kvmalloc()/kvzalloc() instead of atomisp_kernel_malloc()
> /atomisp_kernel_zalloc().
>
> Signed-off-by: Geliang Tang
Definitely better now we have kvmalloc/kvzalloc.
Thanks
Alan
_
ly bind to their
normal drivers on the host. You probably don't want that to happen.
(Although, at the moment, I don't see how you can prevent it.)
Also, in your patch, stub_probe() calls usb_choose_configuration().
Shouldn't that be done by the client, since the client no
at we
> can stash somewhere for it to look up later. Perhaps someone more
> familiar with the USB stack can help with that.
The correct solution is to set
qh = ep->hcpriv;
udev = qh->udev;
However, the driver doesn't store udev in qh (dwc2_qh_init
extra copies is not the
right answer.
It should be mapping the pages when they are first set up.
Alan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
to move cptm1217 out of staging, however its now been
there so many years waiting the rumoured RMI4 driver that I don't have
hardware to do any testing on it, so it would need to be a straight
move.
Alan
___
devel mailing list
de...@linuxdriverprojec
On Sun, 2014-08-31 at 13:02 -0700, Greg Kroah-Hartman wrote:
> Adding Alan Cox, as he pushed this driver upstream...
It's sort of a false positive. The existing code will work fine.
Arguably all of this should be using the dma_ APIs.
Alan
_
ng in over a
> > year. Are there any plans to clean it up and move it out soon?
>
> No response from Mark here.
>
> Alan, Jayant, either of you know what the status of the sep staging
> driver is?
I believe "works last time anyone checked". I don't think
On Fri, 2014-07-25 at 21:54 -0700, Greg KH wrote:
> On Fri, Jul 25, 2014 at 10:54:47PM +0100, Alan Cox wrote:
> > On Fri, 2014-07-25 at 20:17 +0300, Kristina Martšenko wrote:
> > > On 23/06/14 23:32, Kristina Martšenko wrote:
> > > > Hi Mark,
> > > >
&g
@gmail.com
Signed-off-by: Sudip Mukherjee
Acked-by: Moritz Fischer
Cc: Alan Tull
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
Alan
> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another
> symbol that implies HAS_DMA, and, optionally, on
On Tue, Mar 20, 2018 at 5:04 AM, Geert Uytterhoeven
wrote:
Hi Geert,
> Hi Alan,
>
> On Mon, Mar 19, 2018 at 5:06 PM, Alan Tull wrote:
>> On Fri, Mar 16, 2018 at 8:51 AM, Geert Uytterhoeven
>> wrote:
>> This essentially removes this commit
>>
>> commit 1
it is first
loaded, there probably is no device around at that time. However, in
most cases there _is_ an associated device.
Alan Stern
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ma_set_coherent_mask or
dma_coerce_mask_and_coherent unconditionally, this patch (and the next)
would overwrite those initial settings.
I don't know to what extent the same may be true for the other,
platform-specific, drivers changed by this patch. But it's something
to
f how
this patch version is different from all the earlier versions. Do that
and submit it as [PATCH v4], and make sure you explain how it is
different from versions 1, 2, and 3.
There are lots of examples of patches like this in the mailing list
archives. Look at some of them to see what they do
automatizovaném procesu ponoru. Detaily práškově lakujeme na robotické lince od
renomované švýcarské firmy.
Pokud vidíte příležitost ke spolupráci, kontaktujte mě.
Alan Beran
___
devel mailing list
de...@linuxdriverproject.org
http
MONEY GRAM.
AROPORT INTL DE COTONOU COTONOU.
Office of Mrs. ALAN UDE.
Attn,Dear Funds beneficiary.
I am Mrs. ALAN UDE., Official Director.Money Gram-Benin
Confirm to us urgent,
Why did you authorized Mrs. Lyndia Paulson to receive your funds
$4.800.000 us dollars from this office?, I need your
77 matches
Mail list logo
