[PATCH] staging: rtl8188eu: use usleep_range() for ATIM window size

2020-05-09 Thread Qiuhao Li
According to Documentation/timers/timers-howto.rst, sleeping for small milliseconds should use usleep_range() instead of msleep(). Signed-off-by: Qiuhao Li --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8

Re: [PATCH] staging: rtl8188eu: use usleep_range() for ATIM window size

2020-05-09 Thread Greg KH
On Sat, May 09, 2020 at 03:19:31PM +0800, Qiuhao Li wrote: > According to Documentation/timers/timers-howto.rst, sleeping for small > milliseconds should use usleep_range() instead of msleep(). > > Signed-off-by: Qiuhao Li > --- > drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 3 ++- > 1 file c

[PATCH] staging: vt6656: vt6655: clean Makefiles

2020-05-09 Thread Matej Dujava
This patch is removing CFLAGS that are defining flags that are not used. Signed-off-by: Matej Dujava --- drivers/staging/vt6655/Makefile | 27 --- drivers/staging/vt6655/device_main.c | 1 - drivers/staging/vt6656/Makefile | 7 ++- 3 files changed, 14 inse

Re: [PATCH v2 7/9] media: MAINTAINERS: rkisp1: add path to dt-bindings

2020-05-09 Thread Ezequiel Garcia
Hi Hans, On Fri, 2020-04-17 at 09:18 +0200, Hans Verkuil wrote: > On 03/04/2020 18:15, Helen Koike wrote: > > The Rockchip ISP bindings was moved out of staging. > > Update MAINTAINERS file with the new path. > > Shouldn't there be a reference to > Documentation/devicetree/bindings/phy/rockchip-

Re: [PATCH v2 8/9] arm64: dts: rockchip: add rx0 mipi-phy for rk3399

2020-05-09 Thread Ezequiel Garcia
Hi Heiko, On Fri, 2020-04-03 at 13:15 -0300, Helen Koike wrote: > From: Shunqian Zheng > > Designware MIPI D-PHY, used for ISP0 in rk3399. > > Verified with: > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml > > Signed-off-by: Shu

[PATCH] staging: vc04_services: interface: vchiq_arm: vchiq_connected.c: Block comments should align the * on each line

2020-05-09 Thread John Oldman
Coding style issue Signed-off-by: John Oldman --- .../interface/vchiq_arm/vchiq_connected.c | 32 +-- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interfac

Re: [PATCH] staging: vt6656: vt6655: clean Makefiles

2020-05-09 Thread Greg Kroah-Hartman
On Sat, May 09, 2020 at 11:07:27AM +0200, Matej Dujava wrote: > This patch is removing CFLAGS that are defining flags that are not used. You are also modifying the indentation and moving lines around for no reason :( Please only do one thing for a patch, and always describe everything you do in t

Re: [PATCH] staging: vc04_services: interface: vchiq_arm: vchiq_connected.c: Block comments should align the * on each line

2020-05-09 Thread Greg KH
On Sat, May 09, 2020 at 02:07:14PM +0100, John Oldman wrote: > Coding style issue Your subject line needs to be much shorter, don't you think? Please fix up and resend. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linux

Re: [PATCH] staging: vc04_services: interface: vchiq_arm: vchiq_connected.c: Block comments should align the * on each line

2020-05-09 Thread John Oldman
Hi Greg Yea, thanks for the feedback. Will fix and resend... John On Sat, 9 May 2020 at 18:11, Greg KH wrote: > > On Sat, May 09, 2020 at 02:07:14PM +0100, John Oldman wrote: > > Coding style issue > > Your subject line needs to be much shorter, don't you think? > > Please fix up and resend.

Re: [PATCH] staging: vt6656: vt6655: clean Makefiles

2020-05-09 Thread Matej Dujava
On Sat, May 09, 2020 at 07:07:14PM +0200, Greg Kroah-Hartman wrote: On Sat, May 09, 2020 at 11:07:27AM +0200, Matej Dujava wrote: This patch is removing CFLAGS that are defining flags that are not used. You are also modifying the indentation and moving lines around for no reason :( Please onl

[PATCH V2] staging: vc04_services: vchiq_connected.c: Block comment alignment

2020-05-09 Thread John Oldman
Coding style issue Signed-off-by: John Oldman --- v1: Initial attempt. V2: Resubmitted with shorter comment line, as suggested by Greg KH. This patch clears the checkpatch.pl "Block comments should align the * on each line" warning. .../interface/vchiq_arm/vchiq_connected.c | 32 +

Re: [PATCH V2] staging: vc04_services: vchiq_connected.c: Block comment alignment

2020-05-09 Thread Greg KH
On Sun, May 10, 2020 at 07:06:45AM +0100, John Oldman wrote: > Coding style issue > > Signed-off-by: John Oldman > --- > v1: Initial attempt. > V2: Resubmitted with shorter comment line, as suggested by Greg KH. > > This patch clears the checkpatch.pl "Block comments should align the * on > eac