On Wed, Mar 11, 2020 at 01:23:32AM +, Thiago Souza Ferreira wrote:
> Fix "Block comments use * on subsequent lines" warning of
> rtw_mlme_ext.c, found by checkpatch.pl script
>
> Signed-off-by: Thiago Souza Ferreira
> ---
> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 69 ++---
Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit. Fix it by replacing with scnprintf().
Signed-off-by: Takashi Iwai
---
drivers/staging/greybus/tools/loopback_test.c | 24
1 fi
Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit. Fix it by replacing with scnprintf().
Signed-off-by: Takashi Iwai
---
drivers/staging/most/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deleti
Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit. Fix it by replacing with scnprintf().
Signed-off-by: Takashi Iwai
---
drivers/staging/rtl8192e/rtllib_rx.c | 4 ++--
drivers/staging/rtl8192e/rtllib_wx
Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit. Fix it by replacing with scnprintf().
Signed-off-by: Takashi Iwai
---
drivers/staging/rtl8188eu/core/rtw_debug.c | 16
drivers/sta
Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit. Fix it by replacing with scnprintf().
Signed-off-by: Takashi Iwai
---
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 14 +++---
drivers/stagi
Hi,
here is a series of trivial patches just to convert suspicious
snprintf() usages with the more safer one, scnprintf(), just like
other few patches I've already sent out.
Takashi
===
Takashi Iwai (3):
staging: rtl8188eu: Use scnprintf() for avoiding potential buffer
overflow
stagi
GPIO mode is not needed to be set up anymore. Hence
remove useless related definitions.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c
b/drivers/staging/mt7621-pci/pci-mt7
Properly update bindings documentation with added 'reset-gpios'
property. Delete also 'perst-gpio' which is not being used anymore.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/
Original driver code was using three gpio's for reset
asserts and deasserts the pcis. Instead of using that
a general reset control with a perst gpio was introduced
and it seems it is partially working but sometimes there
are some unexpected hangs on boot. This commit make use of
the three original
Some time ago Greg Ungerer reported some random hangs using
the staging mt7621-pci driver:
See:
*
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2019-June/134947.html
Try to fix that is the main motivation of this patch series.
Also in openwrt there is a driver for mt7621-p
Properly set pins for group pcie as 'gpio' function and declare
gpio's in the pci node to make reset stuff properly functional.
Delete no more needed general reset and previous pers gpio which
is now being used in 'reset-gpios' property.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt76
Value of 'PERST_DELAY_US' is too high and it is ok just
to set up to 100 us.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c
b/drivers/staging/mt7621-pci/pci
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers/staging/rtl8188eu/core/
shreeya@Shreeya-Patel:~git/kernels/staging$
git diff -w shows no difference.
shree
On Wed, Mar 11, 2020 at 10:19:06AM +0100, Takashi Iwai wrote:
> Since snprintf() returns the would-be-output size instead of the
> actual output size, the succeeding calls may go beyond the given
> buffer limit. Fix it by replacing with scnprintf().
>
> Signed-off-by: Takashi Iwai
> ---
> drive
On Wed, 11 Mar 2020 10:58:14 +0100,
Johan Hovold wrote:
>
> On Wed, Mar 11, 2020 at 10:19:06AM +0100, Takashi Iwai wrote:
> > Since snprintf() returns the would-be-output size instead of the
> > actual output size, the succeeding calls may go beyond the given
> > buffer limit. Fix it by replacing
Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit. Fix it by replacing with scnprintf().
Signed-off-by: Takashi Iwai
---
Just corrected the subject prefix per request.
drivers/staging/greybus/tools/lo
On Wed, Mar 11, 2020 at 11:02:33AM +0100, Takashi Iwai wrote:
> On Wed, 11 Mar 2020 10:58:14 +0100,
> Johan Hovold wrote:
> >
> > On Wed, Mar 11, 2020 at 10:19:06AM +0100, Takashi Iwai wrote:
> > > Since snprintf() returns the would-be-output size instead of the
> > > actual output size, the succe
On Wed, Mar 11, 2020 at 11:05:35AM +0100, Takashi Iwai wrote:
> Since snprintf() returns the would-be-output size instead of the
> actual output size, the succeeding calls may go beyond the given
> buffer limit. Fix it by replacing with scnprintf().
>
> Signed-off-by: Takashi Iwai
> ---
>
> Jus
On Wed, 11 Mar 2020, Shreeya Patel wrote:
> Add space around operators for improving the code
> readability.
>
> Reported by checkpatch.pl
>
> Signed-off-by: Shreeya Patel
> ---
>
> shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
> drivers/staging/rtl8188eu/core/
> shreeya@Shreeya-Pat
Add Boot-Regions verification specified in exFAT specification.
Reviewed-by: Takahiro Mori
Signed-off-by: Tetsuhiro Kohada
---
drivers/staging/exfat/exfat_core.c | 69 ++
1 file changed, 69 insertions(+)
diff --git a/drivers/staging/exfat/exfat_core.c
b/drivers/sta
Consolidate boot sector analysis into read_boot_sector().
- Move boot sector analysis from exfat_mount() to read_boot_sector().
- Fix num_fats check in read_boot_sector().
- Consolidate p_fs->boot_bh initialization/release into mount/umount.
This fixes vol_flags inconsistency at read failed in
- Remove redundant code of calc_checksum_2byte() and rename to calc_checksum16.
- Replace checksum calculation in __load_upcase_table() with calc_checksum32().
Reviewed-by: Takahiro Mori
Signed-off-by: Tetsuhiro Kohada
---
drivers/staging/exfat/exfat.h | 3 ++-
drivers/staging/exfat/exfat
Redefine 'pbr_sector_t' as 'boot_sector_t' to comply with exFAT specification.
- Redefine 'pbr_sector_t' as 'boot_sector_t'.
- Rename variable names including 'pbr'.
- Replace GET**()/SET**() macro with cpu_to_le**()/le**_ to_cpu().
- Remove fs_info_t.PBR_sector (always 0).
- Remove unused def
Separate the mount process related to the exFAT specification in ffsMountVol()
and move it to exfat_mount.c.
- Rename exfat_mount() to read_boot_sector().
- Separate exFAT-mount core process and move to exfat_mount.c as NEW
exfat_mount().
- Move free_upcase_table()/free_alloc_bitmap() to exfa
On Wed, 11 Mar 2020 11:09:03 +0100,
Johan Hovold wrote:
>
> On Wed, Mar 11, 2020 at 11:02:33AM +0100, Takashi Iwai wrote:
> > On Wed, 11 Mar 2020 10:58:14 +0100,
> > Johan Hovold wrote:
> > >
> > > On Wed, Mar 11, 2020 at 10:19:06AM +0100, Takashi Iwai wrote:
> > > > Since snprintf() returns the
On Wed, Mar 11, 2020 at 07:52:41PM +0900, Tetsuhiro Kohada wrote:
> Redefine 'pbr_sector_t' as 'boot_sector_t' to comply with exFAT specification.
> - Redefine 'pbr_sector_t' as 'boot_sector_t'.
> - Rename variable names including 'pbr'.
> - Replace GET**()/SET**() macro with cpu_to_le**()/le**_
From: Ajay Singh
Moved 'drivers/staging/wilc1000/wlan_cfg.h' to
'drivers/net/wireless/microchip/wilc1000/wlan_cfg.h'.
Signed-off-by: Ajay Singh
---
.../wireless/microchip/wilc1000/wlan_cfg.h| 54 +++
1 file changed, 54 insertions(+)
create mode 100644 drivers/net/wireless/
From: Ajay Singh
Moved 'drivers/staging/wilc1000/wlan_if.h' to
'drivers/net/wireless/microchip/wilc1000/wlan_if.h'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip/wilc1000/wlan_if.h | 803 ++
1 file changed, 803 insertions(+)
create mode 100644 drivers/net/wireless/m
From: Ajay Singh
Moved 'drivers/staging/wilc1000/cfg80211.h' to
'drivers/net/wireless/microchip/wilc1000/cfg80211.h'.
Signed-off-by: Ajay Singh
---
.../wireless/microchip/wilc1000/cfg80211.h| 29 +++
1 file changed, 29 insertions(+)
create mode 100644 drivers/net/wireless/
From: Ajay Singh
Moved 'drivers/staging/wilc1000/hif.h' to
'drivers/net/wireless/microchip/wilc1000/hif.h'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/microchip/wilc1000/hif.h | 214 ++
1 file changed, 214 insertions(+)
create mode 100644 drivers/net/wireless/microchip
From: Ajay Singh
Moved 'drivers/staging/wilc1000/netdev.h' to
'drivers/net/wireless/microchip/wilc1000/netdev.h'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip/wilc1000/netdev.h | 294 ++
1 file changed, 294 insertions(+)
create mode 100644 drivers/net/wireless/mic
From: Ajay Singh
This patch series is to review and move wilc1000 driver out of staging.
Most of the review comments received in [1] & [2] are addressed in the
latest code. Please review and provide your inputs.
[1].
https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.
From: Ajay Singh
Moved 'drivers/staging/wilc1000/wlan.c' to
'drivers/net/wireless/microchip/wilc1000/wlan.c'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip/wilc1000/wlan.c| 1238 +
1 file changed, 1238 insertions(+)
create mode 100644 drivers/net/wireless/microc
From: Ajay Singh
Moved 'drivers/staging/wilc1000/wlan.h' to
'drivers/net/wireless/microchip/wilc1000/wlan.h'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip/wilc1000/wlan.h| 397 ++
1 file changed, 397 insertions(+)
create mode 100644 drivers/net/wireless/microch
From: Ajay Singh
Moved 'drivers/staging/wilc1000/hif.c' to
'drivers/net/wireless/microchip/wilc1000/hif.c'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/microchip/wilc1000/hif.c | 1959 +
1 file changed, 1959 insertions(+)
create mode 100644 drivers/net/wireless/microchi
From: Ajay Singh
Moved 'drivers/staging/wilc1000/spi.c' to
'drivers/net/wireless/microchip/wilc1000/spi.c'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/microchip/wilc1000/spi.c | 988 ++
1 file changed, 988 insertions(+)
create mode 100644 drivers/net/wireless/microchip
From: Ajay Singh
Added Makefile and Kconfig files for compiling wilc1000 module from
'drivers/net/wireless/microchip/'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/Kconfig | 1 +
drivers/net/wireless/Makefile | 1 +
drivers/net/wireless/microchip/Kconf
From: Ajay Singh
This file describes the binding details to connect wilc1000 device. It's
moved from staging to 'Documentation/devicetree/bindings/net/wireless'
path.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip,wilc1000.yaml | 72 +++
1 file changed, 72 insert
From: Ajay Singh
Moved 'drivers/staging/wilc1000/cfg80211.c' to
'drivers/net/wireless/microchip/wilc1000/cfg80211.c'.
Signed-off-by: Ajay Singh
---
.../wireless/microchip/wilc1000/cfg80211.c| 1850 +
1 file changed, 1850 insertions(+)
create mode 100644 drivers/net/wireles
From: Ajay Singh
Moved 'drivers/staging/wilc1000/mon.c' to
'drivers/net/wireless/microchip/wilc1000/mon.c'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/microchip/wilc1000/mon.c | 260 ++
1 file changed, 260 insertions(+)
create mode 100644 drivers/net/wireless/microchip
From: Ajay Singh
Moved 'drivers/staging/wilc1000/sdio.c' to
'drivers/net/wireless/microchip/wilc1000/sdio.c'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip/wilc1000/sdio.c| 1023 +
1 file changed, 1023 insertions(+)
create mode 100644 drivers/net/wireless/microc
From: Ajay Singh
Moved 'drivers/staging/wilc1000/fw.h' to
'drivers/net/wireless/microchip/wilc1000/fw.h'.
Signed-off-by: Ajay Singh
---
drivers/net/wireless/microchip/wilc1000/fw.h | 119 +++
1 file changed, 119 insertions(+)
create mode 100644 drivers/net/wireless/microchip/w
From: Ajay Singh
Moved 'drivers/staging/wilc1000/netdev.c' to
'drivers/net/wireless/microchip/wilc1000/netdev.c'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip/wilc1000/netdev.c | 932 ++
1 file changed, 932 insertions(+)
create mode 100644 drivers/net/wireless/mic
From: Ajay Singh
Moved 'drivers/staging/wilc1000/wlan_cfg.c' to
'drivers/net/wireless/microchip/wilc1000/wlan_cfg.c'.
Signed-off-by: Ajay Singh
---
.../wireless/microchip/wilc1000/wlan_cfg.c| 413 ++
1 file changed, 413 insertions(+)
create mode 100644 drivers/net/wireless
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by: Shreeya Patel
---
shreeya@Shreeya-Patel:~git/kernels/staging$ git diff -w
drivers/stag
Remove if and else conditions since both are leading to the
initialization of "valueDMATimeout" and "valueDMAPageCount" with
the same value.
Found using coccinelle script.
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 +
1 file changed, 5 ins
Remove unnecessary if and else conditions since both are leading to the
initialization of "phtpriv->ampdu_enable" with the same value.
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers
On Wed, Mar 11, 2020 at 12:01:26PM +0100, Takashi Iwai wrote:
> On Wed, 11 Mar 2020 11:09:03 +0100,
> Johan Hovold wrote:
> >
> > On Wed, Mar 11, 2020 at 11:02:33AM +0100, Takashi Iwai wrote:
> > > On Wed, 11 Mar 2020 10:58:14 +0100,
> > > Johan Hovold wrote:
> > > >
> > > > On Wed, Mar 11, 2020
On Wed, Mar 11, 2020 at 11:09:59AM +0100, Johan Hovold wrote:
> On Wed, Mar 11, 2020 at 11:05:35AM +0100, Takashi Iwai wrote:
> > Since snprintf() returns the would-be-output size instead of the
> > actual output size, the succeeding calls may go beyond the given
> > buffer limit. Fix it by replac
On Wed, 11 Mar 2020 17:40:02 +0100,
Johan Hovold wrote:
>
> On Wed, Mar 11, 2020 at 12:01:26PM +0100, Takashi Iwai wrote:
> > On Wed, 11 Mar 2020 11:09:03 +0100,
> > Johan Hovold wrote:
> > >
> > > On Wed, Mar 11, 2020 at 11:02:33AM +0100, Takashi Iwai wrote:
> > > > On Wed, 11 Mar 2020 10:58:14
On Wed, Mar 11, 2020 at 05:45:31PM +0100, Takashi Iwai wrote:
> On Wed, 11 Mar 2020 17:40:02 +0100, Johan Hovold wrote:
> > But isn't the first snprintf() in such a sequence as much a part of the
> > problem as the following ones?
> >
> > If the first pos = snprintf(buf, limit, ...) overflows buf
On Wed, 11 Mar 2020 18:47:42 +0530
Shreeya Patel wrote:
> Add space around operators for improving the code
> readability.
> Reported by checkpatch.pl
>
> git diff -w shows no difference.
> diff of the .o files before and after the changes shows no difference.
>
> Signed-off-by: Shreeya Patel
On Wed, 11 Mar 2020 19:08:11 +0530
Shreeya Patel wrote:
> Remove if and else conditions since both are leading to the
> initialization of "valueDMATimeout" and "valueDMAPageCount" with
> the same value.
>
> Found using coccinelle script.
>
> Signed-off-by: Shreeya Patel
Reviewed-by: Stefano B
On Wed, 2020-03-11 at 19:08 +0530, Shreeya Patel wrote:
> Remove if and else conditions since both are leading to the
> initialization of "valueDMATimeout" and "valueDMAPageCount" with
> the same value.
You might consider removing the
/* Timeout value is calculated by 34 / (2^n) */
comment
Original driver code was using three gpio's for reset
asserts and deasserts the pcis. Instead of using that
a general reset control with a perst gpio was introduced
and it seems it is partially working but sometimes there
are some unexpected hangs on boot. This commit make use of
the three original
Some time ago Greg Ungerer reported some random hangs using
the staging mt7621-pci driver:
See:
*
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2019-June/134947.html
Try to fix that is the main motivation of this patch series.
Also in openwrt there is a driver for mt7621-p
Value of 'PERST_DELAY_US' is too high and it is ok just
to set up to 100 us.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c
b/drivers/staging/mt7621-pci/pci
R3G's LEDs fail to initialize because one of them uses GPIO8
Hence, release the GPIO resources after PCIe initialization.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/staging/mt7621-pci/pci-m
Properly set pins for group pcie as 'gpio' function and declare
gpio's in the pci node to make reset stuff properly functional.
Delete no more needed general reset and previous pers gpio which
is now being used in 'reset-gpios' property.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt76
Properly update bindings documentation with added 'reset-gpios'
property. Delete also 'perst-gpio' which is not being used anymore.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/
Hey Joe,
On March 11, 2020 10:56:29 PM GMT+05:30, Joe Perches wrote:
>On Wed, 2020-03-11 at 19:08 +0530, Shreeya Patel wrote:
>> Remove if and else conditions since both are leading to the
>> initialization of "valueDMATimeout" and "valueDMAPageCount" with
>> the same value.
>
>You might consider
On March 11, 2020 10:34:28 PM GMT+05:30, Stefano Brivio
wrote:
Hey Stefano,
>On Wed, 11 Mar 2020 18:47:42 +0530
>Shreeya Patel wrote:
>
>> Add space around operators for improving the code
>> readability.
>> Reported by checkpatch.pl
>>
>> git diff -w shows no difference.
>> diff of the .o
On Tuesday 10 March 2020 11:54:21 Greg Kroah-Hartman wrote:
> Now that there is a "real" solution for exfat in the vfs tree queued up
> to be merged in 5.7-rc1 the "old" exfat code in staging can be removed.
>
> Many thanks to Valdis for doing the work to get this into the tree in
> the first plac
-32bit_defconfig
parisc allyesconfig
x86_64 randconfig-a001-20200311
x86_64 randconfig-a002-20200311
x86_64 randconfig-a003-20200311
i386 randconfig-a001-20200311
i386 randconfig-a002-20200311
i386
fuloong2e_defconfig
pariscallnoconfig
parisc allyesconfig
pariscgeneric-32bit_defconfig
pariscgeneric-64bit_defconfig
x86_64 randconfig-a001-20200311
x86_64 randconfig-a002
On 3/11/2020 6:58 AM, Shreeya Patel wrote:
Remove unnecessary if and else conditions since both are leading to the
initialization of "phtpriv->ampdu_enable" with the same value.
Signed-off-by: Shreeya Patel
Stating this based on the patch descriptions I have seen.
Others, please advise\corre
Buenos días
Os informamos que se encuentra abierto el plazo de inscripción para la presente
Convocatoria de Cursos Bonificables para empleados (Marzo 2020)
Todos los cursos son totalmente Bonificables con cargo al Crédito de Formación
2020 que disponen las empresas.
Deseáis que os mandemos
Hi Sergio,
On 12/3/20 4:58 am, Sergio Paracuellos wrote:
Some time ago Greg Ungerer reported some random hangs using
the staging mt7621-pci driver:
See:
*
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2019-June/134947.html
Try to fix that is the main motivation of this pat
Compliment to you,
Am so sorry for contacting you through this medium. I was desperate looking
for a reputable company or individual that is ready to work with me before I
contacted you.
We are a group of miners looking for potential, reliable and regular Buyers who
can sign at least six month
Compliment to you,
Am so sorry for contacting you through this medium. I was desperate looking
for a reputable company or individual that is ready to work with me before I
contacted you.
We are a group of miners looking for potential, reliable and regular Buyers who
can sign at least six month
Hi Greg,
On Thu, Mar 12, 2020 at 5:56 AM Greg Ungerer wrote:
>
> Hi Sergio,
>
> On 12/3/20 4:58 am, Sergio Paracuellos wrote:
> > Some time ago Greg Ungerer reported some random hangs using
> > the staging mt7621-pci driver:
> >
> > See:
> > *
> > http://driverdev.linuxdriverproject.org/pipermai
72 matches
Mail list logo
