Re: [PATCH 8/8] staging: rtl8192e: rename macro arguments to avoid camel case - style

2019-02-13 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Dodatečné zdroje

2019-02-13 Thread Kamil Adamiec
Dobrý den! Pro rozvoj podnikání živnostníků je zpravidla bariérou nedostatek provozních zdrojů na nákup materiálu, zboží nebo surovin z důvodu např. nezaplacení faktur (nezaplacení od dodavatelů, prodloužená splatnost apod.). V této oblasti jsme již pomohli řadě firem, které mohly díky získání

Dodatečné zdroje

2019-02-13 Thread Kamil Adamiec
Dobrý den! Pro rozvoj podnikání živnostníků je zpravidla bariérou nedostatek provozních zdrojů na nákup materiálu, zboží nebo surovin z důvodu např. nezaplacení faktur (nezaplacení od dodavatelů, prodloužená splatnost apod.). V této oblasti jsme již pomohli řadě firem, které mohly díky získání

Dodatečné zdroje

2019-02-13 Thread Kamil Adamiec
Dobrý den! Pro rozvoj podnikání živnostníků je zpravidla bariérou nedostatek provozních zdrojů na nákup materiálu, zboží nebo surovin z důvodu např. nezaplacení faktur (nezaplacení od dodavatelů, prodloužená splatnost apod.). V této oblasti jsme již pomohli řadě firem, které mohly díky získání

Re: [PATCH v2] staging: comedi: ni_660x: fix missing break in switch statement

2019-02-13 Thread Ian Abbott
On 12/02/2019 18:44, Gustavo A. R. Silva wrote: Add missing break statement in order to prevent the code from falling through to the default case and return -EINVAL every time. This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough. Fixes: aa94f225 ("staging: come

Re: [PATCH v2 1/2] PCI: hv: Replace hv_vp_set with hv_vpset

2019-02-13 Thread Lorenzo Pieralisi
On Wed, Feb 13, 2019 at 02:20:29AM +, Michael Kelley wrote: > From: Lorenzo Pieralisi Sent: Tuesday, February > 12, 2019 8:35 AM > > > > On Mon, Jan 28, 2019 at 09:49:32PM -0800, Maya Nakamura wrote: > > > On Sun, Jan 27, 2019 at 05:11:48AM +, Michael Kelley wrote: > > > > From: Maya Nak

Re: [PATCH] staging: vt6656: Use the correct style for SPDX license Identifier

2019-02-13 Thread Nishad Kamdar
On Wed, Feb 06, 2019 at 11:17:35PM -0800, Joe Perches wrote: > On Wed, 2019-02-06 at 17:25 +0100, Greg Kroah-Hartman wrote: > > On Tue, Feb 05, 2019 at 10:59:40AM -0800, Joe Perches wrote: > > > On Tue, 2019-02-05 at 19:44 +0100, Greg Kroah-Hartman wrote: > > > > On Tue, Feb 05, 2019 at 08:36:24PM

Re: [PATCH 2/2] staging: erofs: remove redundant unlikely annotation in unzip_vle.c

2019-02-13 Thread cgxu519
On 2/13/19 2:36 PM, Chao Yu wrote: On 2019/2/12 11:24, Chengguang Xu wrote: unlikely has already included in IS_ERR(), so just remove it. Signed-off-by: Chengguang Xu It looks like we don't need to send two patch to fix two similar issues, if you can merge them, it will be better. I agree w

Re: [PATCH v3 0/2] PCI: hv: Refactor hv_irq_unmask() to use hv_vpset and cpumask_to_vpset()

2019-02-13 Thread Lorenzo Pieralisi
On Mon, Jan 28, 2019 at 11:15:37PM -0800, Maya Nakamura wrote: > This patchset removes a duplicate definition of VP set (hv_vp_set) and > uses the common definition (hv_vpset) that is used in other places. It > changes the order of the members in struct hv_pcibus_device due to > flexible array in h

Re: [PATCH 2/2] staging: erofs: remove redundant unlikely annotation in unzip_vle.c

2019-02-13 Thread Gao Xiang
Hi Chengguang, On 2019/2/13 22:50, cgxu519 wrote: > > On 2/13/19 2:36 PM, Chao Yu wrote: >> On 2019/2/12 11:24, Chengguang Xu wrote: >>> unlikely has already included in IS_ERR(), >>> so just remove it. >>> >>> Signed-off-by: Chengguang Xu >> It looks like we don't need to send two patch to fix t

Re: [PATCH] staging: android: ion: Use low_order_gfp_flags for smaller allocations

2019-02-13 Thread Laura Abbott
On 2/11/19 11:09 PM, Jing Xia wrote: gfp_flags is always set high_order_gfp_flags even if allocations of order 0 are made.But for smaller allocations, the system should be able to reclaim some memory. Signed-off-by: Jing Xia Reviewed-by: Yuming Han Reviewed-by: Zhaoyang Huang Reviewed-by: Ors

Re: [PATCH v2] staging: comedi: ni_660x: fix missing break in switch statement

2019-02-13 Thread Gustavo A. R. Silva
On 2/13/19 4:41 AM, Ian Abbott wrote: > On 12/02/2019 18:44, Gustavo A. R. Silva wrote: >> Add missing break statement in order to prevent the code from falling >> through to the default case and return -EINVAL every time. >> >> This bug was found thanks to the ongoing efforts to enable >> -Wimpl

[PATCH v4] staging: nrf24: add new driver for 2.4GHz radio transceiver

2019-02-13 Thread Marcin Ciupak
This patch adds driver for Nordic Semiconductor nRF24L01+ radio transceiver. Signed-off-by: Marcin Ciupak --- Changes in v2: - add terminating newlines to all logging formats Changes in v3: - patch subject - comments cleanup - goto labels cleanup - scnprintf bugfix - ida_simple_remove

[PATCH] binder: fix sparse issue in binder_alloc_selftest.c

2019-02-13 Thread Todd Kjos
Fixes sparse issues reported by the kbuild test robot running on https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing: bde4a19fc04f5 ("binder: use userspace pointer as base of buffer space") Error output (drivers/android/binder_alloc_selftest.c): sparse: warning:

Re: [PATCH 8/8] staging: rtl8192e: rename macro arguments to avoid camel case - style

2019-02-13 Thread Himadri Pandya
On 13/02/19 2:36 PM, Greg KH wrote: A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thi

[PATCH] staging: rtl8192e: rename macro arguments to avoid camel case - style

2019-02-13 Thread Himadri Pandya
Rename following macro arguments to fix checkpatch warning: Avoid CamelCase and make the arguments more readable, understandable. __pIeeeDev -> __ieee_dev __pTa -> __address Signed-off-by: Himadri Pandya --- drivers/staging/rtl8192e/dot11d.h | 30 +++--- 1

[PATCH net-next 0/9] net: Get rid of switchdev_port_attr_get()

2019-02-13 Thread Florian Fainelli
Hi all, This patch series splits the removal of the switchdev_ops that was proposed a few times before and first tackles the easy part which is the removal of the single call to switchdev_port_attr_get() within the bridge code. As suggestd by Ido, this patch series adds a SWITCHDEV_ATTR_ID_PORT_P

[PATCH net-next 2/9] net: switchdev: Add PORT_PRE_BRIDGE_FLAGS

2019-02-13 Thread Florian Fainelli
In preparation for removing switchdev_port_attr_get(), introduce PORT_PRE_BRIDGE_FLAGS which will be called through switchdev_port_attr_set(), in the caller's context (possibly atomic) and which must be checked by the switchdev driver in order to return whether the operation is supported or not. T

[PATCH net-next 1/9] Documentation: networking: switchdev: Update port parent ID section

2019-02-13 Thread Florian Fainelli
Update the section about switchdev drivers having to implement a switchdev_port_attr_get() function to return SWITCHDEV_ATTR_ID_PORT_PARENT_ID since that is no longer valid after commit bccb30254a4a ("net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID"). Fixes: bccb30254a4a ("net: Get rid of SWITCHD

[PATCH net-next 3/9] mlxsw: spectrum: Check bridge flags during prepare phase

2019-02-13 Thread Florian Fainelli
In preparation for getting rid of switchdev_port_attr_get(), have mlxsw check for the bridge flags being set through switchdev_port_attr_set() when the SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS attribute identifier is used. Signed-off-by: Florian Fainelli --- .../ethernet/mellanox/mlxsw/spectrum_s

[PATCH net-next 7/9] net: bridge: Stop calling switchdev_port_attr_get()

2019-02-13 Thread Florian Fainelli
Now that all switchdev drivers have been converted to checking the bridge port flags during the prepare phase of the switchdev_port_attr_set() when the process SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS, we can avoid calling switchdev_port_attr_get() with SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT.

[PATCH net-next 9/9] net: Get rid of switchdev_port_attr_get()

2019-02-13 Thread Florian Fainelli
With the bridge no longer calling switchdev_port_attr_get() to obtain the supported bridge port flags from a driver but instead trying to set the bridge port flags directly and relying on driver to reject unsupported configurations, we can effectively get rid of switchdev_port_attr_get() entirely s

[PATCH net-next 6/9] rocker: Check bridge flags during prepare phase

2019-02-13 Thread Florian Fainelli
In preparation for getting rid of switchdev_port_attr_get(), have rocker check for the bridge flags being set through switchdev_port_attr_set() with the SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS attribute identifier. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rocker/rocker_main.c | 4

[PATCH net-next 4/9] staging: fsl-dpaa2: ethsw: Check bridge port flags during prepare

2019-02-13 Thread Florian Fainelli
In preparation for removing SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT, have ethsw check that the bridge port flags that are being set are supported when SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS is specified. Signed-off-by: Florian Fainelli --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 12 ++

[PATCH net-next 8/9] net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT

2019-02-13 Thread Florian Fainelli
Now that we have converted the bridge code and the drivers to check for bridge port(s) flags at the time we try to set them, there is no need for a get() -> set() sequence anymore and SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT therefore becomes unused. Signed-off-by: Florian Fainelli --- .../et

[PATCH net-next 5/9] net: dsa: Add setter for SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS

2019-02-13 Thread Florian Fainelli
In preparation for removing SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT, add support for a function that processes the SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS and SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS attributes and returns not supported for any flag set, since DSA does not currently support toggling

[PATCH V2 1/7] mm/gup: Replace get_user_pages_longterm() with FOLL_LONGTERM

2019-02-13 Thread ira . weiny
From: Ira Weiny Rather than have a separate get_user_pages_longterm() call, introduce FOLL_LONGTERM and change the longterm callers to use it. This patch does not change any functionality. FOLL_LONGTERM can only be supported with get_user_pages() as it requires vmas to determine if DAX is in us

[PATCH V2 2/7] mm/gup: Change write parameter to flags in fast walk

2019-02-13 Thread ira . weiny
From: Ira Weiny In order to support more options in the GUP fast walk, change the write parameter to flags throughout the call stack. This patch does not change functionality and passes FOLL_WRITE where write was previously used. Signed-off-by: Ira Weiny --- mm/gup.c | 52

[PATCH V2 5/7] IB/hfi1: Use the new FOLL_LONGTERM flag to get_user_pages_fast()

2019-02-13 Thread ira . weiny
From: Ira Weiny Use the new FOLL_LONGTERM to get_user_pages_fast() to protect against FS DAX pages being mapped. Signed-off-by: Ira Weiny --- drivers/infiniband/hw/hfi1/user_pages.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/user_pages.

[PATCH V2 0/7] Add FOLL_LONGTERM to GUP fast and use it

2019-02-13 Thread ira . weiny
From: Ira Weiny NOTE: This series depends on my clean up patch to remove the write parameter from gup_fast_permitted()[1] HFI1, qib, and mthca, use get_user_pages_fast() due to it performance advantages. These pages can be held for a significant time. But get_user_pages_fast() does not protect

[PATCH V2 4/7] mm/gup: Add FOLL_LONGTERM capability to GUP fast

2019-02-13 Thread ira . weiny
From: Ira Weiny DAX pages were previously unprotected from longterm pins when users called get_user_pages_fast(). Use the new FOLL_LONGTERM flag to check for DEVMAP pages and fall back to regular GUP processing if a DEVMAP page is encountered. Signed-off-by: Ira Weiny --- mm/gup.c | 24 ++

[PATCH V2 7/7] IB/mthca: Use the new FOLL_LONGTERM flag to get_user_pages_fast()

2019-02-13 Thread ira . weiny
From: Ira Weiny Use the new FOLL_LONGTERM to get_user_pages_fast() to protect against FS DAX pages being mapped. Signed-off-by: Ira Weiny --- drivers/infiniband/hw/mthca/mthca_memfree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mthca/mthca_memf

[PATCH V2 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool'

2019-02-13 Thread ira . weiny
From: Ira Weiny To facilitate additional options to get_user_pages_fast() change the singular write parameter to be gup_flags. This patch does not change any functionality. New functionality will follow in subsequent patches. Some of the get_user_pages_fast() call sites were unchanged because

[PATCH V2 6/7] IB/qib: Use the new FOLL_LONGTERM flag to get_user_pages_fast()

2019-02-13 Thread ira . weiny
From: Ira Weiny Use the new FOLL_LONGTERM to get_user_pages_fast() to protect against FS DAX pages being mapped. Signed-off-by: Ira Weiny --- drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c

Re: [PATCH V2 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool'

2019-02-13 Thread Jason Gunthorpe
On Wed, Feb 13, 2019 at 03:04:51PM -0800, ira.we...@intel.com wrote: > From: Ira Weiny > > To facilitate additional options to get_user_pages_fast() change the > singular write parameter to be gup_flags. So now we have: long get_user_pages_unlocked(unsigned long start, unsigned long nr_pages,

Re: [PATCH V2 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool'

2019-02-13 Thread Ira Weiny
On Wed, Feb 13, 2019 at 04:11:10PM -0700, Jason Gunthorpe wrote: > On Wed, Feb 13, 2019 at 03:04:51PM -0800, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > To facilitate additional options to get_user_pages_fast() change the > > singular write parameter to be gup_flags. > > So now we hav

[PATCH 1/1] staging: android: ion: Add the GPL exception for syscalls

2019-02-13 Thread Hyun Kwon
Add "WITH Linux-syscall-note" to the license to not put GPL restrictions on user space programs using this header. Signed-off-by: Hyun Kwon --- drivers/staging/android/uapi/ion.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/uapi/ion.h b/drivers/sta

[PATCH] erofs: fix memleak of node's shared xattr array

2019-02-13 Thread Sheng Yong
If it fails to read a shared xattr page, the node's shared xattr array is not freed. The next time the node's xattr is accessed, the previously allocated array is leaked. Signed-off-by: Sheng Yong --- drivers/staging/erofs/xattr.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff -

Re: [PATCH] erofs: fix memleak of node's shared xattr array

2019-02-13 Thread Gao Xiang
Hi Sheng, On 2019/2/14 17:37, Sheng Yong wrote: > If it fails to read a shared xattr page, the node's shared xattr array node -> inode since erofs doesn't have 'node' concept like f2fs... > is not freed. The next time the node's xattr is accessed, the previously > allocated array is leaked. >

Re: [PATCH] staging: android: ion: Use low_order_gfp_flags for smaller allocations

2019-02-13 Thread jing xia
Thanks. On Thu, Feb 14, 2019 at 2:27 AM Laura Abbott wrote: > > On 2/11/19 11:09 PM, Jing Xia wrote: > > gfp_flags is always set high_order_gfp_flags even if allocations of > > order 0 are made.But for smaller allocations, the system should be able > > to reclaim some memory. > > > > Signed-off-b

[PATCH 0/1] staging: android: ion: add the GPL exception note to header

2019-02-13 Thread Hyun Kwon
Hi, I wonder if the exception, "WITH Linux-syscall-note", can be added to the ion header license, to allow user source code with different license to include it without being derivative of GPL. More specifically, we want to use this ion header in a BSD license module [1], without enforcing the GP

Re: [PATCH 2/2] Drivers: hv: vmbus: Display nothing in sysfs if monitor_allocated not set

2019-02-13 Thread Kimberly Brown
On Mon, Feb 11, 2019 at 10:02:47AM -0800, Stephen Hemminger wrote: > On Mon, 11 Feb 2019 02:01:18 -0500 > Kimberly Brown wrote: > > > On Fri, Feb 08, 2019 at 02:32:09PM -0800, Stephen Hemminger wrote: > > > On Fri, 8 Feb 2019 05:01:12 -0500 > > > Kimberly Brown wrote: > > > > > > You are right,

[PATCH v2] staging: erofs: fix memleak of inode's shared xattr array

2019-02-13 Thread Sheng Yong
If it fails to read a shared xattr page, the inode's shared xattr array is not freed. The next time the inode's xattr is accessed, the previously allocated array is leaked. Signed-off-by: Sheng Yong --- v2: * s/node/inode in commit message * add prefix `staging:' to the subject --- drivers/s

Re: [PATCH v2] staging: erofs: fix memleak of inode's shared xattr array

2019-02-13 Thread Gao Xiang
On 2019/2/14 14:46, Sheng Yong wrote: > If it fails to read a shared xattr page, the inode's shared xattr array > is not freed. The next time the inode's xattr is accessed, the previously > allocated array is leaked. > > Signed-off-by: Sheng Yong LGTM, Fixes: b17500a0fdba ("staging: erofs: i