On 2/13/19 4:41 AM, Ian Abbott wrote: > On 12/02/2019 18:44, Gustavo A. R. Silva wrote: >> Add missing break statement in order to prevent the code from falling >> through to the default case and return -EINVAL every time. >> >> This bug was found thanks to the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Fixes: aa94f2888825 ("staging: comedi: ni_660x: tidy up >> ni_660x_set_pfi_routing()") >> Cc: sta...@vger.kernel.org >> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> >> --- >> Changes in v2: >> - Fix Fixes tag. >> >> drivers/staging/comedi/drivers/ni_660x.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/staging/comedi/drivers/ni_660x.c >> b/drivers/staging/comedi/drivers/ni_660x.c >> index e70a461e723f..405573e927cf 100644 >> --- a/drivers/staging/comedi/drivers/ni_660x.c >> +++ b/drivers/staging/comedi/drivers/ni_660x.c >> @@ -656,6 +656,7 @@ static int ni_660x_set_pfi_routing(struct comedi_device >> *dev, >> case NI_660X_PFI_OUTPUT_DIO: >> if (chan > 31) >> return -EINVAL; >> + break; >> default: >> return -EINVAL; >> } >> > > Thanks for the bug fix! >
Glad to help. :) > Reviewed-by: Ian Abbott <abbo...@mev.co.uk> > Thanks, Ian. -- Gustavo _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel