On 12/15/18 5:53 PM, Joe Perches wrote:
On Sat, 2018-12-15 at 17:46 +0100, Michael Straube wrote:
Replace tabs with spaces and/or remove spaces in declarations.
Remove unused/commented declarations, remove unnecessary comment,
remove blank lines between declarations and add missing lines after
d
On Sun, Dec 16, 2018 at 08:57:40AM +0100, Sergio Paracuellos wrote:
> +static int ksz_i2c_read_reg(struct i2c_client *client, u32 reg, u8 *val,
> + unsigned int len)
> +{
> + struct i2c_adapter *adapter = client->adapter;
> + struct i2c_msg msg[2];
> + u8 txd[2];
On Sun, Dec 16, 2018 at 08:57:41AM +0100, Sergio Paracuellos wrote:
> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
>
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Sergio Paracuellos
> ---
> .../devicetree/bindings/net/dsa/ksz.txt | 50 +++
>
On Sun, Dec 16, 2018 at 9:18 AM Andrew Lunn wrote:
>
> On Sun, Dec 16, 2018 at 08:57:41AM +0100, Sergio Paracuellos wrote:
> > Add device-tree binding example of the ksz9477 switch managed in i2c mode.
> >
> > Cc: devicet...@vger.kernel.org
> > Signed-off-by: Sergio Paracuellos
> > ---
> > .../d
On Sun, Dec 16, 2018 at 9:15 AM Andrew Lunn wrote:
>
> On Sun, Dec 16, 2018 at 08:57:40AM +0100, Sergio Paracuellos wrote:
> > +static int ksz_i2c_read_reg(struct i2c_client *client, u32 reg, u8 *val,
> > + unsigned int len)
> > +{
> > + struct i2c_adapter *adapter = cl
> I'll change these two to to get memory from kernel allocators instead
> of using the stack. Thanks for let me know this.
There appear to be other cases as well. Please review the whole
driver.
Thanks
Andrew
___
devel mailing li
Add device-tree binding example of the ksz9477 switch managed in i2c mode.
Cc: devicet...@vger.kernel.org
Signed-off-by: Sergio Paracuellos
---
Changes v2:
- Use generic name for label of the switch and make sure reg and @X
have the same value.
.../devicetree/bindings/net/dsa/ksz.txt
In this mode the switch device and the internal phys will be managed via
I2C interface.
Signed-off-by: Sergio Paracuellos
---
Changes v2:
- Use dev->txbuf as transmition buffer which is allocated using
kernel allocators avoiding some possible DMA issues using the
stack.
drivers/n
Rob, Clk experts, questions for you below.
Jonathan
On Thu, 13 Dec 2018 17:39:22 -0800
Stephen Boyd wrote:
> Quoting Jonathan Cameron (2018-12-08 07:29:54)
> > On Thu, 6 Dec 2018 11:10:51 +0200
> > Mircea Caprioru wrote:
> >
> > > This patch adds a clock to the state structure of ad7192 fo
Chunk heap instantiation should be supported for device tree platforms and
non device tree platforms. For device tree platforms, it's a platform
specific code responsibility to retrieve the heap configuration data
and to call the appropriate API for heap creation. For non device tree
platforms, the
On Tue, 11 Dec 2018 17:54:53 -0700
Jeremy Fertic wrote:
> Change two register addresses and one bit definition to match the
> datasheet.
>
> Signed-off-by: Jeremy Fertic
One comment inline. I added a fixes tag but also a note saying I would
not suggest backporting to stable.
There are too man
On Fri, 14 Dec 2018 09:18:20 +0300
Dan Carpenter wrote:
> On Thu, Dec 13, 2018 at 03:06:29PM -0700, Jeremy Fertic wrote:
> > On Wed, Dec 12, 2018 at 11:19:49AM +0300, Dan Carpenter wrote:
> > > On Tue, Dec 11, 2018 at 05:54:54PM -0700, Jeremy Fertic wrote:
> > > > ADT7316_DA_EN_VIA_DAC_LDCA i
On Tue, 11 Dec 2018 17:54:55 -0700
Jeremy Fertic wrote:
> The only assignment to dac_bits is in adt7316_store_da_high_resolution().
> This function enables or disables 10 bit dac resolution for the adt7316/7
> and adt7516/7 when they're set to output voltage proportional to
> temperature. Remove
On Tue, 11 Dec 2018 17:54:57 -0700
Jeremy Fertic wrote:
> The calculation of the current dac value is using the wrong bits of the
> dac lsb register. Create two macros to shift the lsb register value into
> lsb position, depending on whether the dac is 10 or 12 bit. Initialize
> data to 0 so, wit
On Tue, 11 Dec 2018 17:54:58 -0700
Jeremy Fertic wrote:
> The lsb calculation is not masking the correct bits from the user input.
> Subtract 1 from (1 << offset) to correctly set up the mask to be applied
> to user input.
>
> The lsb register stores its value starting at the bit 7 position.
> a
On Tue, 11 Dec 2018 17:54:59 -0700
Jeremy Fertic wrote:
> The dac internal vref settings are part of the ldac config register rather
> than the dac config register. Change the variable being used so the read
> returns the correct result.
>
> Signed-off-by: Jeremy Fertic
Is this a follow through
On Tue, 11 Dec 2018 17:55:00 -0700
Jeremy Fertic wrote:
> With adt7516/7/9, internal vref is available for dacs a and b, dacs c and
> d, or all dacs. The driver doesn't currently support internal vref for all
> dacs. Change the else if to an if so both bits are checked rather than
> just one or t
On Tue, 11 Dec 2018 17:55:01 -0700
Jeremy Fertic wrote:
> The option to allow the external vref to bypass the reference buffer is
> only available for adt7316/7/8. Remove the attributes for adt751x as
> well as the chip->id checks from the show and store functions.
>
> Signed-off-by: Jeremy Fert
On Tue, 11 Dec 2018 17:55:02 -0700
Jeremy Fertic wrote:
> Based on the output of adt7316_show_all_DAC_update_modes() and
> adt7316_show_DAC_update_mode(), adt7316_store_DAC_update_mode() should
> expect the user to enter an integer input from 0 to 3. The user input is
> currently expected to acco
On Tue, 11 Dec 2018 17:55:03 -0700
Jeremy Fertic wrote:
> Change LDCA to LDAC.
>
> Signed-off-by: Jeremy Fertic
Ah. Here it is ;) As commented on earlier.
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> driv
On Wed, 12 Dec 2018 22:17:46 +0530
Hardik Singh Rathore wrote:
> Initialization is unnecessary when the variable is written before it is
> read. There were some occasions in which the driver would initialize `ret'
> during declaration without need.
>
> Purely a cosmetic change with no functional
On Fri, 14 Dec 2018 01:13:35 +0530
Shreeya Patel wrote:
> ADT7316 driver no more uses platform data and hence use device tree
> data instead of platform data for assigning irq_type field and
> implement this in adt7316_irq_setup function.
> Switch case figures out the type of irq and if it's the
On Sat, 8 Dec 2018 16:19:08 -0200
Marcelo Schmitt wrote:
> Set a single voltage regulator for all voltage references.
> Remove voltage reference value from default platafrom data struct.
>
> Signed-off-by: Marcelo Schmitt
> Signed-off-by: Gabriel Capella
> Co-Developed-by: Gabriel Capella
App
On Sat, 8 Dec 2018 16:19:38 -0200
Marcelo Schmitt wrote:
> Add the option to specify the external clock (MCLK) using the clock
> framework.
> Also remove the old platform data structure.
>
> Signed-off-by: Marcelo Schmitt
> Signed-off-by: Gabriel Capella
> Co-Developed-by: Gabriel Capella
App
On Mon, 10 Dec 2018 21:27:02 +
Jonathan Cameron wrote:
> On Sat, 8 Dec 2018 16:19:59 -0200
> Marcelo Schmitt wrote:
>
> > Add a devicetree documentation for the ad5933 and ad5934 impedance
> > converter, network analyzer.
> >
> > Signed-off-by: Marcelo Schmitt
> > Signed-off-by: Gabriel C
This patch avoids that a sound card is created and registered with ALSA
every time a channel is being linked. Instead the channels are hooked on
the same card, which is registered not until the final link has been added
to the component. The string provided by user space that used to be the
card na
Adding the channel number to the name of the sound card is wrong,
as the card does not represent a single streaming channel of the
MOST device.
Signed-off-by: Christian Gromm
---
v2:
nothing
drivers/staging/most/sound/sound.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
Since the channels of a MOST device are now being represented as
individual PCM devices of one sound card, the variable card_name is not
suitable anymore to describe them. Therefore, this patch renames the
variable to device_name.
Signed-off-by: Christian Gromm
---
v2:
Reported-by: Dan Carpenter
Currently, for every synchronous channel allocated on MOST an extra sound
card is being created and registered with ALSA. From a logical point of
view this fails to reflect the actual condition, as all channels originate
in the same physical device. This patch series introduces a way to map this
la
This patch updates driver_usage.txt file to reflect the latest changes
that this patch set introduces.
Signed-off-by: Christian Gromm
---
v2:
nothing
drivers/staging/most/Documentation/driver_usage.txt | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a
This patch uses a static name for the sound card's short name and
long name. Having the card names configurable doesn't make sense
anymore, as the card represents the same physical hardware.
Signed-off-by: Christian Gromm
---
v2:
nothing
drivers/staging/most/sound/sound.c | 4 ++--
1 fi
This patch fixes the lable name that is used to jump to error
handling section of function audio_probe_channel() in case
something went wrong.
Signed-off-by: Christian Gromm
---
v2:
nothing
drivers/staging/most/sound/sound.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(
On Wed, 12 Dec 2018 23:27:07 +0530
Hardik Singh Rathore wrote:
> Initialization is unnecessary when the variable is written before it is
> read. There were some occasions in which the driver would initialize `ret'
> during declaration without need.
>
> Signed-off-by: Hardik Singh Rathore
Applie
On Thu, 13 Dec 2018 14:46:15 +0200
Stefan Popa wrote:
> This patch replaces the use of wait_event_interruptible() with
> wait_for_completion_timeout() when reading the result of a single
> conversion. In this way, if the interrupt never occurs, the program will
> not remain blocked.
>
> Signed-o
On Thu, 13 Dec 2018 14:46:16 +0200
Stefan Popa wrote:
> Switch to devm version of request_irq, iio_triggered_buffer_setup,
> iio_device_register. To avoid potential ordering issues in probe,
> devm_add_action_or_reset() is used for the regulator_disable(). This
> simplifies the code and decreases
On Thu, 13 Dec 2018 14:46:17 +0200
Stefan Popa wrote:
> This patch replaces the use of a polling ring buffer with a threaded
> interrupt.
>
> Enabling the buffer sets the CONVST signal to high. When the rising edge
> of the CONVST is applied, BUSY signal goes logic high and transitions low
> at
On Thu, 13 Dec 2018 14:46:18 +0200
Stefan Popa wrote:
> When looking for the available scale or oversampling ratio, it is better
> to use the find_closest() macro. This simplifies the code and also does
> not require an exact value to be entered from the user space.
>
> Signed-off-by: Stefan Pop
On Thu, 13 Dec 2018 14:46:19 +0200
Stefan Popa wrote:
> The 'adi' vendor prefix needs to be added to conversion-start, range,
> first-data and oversampling-ratio properties.
>
> Signed-off-by: Stefan Popa
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to
On Thu, 13 Dec 2018 14:46:20 +0200
Stefan Popa wrote:
> The driver does not have a struct of_device_id table, but supported
> devices are registered via Device Trees. This patch adds and OF device
> ID table.
>
> Signed-off-by: Stefan Popa
Applied.
Thanks,
Jonathan
> ---
> drivers/staging/i
On Thu, 13 Dec 2018 14:46:21 +0200
Stefan Popa wrote:
> * Placed includes in alphabetical order
> * Added brackets around num and mask through out for AD760X_CHANNEL
> * Used single line comments where needed
> * Removed extra lines and spaces
>
> Signed-off-by: Stefan Popa
Looks fine, but unsu
On Thu, 13 Dec 2018 14:46:23 +0200
Stefan Popa wrote:
> Document support for AD7606 Analog to Digital Converter.
>
> Signed-off-by: Stefan Popa
> Reviewed-by: Rob Herring
Will have to wait on this as the MAINTAINERS bit obviously isn't there yet.
Otherwise I would have just added it now. Oh w
On Thu, 13 Dec 2018 14:46:22 +0200
Stefan Popa wrote:
> Move ad7606 ADC driver out of staging and into the mainline.
>
> Signed-off-by: Stefan Popa
Other than the things already mentioned in earlier patches, looks good to
me.
Thanks
Jonathan
> ---
> MAINTAINERS |
Fixed an endline open parenthesis issue and replaced udelay() by the
preferred usleep_range() function.
Signed-off-by: Amir Mahdi Ghorbanian
---
drivers/staging/nvec/nvec.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/stagin
Fixed a coding style issue.
Signed-off-by: Amir Mahdi Ghorbanian
---
drivers/staging/comedi/drivers/cb_pcidas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c
b/drivers/staging/comedi/drivers/cb_pcidas.c
index 8429d57..02ae00c 1006
On Sun, 2018-12-16 at 08:57 -0800, Amir Mahdi Ghorbanian wrote:
> Fixed an endline open parenthesis issue and replaced udelay() by the
> preferred usleep_range() function.
Not all checkpatch bleats need to be fixed.
Function names with 40+ character length identifiers makes
fitting within an 80 c
Replaced udelay() by the preferred usleep_range() function.
Signed-off-by: Amir Mahdi Ghorbanian
---
drivers/staging/nvec/nvec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 08027a3..6f35f92 100644
--- a/d
On Sun, Dec 16, 2018 at 01:43:54PM -0800, Amir Mahdi Ghorbanian wrote:
> Replaced udelay() by the preferred usleep_range() function.
>
> Signed-off-by: Amir Mahdi Ghorbanian
Nack, usleep_range isn't for atomic contexts like interrupt handlers.
> ---
> drivers/staging/nvec/nvec.c | 4 ++--
> 1
On Sun, 2018-12-16 at 13:43 -0800, Amir Mahdi Ghorbanian wrote:
> Replaced udelay() by the preferred usleep_range() function.
[]
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
[]
> @@ -626,7 +626,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> br
Hi Amir,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.20-rc7 next-20181214]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-c
staging:iio:adc: fix codestyle
Signed-off-by: Sergey Efimochkin
---
drivers/staging/iio/adc/ad7280a.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c
b/drivers/staging/iio/adc/ad7280a.c
index 58420dcb406d..52e12d1201b3 1
On Sun, Dec 16, 2018 at 08:57:40AM +0100, Sergio Paracuellos wrote:
> +static int ksz_i2c_write(struct ksz_device *dev, u32 reg, u8 *val,
> + unsigned int len)
> +{
> + struct i2c_client *client = dev->priv;
> + unsigned int cnt = len;
> + int i = 0;
> + u8 txb[
We free instance here and in the caller. It should be only the caller
which handles it.
Fixes: d7ca3a71545b ("staging: bcm2835-audio: Operate non-atomic PCM ops")
Signed-off-by: Dan Carpenter
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 1 -
1 file changed, 1 deletion(-)
d
On Sun, Dec 16, 2018 at 10:49:52AM +0100, Sergio Paracuellos wrote:
> In this mode the switch device and the internal phys will be managed via
> I2C interface.
>
> Signed-off-by: Sergio Paracuellos
> ---
> Changes v2:
> - Use dev->txbuf as transmition buffer which is allocated using
> k
The patch prefix should be "staging: iio: adc: ad7280a:". Do
git log --oneline drivers/staging/iio/adc/ad7280a.c and copy what
other people do.
On Mon, Dec 17, 2018 at 04:43:33AM +0300, Sergey Efimochkin wrote:
> staging:iio:adc: fix codestyle
Only to do one thing per patch. We need a better pa
On Sun, Dec 16, 2018 at 01:36:19PM +0100, Christian Gromm wrote:
> @@ -571,6 +600,39 @@ static int audio_probe_channel(struct most_interface
> *iface, int channel_id,
> return -EINVAL;
> }
>
> + ret = split_arg_list(arg_list, &card_name, &ch_num, &sample_res,
> +
55 matches
Mail list logo
