On Sun, Dec 16, 2018 at 9:18 AM Andrew Lunn <and...@lunn.ch> wrote:
>
> On Sun, Dec 16, 2018 at 08:57:41AM +0100, Sergio Paracuellos wrote:
> > Add device-tree binding example of the ksz9477 switch managed in i2c mode.
> >
> > Cc: devicet...@vger.kernel.org
> > Signed-off-by: Sergio Paracuellos <sergio.paracuel...@gmail.com>
> > ---
> >  .../devicetree/bindings/net/dsa/ksz.txt       | 50 +++++++++++++++++++
> >  1 file changed, 50 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt 
> > b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> > index 0f407fb371ce..9e715358cebb 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
> > +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> > @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port 
> > wired to eth0:
> >                                                               };
> >                                               };
> >                               };
> > +
> > +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
> > +
> > +                             eth0: ethernet@10001000 {
> > +                                             fixed-link {
> > +                                                             speed = 
> > <1000>;
> > +                                                             full-duplex;
> > +                                             };
> > +                             };
> > +
> > +                             i2c0: i2c@f8008000 {
> > +                                             ksz9897: ksz9897@0 {
>
> Hi Sergio
>

Hi Andrew,

Thanks for such a fast review :-)

> You should use a generic name here. Plus the @X needs to be the same as the 
> reg value.
> So switch: ksz9897@5f.

Ok, I'll change this. Copy paste is bad friend sometimes.

>
>    Andrew

Best regards,
    Sergio Paracuellos
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to