[PATCH] staging: bcm2835-camera: Fix module section mismatch warnings.

Noticed by Stephen Rothwell in -next. Signed-off-by: Eric Anholt Fixes: 4bebb0312ea9 ("staging/bcm2835-camera: Set ourselves up as a platform driver.") Cc: Stephen Rothwell --- Note: only compile tested here. .../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 8 1 file chan

Re: [PATCH 14/30] staging: wilc1000: fix line over 80 chars in add_network_to_shadow()

Hi Ajay, On 10.05.2018 08:27, Claudiu Beznea wrote: > > > On 09.05.2018 21:42, Ajay Singh wrote: >> On Wed, 9 May 2018 16:43:14 +0300 >> Claudiu Beznea wrote: >> >>> On 07.05.2018 11:43, Ajay Singh wrote: Fix line over 80 characters issue reported by checkpatch in add_network_to_shado

Re: [PATCH] staging: bcm2835-camera: Fix module section mismatch warnings.

On Mon, May 14, 2018 at 08:44:11AM +0100, Eric Anholt wrote: > Noticed by Stephen Rothwell in -next. > > Signed-off-by: Eric Anholt > Fixes: 4bebb0312ea9 ("staging/bcm2835-camera: Set ourselves up as a platform > driver.") > Cc: Stephen Rothwell Should be: Reported-by: Stephen Rothwell I'll

[PATCH] staging: most: video: fix build warnings

Commit 7d7cdb4fa552 ("staging: most: video: remove debugging code") ended up adding a bunch of build warnings about unused variables. Fix that up by removing those variables as we don't need them anymore. Cc: Abdun Nihaal Reported-by: Stephen Rothwell Fixes: 7d7cdb4fa552 ("staging: most: video:

[PATCH] staging: video: fix warning unused variable

When building video warnings pops up unused variable 'mdev', drivers/staging/most/video/video.c: In function ‘vidioc_enum_fmt_vid_cap’: drivers/staging/most/video/video.c:265:25: warning: unused variable ‘mdev’ [-Wunused-variable] struct most_video_dev *mdev = fh->mdev;

Re: [PATCH] staging: video: fix warning unused variable

On Mon, May 14, 2018 at 12:54:42PM +0200, Anders Roxell wrote: > When building video warnings pops up unused variable 'mdev', > drivers/staging/most/video/video.c: In function ‘vidioc_enum_fmt_vid_cap’: > drivers/staging/most/video/video.c:265:25: warning: unused variable ‘mdev’ > [-Wunused-variab

Re: [PATCH 14/30] staging: wilc1000: fix line over 80 chars in add_network_to_shadow()

Hi Claudiu, On Mon, 14 May 2018 11:57:24 +0300 Claudiu Beznea wrote: > Hi Ajay, > > On 10.05.2018 08:27, Claudiu Beznea wrote: > > > > > > On 09.05.2018 21:42, Ajay Singh wrote: > >> On Wed, 9 May 2018 16:43:14 +0300 > >> Claudiu Beznea wrote: > >> > >>> On 07.05.2018 11:43, Ajay Singh w

Re: [PATCH] staging: bcm2835-camera: Add TODO for removing overlay support

On Fri, May 11, 2018 at 01:12:44AM +0200, Stefan Schake wrote: > The overlay code is non-functional since it relies on firmware control > of the HVS. > > Signed-off-by: Stefan Schake > --- > Dave, does this match your understanding? This doesn't apply to my tree, can you rebase and resend? than

Re: [PATCH 00/14] staging: clocking-wizard: Implement many TODOs

On Mon, May 07, 2018 at 11:20:26AM +1000, James Kelly wrote: > This series of patches attempts to implement many of the outstanding TODOs > for the Xilinx Clocking Wizard IP driver that has been languishing in the > staging tree for some time. I had a need for this driver so I thought it > appropr

Re: [PATCH] ANDROID: binder: remove 32-bit binder interface.

On Fri, May 11, 2018 at 09:57:52AM +0200, Martijn Coenen wrote: > On Sat, May 5, 2018 at 2:10 PM, kbuild test robot wrote: > >drivers/android/binder.o: In function `binder_thread_write': > >>> binder.c:(.text+0x6a16): undefined reference to `__get_user_bad' > > Looks like m68k doesn't support

Re: [PATCH 0/4] staging: Few fixes for the mt7621-eth driver

On Mon, May 07, 2018 at 08:38:29AM +1000, NeilBrown wrote: > > Thanks for these. Unfortunately you didn't cc me on the individual > patches so I had to go and look in the online archive. Btw, these days everyone uses git so get_maintainer.pl picks you as a maintainer but you should add yourself

Re: [PATCH 3/7] staging: ks7010: Remove unnecessary limit checks

On Sun, May 06, 2018 at 03:03:00PM -0700, Nathan Chancellor wrote: > uwrq is an unsigned 32-bit integer, it cannot be less than zero. > > Signed-off-by: Nathan Chancellor > --- > drivers/staging/ks7010/ks_wlan_net.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/

Re: [PATCH 2/6] staging: android: Clean up license identifiers

On Sun, May 06, 2018 at 06:13:24PM -0700, Nathan Chancellor wrote: > Add the identifiers when missing and fix the ones already present > according to checkpatch.pl. > > Signed-off-by: Nathan Chancellor > --- > drivers/staging/android/ashmem.h| 6 +- > drivers/staging/android/uapi/as

Re: [PATCH 3/6] staging: android: vsoc: Fix ending '(' warnings in function defintions

I hate this checkpatch warning... The original is often superior to the modified versions we see. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 01/14] staging: clocking-wizard: Add principles of operation

On Fri, May 11, 2018 at 08:04:01AM +0200, Michal Simek wrote: > > There are some double spaces in the text without any reason. > Are you talking about two spaces after a period?? Kernel style guide has no official position on this. It's up to the author. regards, dan carpenter __

Re: [PATCH 03/14] staging: clocking-wizard: Split probe function

On Mon, May 07, 2018 at 11:20:29AM +1000, James Kelly wrote: > +static int clk_wzrd_probe(struct platform_device *pdev) > +{ > + int ret; > + struct device *dev = &pdev->dev; > + > + ret = clk_wzrd_get_device_tree_data(dev); > + if (ret) > + return ret; > + > + ret =

Re: [PATCH 2/6] staging: android: Clean up license identifiers

On Mon, May 14, 2018 at 04:29:45PM +0300, Dan Carpenter wrote: > On Sun, May 06, 2018 at 06:13:24PM -0700, Nathan Chancellor wrote: > > Add the identifiers when missing and fix the ones already present > > according to checkpatch.pl. > > > > Signed-off-by: Nathan Chancellor > > --- > > drivers/s

Re: [PATCH 2/6] staging: android: Clean up license identifiers

> On 14 May 2018 at 14:29 Dan Carpenter wrote: > > > On Sun, May 06, 2018 at 06:13:24PM -0700, Nathan Chancellor wrote: > > Add the identifiers when missing and fix the ones already present > > according to checkpatch.pl. > > > > Signed-off-by: Nathan Chancellor > > --- > > drivers/staging/a

Re: [PATCH] ANDROID: binder: remove 32-bit binder interface.

Hi Christoph, On Mon, May 14, 2018 at 2:03 PM, Christoph Hellwig wrote: > On Fri, May 11, 2018 at 09:57:52AM +0200, Martijn Coenen wrote: >> On Sat, May 5, 2018 at 2:10 PM, kbuild test robot wrote: >> >drivers/android/binder.o: In function `binder_thread_write': >> >>> binder.c:(.text+0x6a16

[PATCH 0/5] staging: mt7621-gpio: some driver cleanups

The following patch series fix all remaining checkpatch complains about this driver. Changes have not been tested and also compiled but it should not have any problem about them. Sergio Paracuellos (5): staging: mt7621-gpio: fix some warnings because of lines exceded 80 characters staging:

[PATCH 3/5] dt-bindings: add compatible string for 'mtk' MediaTek

There is a complain of checkpatch script about the not documented DT compatible string for vendor "mtk". Add it to vendor-prefixes.txt file. Signed-off-by: Sergio Paracuellos --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentati

[PATCH 4/5] dt-bindings: gpio: add documentation for mt7621-gpio

This commit add missing dt bindings documentation for mt7621-gpio driver. After this checkpatch script complain about this issue dissapears. Signed-off-by: Sergio Paracuellos --- .../devicetree/bindings/gpio/mtk,mt7621-gpio.txt | 51 ++ 1 file changed, 51 insertions(+) cre

[PATCH 2/5] staging: mt7621-gpio: add SPDX identifier

It's good to have SPDX identifiers in driver files to make it easier to audit the kernel tree for correct licenses. Fix up the one of staging gpio-mt7621 file to have a proper SPDX identifier, based on the license text in the file itself. The SPDX identifier is a legally binding shorthand, which c

[PATCH 1/5] staging: mt7621-gpio: fix some warnings because of lines exceded 80 characters

This patch silence some complains of checkpatch script because of the use of long lines. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-gpio/gpio-mt7621.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/staging/mt7621-gpio/gpio-mt762

[PATCH 5/5] staging: mt7621-gpio: remove device tree related stuff from TODO file

Documentation related with device tree and its checkpatch complains have been added. Update TODO file accordingly. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-gpio/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/mt7621-gpio/TODO b/drivers/staging/mt7621-g

[PATCH] staging: ks7010: Remove unused define

After commit 6d6612deaf55 ("staging: ks7010: Remove unnecessary limit checks"), this define is not used anywhere. Remove it as well. Suggested-by: Dan Carpenter Signed-off-by: Nathan Chancellor --- drivers/staging/ks7010/ks_wlan.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/stagi

Re: [PATCH 3/7] staging: ks7010: Remove unnecessary limit checks

On Mon, May 14, 2018 at 04:17:36PM +0300, Dan Carpenter wrote: > On Sun, May 06, 2018 at 03:03:00PM -0700, Nathan Chancellor wrote: > > uwrq is an unsigned 32-bit integer, it cannot be less than zero. > > > > Signed-off-by: Nathan Chancellor > > --- > > drivers/staging/ks7010/ks_wlan_net.c | 6 +

Re: [PATCH 2/6] staging: android: Clean up license identifiers

On Mon, May 14, 2018 at 02:52:16PM +0100, Justin Skists wrote: > > > On 14 May 2018 at 14:29 Dan Carpenter wrote: > > > > > > On Sun, May 06, 2018 at 06:13:24PM -0700, Nathan Chancellor wrote: > > > Add the identifiers when missing and fix the ones already present > > > according to checkpatch.

Re: [PATCH 3/7] staging: ks7010: Remove unnecessary limit checks

On Mon, May 14, 2018 at 07:06:22AM -0700, Nathan Chancellor wrote: > On Mon, May 14, 2018 at 04:17:36PM +0300, Dan Carpenter wrote: > > On Sun, May 06, 2018 at 03:03:00PM -0700, Nathan Chancellor wrote: > > > uwrq is an unsigned 32-bit integer, it cannot be less than zero. > > > > > > Signed-off-b

Re: [PATCH 03/14] staging: clocking-wizard: Split probe function

On Mon, May 14, 2018 at 04:47:26PM +0300, Dan Carpenter wrote: > On Mon, May 07, 2018 at 11:20:29AM +1000, James Kelly wrote: > > +static int clk_wzrd_probe(struct platform_device *pdev) > > +{ > > + int ret; > > + struct device *dev = &pdev->dev; > > + > > + ret = clk_wzrd_get_device_tree_da

Coding Style of drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

There were a lot of coding style issues with this file, but I think I've reduced the number down to mainly line length and CamelCase issues. I've put it in 13 patches to, hopefully, make it easier to review, and see that I've made no changes to functionality of the code, (I hope). John __

[PATCH 02/13] coding style chages to the switch statements in the file.

Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 93 ++ 1 file changed, 44 insertions(+), 49 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 17a7209

[PATCH 01/13] Coding style changes to block comments

The file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c has a lot of coding style issues, this will be the first of many small patches which clear up some, if not all, of the problems with the file. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 319 ++

[PATCH 04/13] coding style corrections, spaces around ', ' characters and removal of blank lines

Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 134 +++-- 1 file changed, 42 insertions(+), 92 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 9366b62

[PATCH 03/13] coding style corrections for if statements

Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 273 + 1 file changed, 112 insertions(+), 161 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 9e596

[PATCH 09/13] Coding style, corrected bad indentation of a statement.

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 254d536c21d8..f26b01c56d66 1006

[PATCH 13/13] Coding style, corrected an indentation issue, (use tabs).

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index af6508dfd897..7a765b022f8c 1006

[PATCH 07/13] Coding style, removal of redundant returns from void functions.

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 13f1eee7d8b1..56cc1192cf9f 100644 --- a/driv

[PATCH 05/13] Coding style corrections. Added spaces around operators.

Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 148 ++--- 1 file changed, 74 insertions(+), 74 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 110fa8b

[PATCH 11/13] Coding style: corrections to for statements.

I few other minor coding style issues. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 42 ++ 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/

[PATCH 08/13] Coding style, added blank line after declarations.

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 56cc1192cf9f..254

[PATCH 10/13] Coding style: Removal of prohibited spaces.

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index f26b01c56d66..25db00

[PATCH 12/13] Coding style, removal of braces from single statement blocks

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 742eb35ae442..af

[PATCH 06/13] Coding style, removal of redundant braces.

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 925a8f313e9f..13f1

Re: [PATCH 01/13] Coding style changes to block comments

On Mon, May 14, 2018 at 04:53:06PM +0100, John Whitmore wrote: > The file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c has a lot of > coding style issues, this will be the first of many small patches which clear > up some, if not all, of the problems with the file. This isn't a good changel

Re: [PATCH 02/13] coding style chages to the switch statements in the file.

On Mon, May 14, 2018 at 04:53:07PM +0100, John Whitmore wrote: > Signed-off-by: John Whitmore > --- > .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 93 > ++ > 1 file changed, 44 insertions(+), 49 deletions(-) And I can't take patches without any changelog comments at

Re: A few questions about warnings in the ion driver

On 05/07/2018 07:51 AM, Nathan Chancellor wrote: On Mon, May 07, 2018 at 06:46:23AM -0700, Laura Abbott wrote: On 05/06/2018 06:43 PM, Nathan Chancellor wrote: Hi everyone, I compiled the ion driver with W=1 where I encountered the two following warnings and I had a couple of questions about s

RE: [PATCH 1/1] Drivers: hv: vmbus: enable VMBus protocol version 5.0

> From: devel On Behalf Of > Stephen Hemminger > Sent: Sunday, May 13, 2018 10:24 > > ... > > @@ -372,6 +400,18 @@ int vmbus_post_msg(void *buffer, size_t buflen, > bool can_sleep) > > ... > > + hdr = (struct vmbus_channel_message_header *)buffer; > > Hate to pick o the details,

Re: [PATCH 1/1] Drivers: hv: vmbus: enable VMBus protocol version 5.0

On Mon, 14 May 2018 18:14:15 + Dexuan Cui wrote: > > From: devel On Behalf Of > > Stephen Hemminger > > Sent: Sunday, May 13, 2018 10:24 > > > ... > > > @@ -372,6 +400,18 @@ int vmbus_post_msg(void *buffer, size_t buflen, > > bool can_sleep) > > > ... > > > + hdr = (str

[PATCH] staging: android: ion: Check return value of ion_buffer_kmap_get

GCC warns that vaddr is set but unused. Check the return value of ion_buffer_kmap_get to make vaddr useful and make sure everything is properly configured before beginning a DMA. Suggested-by: Laura Abbott Signed-off-by: Nathan Chancellor --- drivers/staging/android/ion/ion.c | 10 -- 1

RE: [PATCH 1/1] Drivers: hv: vmbus: enable VMBus protocol version 5.0

> From: Stephen Hemminger > Sent: Monday, May 14, 2018 11:18 > To: Dexuan Cui > > > ... > > > Hate to pick o the details, but buffer is void * so cast is not necessary > > > here. > > > > Yes, it's unnecessary in C, though it's necessary in C++. > > > > I found the patch went into char-misc 4 ho

Re: [PATCH 03/14] staging: clocking-wizard: Split probe function

Dan, > On 14 May 2018, at 11:47 pm, Dan Carpenter wrote: > > On Mon, May 07, 2018 at 11:20:29AM +1000, James Kelly wrote: >> +static int clk_wzrd_probe(struct platform_device *pdev) >> +{ >> +int ret; >> +struct device *dev = &pdev->dev; >> + >> +ret = clk_wzrd_get_device_tree_data(d

Re: [PATCH 00/14] staging: clocking-wizard: Implement many TODOs

Greg, > On 14 May 2018, at 10:02 pm, Greg Kroah-Hartman > wrote: > > Can you please fix up the issues reported in this series, rebase on my > latest tree, and resend so that I can apply them? > > thanks, > > greg k-h I’m working on a version 2 patch set and will post when it is ready. Jame

[PATCH] staging: mt7621-eth: Remove unused variable

Remove unused variable 'condition' which was set but not used. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c b/drivers/staging/mt7621-eth/mtk_eth_soc.c index

Re: WARNING in ion_buffer_destroy

On 05/09/2018 11:59 PM, Dmitry Vyukov wrote: On Wed, Jan 10, 2018 at 7:14 PM, Laura Abbott wrote: On 01/09/2018 02:58 PM, syzbot wrote: Hello, syzkaller hit the following crash on 06d41862286aa7bc634a1dd9e6e7e96f925ef30a git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/maste

[PATCH] staging: speakup: use true/false instead of 1/0

Signed-off-by: Samuel Thibault --- drivers/staging/speakup/buffers.c |2 +- drivers/staging/speakup/main.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/drivers/staging/speakup/buffers.c +++ b/drivers/staging/speakup/buffers.c @@ -80,7 +80,7 @@ void synth_buffer_add(u1

[PATCH 02/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: space before ', '

Coding style edit to clear the checkpatch.pl errors of the type: ERROR: space prohibited before that ',' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH 07/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct indentation of switch statements

Coding style edit to clear the checkpatch.pl error: ERROR: switch and case should be at the same indent Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 48 +++--- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/staging

[PATCH 01/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct braces

Coding style edit to clear the checkpatch.pl errors of the type: ERROR: that open brace { should be on the previous line Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 197 - 1 file changed, 70 insertions(+), 127 deletions(-) diff --git

[PATCH 03/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct space before ')'

Coding style edit to clear the checkpatch.pl errors of the type: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/dri

[PATCH 09/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed redundant return statement

Coding style edit to clear the checkpatch.pl warning: WARNING: void function return statements are not generally useful Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl

[PATCH 04/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct spaces around operators

Coding style edit to clear the checkpatch.pl errors of the type: ERROR: spaces required around that... Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 122 ++--- 1 file changed, 61 insertions(+), 61 deletions(-) diff --git a/drivers/staging/

[PATCH 08/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct whitespace style errors

Coding style edit to clear the remaining checkpatch.pl errors: ERROR: trailing whitespace ERROR: space prohibited after that open parenthesis '(' ERROR: space required before the open brace '{' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 6 +++--- 1 fil

[PATCH 10/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Added missing blank line after declarations.

Coding style edit to clear the checkpatch.pl warnings: WARNING: Missing a blank line after declarations Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTP

[PATCH 15/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Use __func__ instead of hardcoded function name

Coding style edit to clear the checkpatch.pl warnings: WARNING: Prefer using '"%s...", __func__' to using '', this function's name, in a string Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletion

coding style changes to drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

Second attempt at this commit, apologies for that. Coding style changes to resolve some of the scripts/checkpatch.pl issues with the file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c. There remain line length and CamelCase issues unresolved in the file. ___

[PATCH 17/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Added blank line after function

Coding style edit to clear the checkpatch.pl check: CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/rtl8192

[PATCH 24/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: coding style correction of NULL tests

Coding style edit to clear the checkpatch.pl check: CHECK: Comparison to NULL could be written "!..." Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee8

[PATCH 16/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed blank lines before closing brace

Coding style edit to clear the checkpatch.pl check: CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee802

[PATCH 18/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Removed blank lines after opening brace

Coding style edit to clear the checkpatch.pl check: CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_

[PATCH 06/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct braces of else statement

Coding style edit to clear the checkpatch.pl error: ERROR: space required after that close brace '}' And balanced the brace of the same else statement: CHECK: Unbalanced braces around else statement Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 ++-- 1

[PATCH 14/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: corrected block comment style

Coding style edit to clear the checkpatch.pl warning: WARNING: Block comments use * on subsequent lines Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging/r

[PATCH 19/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed extra blank lines

Coding style edit to clear the checkpatch.pl check: CHECK: Please don't use multiple blank lines Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 24 -- 1 file changed, 24 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl81

[PATCH 11/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: corrected block comments

Coding style edit to clear the checkpatch.pl Warnings: WARNING: Block comments should align the * on each line Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 181 +++-- 1 file changed, 97 insertions(+), 84 deletions(-) diff --git a/drivers/

[PATCH 13/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed redundant braces

Coding style edit to clear the checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/stagi

[PATCH 21/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: corrected indentation

Coding style edit to clear the checkpatch.pl check: CHECK: Alignment should match open parenthesis Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192u/ie

[PATCH 05/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct missing space before '('

Coding style edit to clear the checkpatch.pl errors of the type: ERROR: space required before the open parenthesis '(' Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 176 ++--- 1 file changed, 87 insertions(+), 89 deletions(-) diff --git a/

[PATCH 26/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Spelling correction in a comment

Spelling correction in comment: singal -> signal Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl8

[PATCH 25/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Added prefered spacing around operators

Coding style edit to clear the checkpatch.pl check: CHECK: spaces preferred around that 'x' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH 27/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed redundant return statement

Coding style edit to clear the checkpatch.pl warnings: WARNING: void function return statements are not generally useful Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rt

[PATCH 22/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: coding style correction of a function declaration

Coding style edit to clear the checkpatch.pl check: CHECK: Lines should not end with a '(' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc

[PATCH 12/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed space from start of line

Coding style edit to clear the checkpatch.pl warning: WARNING: please, no spaces at the start of a line Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl8

[PATCH 23/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed unnecessary parentheses

Coding style edit to clear the checkpatch.pl check: CHECK: Unnecessary parentheses around ... Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/r

driverdev-devel@linuxdriverproject.org

Coding style edit to clear the checkpatch.pl check: CHECK: spaces preferred around that '&' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_

Re: [PATCH] ANDROID: binder: remove 32-bit binder interface.

On Mon, May 14, 2018 at 4:00 PM, Geert Uytterhoeven wrote: > Patch sent. Thanks for the quick turn-around! > > BTW, sh also doesn't seem to have 64-bit get_user(). > There may be others. I checked quickly, nios2 is the only other arch that explicitly doesn't support it and would result in a bui

[PATCH] staging: android: ion: Switch to pr_warn_once in ion_buffer_destroy

Syzbot reported yet another warning with Ion: WARNING: CPU: 0 PID: 1467 at drivers/staging/android/ion/ion.c:122 ion_buffer_destroy+0xd4/0x190 drivers/staging/android/ion/ion.c:122 Kernel panic - not syncing: panic_on_warn set ... This is catching that a buffer was freed with an existing kernel m

[PATCH] Drivers: hv: vmbus: Removed an unnecessary cast from void *

In C, we don't need such a cast. Fixes: ae20b254306a ("Drivers: hv: vmbus: enable VMBus protocol version 5.0") Signed-off-by: Dexuan Cui Cc: Stephen Hemminger Cc: K. Y. Srinivasan --- Thanks Stephen Hemminger for pointing this out! So far, ae20b254306a ("Drivers: hv: vmbus: enable VMBus prot

Re: [PATCH 4/4] staging: lustre: obdclass: change object lookup to no wait mode

> On Wed, May 02 2018, James Simmons wrote: > > > From: Lai Siyao > > > > Currently we set LU_OBJECT_HEARD_BANSHEE on object when we want > > to remove object from cache, but this may lead to deadlock, because > > when other process lookup such object, it needs to wait for this > > object until

Re: [PATCH] staging: mt7621-eth: Remove unused variable

On Mon, May 14 2018, Kamal Heib wrote: > Remove unused variable 'condition' which was set but not used. > > Signed-off-by: Kamal Heib Reviewed-by: NeilBrown This is the same patch as Commit: f03b06f3bae8 ("net: ethernet: mediatek: remove useless code in mtk_poll_tx()") which applies to driv

Re: [PATCH 0/5] staging: mt7621-gpio: some driver cleanups

On Mon, May 14 2018, Sergio Paracuellos wrote: > The following patch series fix all remaining checkpatch complains > about this driver. Changes have not been tested and also compiled > but it should not have any problem about them. Thanks for these. As you say, nothing in them could change behav

Re: [PATCH 4/5] dt-bindings: gpio: add documentation for mt7621-gpio

On Mon, May 14 2018, Sergio Paracuellos wrote: > This commit add missing dt bindings documentation for mt7621-gpio > driver. After this checkpatch script complain about this > issue dissapears. > > Signed-off-by: Sergio Paracuellos > --- > .../devicetree/bindings/gpio/mtk,mt7621-gpio.txt | 51

Re: [PATCH 5/5] staging: mt7621-gpio: remove device tree related stuff from TODO file

On Mon, May 14 2018, Sergio Paracuellos wrote: > Documentation related with device tree and its checkpatch complains > have been added. Update TODO file accordingly. > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/mt7621-gpio/TODO | 1 - > 1 file changed, 1 deletion(-) > > diff --g

Re: [PATCH 4/4] staging: lustre: obdclass: change object lookup to no wait mode

On Tue, May 15 2018, James Simmons wrote: >> On Wed, May 02 2018, James Simmons wrote: >> >> > From: Lai Siyao >> > >> > Currently we set LU_OBJECT_HEARD_BANSHEE on object when we want >> > to remove object from cache, but this may lead to deadlock, because >> > when other process lookup such ob

Re: [PATCH 4/4] staging: lustre: obdclass: change object lookup to no wait mode

> >> On Wed, May 02 2018, James Simmons wrote: > >> > >> > From: Lai Siyao > >> > > >> > Currently we set LU_OBJECT_HEARD_BANSHEE on object when we want > >> > to remove object from cache, but this may lead to deadlock, because > >> > when other process lookup such object, it needs to wait for t

[PATCH v2] staging: lustre: obdclass: change object lookup to no wait mode

From: Lai Siyao Currently we set LU_OBJECT_HEARD_BANSHEE on object when we want to remove object from cache, but this may lead to deadlock, because when other process lookup such object, it needs to wait for this object until release (done at last refcount put), while that process maybe already h

[PATCH 3/5] staging: lustre: acl: increase ACL entries limitation

From: Fan Yong Originally, the limitation of ACL entries is 32, that is not enough for some use cases. In fact, restricting ACL entries count is mainly for preparing the RPC reply buffer to receive the ACL data. So we cannot make the ACL entries count to be unlimited. But we can enlarge the RPC r

[PATCH v2 2/5] staging: lustre: llite: remove unused parameters from md_{get, set}xattr()

From: "John L. Hammond" md_getxattr() and md_setxattr() each have several unused parameters. Remove them and improve the naming or remaining parameters. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10792 Reviewed-on: https://review.whamcloud.com/ Reviewed-b

[PATCH v2 1/5] staging: lustre: llite: add support set_acl method in inode operations

From: Dmitry Eremin Linux kernel v3.14 adds set_acl method to inode operations. This patch adds support to Lustre for proper acl management. Signed-off-by: Dmitry Eremin Signed-off-by: John L. Hammond Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Review

[PATCH 0/5] staging: lustre: llite: remaining xattr fixes

Fixed the bugs in the set_acl patch pointed out by Dan Carpenter. Rebased the next patch 'remove unused parameter..." on the parent patch. Added newer xattr fixes that were recently pushed. Andrew Perepechko (1): staging: lustre: mdc: excessive memory consumption by the xattr cache Dmitry Eremi

[PATCH 4/5] staging: lustre: mdc: excessive memory consumption by the xattr cache

From: Andrew Perepechko The refill operation of the xattr cache does not know the reply size in advance, so it makes a guess based on the maxeasize value returned by the MDS. In practice, it allocates 16 KiB for the common case and 4 MiB for the large xattr case. However, a typical reply is just

  1   2   >