On Sun, May 06, 2018 at 03:03:00PM -0700, Nathan Chancellor wrote: > uwrq is an unsigned 32-bit integer, it cannot be less than zero. > > Signed-off-by: Nathan Chancellor <natechancel...@gmail.com> > --- > drivers/staging/ks7010/ks_wlan_net.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_wlan_net.c > b/drivers/staging/ks7010/ks_wlan_net.c > index e96477937f65..0c83d6fe270f 100644 > --- a/drivers/staging/ks7010/ks_wlan_net.c > +++ b/drivers/staging/ks7010/ks_wlan_net.c > @@ -1928,7 +1928,7 @@ static int ks_wlan_set_beacon_lost(struct net_device > *dev, > if (priv->sleep_mode == SLP_SLEEP) > return -EPERM; > /* for SLEEP MODE */ > - if (*uwrq < BEACON_LOST_COUNT_MIN || *uwrq > BEACON_LOST_COUNT_MAX) > + if (*uwrq > BEACON_LOST_COUNT_MAX)
I believe Smatch is supposed to ignore this sort of code because comparing "if (foo < 0 || foo > max) " is pretty readable and idiomatic. Presumably this was so we could redefine BEACON_LOST_COUNT_MIN, but it's fine to unused code. The define isn't needed at all, so you can delete that as well. regards, dan carpenter _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
