Re: [PATCH v1 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-09-28 Thread Dan Carpenter
On Thu, Sep 28, 2017 at 02:28:04AM +0300, Dmitry Osipenko wrote: > >> + if (is_baseline_profile) > >> + frame->aux_paddr = 0xF4DEAD00; > > > > The handling of is_baseline_profile is strange to me. It feels like we > > should always check it before we use ->aux_paddr but we don't ever do

[PATCH] Staging: fsl-mc: remove unnecessary parenthesis

2017-09-28 Thread Keerthi Reddy
Remove unnecessary parenthesis Signed-off-by: Keerthi Reddy --- drivers/staging/fsl-mc/bus/fsl-mc-msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/fsl-mc-msi.c index 038da4d..f74a6f1 100644 --- a/drive

Re: [PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-09-28 Thread Sylwester Nawrocki
On 09/27/2017 11:46 PM, Mauro Carvalho Chehab wrote: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME > match criteria requires just a device name. > > So, it doesn't make sense to enclose those into structs,

Re: [PATCH v1 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-09-28 Thread Dmitry Osipenko
On 28.09.2017 10:23, Dan Carpenter wrote: > On Thu, Sep 28, 2017 at 02:28:04AM +0300, Dmitry Osipenko wrote: + if (is_baseline_profile) + frame->aux_paddr = 0xF4DEAD00; >>> >>> The handling of is_baseline_profile is strange to me. It feels like we >>> should always check it bef

Re: [PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-09-28 Thread Sakari Ailus
Hi Mauro, On Wed, Sep 27, 2017 at 06:46:56PM -0300, Mauro Carvalho Chehab wrote: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME > match criteria requires just a device name. > > So, it doesn't make sense to

[RESEND PATCH 0/3] staging: rtl8188eu: perform minor code cleanup

2017-09-28 Thread Aishwarya Pant
Patch series performs minor coccicheck and checkpatch cleanups. Aishwarya Pant (3): staging: rtl8188eu: remove unneeded conversions to bool staging: rtl8188eu: remove implicit bool->int conversions staging: rtl8188eu: wrap lines in 80 characters drivers/staging/rtl8188eu/core/rtw_mlme_ext.

[RESEND PATCH 1/3] staging: rtl8188eu: remove unneeded conversions to bool

2017-09-28 Thread Aishwarya Pant
Patch suppresses the following warning issued by coccicheck: WARNING: conversion to bool not needed here Signed-off-by: Aishwarya Pant Acked-by: Julia Lawall --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/sta

[RESEND PATCH 3/3] staging: rtl8188eu: wrap lines in 80 characters

2017-09-28 Thread Aishwarya Pant
Perform cleanup for all function declarations in core/rtw_mlme_ext wherever checkpatch complains about lines being over 80 characters long. Signed-off-by: Aishwarya Pant --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 51 ++- 1 file changed, 34 insertions(+), 17 delet

[RESEND PATCH 2/3] staging: rtl8188eu: remove implicit bool->int conversions

2017-09-28 Thread Aishwarya Pant
Implicit type conversions are bad; they hinder readability of code and have potential to cause bugs. Here the variable wait_ack is always supplied a bool value while in function declarations it is defined as an int type. Fix it by defining wait_ack a bool type in all usages. Signed-off-by: Aishwar

Re: [PATCH] staging: fsl-mc/dpio: Fix incorrect comparison

2017-09-28 Thread Dan Carpenter
On Wed, Sep 27, 2017 at 12:57:28PM -0500, Ioana Radulescu wrote: > diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c > b/drivers/staging/fsl-mc/bus/dpio/dpio-service.c > index f809682..26922fc 100644 > --- a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c > +++ b/drivers/staging/fsl-mc/bu

[RESEND PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-09-28 Thread Mauro Carvalho Chehab
(Resending for Mauro, while dropping the non-list recipients. The original likely had too many recipients.) The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME match criteria requires just a device name. So, it does

Re: [PATCH] staging: fsl-mc/dpio: Fix incorrect comparison

2017-09-28 Thread Dan Carpenter
On Thu, Sep 28, 2017 at 03:48:36PM +0300, Dan Carpenter wrote: > On Wed, Sep 27, 2017 at 12:57:28PM -0500, Ioana Radulescu wrote: > > diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c > > b/drivers/staging/fsl-mc/bus/dpio/dpio-service.c > > index f809682..26922fc 100644 > > --- a/drivers

Re: [RESEND PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-09-28 Thread Sakari Ailus
Hi Mauro, On Wed, Sep 27, 2017 at 06:46:56PM -0300, Mauro Carvalho Chehab wrote: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME > match criteria requires just a device name. > > So, it doesn't make sense to

Re: [RESEND PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-09-28 Thread Sylwester Nawrocki
On 09/28/2017 02:53 PM, Mauro Carvalho Chehab wrote: > (Resending for Mauro, while dropping the non-list recipients. The original > likely had too many recipients.) > > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_D

RE: [PATCH] staging: fsl-mc/dpio: Fix incorrect comparison

2017-09-28 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Thursday, September 28, 2017 3:49 PM > To: Ruxandra Ioana Radulescu > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; > a...@arndb.de; stuyo...@gmail.com; Roy Pledge ; > linux-ker...@vger.kerne

Re: [PATCH] staging: fsl-mc/dpio: Fix incorrect comparison

2017-09-28 Thread gre...@linuxfoundation.org
On Thu, Sep 28, 2017 at 01:07:48PM +, Ruxandra Ioana Radulescu wrote: > > -Original Message- > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > > Sent: Thursday, September 28, 2017 3:49 PM > > To: Ruxandra Ioana Radulescu > > Cc: gre...@linuxfoundation.org; de...@driverdev.osu

Re: [RESEND PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-09-28 Thread Sakari Ailus
Hi Mauro, On Wed, Sep 27, 2017 at 06:46:56PM -0300, Mauro Carvalho Chehab wrote: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME > match criteria requires just a device name. > > So, it doesn't make sense to

Re: [PATCH 33/45] staging: unisys: visorbus: shrink name of POLLJIFFIES_CONTROLVMCHANNEL_XXX

2017-09-28 Thread Dan Carpenter
On Wed, Sep 27, 2017 at 01:14:38PM -0400, David Kershner wrote: > + if (chipset_dev->poll_jiffies != POLLJIFFIES_CONTROLVM_SLOW) > + chipset_dev->poll_jiffies = POLLJIFFIES_CONTROLVM_SLOW; > + } else { > + if (chipset_dev->poll_jiffies != POLLJIFFIES_

Re: [PATCH 44/45] staging: unisys: visorhba: clean up parenthesis

2017-09-28 Thread Dan Carpenter
On Wed, Sep 27, 2017 at 01:14:49PM -0400, David Kershner wrote: > Clean up unneeded parenthesis reported by checkpatch.pl. > > Signed-off-by: David Kershner > Reviewed-by: Tim Sell > --- > drivers/staging/unisys/visorhba/visorhba_main.c | 8 > 1 file changed, 4 insertions(+), 4 deletio

Re: [PATCH 38/45] staging: unisys: check the whole channel instead of just guid for match

2017-09-28 Thread Dan Carpenter
On Wed, Sep 27, 2017 at 01:14:43PM -0400, David Kershner wrote: > From: Sameer Wadgaonkar > > Validate that the channel contents match the channel type that we are > matching. > What are the user visible effects of this change? Does it have security implications? Does it prevent a crash? Is

RE: [PATCH] staging: fsl-mc/dpio: Fix incorrect comparison

2017-09-28 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Thursday, September 28, 2017 4:18 PM > To: Ruxandra Ioana Radulescu > Cc: Dan Carpenter ; > de...@driverdev.osuosl.org; a...@arndb.de; stuyo...@gmail.com; Roy > Pledge ; linux-ker...@vger.ke

Re: [PATCH 45/45] staging: unisys: visornic: clean up parenthesis

2017-09-28 Thread Dan Carpenter
On Wed, Sep 27, 2017 at 01:14:50PM -0400, David Kershner wrote: > Clean up unneeded parenthesis reported by checkpatch.pl. > > Signed-off-by: David Kershner > Reviewed-by: Tim Sell > --- > drivers/staging/unisys/visornic/visornic_main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions

[PATCH v2] staging: fsl-mc/dpio: Fix incorrect comparison

2017-09-28 Thread Ioana Radulescu
For some dpio functions, a cpu id parameter value of -1 is valid and means "any". But when trying to validate this param value against an upper limit, in this case num_possible_cpus(), we risk obtaining the wrong result due to an implicit cast. Avoid an incorrect check result by explicitly compari

[PATCH] staging: wlan-ng: resolve sparse Endianness issue.

2017-09-28 Thread Matthew Giassa
Explicitly converting from __le16 to CPU u16 to resolve sparse error in prism2sta.c. Original error: drivers/staging//wlan-ng/prism2sta.c:1450:29: warning: incorrect type in assignment (different base types) drivers/staging//wlan-ng/prism2sta.c:1450:29:expected unsigned short [unsigned] [usert

[0-Day CI notification] 0-Day kernel test service will be shut down from Sep 30 3PM to Oct 5

2017-09-28 Thread Philip Li
Hi all, this is Philip who maintains the 0-Day kernel test service. Thanks for subscribing to 0-Day kernel testing. We will have lab power down from Oct 1 to Oct 5, so that the service will be shut down from Asia Pacific Time Sep 30 3PM and will recover from Oct 6 as soon as we can. Sorry for any