Re: [PATCH 2/7] x86/hyper-v: fast hypercall implementation

2017-04-10 Thread Vitaly Kuznetsov
KY Srinivasan writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Friday, April 7, 2017 4:27 AM >> To: de...@linuxdriverproject.org; x...@kernel.org >> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; >> Haiyang Zhang ; Stephen Hemminger >> ; Tho

Re: [PATCH 4/7] x86/hyperv: implement rep hypercalls

2017-04-10 Thread Vitaly Kuznetsov
Jork Loeser writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Friday, April 7, 2017 04:27 >> To: de...@linuxdriverproject.org; x...@kernel.org >> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; >> Haiyang Zhang ; Stephen Hemminger >> ; Thomas

Re: [PATCH 2/7] x86/hyper-v: fast hypercall implementation

2017-04-10 Thread Vitaly Kuznetsov
Jork Loeser writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Friday, April 7, 2017 04:27 >> To: de...@linuxdriverproject.org; x...@kernel.org >> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; >> Haiyang Zhang ; Stephen Hemminger >> ; Thomas

Re: [PATCH v3] Staging: most: use __func__ instead of the function name

2017-04-10 Thread Christian Gromm
Sorry for the delay... On 04/10/2017 05:24 AM, chandrasekhar annamaneni wrote: Second reminder, please review. Thanks. Chandra On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni mailto:chandra...@gmail.com>> wrote: Change video.c to use %s, __func__ instead of function names. W

[PATCH] staging: rtl8723bs: remove null test before kfree

2017-04-10 Thread Aishwarya Pant
kfree(..) on a NULL pointer is a no-op; the null test here is redundant. Detected by coccicheck. Signed-off-by: Aishwarya Pant --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 6 ++ drivers/staging/rtl8723bs/hal/sdio_ops.c | 6 ++ drivers/staging/rtl8723bs/os_dep/ioctl_

Re: [PATCH 6/7] x86/hyper-v: use hypercall for remove TLB flush

2017-04-10 Thread Vitaly Kuznetsov
KY Srinivasan writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Friday, April 7, 2017 4:27 AM >> To: de...@linuxdriverproject.org; x...@kernel.org >> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; >> Haiyang Zhang ; Stephen Hemminger >> ; Tho

Re: [PATCH 2/7] x86/hyper-v: fast hypercall implementation

2017-04-10 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > Jork Loeser writes: > [snip] > >>> + } >>> +#else >>> + { >>> + u32 hv_status_hi, hv_status_lo; >>> + >>> + __asm__ __volatile__ ("call *%6" >>> + : "=d"(hv_status_hi), >>> + "=

Re: [PATCHv3 17/22] staging: android: ion: Collapse internal header files

2017-04-10 Thread Laura Abbott
On 04/08/2017 11:12 AM, Emil Velikov wrote: > Hi Laura, > > Couple of trivial nitpicks below. > > On 3 April 2017 at 19:57, Laura Abbott wrote: > >> --- a/drivers/staging/android/ion/ion.h >> +++ b/drivers/staging/android/ion/ion.h >> @@ -1,5 +1,5 @@ >> /* >> - * drivers/staging/android/ion/io

Re: [PATCH] Staging: comedidev.h comedi_lrange should be const struct

2017-04-10 Thread Arthur Brainville
On Sun, Apr 09, 2017 at 09:02:03PM +0200, Greg KH wrote: On Sun, Apr 09, 2017 at 04:28:12PM +0200, Arthur Brainville (Ybalrid) wrote: > According to checkpatch.pl, comedi_lrange should be declared as `const > struct` instead of `struct` in driver/staging/comedidev.h > > Signed-off-by: Arthur Brai

Re: [PATCH] staging: rtl8723bs: remove null test before kfree

2017-04-10 Thread Larry Finger
On 04/10/2017 08:43 AM, Aishwarya Pant wrote: kfree(..) on a NULL pointer is a no-op; the null test here is redundant. Detected by coccicheck. Signed-off-by: Aishwarya Pant Acked-by: Larry Finger Thanks, Larry --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 6 ++ drivers/st

Re: [PATCHv3 00/22] Ion clean up in preparation in moving out of staging

2017-04-10 Thread Laura Abbott
On 04/08/2017 03:38 AM, Greg Kroah-Hartman wrote: > On Mon, Apr 03, 2017 at 11:57:42AM -0700, Laura Abbott wrote: >> Hi, >> >> This is v3 of the series to do some serious Ion cleanup in preparation for >> moving out of staging. I didn't hear much on v2 so I'm going to assume >> people are okay with

Re: [PATCHv3 00/22] Ion clean up in preparation in moving out of staging

2017-04-10 Thread Greg Kroah-Hartman
On Mon, Apr 10, 2017 at 09:20:27AM -0700, Laura Abbott wrote: > On 04/08/2017 03:38 AM, Greg Kroah-Hartman wrote: > > On Mon, Apr 03, 2017 at 11:57:42AM -0700, Laura Abbott wrote: > >> Hi, > >> > >> This is v3 of the series to do some serious Ion cleanup in preparation for > >> moving out of stagin

RE: [PATCH 2/7] x86/hyper-v: fast hypercall implementation

2017-04-10 Thread Jork Loeser
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Vitaly Kuznetsov writes: > > > Jork Loeser writes: > > > > [snip] > > > > >>> + } > >>> +#else > >>> + { > >>> + u32 hv_status_hi, hv_status_lo; > >>> + > >>> + __asm__ __volatile__ ("call *%6

Re: [PATCHv3 00/22] Ion clean up in preparation in moving out of staging

2017-04-10 Thread Laura Abbott
On 04/10/2017 09:25 AM, Greg Kroah-Hartman wrote: > On Mon, Apr 10, 2017 at 09:20:27AM -0700, Laura Abbott wrote: >> On 04/08/2017 03:38 AM, Greg Kroah-Hartman wrote: >>> On Mon, Apr 03, 2017 at 11:57:42AM -0700, Laura Abbott wrote: Hi, This is v3 of the series to do some serious Ion

Re: [PATCH 6/7] x86/hyper-v: use hypercall for remove TLB flush

2017-04-10 Thread Vitaly Kuznetsov
Jork Loeser writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Friday, April 7, 2017 04:27 >> To: de...@linuxdriverproject.org; x...@kernel.org >> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; >> Haiyang Zhang ; Stephen Hemminger >> ; Thomas

RE: [PATCH 6/7] x86/hyper-v: use hypercall for remove TLB flush

2017-04-10 Thread Jork Loeser
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > > We may be supporting more than 64 CPUs in this hypercall. I am going > > to inquire with the Windows folks and get back to you. > > Thanks! It is even specified in the specification: > "Future versions of the h

Re: [staging:staging-next 751/807] drivers/staging/rtl8723bs/hal/Hal8723BPwrSeq.o:(.data+0x138): multiple definition of `rtl8723B_leave_lps_flow'

2017-04-10 Thread Hans de Goede
Hi, On 09-04-17 21:06, Greg Kroah-Hartman wrote: On Sun, Apr 09, 2017 at 11:40:15AM +0200, Hans de Goede wrote: Hi, On 09-04-17 11:37, Greg Kroah-Hartman wrote: On Sun, Apr 09, 2017 at 05:02:01PM +0800, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/s

Re: [PATCH] staging: wilc1000: use kernel define byte order macros

2017-04-10 Thread perry
Hi Dan, Can you clarify why the rx_buffer always holds little-endian data? It looks to me like this buffer is filled by wilc_sdio_cmd53(), which uses sdio_memcpy_toio(), which ultimately sets the data with sg_set_buf(). This function appears to use host-endian byte ordering. Regards, Perry On

Re: [staging:staging-next 751/807] drivers/staging/rtl8723bs/hal/Hal8723BPwrSeq.o:(.data+0x138): multiple definition of `rtl8723B_leave_lps_flow'

2017-04-10 Thread Greg Kroah-Hartman
On Mon, Apr 10, 2017 at 09:02:36PM +0200, Hans de Goede wrote: > Hi, > > On 09-04-17 21:06, Greg Kroah-Hartman wrote: > > On Sun, Apr 09, 2017 at 11:40:15AM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 09-04-17 11:37, Greg Kroah-Hartman wrote: > > > > On Sun, Apr 09, 2017 at 05:02:01PM +0

Re: [PATCH] Staging: comedidev.h comedi_lrange should be const struct

2017-04-10 Thread Greg KH
On Mon, Apr 10, 2017 at 05:25:49PM +0200, Arthur Brainville wrote: > On Sun, Apr 09, 2017 at 09:02:03PM +0200, Greg KH wrote: > > On Sun, Apr 09, 2017 at 04:28:12PM +0200, Arthur Brainville (Ybalrid) wrote: > > > According to checkpatch.pl, comedi_lrange should be declared as `const > > > struct` i

Re: [PATCH] Staging: comedidev.h comedi_lrange should be const struct

2017-04-10 Thread Arthur Brainville (Ybalrid)
On Mon, Apr 10, 2017 at 10:01:05PM +0200, Greg KH wrote: > On Mon, Apr 10, 2017 at 05:25:49PM +0200, Arthur Brainville wrote: > > On Sun, Apr 09, 2017 at 09:02:03PM +0200, Greg KH wrote: > > > On Sun, Apr 09, 2017 at 04:28:12PM +0200, Arthur Brainville (Ybalrid) > > > wrote: > > > > According to c

Re: [PATCH v2] staging: wilc1000: New cfg packet format in handle_set_wfi_drv_handler

2017-04-10 Thread Arend Van Spriel
On 10-4-2017 7:01, Aditya Shankar wrote: > Change the config packet format used in handle_set_wfi_drv_handler() > to align the host driver with the new format used in the wilc firmware. > > The change updates the format in which the host driver provides the > firmware with the drv_handler index an

RE: [PATCH 6/7] x86/hyper-v: use hypercall for remove TLB flush

2017-04-10 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Monday, April 10, 2017 7:44 AM > To: KY Srinivasan > Cc: de...@linuxdriverproject.org; x...@kernel.org; linux- > ker...@vger.kernel.org; Haiyang Zhang ; > Stephen Hemminger ; Thomas Gleixner > ; Ingo Molna

[PATCH v2] Fix endianness issues in mdc_request.c

2017-04-10 Thread skanda . kashyap
From: Skanda Guruanand Signed-off-by: Skanda Guruanand --- I have modified struct lu_dirpage in lustre_idl.h file to remove the sparse warnings where cast to restricted types are made. Following warnings were removed by this fix. drivers/staging/lustre/lustre/mdc/mdc_request.c:958:42: warning

Re: [PATCHv3 08/22] staging: android: ion: Remove crufty cache support

2017-04-10 Thread Archit Taneja
Hi, On 04/04/2017 12:27 AM, Laura Abbott wrote: Now that we call dma_map in the dma_buf API callbacks there is no need to use the existing cache APIs. Remove the sync ioctl and the existing bad dma_sync calls. Explicit caching can be handled with the dma_buf sync API. We could get rid of the I

Re: [PATCH v2] Fix endianness issues in mdc_request.c

2017-04-10 Thread Greg KH
On Mon, Apr 10, 2017 at 10:05:25PM -0700, skanda.kash...@gmail.com wrote: > From: Skanda Guruanand > > Signed-off-by: Skanda Guruanand I can't take patches with no changelog text at all, sorry. Please fix up and resend. greg k-h ___ devel mailing li

Re: [PATCHv3 07/22] staging: android: ion: Remove page faulting support

2017-04-10 Thread Archit Taneja
Hi, On 04/04/2017 12:27 AM, Laura Abbott wrote: The new method of syncing with dma_map means that the page faulting sync implementation is no longer applicable. Remove it. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 117 -- 1 file ch

Re: [PATCHv3 13/22] staging: android: ion: Use CMA APIs directly

2017-04-10 Thread Laurent Pinchart
Hi Laura, Thank you for the patch. On Monday 03 Apr 2017 11:57:55 Laura Abbott wrote: > When CMA was first introduced, its primary use was for DMA allocation > and the only way to get CMA memory was to call dma_alloc_coherent. This > put Ion in an awkward position since there was no device struct