Fix 'multiple blank lines' coding style problem reported by
checkpatch.pl.
Signed-off-by: Andrii Vladyka diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
index 255c30e..3fa6af2 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/
>
> This patch series adds the driver for the DPIO object which is a step
> to addressing the final item in the staging TODO list-- adding a
> functional driver on top of the bus driver. The DPIO driver is a
> dependency for other functional drivers such as Ethernet.
>
> An overview of the DPIO ob
Simple patch set. Clears 29 checkpatch errors/warnings.
Patch 01 does various fixes, all whitespace only changes.
Is this ok putting multiple checkpatch types in one patch if they are
all whitespace? Please advise, I would like to make review as easy as
possible.
Patch 02 adds parentheses to ar
Checkpatch emits ERROR: Macros with complex values should be enclosed
in parentheses. Error may be fixed by adding parentheses around macro
definition, macros are simple arithmetic statement.
Add parentheses around macro definitions. Fix 24 cases of identical
error. Do commented out macros also to
Checkpatch emits various warnings, errors and checks;
ERROR:TRAILING_WHITESPACE: trailing whitespace
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
ERROR:CODE_INDENT: code indent should use tabs where possible
CHECK:PARENTHESIS_AL
On Sun, Mar 12, 2017 at 09:26:41PM -0700, Steve Longerbeam wrote:
> On 03/12/2017 01:22 PM, Russell King - ARM Linux wrote:
> >What I had was this patch for your v3. I never got to testing your
> >v4 because of the LP-11 problem.
> >
> >In v5, you've changed to propagate the ipu_cpmem_set_image()
On Mon, Mar 13, 2017 at 08:16:25AM +, Russell King - ARM Linux wrote:
> On Sun, Mar 12, 2017 at 09:26:41PM -0700, Steve Longerbeam wrote:
> > On 03/12/2017 01:22 PM, Russell King - ARM Linux wrote:
> > >What I had was this patch for your v3. I never got to testing your
> > >v4 because of the L
Driver mixes spelling michael and michel in symbol names and
comments. Michael here references the IEEE 802.11i Message Integrity
Code. It is incorrect to spell it michel and confusing having two
spellings for the same thing.
Change michel -> micheal in both symbol names and comments.
Signed-off-
On 03/11/2017 07:20 PM, Steve Longerbeam wrote:
>
>
> On 03/11/2017 05:49 AM, Sakari Ailus wrote:
>> Hi Steve,
>>
>> On Thu, Mar 09, 2017 at 08:53:01PM -0800, Steve Longerbeam wrote:
>>> Add an empty UAPI Kbuild file for media UAPI headers.
>>>
>>> Signed-off-by: Steve Longerbeam
>>
>> The exist
Samuel Thibault writes:
> 9831013cbdbd3d06430a1db01d8c32d50c7d1c04 ('speakup: convert screen reading to
> 16bit characters') paved the way for handling unicode characters in speakup,
> but
> for the review mode, it missed actually getting unicode characters from the
> VC. This fixes by just tur
On 03/11/2017 07:14 PM, Steve Longerbeam wrote:
>
>
> On 03/11/2017 03:39 AM, Hans Verkuil wrote:
>> On 10/03/17 19:37, Steve Longerbeam wrote:
>>> Hi Hans,
>>>
>>> On 03/10/2017 04:03 AM, Hans Verkuil wrote:
On 10/03/17 05:52, Steve Longerbeam wrote:
> Add a new FRAME_INTERVAL_ERROR eve
Allows bpp to be set from dt
Signed-off-by: Radoslaw Pietrzyk
---
drivers/staging/fbtft/fbtft-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/staging/fbtft/fbtft-core.c
index 7c8af29..cb0c10d 100644
--- a/drivers/staging/fbtft/fbtft-core
On 03/12/2017 06:56 PM, Steve Longerbeam wrote:
>
>
> On 03/11/2017 11:37 PM, Russell King - ARM Linux wrote:
>> On Sat, Mar 11, 2017 at 07:31:18PM -0800, Steve Longerbeam wrote:
>>>
>>>
>>> On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote:
On Sat, Mar 11, 2017 at 10:54:55AM -0800, Ste
On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote:
> On 03/11/2017 07:14 PM, Steve Longerbeam wrote:
> > The event must be user visible, otherwise the user has no indication
> > the error, and can't correct it by stream restart.
>
> In that case the driver can detect this and call vb2_q
On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote:
> On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote:
>> On 03/11/2017 07:14 PM, Steve Longerbeam wrote:
>>> The event must be user visible, otherwise the user has no indication
>>> the error, and can't correct it by stream restart.
On Sun, Mar 12, 2017 at 02:34:14PM +0100, Benjamin Gaignard wrote:
2017-03-09 18:38 GMT+01:00 Laura Abbott :
On 03/09/2017 02:00 AM, Benjamin Gaignard wrote:
2017-03-06 17:04 GMT+01:00 Daniel Vetter :
On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown wrote:
On Mon, Mar 06, 2017 at 11:40:41
If the atomisp_kernel_zalloc() has "true" as a second parameter, it
tries to allocate zeroing memory from kmalloc(vmalloc) and memset.
But using kzalloc is rather than kmalloc followed by memset with 0.
(vzalloc is for same reason with kzalloc)
And also atomisp_kernel_malloc() can be used with
ato
On Mon, Mar 13, 2017 at 11:44:50AM +0100, Hans Verkuil wrote:
> On 03/12/2017 06:56 PM, Steve Longerbeam wrote:
> > In summary, I do like the media framework, it's a good abstraction of
> > hardware pipelines. It does require a lot of system level knowledge to
> > configure, but as I said that is a
On Mon, Mar 13, 2017 at 11:28:45AM +0100, Radoslaw Pietrzyk wrote:
> Allows bpp to be set from dt
>
Who does this affect in real life? You haven't tested it apparently so
it's hard to say why you are doing this.
regards,
dan carpenter
___
devel maili
I have and used with stm32 and fb_ili9341. First patch was shitty, my bad.
2017-03-13 12:00 GMT+01:00 Dan Carpenter :
> On Mon, Mar 13, 2017 at 11:28:45AM +0100, Radoslaw Pietrzyk wrote:
>> Allows bpp to be set from dt
>>
>
> Who does this affect in real life? You haven't tested it apparently so
On 03/13/2017 11:58 AM, Russell King - ARM Linux wrote:
> On Mon, Mar 13, 2017 at 11:44:50AM +0100, Hans Verkuil wrote:
>> On 03/12/2017 06:56 PM, Steve Longerbeam wrote:
>>> In summary, I do like the media framework, it's a good abstraction of
>>> hardware pipelines. It does require a lot of syste
On Mon, Mar 13, 2017 at 12:07:20PM +0100, Radosław Pietrzyk wrote:
> I have and used with stm32 and fb_ili9341. First patch was shitty, my bad.
>
Could you resend with a patch description which says why you are doing
this?
"With stm32 and fb_ili9341 the monitor just sits there blinking because
b
Ok I will. I just have thought that in general it might be helpful to
have this possibility as DT is parsed for this option anyway. If you
think it is not needed at all that why to bother parsing DT for this
option in the first place ?
2017-03-13 12:11 GMT+01:00 Dan Carpenter :
> On Mon, Mar 13, 2
On Mon, Mar 13, 2017 at 12:16:13PM +0100, Radosław Pietrzyk wrote:
> Ok I will. I just have thought that in general it might be helpful to
> have this possibility as DT is parsed for this option anyway. If you
> think it is not needed at all that why to bother parsing DT for this
> option in the fi
Understood
2017-03-13 12:19 GMT+01:00 Dan Carpenter :
> On Mon, Mar 13, 2017 at 12:16:13PM +0100, Radosław Pietrzyk wrote:
>> Ok I will. I just have thought that in general it might be helpful to
>> have this possibility as DT is parsed for this option anyway. If you
>> think it is not needed at a
Em Mon, 13 Mar 2017 10:58:42 +
Russell King - ARM Linux escreveu:
> On Mon, Mar 13, 2017 at 11:44:50AM +0100, Hans Verkuil wrote:
> > On 03/12/2017 06:56 PM, Steve Longerbeam wrote:
> > > In summary, I do like the media framework, it's a good abstraction of
> > > hardware pipelines. It does
On Mon, Mar 13, 2017 at 07:54:21PM +0900, Daeseok Youn wrote:
> If the atomisp_kernel_zalloc() has "true" as a second parameter, it
> tries to allocate zeroing memory from kmalloc(vmalloc) and memset.
> But using kzalloc is rather than kmalloc followed by memset with 0.
> (vzalloc is for same reaso
On 03/12/2017 02:32 PM, simran singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used to protect hardware
On Sun, Mar 12, 2017 at 02:37:22PM +0100, Greg KH wrote:
> On Sat, Mar 11, 2017 at 01:07:40PM +, Craig Inches wrote:
> > This patch resolves the "Comparisons should place the constant on
> > the right side of the test" found with checkpatch tool.
>
> Both are constants, I think checkpatch is t
On Mon, Mar 13, 2017 at 12:01 AM, Alison Schofield wrote:
> On Sun, Mar 12, 2017 at 06:40:52PM +0530, simran singhal wrote:
>> The IIO subsystem is redefining iio_dev->mlock to be used by
>> the IIO core only for protecting device operating mode changes.
>> ie. Changes between INDIO_DIRECT_MODE, I
On 03/12/2017 02:10 PM, simran singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used to protect hardware
On Mon, Mar 13, 2017 at 5:30 PM, Lars-Peter Clausen wrote:
> On 03/12/2017 02:32 PM, simran singhal wrote:
>> The IIO subsystem is redefining iio_dev->mlock to be used by
>> the IIO core only for protecting device operating mode changes.
>> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* mod
md_type is an enum. On my tests, GCC treats it as unsigned but
according to the C standard it's an implementation dependant thing so we
should check for negatives.
Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging
On Mon, Mar 13, 2017 at 08:42:15AM -0300, Mauro Carvalho Chehab wrote:
> I don't have myself any hardware with i.MX6. Yet, I believe that
> a low cost board like SolidRun Hummingboard - with comes with a
> CSI interface compatible with RPi camera modules - will likely
> attract users who need to r
On Sun, Mar 12, 2017 at 02:10:01AM +0530, simran singhal wrote:
> Replace strcpy with strlcpy as strcpy does not check for buffer
> overflow.
> This is found using Flawfinder.
>
> Signed-off-by: simran singhal
> ---
> drivers/staging/android/ashmem.c | 3 ++-
> 1 file changed, 2 insertions(+), 1
Hi Mauro,
On Sat, Mar 11, 2017 at 08:25:49AM -0300, Mauro Carvalho Chehab wrote:
> Em Sat, 11 Mar 2017 00:37:14 +0200
> Sakari Ailus escreveu:
>
> > Hi Mauro (and others),
> >
> > On Fri, Mar 10, 2017 at 12:53:42PM -0300, Mauro Carvalho Chehab wrote:
> > > Em Fri, 10 Mar 2017 15:20:48 +0100
> >
On Mon, Mar 13, 2017 at 6:11 PM, Dan Carpenter wrote:
> On Sun, Mar 12, 2017 at 02:10:01AM +0530, simran singhal wrote:
>> Replace strcpy with strlcpy as strcpy does not check for buffer
>> overflow.
>> This is found using Flawfinder.
>>
>> Signed-off-by: simran singhal
>> ---
>> drivers/staging
Run your patches through scripts/checkpatch.pl
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Mar 13, 2017 at 06:17:22PM +0530, SIMRAN SINGHAL wrote:
> On Mon, Mar 13, 2017 at 6:11 PM, Dan Carpenter
> wrote:
> > On Sun, Mar 12, 2017 at 02:10:01AM +0530, simran singhal wrote:
> >> Replace strcpy with strlcpy as strcpy does not check for buffer
> >> overflow.
> >> This is found usin
On Mon, Mar 13, 2017 at 03:11:10PM +0300, Dan Carpenter wrote:
> On Sun, Mar 12, 2017 at 02:37:22PM +0100, Greg KH wrote:
> > On Sat, Mar 11, 2017 at 01:07:40PM +, Craig Inches wrote:
> > > This patch resolves the "Comparisons should place the constant on
> > > the right side of the test" found
Hi,
I found that many "warning: cast to restricted __le16" in staging/wlan-ng
directory.
I don't know why but many structures has u16 type variable, not __le16.
And they are read by le16_to_cpu macro.
So I introduced a wrapper macro to read u16 type variable without Sparse
warning,
and convert
read_u16 is wrapper of le16_to_cpu to read u16 variable,
rather than __le16.
Signed-off-by: Gioh Kim
---
drivers/staging/wlan-ng/prism2mgmt.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/wlan-ng/prism2mgmt.h
b/drivers/staging/wlan-ng/prism2mgmt.h
index 88b979f..97ede25
Remove Sparse warnings "warning: cast to restricted __le16"
Signed-off-by: Gioh Kim
---
drivers/staging/wlan-ng/prism2sta.c | 128 ++--
1 file changed, 64 insertions(+), 64 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2sta.c
b/drivers/staging/wlan-ng/p
On Mon, Mar 13, 2017 at 6:27 PM, Dan Carpenter wrote:
> On Mon, Mar 13, 2017 at 06:17:22PM +0530, SIMRAN SINGHAL wrote:
>> On Mon, Mar 13, 2017 at 6:11 PM, Dan Carpenter
>> wrote:
>> > On Sun, Mar 12, 2017 at 02:10:01AM +0530, simran singhal wrote:
>> >> Replace strcpy with strlcpy as strcpy doe
Hi Philipp,
On Tue, Feb 21, 2017 at 09:50:23AM +0100, Philipp Zabel wrote:
...
> > > Then there's the issue where, if you have this setup:
> > >
> > > camera --> csi2 receiver --> csi --> capture
> > >
> > > and the "csi" subdev can skip frames, you need to know (a) at the CSI
> > > sink pad what
On Mon, Mar 13, 2017 at 10:54:33AM +, Brian Starkey wrote:
> On Sun, Mar 12, 2017 at 02:34:14PM +0100, Benjamin Gaignard wrote:
> > Another point is how can we put secure rules (like selinux policy) on
> > heaps since all the allocations
> > go to the same device (/dev/ion) ? For example, unti
Commenting out code is a bad idea.
As comments are for explaining what code is about.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
b/drivers/staging/rt
On Mon, Mar 13, 2017 at 03:16:48PM +0200, Sakari Ailus wrote:
> The vast majority of existing drivers do not implement them nor the user
> space expects having to set them. Making that mandatory would break existing
> user space.
>
> In addition, that does not belong to link validation either: lin
All devm functions has a device structure as the first argument which is
required by dev_{err,info,dbg} printing functions.
This patch converts pr_err to dev_err as dev_* is preferred after calls
to devm functions.
Done using coccinelle:
@r1 exists@
expression e,e1;
identifier f =~ "^devm_";
iden
On Mon, 2017-03-13 at 13:27 +, Russell King - ARM Linux wrote:
> On Mon, Mar 13, 2017 at 03:16:48PM +0200, Sakari Ailus wrote:
> > The vast majority of existing drivers do not implement them nor the user
> > space expects having to set them. Making that mandatory would break existing
> > user s
On 03/13/2017 01:33 PM, SIMRAN SINGHAL wrote:
> On Mon, Mar 13, 2017 at 5:30 PM, Lars-Peter Clausen wrote:
>> On 03/12/2017 02:32 PM, simran singhal wrote:
>>> The IIO subsystem is redefining iio_dev->mlock to be used by
>>> the IIO core only for protecting device operating mode changes.
>>> ie. C
2017-03-13 20:51 GMT+09:00 Dan Carpenter :
> On Mon, Mar 13, 2017 at 07:54:21PM +0900, Daeseok Youn wrote:
>> If the atomisp_kernel_zalloc() has "true" as a second parameter, it
>> tries to allocate zeroing memory from kmalloc(vmalloc) and memset.
>> But using kzalloc is rather than kmalloc followe
Dan Carpenter, on lun. 13 mars 2017 15:46:34 +0300, wrote:
> Run your patches through scripts/checkpatch.pl
D'oh. For such a small patch, I didn't bother doing it indeed. Anyway,
that's superseded by version 2 I have submitted (speakup: Support
spelling unicode characters)
Samuel
Hi,
I haven't received any feedback yet.
Should I resend?
Thanks,
Cathy
On 02/28/2017 01:45 PM, Cathy Avery wrote:
Included in the current storvsc driver for Hyper-V is the ability
to access luns on an FC fabric via a virtualized fiber channel
adapter exposed by the Hyper-V host. The driver
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a lock in the devices g
2017-03-13 23:07 GMT+09:00 DaeSeok Youn :
> 2017-03-13 20:51 GMT+09:00 Dan Carpenter :
>> On Mon, Mar 13, 2017 at 07:54:21PM +0900, Daeseok Youn wrote:
>>> If the atomisp_kernel_zalloc() has "true" as a second parameter, it
>>> tries to allocate zeroing memory from kmalloc(vmalloc) and memset.
>>>
Fix multiple code styling warnings issued by checkpatch on files
in sm750fb driver
Arushi Singhal (4):
staging: sm750fb: function prototype argument should have an
identifier name
staging: sm750fb: fixes add blank line after
function/struct/union/enum declarations
staging: sm750fb:
function prototype arguments like 'struct vb_device_info *','unsigned
long' etc. should have an identifier name.
Signed-off-by: Arushi Singhal
---
changes in v2
- add the identifier name of one more prototype arguments.
drivers/staging/sm750fb/ddk750_display.h | 2 +-
drivers/staging/sm750fb/
This patch fixes the warnings reported by checkpatch.pl
for please use a blank line after function/struct/union/enum
declarations.
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/sm750_cursor.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/sm750fb/sm750_cursor.
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_mode.c | 79 +--
1 file changed, 39 insertions(+), 40 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.c
b/driv
This patch removes typedefs from structures and renames them as per
kernel coding standards.
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_mode.c | 6 +++---
drivers/staging/sm750fb/ddk750_mode.h | 20 +---
drivers/staging/sm750fb/sm750_hw.c| 2 +-
3 file
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a lock in the devices g
On 03/13/2017 03:53 AM, Hans Verkuil wrote:
On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote:
On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote:
On 03/11/2017 07:14 PM, Steve Longerbeam wrote:
The event must be user visible, otherwise the user has no indication
the error, an
On 03/13/2017 06:06 PM, Steve Longerbeam wrote:
>
>
> On 03/13/2017 03:53 AM, Hans Verkuil wrote:
>> On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote:
>>> On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote:
On 03/11/2017 07:14 PM, Steve Longerbeam wrote:
> The event must
On Mon, 2017-03-13 at 15:34 +0300, Dan Carpenter wrote:
> md_type is an enum. On my tests, GCC treats it as unsigned but
> according to the C standard it's an implementation dependant thing so
> we
> should check for negatives.
Can do but the kernel assumes GNU C everywhere else.
Acked-by: Alan
On Mon, 2017-03-13 at 19:54 +0900, Daeseok Youn wrote:
> If the atomisp_kernel_zalloc() has "true" as a second parameter, it
> tries to allocate zeroing memory from kmalloc(vmalloc) and memset.
> But using kzalloc is rather than kmalloc followed by memset with 0.
> (vzalloc is for same reason with
From: Colin Ian King
There is no need to perform a null check on frame as there is an earlier
null check check and return hence making the null check redundant.
Remove it.
Detected by CoverityScan, CID#1416563 ("Logically Dead Code")
Signed-off-by: Colin Ian King
---
.../media/atomisp/pci/ato
On 03/13/2017 06:55 AM, Philipp Zabel wrote:
On Mon, 2017-03-13 at 13:27 +, Russell King - ARM Linux wrote:
On Mon, Mar 13, 2017 at 03:16:48PM +0200, Sakari Ailus wrote:
The vast majority of existing drivers do not implement them nor the user
space expects having to set them. Making that
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a lock in the devices g
From: Colin Ian King
I believe there is a missing break in the switch statement for
case V4L2_CID_FOCUS_STATUS as the current fall-through looks
suspect to me.
Detected by CoverityScan, CID#1416580 ("Missing break in switch")
Signed-off-by: Colin Ian King
---
drivers/staging/media/atomisp/i2c
New variables are added to make the code more readable.
Signed-off-by: Arushi Singhal
---
changes in v2
- removed the error.
drivers/staging/sm750fb/ddk750_mode.c | 103 --
1 file changed, 49 insertions(+), 54 deletions(-)
diff --git a/drivers/staging/sm750fb/
From: Stuart Yoder
add document describing the dpio driver and it's role, components
and major interfaces
Signed-off-by: Stuart Yoder
Signed-off-by: Roy Pledge
---
Notes:
-v4
-updated copyright
drivers/staging/fsl-mc/bus/dpio/dpio-driver.txt | 135
This patch series adds the driver for the DPIO object which is a step to
addressing the final item in the staging TODO list-- adding a functional driver
on top of the bus driver. The DPIO driver is a dependency for other functional
drivers such as Ethernet.
An overview of the DPIO object and d
From: Roy Pledge
Add global definitions for DPAA2 frame descriptors and scatter
gather entries.
Signed-off-by: Roy Pledge
Signed-off-by: Stuart Yoder
---
Notes:
-v6
-Fix incorrect size of FD_SHORT_LEN_MASK
-v4
-updated copyright
-adjust file lo
From: Roy Pledge
Create header for global dpaa2 definitions. Add definitions
for dequeue results.
Signed-off-by: Roy Pledge
Signed-off-by: Stuart Yoder
---
Notes:
-v4
-adjust file location to be in drivers/staging
-whitespace/alignment cleanup, make dpaa2_dq_is_
From: Ioana Radulescu
Add the command build/parse APIs for operating on DPIO objects through
the DPAA2 Management Complex.
Signed-off-by: Ioana Radulescu
Signed-off-by: Roy Pledge
Signed-off-by: Stuart Yoder
---
Notes:
-v6
- checkpatch: add additional () in DPIO_CMD
The DPIO driver registers with the fsl-mc bus to handle bus-related
events for DPIO objects. Key responsibility is mapping I/O
regions, setting up interrupt handlers, and calling the DPIO
service initialization during probe.
Signed-off-by: Roy Pledge
Signed-off-by: Haiying Wang
Signed-off-by: S
From: Roy Pledge
add Roy Pledge as maintainer of DPIO
Signed-off-by: Roy Pledge
Signed-off-by: Stuart Yoder
---
Notes:
Notes:
-v4
-adjust file location to be in drivers/staging
-v3
-no changes
-v2
-corrected location of maintainer e
From: Roy Pledge
The DPIO service interface handles initialization of DPIO objects
and exports APIs to be used by other DPAA2 object drivers to perform
queuing and buffer management related operations. The service allows
registration of callbacks when frames or notifications are received.
Signe
From: Roy Pledge
Add QBman APIs for frame queue and buffer pool operations.
Signed-off-by: Roy Pledge
Signed-off-by: Haiying Wang
Signed-off-by: Stuart Yoder
---
Notes:
-v6
-checkpatch: Add additional () in QBMAN_INDEX_FROM_DQRR
-checkpatch: Replace check for NU
On Mon, Mar 13, 2017 at 11:41:30PM +0530, simran singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used t
On Mon, Mar 13, 2017 at 10:01:07PM +0530, simran singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used t
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (2):
staging: speakup: identation should use tabs
staging: dvb-frontends: removed code in comments.
drivers/media/dvb-frontends/drxk_hard.c | 1 -
drivers/staging/speakup/speakup_dtlk.h | 10
Indentation should always use tabs and never spaces.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/speakup_dtlk.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/speakup/speakup_dtlk.h
b/drivers/staging/speakup/speakup_dtlk.h
index b3b3
Commenting out Code is a Bad Idea.
Comments are their to explain the code and how the code achieves its
goal and as codes in the comments does not explain what the code is
doing so there is no use of commenting them.
So in this patch codes in the comments are removed.
Signed-off-by: Arushi Singha
Improve readability by fixing multiple checkpatch.pl
issues in drivers.
Arushi Singhal (2):
staging: speakup: identation should use tabs
staging: dvb-frontends: removed code in comments.
drivers/media/dvb-frontends/drxk_hard.c | 1 -
drivers/staging/speakup/speakup_dtlk.h | 10 +--
Indentation should always use tabs and never spaces.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/speakup_dtlk.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/speakup/speakup_dtlk.h
b/drivers/staging/speakup/speakup_dtlk.h
index b3b3
Commenting out Code is a Bad Idea.
Comments are their to explain the code and how the code achieves its
goal and as codes in the comments does not explain what the code is
doing so there is no use of commenting them.
So in this patch codes in the comments are removed.
Signed-off-by: Arushi Singha
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (2):
staging: speakup: Added blank line after function/struct/union/enum
declarations
staging: speakup: fix "Alignment match open parenthesis"
drivers/staging/speakup/kobjects.c | 2 +-
dri
This patch fixes the warnings reported by checkpatch.pl
for please use a blank line after function/struct/union/enum
declarations.
Signed-off-by: Arushi Singhal
---
changes in v2
- change the subject to make it more relevant.
drivers/staging/speakup/main.c | 1 +
drivers/staging/speak
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/kobjects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/kobjects.c
b/drivers/staging/speakup/kobjects.c
index 8a58632
Fix multiple code styling warnings issued by checkpatch on files
in sm750fb driver
Arushi Singhal (4):
staging: sm750fb: function prototype argument should have an
identifier name
staging: sm750fb: fixes add blank line after
function/struct/union/enum declarations
staging: sm750fb:
function prototype arguments like 'struct vb_device_info *','unsigned
long' etc. should have an identifier name.
Signed-off-by: Arushi Singhal
---
changes in v3
- add the identifier name of one more prototype arguments.
drivers/staging/sm750fb/ddk750_display.h | 2 +-
drivers/staging/sm750fb/
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_mode.c | 79 +--
1 file changed, 39 insertions(+), 40 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.c
b/driv
This patch fixes the warnings reported by checkpatch.pl
for please use a blank line after function/struct/union/enum
declarations.
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/sm750_cursor.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/sm750fb/sm750_cursor.
This patch removes typedefs from structures and renames them as per
kernel coding standards.
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_mode.c | 6 +++---
drivers/staging/sm750fb/ddk750_mode.h | 20 +---
drivers/staging/sm750fb/sm750_hw.c| 2 +-
3 file
On 03/13/2017 06:56 AM, simran singhal wrote:
> All devm functions has a device structure as the first argument which is
> required by dev_{err,info,dbg} printing functions.
> This patch converts pr_err to dev_err as dev_* is preferred after calls
> to devm functions.
>
> Done using coccinelle:
>
Hi Russell,
On Mon, Mar 13, 2017 at 01:27:02PM +, Russell King - ARM Linux wrote:
> On Mon, Mar 13, 2017 at 03:16:48PM +0200, Sakari Ailus wrote:
> > The vast majority of existing drivers do not implement them nor the user
> > space expects having to set them. Making that mandatory would break
Hi Steve,
On Mon, Mar 13, 2017 at 11:06:22AM -0700, Steve Longerbeam wrote:
>
>
> On 03/13/2017 06:55 AM, Philipp Zabel wrote:
> >On Mon, 2017-03-13 at 13:27 +, Russell King - ARM Linux wrote:
> >>On Mon, Mar 13, 2017 at 03:16:48PM +0200, Sakari Ailus wrote:
> >>>The vast majority of existin
On 03/12/2017 12:05 PM, Daniel Vetter wrote:
> On Sun, Mar 12, 2017 at 2:34 PM, Benjamin Gaignard
> wrote:
>> 2017-03-09 18:38 GMT+01:00 Laura Abbott :
>>> On 03/09/2017 02:00 AM, Benjamin Gaignard wrote:
2017-03-06 17:04 GMT+01:00 Daniel Vetter :
> On Mon, Mar 06, 2017 at 11:58:05AM +010
1 - 100 of 183 matches
Mail list logo
