Re: [PATCH v2 1/5] staging: greybus: operation: add asynchronous gb_operation_cancel

2017-01-03 Thread Bryan O'Donoghue
On 02/01/17 16:16, Johan Hovold wrote: > On Tue, Dec 27, 2016 at 01:01:35PM +, Bryan O'Donoghue wrote: >> Later patches don't want or need to serialize the cancellation of an >> operation. This patch adds gb_operation_cancel_async() as a simple subset >> of the existing gb_operation_cancel() sa

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-03 Thread Paolo Bonzini
On 02/01/2017 20:39, Stephen Hemminger wrote: >>> >>> I would like to minimize what we include in the uapi header; especially >>> when MSFT has made no guarantees >>> with regards how they may be evolved. I will also work on getting some >>> clarity on both stability and >>> under what license

Re: [PATCH v2 2/2] staging: greybus: loopback_test: Fix race preventing test completion

2017-01-03 Thread Bryan O'Donoghue
On 02/01/17 17:27, Axel Haslam wrote: > Hi Bryan, > > On Mon, Jan 2, 2017 at 3:32 PM, Johan Hovold wrote: >> Adding Axel on CC. >> >> On Thu, Dec 22, 2016 at 12:37:29AM +, Bryan O'Donoghue wrote: >>> commit 9250c0ee2626 ("greybus: Loopback_test: use poll instead of >>> inotify") changes the f

Re: [PATCH v2 1/5] staging: greybus: operation: add asynchronous gb_operation_cancel

2017-01-03 Thread Johan Hovold
On Tue, Jan 03, 2017 at 09:23:29AM +, Bryan O'Donoghue wrote: > On 02/01/17 16:16, Johan Hovold wrote: > > On Tue, Dec 27, 2016 at 01:01:35PM +, Bryan O'Donoghue wrote: > >> Later patches don't want or need to serialize the cancellation of an > >> operation. This patch adds gb_operation_can

Re: [PATCH v2 2/2] staging: greybus: loopback_test: Fix race preventing test completion

2017-01-03 Thread Axel Haslam
On Tue, Jan 3, 2017 at 10:33 AM, Bryan O'Donoghue wrote: > On 02/01/17 17:27, Axel Haslam wrote: >> Hi Bryan, >> >> On Mon, Jan 2, 2017 at 3:32 PM, Johan Hovold wrote: >>> Adding Axel on CC. >>> >>> On Thu, Dec 22, 2016 at 12:37:29AM +, Bryan O'Donoghue wrote: commit 9250c0ee2626 ("greyb

Re: [PATCH 0/5] Staging: comedi: Proc FS related cleanup

2017-01-03 Thread Ian Abbott
On 30/12/16 11:24, Cheah Kok Cheong wrote: This series does trivial cleanup for COMEDI proc fs related stuff. Cheah Kok Cheong (5): Staging: comedi: comedi_fops: Avoid orphaned proc entry Staging: comedi: proc: Change file permission to read only Staging: comedi: proc: Add __init prefix

Re: [PATCH] Staging: comedi: comedi_compat32: fixed a syntax error

2017-01-03 Thread Ian Abbott
On 26/12/16 06:26, Jonathan Villatoro wrote: Fixed a syntax error in the function definition's parameter. It's not really a syntax error, just a coding style issue. Signed-off-by: Jonathan Horacio Villatoro Córdoba --- drivers/staging/comedi/comedi_compat32.h | 2 +- 1 file changed, 1 inse

Re: [PATCH v2 2/6] staging: fbtft: do not override DMA coherent mask

2017-01-03 Thread Andy Shevchenko
On Mon, 2017-01-02 at 19:14 +0100, Noralf Trønnes wrote: > Den 02.01.2017 12:35, skrev Andy Shevchenko: > > Usually it's not consumer's business to override resources passed > > from > > provider, in particularly DMA coherent mask. > > --- a/drivers/staging/fbtft/fbtft-core.c > > +++ b/drivers/sta

Re: [PATCH] Staging: comedi: comedidev.h: Drop old style zero-length array

2017-01-03 Thread Ian Abbott
On 21/12/16 19:13, Cheah Kok Cheong wrote: According to Documentation/Changes, the minimum gcc version required to compile the kernel is 3.2 (this is probably outdated too). Signed-off-by: Cheah Kok Cheong --- drivers/staging/comedi/comedidev.h | 8 +--- 1 file changed, 1 insertion(+), 7 d

Re: [PATCH v2 2/2] staging: greybus: loopback_test: Fix race preventing test completion

2017-01-03 Thread Bryan O'Donoghue
On 03/01/17 10:17, Axel Haslam wrote: > as i see it, a successful test means: > 1- each interfaces should send an event upon completion. yes > 2- the iteration count should equal iteration_max on each of the interfaces yes > what am i missing? count == max implies the kernel thread is still w

Re: [PATCH 4/4] hv_util: improve time adjustment accuracy by disabling interrupts

2017-01-03 Thread Vitaly Kuznetsov
Stephen Hemminger writes: > On Mon, 2 Jan 2017 20:41:14 +0100 > Vitaly Kuznetsov wrote: > >> If we happen to receive interrupts during hv_set_host_time() execution >> our adjustments may get inaccurate. Make the whole function atomic. >> Unfortunately, we can's call do_settimeofday64() with int

Re: [PATCH v2 2/2] staging: greybus: loopback_test: Fix race preventing test completion

2017-01-03 Thread Axel Haslam
On Tue, Jan 3, 2017 at 12:51 PM, Bryan O'Donoghue wrote: > On 03/01/17 10:17, Axel Haslam wrote: >> as i see it, a successful test means: >> 1- each interfaces should send an event upon completion. > yes > >> 2- the iteration count should equal iteration_max on each of the interfaces > > yes > >>

Re: [PATCH 3/4] hv_util: use do_adjtimex() to update system time

2017-01-03 Thread Vitaly Kuznetsov
"Alex Ng (LIS)" writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Monday, January 2, 2017 11:41 AM >> To: de...@linuxdriverproject.org >> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; >> Haiyang Zhang ; John Stultz >> ; Thomas Gleixner ; Ale

Re: [PATCH v2 2/6] staging: fbtft: do not override DMA coherent mask

2017-01-03 Thread Andy Shevchenko
On Tue, 2017-01-03 at 12:51 +0200, Andy Shevchenko wrote: > On Mon, 2017-01-02 at 19:14 +0100, Noralf Trønnes wrote: > > Den 02.01.2017 12:35, skrev Andy Shevchenko: > > > Usually it's not consumer's business to override resources passed > > > from > > > provider, in particularly DMA coherent mask.

Re: [PATCH] staging: lustre: selftest: Make brw_inject_one_error() static

2017-01-03 Thread Greg KH
On Fri, Dec 23, 2016 at 09:12:44PM +0530, Karthik Nayak wrote: > Since the function brw_inject_one_error() is used only within > brw_test.c, make it static. This was reported as a warning by sparse. > > Signed-off-by: Karthik Nayak > --- > drivers/staging/lustre/lnet/selftest/brw_test.c | 2 +- >

Re: [PATCH] staging: lustre: headers: potential UAPI headers

2017-01-03 Thread Greg Kroah-Hartman
On Mon, Dec 19, 2016 at 12:06:47PM -0500, James Simmons wrote: > Not for landing. This is the purposed UAPI headers > with the removal of unlikely and debugging macros. > This is just for feedback to see if this is acceptable > for the upstream client. > > Signed-off-by: James Simmons > --- > ..

Re: [PATCH] staging : lustre : Remove braces from single-line body.

2017-01-03 Thread Greg KH
On Wed, Dec 28, 2016 at 07:40:09PM +0530, Tabrez khan wrote: > Remove unnecessary braces from single-line if statement. > This warning is found using checkpatch.pl. > > Signed-off-by: Tabrez khan > --- > drivers/staging/lustre/lustre/ptlrpc/import.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH 11/12] staging: unisys: visorbus: visorchipset.c: Don't check for more than PAGE_SIZE length

2017-01-03 Thread Greg KH
On Thu, Dec 22, 2016 at 11:09:08AM -0500, David Kershner wrote: > From: David Binder > > Since a procfs or sysfs entry is allocated 1 page of memory (4096 bytes) > by default, there is no need to enforce this limit in the driver. This > patch corrects visorbus/visorchipset.c. What does procfs ha

Re: [PATCH 12/12] staging: unisys: visorbus: Don't check for more than PAGE_SIZE length in visorbus

2017-01-03 Thread Greg KH
On Thu, Dec 22, 2016 at 11:09:09AM -0500, David Kershner wrote: > From: David Binder > > Since a procfs or sysfs entry is allocated 1 page of memory (4096 bytes) > by default, there is no need to enforce this limit in the driver. This > patch corrects visorbus/visorbus_main.c. Again, why mention

Re: [PATCH] staging: comedi: cb_pcidas64: Fixed coding issue about multiple line dereferencing

2017-01-03 Thread Greg KH
On Mon, Dec 19, 2016 at 08:44:28PM +0530, devendra sharma wrote: > Fixed coding issue about multiple line dereferencing > > Signed-off-by: Devendra Sharma > --- > drivers/staging/comedi/drivers/cb_pcidas64.c | 13 + > 1 file changed, 5 insertions(+), 8 deletions(-) Always test-build

Re: [PATCH v2] drivers/staging/dgnc/dgnc_mgmt.c : add some goto statements for error handling

2017-01-03 Thread Greg KH
On Thu, Dec 22, 2016 at 05:25:24PM +0100, Francis Laniel wrote: > > I follow Dan Carpenter's advices and I update my patch. > I just add goto statements for error handling. > > > Good bye. That's a very strange changelog text, please look at how other kernel patches are written and redo this an

[PATCH 03/14] staging: greybus: arche-platform: Fix typo in the comments.

2017-01-03 Thread chatzi . emanuel
From: Emmanuil Chatzipetru This warning is caught by checkpatch.pl: - CHECK: 'begining' may be misspelled - perhaps 'beginning'? Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/arche-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[PATCH 02/14] staging: greybus: arche-apb-ctrl: Fix open parenthesis alignment.

2017-01-03 Thread chatzi . emanuel
From: Emmanuil Chatzipetru Fix coding style issue caught by checkpatch.pl related to the following warning: - CHECK: Alignment should match open parenthesis Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/arche-apb-ctrl.c | 43 1 file ch

[PATCH 01/14] staging: greybus: arche-apb-ctrl: Remove multiple blank lines.

2017-01-03 Thread chatzi . emanuel
From: Emmanuil Chatzipetru Fix coding style issue caught by checkpatch.pl related to the following warning: - CHECK: Please don't use multiple blank lines Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/arche-apb-ctrl.c | 1 - 1 file changed, 1 deletion(-) diff --git a

[PATCH 06/14] staging: greybus: bootrom: Fix line over 80 characters warning.

2017-01-03 Thread chatzi . emanuel
From: Emmanuil Chatzipetru Fix coding style issue caught by checkpatch.pl related to the following warning: - CHECK: WARNING: line over 80 characters Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/bootrom.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[PATCH 08/14] staging: greybus: camera: Fix NULL comparison to preferred style.

2017-01-03 Thread chatzi . emanuel
From: Emmanuil Chatzipetru Fix coding style issue caught by checkpatch.pl related to the following warning: - CHECK: Comparison to NULL could be written "!token" Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/camera.c | 16 1 file changed, 8 insertions

[PATCH 10/14] staging: greybus: connection: Remove multiple blank lines

2017-01-03 Thread chatzi . emanuel
From: Emmanuil Chatzipetru Fix coding style issue caught by checkpatch.pl related to the following warning: - CHECK: Please don't use multiple blank lines Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/connection.c | 4 1 file changed, 4 deletions(-) diff --git a

[PATCH 05/14] staging: greybus: bootrom: Fix open parenthesis alignment.

2017-01-03 Thread chatzi . emanuel
From: Emmanuil Chatzipetru Fix coding style issue caught by checkpatch.pl related to the following warning: - CHECK: Alignment should match open parenthesis Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/bootrom.c | 22 +++--- 1 file changed, 11 inserti

[PATCH 11/14] staging: greybus: control: Remove multiple blank lines

2017-01-03 Thread chatzi . emanuel
From: Emmanuil Chatzipetru Fix coding style issue caught by checkpatch.pl related to the following warning: - CHECK: Please don't use multiple blank lines Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/control.c | 1 - 1 file changed, 1 deletion(-) diff --git a/driver

[PATCH 13/14] staging: greybus: core: Fix open parenthesis alingment

2017-01-03 Thread chatzi . emanuel
From: Emmanuil Chatzipetru Fix coding style issue caught by checkpatch.pl related to the following warning: - CHECK: Alignment should match open parenthesis Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 04/14] staging: greybus: arche-platform: Fix open parenthesis alignment.

2017-01-03 Thread chatzi . emanuel
From: Emmanuil Chatzipetru Fix coding style issue caught by checkpatch.pl related to the following warning: - CHECK: Alignment should match open parenthesis Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/arche-platform.c | 16 1 file changed, 8 inserti

[PATCH 09/14] staging: greybus: connection: fix open parenthesis alignment

2017-01-03 Thread chatzi . emanuel
From: Emmanuil Chatzipetru Fix coding style issue caught by checkpatch.pl related to the following warning: - CHECK: Alignment should match open parenthesis Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/connection.c | 71 +- drivers/s

[PATCH 12/14] staging: greybus: control: fix open parenthesis alingment

2017-01-03 Thread chatzi . emanuel
From: Emmanuil Chatzipetru Fix coding style issue caught by checkpatch.pl related to the following warning: - CHECK: Alignment should match open parenthesis Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/control.c | 46 +++ 1 file ch

[PATCH 07/14] staging: greybus: camera: Fix open parenthesis alingment.

2017-01-03 Thread chatzi . emanuel
From: Emmanuil Chatzipetru Fix coding style issue caught by checkpatch.pl related to the following warning: - CHECK: Alignment should match open parenthesis Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/camera.c | 12 ++-- 1 file changed, 6 insertions(+), 6 de

[PATCH 14/14] staging: greybus: core: Fix NULL comparison to preferred style.

2017-01-03 Thread chatzi . emanuel
From: Emmanuil Chatzipetru Fix coding style issue caught by checkpatch.pl related to the following warning: - CHECK: Comparison to NULL could be written "!id" Signed-off-by: Emmanuil Chatzipetru --- drivers/staging/greybus/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [PATCH 01/14] staging: greybus: arche-apb-ctrl: Remove multiple blank lines.

2017-01-03 Thread Johan Hovold
On Tue, Jan 03, 2017 at 03:33:03PM +0100, chatzi.eman...@gmail.com wrote: > From: Emmanuil Chatzipetru > > Fix coding style issue caught by checkpatch.pl related to the following > warning: > - CHECK: Please don't use multiple blank lines > > Signed-off-by: Emmanuil Chatzipetru > --- > d

Re: [PATCH 02/14] staging: greybus: arche-apb-ctrl: Fix open parenthesis alignment.

2017-01-03 Thread Johan Hovold
On Tue, Jan 03, 2017 at 03:33:04PM +0100, chatzi.eman...@gmail.com wrote: > From: Emmanuil Chatzipetru > > Fix coding style issue caught by checkpatch.pl related to the following > warning: > - CHECK: Alignment should match open parenthesis This is not even a warning (hint: "CHECK") and no

Re: [PATCH 03/14] staging: greybus: arche-platform: Fix typo in the comments.

2017-01-03 Thread Johan Hovold
On Tue, Jan 03, 2017 at 03:33:05PM +0100, chatzi.eman...@gmail.com wrote: > From: Emmanuil Chatzipetru > > This warning is caught by checkpatch.pl: > - CHECK: 'begining' may be misspelled - perhaps 'beginning'? > > Signed-off-by: Emmanuil Chatzipetru Acked-by: Johan Hovold _

Re: [PATCH 06/14] staging: greybus: bootrom: Fix line over 80 characters warning.

2017-01-03 Thread Johan Hovold
On Tue, Jan 03, 2017 at 03:33:08PM +0100, chatzi.eman...@gmail.com wrote: > From: Emmanuil Chatzipetru > > Fix coding style issue caught by checkpatch.pl related to the following > warning: > - CHECK: WARNING: line over 80 characters > > Signed-off-by: Emmanuil Chatzipetru Acked-by: Jo

Re: [PATCH 08/14] staging: greybus: camera: Fix NULL comparison to preferred style.

2017-01-03 Thread Johan Hovold
On Tue, Jan 03, 2017 at 03:33:10PM +0100, chatzi.eman...@gmail.com wrote: > From: Emmanuil Chatzipetru > > Fix coding style issue caught by checkpatch.pl related to the following > warning: > - CHECK: Comparison to NULL could be written "!token" Again, not a warning, and something that is

Re: [PATCH 10/14] staging: greybus: connection: Remove multiple blank lines

2017-01-03 Thread Johan Hovold
On Tue, Jan 03, 2017 at 03:33:12PM +0100, chatzi.eman...@gmail.com wrote: > From: Emmanuil Chatzipetru > > Fix coding style issue caught by checkpatch.pl related to the following > warning: > - CHECK: Please don't use multiple blank lines Again not a warning, and perfectly valid. Please dr

Re: [PATCH 14/14] staging: greybus: core: Fix NULL comparison to preferred style.

2017-01-03 Thread Johan Hovold
On Tue, Jan 03, 2017 at 03:33:16PM +0100, chatzi.eman...@gmail.com wrote: > From: Emmanuil Chatzipetru > > Fix coding style issue caught by checkpatch.pl related to the following > warning: > - CHECK: Comparison to NULL could be written "!id" Current code is fine. Johan __

[PATCH] staging: most: change dma_buf variable to __le16

2017-01-03 Thread Ramiro Oliveira
dma_buf is being cast to __le16 *, but it was defined as u16 *. sparse reported this error as: drivers/staging/most/hdm-usb/hdm_usb.c:158:16: warning: cast to restricted __le16 This patch changes dma_buf from u16 to __le16. Signed-off-by: Ramiro Oliveira --- drivers/staging/most/hdm-usb/hdm_usb

[PATCH 1/3] staging: comedi: cb_pcidas64: use preferred kernel type u8

2017-01-03 Thread Saber Rezvani
Fix the checkpatch.pl issue: CHECK: Prefer kernel type 'u8' over 'uint8_t' Signed-off-by: Saber Rezvani Reviewed-by: Ian Abbott --- drivers/staging/comedi/drivers/cb_pcidas64.c | 46 ++-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/staging/com

[PATCH 3/3] staging: comedi: cb_pcidas64: use preferred kernel type u32

2017-01-03 Thread Saber Rezvani
Fix the checkpatch.pl issue: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Saber Rezvani Reviewed-by: Ian Abbott --- drivers/staging/comedi/drivers/cb_pcidas64.c | 38 ++-- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/staging/c

[PATCH 2/3] staging: comedi: cb_pcidas64: use preferred kernel type u16

2017-01-03 Thread Saber Rezvani
Fix the checkpatch.pl issue: CHECK: Prefer kernel type 'u16' over 'uint16_t' Signed-off-by: Saber Rezvani Reviewed-by: Ian Abbott --- drivers/staging/comedi/drivers/cb_pcidas64.c | 58 ++-- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/staging/c

[PATCH] staging: comedi: ni_670x: using the BIT(x) macro

2017-01-03 Thread Saber Rezvani
Fix the checkpatch.pl issue: CHECK: Prefer using the BIT macro replacing bit shifting on 1 with the BIT(x) macro. Signed-off-by: Saber Rezvani Reviewed-by: Ian Abbott --- drivers/staging/comedi/drivers/ni_670x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] staging: comedi: ni_at_ao: using the BIT(x) macro

2017-01-03 Thread Saber Rezvani
Fix the checkpatch.pl issue: CHECK: Prefer using the BIT macro replacing bit shifting on 1 with the BIT(x) macro. Signed-off-by: Saber Rezvani Reviewed-by: Ian Abbott --- drivers/staging/comedi/drivers/ni_at_ao.c | 62 +++ 1 file changed, 31 insertions(+), 31 deletio

Re: [PATCH] Staging: i4l: Correct coding style errors

2017-01-03 Thread Greg KH
On Thu, Dec 22, 2016 at 11:32:16PM +0100, Javier Rodriguez wrote: > Some lines with more than 80 characters has been corrected. > > Also, some printk() functions has been changed with their proper > print functions suggested by checkpatch.pl script as well as some > open braces has been aligned pr

Re: [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2017-01-03 Thread Greg Kroah-Hartman
On Wed, Mar 02, 2016 at 08:06:46PM +0100, Arnd Bergmann wrote: > The icn, act2000 and pcbit drivers are all for very old hardware, > and it is highly unlikely that anyone is actually still using them > on modern kernels, if at all. > > All three drivers apparently are for hardware that predates PC

Re: [PATCH] staging: i4l :fixed coding style

2017-01-03 Thread Greg KH
On Fri, Dec 09, 2016 at 11:06:26AM +0530, Tabrez khan wrote: > Remove braces {} for single if statement block. > > Signed-off-by: Tabrez khan > --- > drivers/staging/i4l/act2000/module.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) This patch doesn't apply cleanly, can you refresh

Re: [PATCH] drivers: staging: fbtft: fix checkpatch error and udelay

2017-01-03 Thread Greg KH
On Mon, Dec 19, 2016 at 07:44:42PM +0200, Ozgur Karatas wrote: > 19.12.2016, 08:35, "Greg KH" : > > On Sun, Dec 18, 2016 at 11:47:30AM -0600, Scott Matheina wrote: > >>  These changes where identified by checkpatch.pl as needed changes to > >>  align the code with the linux development coding style

Re: [PATCH v2 0/6] fbtft: make it work with DMA enabled SPI

2017-01-03 Thread Greg Kroah-Hartman
On Mon, Jan 02, 2017 at 01:37:43PM +0200, Andy Shevchenko wrote: > On Mon, 2017-01-02 at 13:35 +0200, Andy Shevchenko wrote: > > This series enables 64x48 OLED display and fixes the driver to work > > with DMA > > enabled SPI properly. > > > > Has been tested on Intel Edison board with Adafruit 2'

Re: [PATCH] staging: fwserial: fix checkpatch alignment check

2017-01-03 Thread Greg KH
On Sun, Jan 01, 2017 at 01:00:59AM +, Abdul Rauf wrote: > Fix the following checks: > Alignment should match open parenthesis. > > Signed-off-by: Abdul Rauf > --- > drivers/staging/fwserial/fwserial.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/stag

Re: [PATCH] staging: gdm724x: add forced casts in endian converters to fix sparse warnings

2017-01-03 Thread Greg KH
On Wed, Dec 28, 2016 at 10:08:43PM -0800, Eric S. Stone wrote: > The modified functions do explicit endian checking and conversion. The > added forced casts fix these sparse warnings: > > CHECK drivers/staging/gdm724x/gdm_endian.c > drivers/staging/gdm724x/gdm_endian.c:28:24: warning: incorrect

Re: [PATCH] Staging: ks7010: ks7010_sdio.h: Fixed coding style error

2017-01-03 Thread Greg KH
On Fri, Dec 09, 2016 at 07:38:36PM +, Manoj Sawai wrote: > Error - Complex macro not in parentheses and trailing whitespace That's two different things, please make two different patches. thanks, greg k-h ___ devel mailing list de...@linuxdriverpro

Re: [PATCH v2 0/6] fbtft: make it work with DMA enabled SPI

2017-01-03 Thread Andy Shevchenko
On Tue, 2017-01-03 at 16:27 +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 02, 2017 at 01:37:43PM +0200, Andy Shevchenko wrote: > > On Mon, 2017-01-02 at 13:35 +0200, Andy Shevchenko wrote: > > > This series enables 64x48 OLED display and fixes the driver to > > > work > > > with DMA > > > enabled

Re: [PATCH v2 0/2] staging: greybus: loopback fixes and updates

2017-01-03 Thread Greg KH
On Thu, Dec 22, 2016 at 12:37:27AM +, Bryan O'Donoghue wrote: > Two simple patches here resulting from using greybus on gbsim and > developing support for async. I found a bug in the user-space tool and > while doing that decided to update the kernel thread to be better behaved > when waiting f

Re: [PATCH v2 3/6] staging: fbtft: fallback to usual allocation when DMA fails

2017-01-03 Thread Andy Shevchenko
On Mon, 2017-01-02 at 13:35 +0200, Andy Shevchenko wrote: > Fall back to usual allocation method if DMA coherent allocation fails. > > SPI framework will map and use DMA mapped memory when possible. Locally I have re-done DMA approach and thus this patch became optional. Should I leave or remove

Re: [PATCH 2/3] staging: rtl8188eu: remove unused function _linked_rx_signal_strehgth_display

2017-01-03 Thread Greg Kroah-Hartman
On Fri, Dec 30, 2016 at 12:01:05AM +0100, Luca Ceresoli wrote: > Not referenced anymore since the removal of field bRxRSSIDisplay in > struct adapter. > > Cc: Greg Kroah-Hartman > Cc: Larry Finger > Cc: Ivan Safonov > Cc: de...@driverdev.osuosl.org > Signed-off-by: Luca Ceresoli > --- > drive

Re: [PATCH] staging: octeon: Call SET_NETDEV_DEV()

2017-01-03 Thread Greg KH
On Tue, Dec 27, 2016 at 02:15:57PM -0800, Florian Fainelli wrote: > On 12/20/2016 07:20 PM, David Miller wrote: > > From: Florian Fainelli > > Date: Tue, 20 Dec 2016 17:02:37 -0800 > > > >> On 12/14/2016 05:13 PM, Florian Fainelli wrote: > >>> The Octeon driver calls into PHYLIB which now checks

Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file

2017-01-03 Thread Greg KH
On Tue, Dec 06, 2016 at 06:10:38PM +, Stuart Yoder wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, December 06, 2016 11:56 AM > > To: Stuart Yoder > > Cc: Ruxandra Ioana Radulescu ; > > de...@driverdev.osuosl.org; linux- > >

Re: [PATCH] staging: fwserial: fix checkpatch alignment check

2017-01-03 Thread Abdul Rauf Mujahid
On 01/03/2017 03:28 PM, Greg KH wrote: > On Sun, Jan 01, 2017 at 01:00:59AM +, Abdul Rauf wrote: >> Fix the following checks: >> Alignment should match open parenthesis. >> >> Signed-off-by: Abdul Rauf >> --- >> drivers/staging/fwserial/fwserial.c | 5 +++-- >> 1 file changed, 3 insertions(

Re: [PATCH v2 2/6] staging: fbtft: do not override DMA coherent mask

2017-01-03 Thread Noralf Trønnes
Den 03.01.2017 14:58, skrev Andy Shevchenko: On Tue, 2017-01-03 at 12:51 +0200, Andy Shevchenko wrote: On Mon, 2017-01-02 at 19:14 +0100, Noralf Trønnes wrote: Den 02.01.2017 12:35, skrev Andy Shevchenko: Usually it's not consumer's business to override resources passed from provider, in part

Re: [PATCH v2 1/6] staging: fbtft: convert fbtft_reset() to be non-atomic

2017-01-03 Thread Noralf Trønnes
Den 02.01.2017 12:35, skrev Andy Shevchenko: First of all, fbtft in current state doesn't allow to override GPIOs to be optional, like "reset" one. It might be a bug somewhere, but rather out of scope of this fix. Second, not all GPIOs available on the board would be SoC based, some of them mig

Re: [PATCH v2 3/6] staging: fbtft: fallback to usual allocation when DMA fails

2017-01-03 Thread Noralf Trønnes
Den 03.01.2017 17:12, skrev Andy Shevchenko: On Mon, 2017-01-02 at 13:35 +0200, Andy Shevchenko wrote: Fall back to usual allocation method if DMA coherent allocation fails. SPI framework will map and use DMA mapped memory when possible. Locally I have re-done DMA approach and thus this patch

Re: [PATCH] staging: fwserial: fix checkpatch alignment check

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 10:16:00PM +, Abdul Rauf Mujahid wrote: > > > On 01/03/2017 03:28 PM, Greg KH wrote: > > On Sun, Jan 01, 2017 at 01:00:59AM +, Abdul Rauf wrote: > >> Fix the following checks: > >> Alignment should match open parenthesis. > >> > >> Signed-off-by: Abdul Rauf > >> -

Re: [PATCH v2 5/6] staging: fbtft: fb_ssd1306: Support smaller screen sizes

2017-01-03 Thread Noralf Trønnes
Den 02.01.2017 12:35, skrev Andy Shevchenko: There is 64x48 display exists. In order to support that set multiplexer to 48 pixels and window address to proper position in the graphic display data RAM. Signed-off-by: Andy Shevchenko --- Patches 5 and 6: Acked-by: Noralf Trønnes drivers/

Re: [PATCH 0/6] staging: vchiq_arm: Fine-tuning for some function implementations

2017-01-03 Thread Eric Anholt
SF Markus Elfring writes: > From: Markus Elfring > Date: Sat, 31 Dec 2016 22:42:34 +0100 > > Some update suggestions were taken into account > from static source code analysis. This series is: Reviewed-by: Eric Anholt signature.asc Description: PGP signature

[PATCH v3 2/5] staging: fbtft: remove custom DMA mapped buffer

2017-01-03 Thread Andy Shevchenko
There is no need to duplicate what SPI core already does, i.e. mapping buffers for DMA capable transfers. Remove all related pices of code. Note, that code, besides its redundancy, was buggy: DMA address potentially can be 0, SPI slave device has nothing to do with DMA capable device properties a

[PATCH v3 0/5] fbtft: make it work with DMA enabled SPI

2017-01-03 Thread Andy Shevchenko
This series enables 64x48 OLED display and fixes the driver to work with DMA enabled SPI properly. Has been tested on Intel Edison board with Adafruit 2'8" and SSD1306 64x48 (Sparkfun for Intel Edison) OLED displays at their maximum speed (25MHz and 10MHz). Since v2: - fix kbuild bot warning - re

[PATCH v3 4/5] staging: fbtft: fb_ssd1306: Support smaller screen sizes

2017-01-03 Thread Andy Shevchenko
There is 64x48 display exists. In order to support that set multiplexer to 48 pixels and window address to proper position in the graphic display data RAM. Acked-by: Noralf Trønnes Signed-off-by: Andy Shevchenko --- drivers/staging/fbtft/fb_ssd1306.c | 21 + 1 file changed,

Re: [PATCH 0/6] staging: vchiq_arm: Fine-tuning for some function implementations

2017-01-03 Thread Greg Kroah-Hartman
On Tue, Jan 03, 2017 at 09:46:51AM -0800, Eric Anholt wrote: > SF Markus Elfring writes: > > > From: Markus Elfring > > Date: Sat, 31 Dec 2016 22:42:34 +0100 > > > > Some update suggestions were taken into account > > from static source code analysis. > > This series is: > > Reviewed-by: Eric

[PATCH v3 5/5] staging: fbtft: fb_ssd1306: Refactor write_vmem()

2017-01-03 Thread Andy Shevchenko
Refactor write_vmem() for sake of readability. While here, fix indentation in one comment. Acked-by: Noralf Trønnes Signed-off-by: Andy Shevchenko --- drivers/staging/fbtft/fb_ssd1306.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/fbtft/f

[PATCH v3 1/5] staging: fbtft: convert fbtft_reset() to be non-atomic

2017-01-03 Thread Andy Shevchenko
First of all, fbtft in current state doesn't allow to override GPIOs to be optional, like "reset" one. It might be a bug somewhere, but rather out of scope of this fix. Second, not all GPIOs available on the board would be SoC based, some of them might sit on I2C GPIO expanders, for example, on In

[PATCH v3 3/5] staging: fbtft: propagate error code from kstrto*()

2017-01-03 Thread Andy Shevchenko
kstrto*() functions return proper error code. Do propogate it to the user. Signed-off-by: Andy Shevchenko --- drivers/staging/fbtft/fbtft-sysfs.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c

Re: [PATCH] staging: greybus: add host device function pointer checks

2017-01-03 Thread Jason Hrycay
On Mon, Jan 02, 2017 at 02:54:37PM +0100, Johan Hovold wrote: > On Tue, Dec 20, 2016 at 02:49:27PM -0600, Jason Hrycay wrote: > > Add sanity checks for cport_quiesce and cport_clear before invoking the > > callbacks as these function pointers are not required during the host > > device registration

RE: [PATCH 3/4] hv_util: use do_adjtimex() to update system time

2017-01-03 Thread Alex Ng (LIS)
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, January 3, 2017 4:32 AM > To: Alex Ng (LIS) > Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; KY > Srinivasan ; Haiyang Zhang ; > John Stultz ; Thomas Gleixner > Subject: Re: [PATCH

[PATCH net-next v2 08/27] net/hyperv: remove use of VLAN_TAG_PRESENT

2017-01-03 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc_drv.c | 13 ++--- drivers/net/hyperv/rndis_filter.c | 4 ++-- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyp

[PATCH net-next v2 26/27] net/hyperv: enable passing of VLAN.CFI bit

2017-01-03 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/net/hyperv/netvsc_drv.c | 1 + drivers/net/hyperv/rndis_filter.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 6597d7901929..4e20f4c247fa 100644 --- a/drivers/net/hyperv/ne

[PATCH v2 02/19] ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and their connections

2017-01-03 Thread Steve Longerbeam
From: Philipp Zabel This patch adds the device tree graph connecting the input multiplexers to the IPU CSIs and the MIPI-CSI2 gasket on i.MX6. The MIPI_IPU multiplexers are added as children of the iomuxc-gpr syscon device node. On i.MX6Q/D two two-input multiplexers in front of IPU1 CSI0 and IPU

[PATCH v2 00/19] i.MX Media Driver

2017-01-03 Thread Steve Longerbeam
In version 2 (no functional changes): - removed patch "gpio: pca953x: Add optional reset gpio control", it has been submitted separately. - fixed some whitespace errors. - added a few missing Signed-off-by's. Philipp Zabel (2): ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and t

[PATCH v2 03/19] ARM: dts: imx6qdl: add media device

2017-01-03 Thread Steve Longerbeam
Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6q.dtsi | 4 arch/arm/boot/dts/imx6qdl.dtsi | 8 2 files changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi index 56a314f..2fbe0b3 100644 --- a/arch/arm/boot/dts/imx6q.dtsi ++

[PATCH v2 01/19] ARM: dts: imx6qdl: Add compatible, clocks, irqs to MIPI CSI-2 node

2017-01-03 Thread Steve Longerbeam
Add to the MIPI CSI2 receiver node: compatible string, interrupt sources, clocks. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 53e6e63..7b546e3 1

[PATCH v2 05/19] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

2017-01-03 Thread Steve Longerbeam
Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. The OV5640 connects to the input port on the MIPI CSI-2 receiver on mipi_csi. It is set to transmit over MIPI virtual channel 1. Until the OV5652 sen

[PATCH v2 08/19] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture

2017-01-03 Thread Steve Longerbeam
Add pinctrl groups for both GPT input capture channels. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi index 516bac

[PATCH v2 09/19] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

2017-01-03 Thread Steve Longerbeam
Enables the ADV7180 decoder sensor. The ADV7180 connects to the parallel-bus mux input on ipu1_csi0_mux. On the sabreauto, two analog video inputs are routed to the ADV7180, composite on Ain1, and composite on Ain3. Those inputs are defined via inputs and input-names under the ADV7180 node. The AD

[PATCH v2 04/19] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

2017-01-03 Thread Steve Longerbeam
Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. Both hang off the same i2c2 bus, so they require different (and non- default) i2c slave addresses. The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. The OV5640 connects to the input port on the MIPI C

[PATCH v2 07/19] ARM: dts: imx6-sabreauto: add reset-gpios property for max7310_b

2017-01-03 Thread Steve Longerbeam
The reset pin to the port expander chip (MAX7310) is controlled by a gpio, so define a reset-gpios property to control it. There are three MAX7310's on the SabreAuto CPU card (max7310_[abc]), but all use the same pin for their reset. Since all can't acquire the same pin, assign it to max7310_b, tha

[PATCH v2 06/19] ARM: dts: imx6-sabreauto: create i2cmux for i2c3

2017-01-03 Thread Steve Longerbeam
The sabreauto uses a steering pin to select between the SDA signal on i2c3 bus, and a data-in pin for an SPI NOR chip. Use i2cmux to control this steering pin. Idle state of the i2cmux selects SPI NOR. This is not a classic way to use i2cmux, since one side of the mux selects something other than a

[PATCH v2 11/19] media: imx: Add CSI subdev driver

2017-01-03 Thread Steve Longerbeam
This is a media entity subdevice for the i.MX Camera Serial Interface module. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Kconfig | 13 + drivers/staging/media/imx/Makefile | 2 + drivers/staging/media/imx/imx-csi.c | 638 3 files chan

[PATCH v2 12/19] media: imx: Add SMFC subdev driver

2017-01-03 Thread Steve Longerbeam
This is a media entity subdevice driver for the i.MX Sensor Multi-FIFO Controller module. Video frames are received from the CSI and can be routed to various sinks including the i.MX Image Converter for scaling, color-space conversion, motion compensated deinterlacing, and image rotation. Signed-o

[PATCH v2 10/19] media: Add i.MX media core driver

2017-01-03 Thread Steve Longerbeam
Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam --- Documentation/devicetree/bindings/media/imx.txt | 205 + Documentation/media/v4l-drivers/imx.rst | 430 ++ drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile

[PATCH v2 14/19] media: imx: Add Camera Interface subdev driver

2017-01-03 Thread Steve Longerbeam
This is the camera interface driver that provides the v4l2 user interface. Frames can be received from various sources: - directly from SMFC for capturing unconverted images directly from camera sensors. - from the IC pre-process encode task. - from the IC pre-process viewfinder task. - from

[PATCH v2 15/19] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-01-03 Thread Steve Longerbeam
Adds MIPI CSI-2 Receiver subdev driver. This subdev is required for sensors with a MIPI CSI2 interface. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile| 1 + drivers/staging/media/imx/imx-mipi-csi2.c | 509 ++ 2 files changed, 510 inse

[PATCH v2 13/19] media: imx: Add IC subdev drivers

2017-01-03 Thread Steve Longerbeam
This is a set of three media entity subdevice drivers for the i.MX Image Converter. The i.MX IC module contains three independent "tasks": - Pre-processing Encode task: video frames are routed directly from the CSI and can be scaled, color-space converted, and rotated. Scaled output is limited

[PATCH v2 19/19] ARM: imx_v6_v7_defconfig: Enable staging video4linux drivers

2017-01-03 Thread Steve Longerbeam
Enable imx v4l2 staging drivers. For video capture on the SabreAuto, the ADV7180 video decoder also requires the i2c-mux-gpio and the max7310 port expander. The Sabrelite requires PWM clocks for the OV5640. Signed-off-by: Steve Longerbeam --- arch/arm/configs/imx_v6_v7_defconfig | 10 +-

[PATCH v2 16/19] media: imx: Add video switch subdev driver

2017-01-03 Thread Steve Longerbeam
From: Philipp Zabel This driver can handle SoC internal and extern video bus multiplexers, controlled either by register bit fields or by GPIO. Signed-off-by: Sascha Hauer Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile | 1 + d

[PATCH v2 17/19] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver

2017-01-03 Thread Steve Longerbeam
This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces and code cleanup. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Kconfig |8 + drivers/staging/media/imx/Makefile |2 + dri

[PATCH v2 1/2] staging: unisys: visorbus: visorchipset.c: Don't check for more than PAGE_SIZE length

2017-01-03 Thread David Kershner
From: David Binder Since a sysfs entry is allocated 1 page of memory (4096 bytes) by default, there is no need to enforce this limit in the driver. This patch corrects visorbus/visorchipset.c. Signed-off-by: David Binder Signed-off-by: David Kershner Reported-by: Greg Kroah-Hartman --- drive

  1   2   >