On Mon, Jan 02, 2017 at 02:54:37PM +0100, Johan Hovold wrote:
> On Tue, Dec 20, 2016 at 02:49:27PM -0600, Jason Hrycay wrote:
> > Add sanity checks for cport_quiesce and cport_clear before invoking the
> > callbacks as these function pointers are not required during the host
> > device registration. This follows the logic implemented elsewhere for
> > various other function pointers.
> 
> Yeah, I allowed for some inconsistency here given that these callbacks
> are mandatory on our current platform.
> 
> No harm in checking this way though (well, at least as long as we
> remember to set the pointers).
> 

OK, makes sense. We ran into it while integrating the Motorola
host-device stack into the latest version of greybus (we were
previously forked from a version a year ago - wow time flies).

> > Signed-off-by: Jason Hrycay <jhry...@gmail.com>
> 
> Acked-by: Johan Hovold <jo...@kernel.org>
> 
> Thanks,
> Johan

-Jason
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to