Staging: i4l: act200:
Signed-off-by: Naeil Zoueidi
---
drivers/staging/i4l/act2000/capi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/i4l/act2000/capi.c
b/drivers/staging/i4l/act2000/capi.c
index 62f5629..b494917 100644
--- a/drivers/staging/i4l/act2000
-the-capi-c-file-that-fixes-one-instance-of-the-following-error-ERROR-do-not-use-assignment-in-if-condition/20161106-165820
config: i386-randconfig-x077-201645 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
Staging: i4l: act2000:
Signed-off-by: Naeil ZOUEIDI
---
drivers/staging/i4l/act2000/capi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/i4l/act2000/capi.c
b/drivers/staging/i4l/act2000/capi.c
index b494917..62dee39 100644
--- a/drivers/staging/i4l/act2000/
On 03/11/16 12:56, Brian Masney wrote:
> There were several places where the driver would first call
> i2c_smbus_write_byte() to select the register on the device, and then
> call i2c_smbus_read_byte() to get the contents of that register. The
> code would look roughly like:
>
> /* Select register
On 03/11/16 12:56, Brian Masney wrote:
> There were several places where the driver would first call
> i2c_smbus_write_byte() to select the register on the device, and then
> call i2c_smbus_read_byte() to get the contents of that register. The
> code would look roughly like:
>
> /* Select register
On 03/11/16 12:56, Brian Masney wrote:
> taos_probe() queries the all of the sensor's registers and loads all of
> the values into a buffer stored on the stack. Only the chip ID register
> was actually used. Change the probe function to just query the chip ID
> register on the device.
>
> Verified
On 03/11/16 12:56, Brian Masney wrote:
> in taos_defaults()
>
> The comments in taos_defaults() appear after the line of code
> that they apply to. This patch moves the comments so that they appear
> before the code. Some of the comments were updated to be more
> informative.
>
> Signed-off-by: B
On 03/11/16 12:56, Brian Masney wrote:
> taos_chip_on() explicitly turns the sensor power on and then writes the
> 8 registers that are stored in taos_config. The first register in
> taos_config is the CONTROL register and the configuration is set to
> turn the power off. The existing state sequenc
On 03/11/16 12:56, Brian Masney wrote:
> in_illuminance_lux_table_store() shuts down the chip, updates the
> contents of the lux table, and then turns the chip back on. The values
> in lux table are not used by the chip and are only used internally by
> the driver. It is not necessary to change the
On 03/11/16 12:56, Brian Masney wrote:
> taos_als_calibrate() queries the control register to determine if the
> unit is powered on and has the ADC enabled. It then queries the same
> register a second time to determine if the ADC reading is valid. This
> patch removes the redundant i2c_smbus_read_
On 03/11/16 12:56, Brian Masney wrote:
> When updating the in_illuminance_calibscale and
> in_illuminance_integration_time sysfs attributes, these values were not
> actually written to the chip. The chip would continue to use the old
> parameters. Extracted out tsl2583_set_als_gain() and
> tsl2583_
On 03/11/16 12:56, Brian Masney wrote:
> in_illuminance_calibrate_store() did not check to see if the chip is
> suspended. This patch adds the proper check. The return value from
> taos_als_calibrate() was also not checked in this function, so the
> proper check was also added while changes are bei
On 03/11/16 12:56, Brian Masney wrote:
> taos_probe() calls i2c_smbus_write_byte() to select the control
> register, however there is no subsequent calls to i2c_smbus_read_byte().
> The write call is unnecessary and is removed by this patch.
>
> Verified that the driver still functions correctly u
The affected files have been modified to remove redundant spaces after
casts to solve checkpatch.pl checks.
Signed-off-by: Shiva Kerdel
---
drivers/staging/speakup/main.c | 42 ++---
drivers/staging/speakup/selection.c | 2 +-
drivers/staging/speakup/seriali
On Sun, Nov 06, 2016 at 12:03:53PM +, Jonathan Cameron wrote:
> On 03/11/16 12:56, Brian Masney wrote:
> > When updating the in_illuminance_calibscale and
> > in_illuminance_integration_time sysfs attributes, these values were not
> > actually written to the chip. The chip would continue to use
'lustre_cfg_new()' does not return NULL but ERR_PTR(-ENOMEM)
So IS_ERR should be used to check the return value.
Signed-off-by: Christophe JAILLET
---
drivers/staging/lustre/lustre/obdclass/obd_config.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustr
'lustre_cfg_new()' can return ERR_PTR(-ENOMEM).
Handle these errors and propagate the error code to the callers.
Error handling has been rearranged in 'lustre_process_log()' with the
addition of a label in order to free some resources.
Signed-off-by: Christophe JAILLET
---
drivers/staging/lustr
Hello!
On Nov 6, 2016, at 12:11 PM, Christophe JAILLET wrote:
> 'lustre_cfg_new()' can return ERR_PTR(-ENOMEM).
> Handle these errors and propagate the error code to the callers.
>
> Error handling has been rearranged in 'lustre_process_log()' with the
> addition of a label in order to free some
On 06/11/16 14:23, Brian Masney wrote:
> On Sun, Nov 06, 2016 at 12:03:53PM +, Jonathan Cameron wrote:
>> On 03/11/16 12:56, Brian Masney wrote:
>>> When updating the in_illuminance_calibscale and
>>> in_illuminance_integration_time sysfs attributes, these values were not
>>> actually written t
Some miscellaneous fixes and enhancements.
V2: Fixed a build issue reported by Greg. Only Patch # 13 is affected.
V3: Address Stephen's comment. Only patch 3 is affected.
Alex Ng (6):
Drivers: hv: utils: Fix the mapping between host version and protocol
to use
Drivers: hv: balloon: Disabl
From: K. Y. Srinivasan
Some miscellaneous fixes and enhancements.
V2: Fixed a build issue reported by Greg. Only Patch # 13 is affected.
V3: Address Stephen's comment. Only patch 3 is affected.
Alex Ng (6):
Drivers: hv: utils: Fix the mapping between host version and protocol
to use
Dri
From: K. Y. Srinivasan
One of the factors that can result in the host concluding that a given
guest in mounting a DOS attack is if the guest generates interrupts
to the host when the host is not expecting it. If these "spurious"
interrupts reach a certain rate, the host can throttle the guest to
From: Weibing Zhang
Remove unnecessary header files and netlink related code as the daemons
do not use netlink to communicate with the kernel now.
Signed-off-by: Weibing Zhang
Signed-off-by: K. Y. Srinivasan
---
tools/hv/hv_fcopy_daemon.c |7 ---
tools/hv/hv_kvp_daemon.c |7
From: Vitaly Kuznetsov
I discovered that at least WS2016TP5 host has 60 seconds timeout for the
ICMSGTYPE_NEGOTIATE message so we need to lower guest's timeout a little
bit to make sure we always respond in time. Let's make it 55 seconds.
Signed-off-by: Vitaly Kuznetsov
Signed-off-by: K. Y. Sri
From: Weibing Zhang
The link flag pthread is not needed.
Signed-off-by: Weibing Zhang
Signed-off-by: K. Y. Srinivasan
---
tools/hv/Makefile |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/tools/hv/Makefile b/tools/hv/Makefile
index a8c4644..0d1e61b 100644
--- a/tool
From: K. Y. Srinivasan
Signal the host when we determine the host is to be signaled.
The currrent code determines the need to signal in the ringbuffer
code and actually issues the signal elsewhere. This can result
in the host viewing this interrupt as spurious since the host may also
poll the cha
From: Vitaly Kuznetsov
With wrap around mappings in place we can always provide drivers with
direct links to packets on the ring buffer, even when they wrap around.
Do the required updates to get_next_pkt_raw()/put_pkt_raw()
The first version of this commit was reverted (65a532f3d50a) to deal wi
From: Alex Ng
We should intentionally declare the protocols to use for every known host
and default to using the latest protocol if the host is unknown or new.
Signed-off-by: Alex Ng
Signed-off-by: K. Y. Srinivasan
---
V3: Addressed Stephen's comment
drivers/hv/hv_util.c |9 +
From: K. Y. Srinivasan
Signal the host when we determine the host is to be signaled -
on th read path. The currrent code determines the need to signal in the
ringbuffer code and actually issues the signal elsewhere. This can result
in the host viewing this interrupt as spurious since the host may
From: Alex Ng
Increase the timeout of backup operations. When system is under I/O load,
it needs more time to freeze. These timeout values should also match the
host timeout values more closely.
Signed-off-by: Alex Ng
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hv_snapshot.c |8 ++-
From: Alex Ng
If the guest does not support memory hotplugging, it should respond to
the host with zero pages added and successful result code. This signals
to the host that hotplugging is not supported and the host will avoid
sending future hot-add requests.
Signed-off-by: Alex Ng
Signed-off-b
From: Weibing Zhang
hv_kvp_daemon.c: In function .kvp_mac_to_if_name.:
hv_kvp_daemon.c:705:2: warning: format not a string literal and no format
arguments [-Wformat-security]
snprintf(dev_id, sizeof(dev_id), kvp_net_dir);
^
hv_kvp_daemon.c:705:2: warning: format not a string literal and no f
From: Alex Ng
Added logging to help troubleshoot common ballooning, hot add,
and versioning issues.
Signed-off-by: Alex Ng
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hv_balloon.c | 31 ---
1 files changed, 28 insertions(+), 3 deletions(-)
diff --git a/driver
From: Alex Ng
Adding log messages to help troubleshoot error cases and transaction
handling.
Signed-off-by: Alex Ng
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hv_snapshot.c | 25 +++--
1 files changed, 19 insertions(+), 6 deletions(-)
diff --git a/drivers/hv/hv_snap
From: Alex Ng
Balloon driver was only printing the size of the info blob and not the
actual content. This fixes it so that the info blob (max page count as
configured in Hyper-V) is printed out.
Signed-off-by: Alex Ng
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hv_balloon.c |9 +++-
Fixed reports from checkpatch that pointed out that the code was not
using the preferred types of the kernel.
Signed-off-by: Shiva Kerdel
---
drivers/staging/fsl-mc/bus/dpmcp.h | 80 -
drivers/staging/fsl-mc/include/mc-bus.h | 4 +-
drivers/staging/fsl-mc/in
> From: Hongchao Zhang
>
> 1, in client_import_del_conn, the export returned from
>class_conn2export is not released after using it.
>
> 2, in ptlrpc_connect_interpret, the export is not released
>if the connect_flags isn't compatible.
Reviewed-by: James Simmons
> Signed-off-by: Hon
> From: Niu Yawei
>
> Otherwise, those leftovers would interfere with new timestamps
> especially when the timestamps are set back in time on the other
> clients.
Reviewed-by: James Simmons
> Signed-off-by: Jinshan Xiong
> Signed-off-by: Niu Yawei
> Reviewed-on: http://review.whamcloud.com
> blocking_refs is only used on the server, so drop it on the client.
Reviewed-by: James Simmons
> Signed-off-by: Oleg Drokin
> ---
> drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm
Dear,
I'm Dr. Andrea Thompson, I'm seeking for investment opportunities around the
globe and wonder if you can be of assistance.
Basically, all I need from you is sincerity, authenticity, integrity
protection, virtue, accountability and honor which brings trust in business. As
you already know
> From: Andriy Skulysh
>
> PW lock isn't replayed once a lock is marked
> LDLM_FL_CANCELING and glimpse lock doesn't wait for
> conflicting locks on the client. So the server will
> grant a PR lock in response to the glimpse lock request,
> which conflicts with the PW lock in LDLM_FL_CANCELING
>
> From: Jinshan Xiong
>
> cl_env hash table is under heavy contention when there are lots of
> processes doing IO at the same time;
> reduce lock contention by replacing cl_env cache with percpu array;
> remove cl_env_nested_get() and cl_env_nested_put();
> remove cl_env_reenter() and cl_env_ree
> The function becomes used again with the next patch, so bring it back
> from dead, only this time make it static.
Reviewed-by: James Simmons
> Reverts: bf2a033360f7 ("staging/lustre/ldlm: Remove unused
> ldlm_enqueue_pack()")
> Signed-off-by: Oleg Drokin
> ---
> drivers/staging/lustre/lus
> From: Andrew Perepechko
>
> This patch releases cl_pages on error in ll_write_begin()
> to avoid memory and object reference leaks. Also, it
> reuses per-cpu lu_env in ll_invalidatepage() in the same
> way as done in ll_releasepage().
Reviewed-by: James Simmons
> Signed-off-by: Andrew Pere
> From: Hongchao Zhang
>
> If there is no request passed into ldlm_cli_enqueue, the enqueue
> request will not engage ELC to drop unneeded locks. currently,
> this kind of request is mainly related to EXTENT locks enqueue
> requests (except for glimpse EXTENT lock for it has an intent).
Reviewe
> From: Bobi Jam
>
> Need to check file's lli_clob object before calling
> lov_read_and_clear_async_rc().
Reviewed-by: James Simmons
> Signed-off-by: Bobi Jam
> Reviewed-by: Jinshan Xiong
> Reviewed-by: Oleg Drokin
> Reviewed-on: http://review.whamcloud.com/23031
> Intel-bug-id: https://j
> This define only made sense in a userspace library client, not in the kernel.
Reviewed-by: James Simmons
> Signed-off-by: Oleg Drokin
> ---
> drivers/staging/lustre/lustre/include/lustre_lib.h | 2 --
> drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 15 +--
> 2 files cha
> From: Jinshan Xiong
>
> Otherwise, if the race between page fault and truncate occurs, it
> will cause the page fault routine to return an EIO error.
>
> In filemap_fault() {
> page_not_uptodate:
> ...
> ClearPageError(page);
> error = mapping->a_ops->readpage(file, pa
> From: Patrick Farrell
>
> -EAGAIN is a normal return when requesting POSIX flocks.
> We can't recognize exactly that case here, but it's the
> only case that should result in -EAGAIN on LDLM_ENQUEUE, so
> don't print to console in that case.
Reviewed-by: James Simmons
> Signed-off-by: Patr
> From: Bobi Jam
>
> When stride-RA hit case miss, we only reset normal sequential
> read-ahead window, but not reset the stride IO to avoid the overhead
> of re-detecting stride IO. While when the normal RA window is set
> to not insect with the stride-RA window, when we try to increase
> the s
On Wed, 2 Nov 2016, Oleg Drokin wrote:
> From: Amir Shehata
>
> cpu_pattern can specify exactly 1 cpu in a partition:
> "0[0]". That means CPT0 will have CPU 0. CPU 0 can have
> hyperthreading enabled. This combination would result in
>
> weight = cfs_cpu_ht_nsiblings(0);
> hrp->hrp_nthrs = cfs
> Removed redundant declaration of variable 'tx' in local scope
> Fixed: sparse warning:
> socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one
> socklnd_cb.c:2435:25: originally declared here
Reviewed-by: James Simmons
> Signed-off-by: Andrew Kanner
> ---
> drivers/staging/lust
> This patch fixes all CODE_INDENT checkpatch errors in o2iblnd.
Reviewed-by: James Simmons
> Signed-off-by: Nicholas Hanley
> ---
> .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 2 +-
> .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 22
> +++---
> 2 files chan
On Mon, 2016-11-07 at 02:02 +, James Simmons wrote:
> > This patch fixes all CODE_INDENT checkpatch errors in o2iblnd.
> Reviewed-by: James Simmons
[]
> > diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> > b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
[]
> > @@ -1637
> On Thu, Oct 27, 2016 at 06:11:56PM -0400, James Simmons wrote:
> > From: John L. Hammond
> >
> > Add a new regular file ioctl LL_IOC_FUTIMES_3 similar to futimes() but
> > which allows setting of all three inode timestamps. Use this ioctl
> > during HSM restore to ensure that the volatile file
> On Mon, 2016-11-07 at 02:02 +, James Simmons wrote:
> > > This patch fixes all CODE_INDENT checkpatch errors in o2iblnd.
> > Reviewed-by: James Simmons
> []
> > > diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> > > b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
>
> On Nov 6, 2016, at 12:11 PM, Christophe JAILLET wrote:
>
> > 'lustre_cfg_new()' can return ERR_PTR(-ENOMEM).
> > Handle these errors and propagate the error code to the callers.
> >
> > Error handling has been rearranged in 'lustre_process_log()' with the
> > addition of a label in order to fr
> On Thu, Nov 3, 2016 at 1:05 AM, Dilger, Andreas
> wrote:
> On Oct 25, 2016, at 10:47, Aya Mahfouz
> wrote:
> >
> > On Mon, Oct 17, 2016 at 10:38:31PM +, Dilger, Andreas wrote:
> >> On Oct 17, 2016, at 15:46, Aya Mahfouz
> wrote:
> >>>
> >>> class_de
On Nov 4, 2016, at 4:37 AM, Aya Mahfouz wrote:
>
> On Thu, Nov 3, 2016 at 1:05 AM, Dilger, Andreas
> wrote:
> On Oct 25, 2016, at 10:47, Aya Mahfouz wrote:
> >
> > On Mon, Oct 17, 2016 at 10:38:31PM +, Dilger, Andreas wrote:
> >> On Oct 17, 2016, at 15:46, Aya Mahfouz
> >> wrote:
> >>>
On Mon, Nov 07, 2016 at 03:55:36AM +, James Simmons wrote:
>
> > On Mon, 2016-11-07 at 02:02 +, James Simmons wrote:
> > > > This patch fixes all CODE_INDENT checkpatch errors in o2iblnd.
> > > Reviewed-by: James Simmons
> > []
> > > > diff --git a/drivers/staging/lustre/lnet/klnds/o2ibln
60 matches
Mail list logo
