[patch] staging: ion: use two separate locks for heaps and clients in ion_device

ion_alloc may get into slow path to get free page, the call stack: __alloc_pages_slowpath ion_page_pool_alloc_pages alloc_buffer_page ion_system_heap_allocate ion_buffer_create <-- hold ion_device->lock ion_alloc after that, kernel invokes low-memory killer to kill some apps in order to free mem

[bug report] greybus: sdio: extend sdio implementation

Hello Rui Miguel Silva, The patch 3b6ecd6de6b4: "greybus: sdio: extend sdio implementation" from Jun 22, 2015, leads to the following static checker warning: drivers/staging/greybus/sdio.c:481 gb_sdio_command() warn: bitwise AND condition is false here drivers/staging/greybus/sdi

Re: [bug report] greybus: sdio: extend sdio implementation

On Fri, Sep 30, 2016 at 3:25 PM, Dan Carpenter wrote: > Hello Rui Miguel Silva, > > The patch 3b6ecd6de6b4: "greybus: sdio: extend sdio implementation" > from Jun 22, 2015, leads to the following static checker warning: > > drivers/staging/greybus/sdio.c:481 gb_sdio_command() > war

[PATCH] Staging: comedi: Align the * in block comments

Align the * on each line of block comments as reported by checkpatch Signed-off-by: Ramiro Oliveira --- drivers/staging/comedi/drivers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c index 44511d7..a5bf2cc

Re: [bug report] greybus: sdio: extend sdio implementation

Hi Dan, On Fri, Sep 30, 2016 at 12:55:59PM +0300, Dan Carpenter wrote: Hello Rui Miguel Silva, The patch 3b6ecd6de6b4: "greybus: sdio: extend sdio implementation" from Jun 22, 2015, leads to the following static checker warning: drivers/staging/greybus/sdio.c:481 gb_sdio_command()

[PATCH] Staging: fsl-mc: Correct errors reported by checkpatch

This patch corrects some errors reported using checkpatch such as unaligned * in some block comments and multiple blank lines Signed-off-by: Ramiro Oliveira --- drivers/staging/fsl-mc/bus/dpbp.c | 60 ++--- drivers/staging/fsl-mc/bus/dpmng.c| 60 ++

[bug report] staging: rtl8188eu: fix missing unlock on error in rtw_resume_process()

Hello Wei Yongjun, The patch eaf47b713b60: "staging: rtl8188eu: fix missing unlock on error in rtw_resume_process()" from Aug 26, 2016, leads to the following static checker warning: drivers/staging/rtl8188eu/os_dep/usb_intf.c:311 rtw_resume_process() error: double unlock 'mutex:&

[bug report] vme: Adding Fake VME driver

Hello Martyn Welch, The patch 658bcdae9c67: "vme: Adding Fake VME driver" from Jul 7, 2016, leads to the following static checker warning: drivers/vme/bridges/vme_fake.c:338 fake_master_set() warn: 'spin_lock:&image->lock' is sometimes locked here and sometimes unlocked. drivers

Re: [PATCH 1/2 v2] pci-hyperv: properly handle pci bus remove

I have not been able to try out your second patch. So once that happens you can add my name. Cathy On 09/27/2016 07:54 PM, Long Li wrote: Thanks for pointing that out. If you don't mind, I will also add "Tested-by: Cathy Avery ". -Original Message- From: devel [mailto:driverdev-de

Re: [PATCH] Staging: fsl-mc: Correct errors reported by checkpatch

On Fri, Sep 30, 2016 at 12:13:02PM +0100, Ramiro Oliveira wrote: > This patch corrects some errors reported using checkpatch such as > unaligned * in some block comments and multiple blank lines Please only do one type of thing at a time, so break this up into multiple patches. thanks, greg k-h

Re: [PATCH 2/2] Revert "staging: wilc1000: Replace kthread with workqueue for host interface"

On Fri, Sep 30, 2016 at 03:43:18PM +0530, Aditya Shankar wrote: > This reverts commit 2518ac59eb27 ("staging: wilc1000: Replace kthread > with workqueue for host interface") > > This commit breaks wilc1000 driver init. A crash was seen > everytime the wlan interface was brought up and wilc device

[PATCH v2 0/2] Staging: fsl-mc: Correct errors reported by checkpatch

This set of patches corrects some errors reported by checkpatch in drivers/staging/fsl-mc v2: Split the patch in 2 parts, one for unaligned * in block comments, other for multiple blank lines. Ramiro Oliveira (2): Staging: fsl-mc: Fix unaligned * in block comments Staging: fsl-mc: Remove blan

[PATCH v2 1/2] Staging: fsl-mc: Fix unaligned * in block comments

Align the * in some block comments as reported by checkpatch. Signed-off-by: Ramiro Oliveira --- drivers/staging/fsl-mc/bus/dpbp.c | 60 ++--- drivers/staging/fsl-mc/bus/dpmng.c| 60 ++--- drivers/staging/fsl-mc/bus/dprc.c | 88

[PATCH v2 2/2] Staging: fsl-mc: Remove blank lines

Remove multiple blank lines as reported by checkpatch Signed-off-by: Ramiro Oliveira --- drivers/staging/fsl-mc/bus/dpmcp.c | 1 - drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/dpmcp.c b/drivers/staging/fsl-mc/bus/dp

[PATCH 8/8] staging:r8188eu: remove GEN_MLME_EXT_HANDLER macro

GEN_MLME_EXT_HANDLER is redundant macro. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_mlme_ext.h b/drivers/staging/rtl8188eu/i

[PATCH 2/8] staging:r8188eu: remove (RGTRY|BSSID)_(OFT|SZ) macros

These macros does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/drv_types.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/drv_types.h b/drivers/staging/rtl8188eu/include/drv_types.h index 5c275fb..c966c8e 100644 --- a/dr

[PATCH 5/8] staging:r8188eu: remove GEN_CMD_CODE macro

GEN_CMD_CODE is redundant macro. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 24 +-- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 14 +++--- drivers/staging/rtl8188eu/include/rtw_cmd.h | 62 +-- 3 files changed, 49 insertio

[PATCH 6/8] staging:r8188eu: remove GEN_EVT_CODE macro

GEN_EVT_CODE is redundant macro. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 10 ++--- drivers/staging/rtl8188eu/include/rtw_event.h| 2 - drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 52 3 files changed, 31 insertions(+)

[PATCH 7/8] staging:r8188eu: remove GEN_DRV_CMD_HANDLER macro

This macro does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_mlme_ext.h b/drivers/staging/rtl8188eu/include/rtw_mlme_ext.h index 80758e1..872a531 100644 --- a/d

[PATCH 1/8] staging:r8188eu: change rtl8188e_process_phy_info function argument type

prframe is (void *), but function used only with (struct recv_frame *). Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 5 ++--- drivers/staging/rtl8188eu/include/rtl8188e_recv.h | 3 ++- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/s

[PATCH 4/8] staging:r8188eu: remove pkt_newalloc member of the recv_buf structure

This member does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_recv.h | 1 - drivers/staging/rtl8188eu/os_dep/recv_linux.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw

[PATCH 3/8] staging:r8188eu: remove rtw_handle_dualmac declaration

It is a declaration of the non-existent function. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/drv_types.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/drv_types.h b/drivers/staging/rtl8188eu/include/drv_types.h index c966c8e..32326

[PATCH] staging: rtl8188eu: fix double unlock error in rtw_resume_process()

Fix following static checker warning: drivers/staging/rtl8188eu/os_dep/usb_intf.c:311 rtw_resume_process() error: double unlock 'mutex:&pwrpriv->mutex_lock' Fixes: eaf47b713b60 ("staging: rtl8188eu: fix missing unlock on error in rtw_resume_process()") Reported-By: Dan Carpenter Signed-of

[PATCH 1/3] staging: greybus: sdio: fix cmd_flags check for none response

When checking for command flags field if response is not available we really need to compare it with the right define and not bitwise AND it. smatch warn: drivers/staging/greybus/sdio.c:481 gb_sdio_command() warn: bitwise AND condition is false here Reported-by: Dan Carpenter Sig

[PATCH 0/3] staging: greybus: smatch warning fixes

Fix several warnings reported by the good tool smatch (another tool to add to the git pre-commit hook). They are related to the greybus sdio and light protocol drivers. Cheers, Rui Rui Miguel Silva (3): staging: greybus: sdio: fix cmd_flags check for none response staging: greybus: light:

[PATCH 2/3] staging: greybus: light: fix attributes allocation

Fix allocation of attributes with the correct size, this also fix smatch warning: drivers/staging/greybus/light.c:293 channel_attr_groups_set() warn: double check that we're allocating correct size: 8 vs 16 Signed-off-by: Rui Miguel Silva --- drivers/staging/greybus/light.c | 2 +- 1 file chang

[PATCH 3/3] staging: greybus: light: check delay_{on|off} before use

Even though we trust leds core that the pointers should be valid, we are safer to check delay_{on|off} before use. Also, this avoid a smatch warning: drivers/staging/greybus/light.c:484 gb_blink_set() warn: variable dereferenced before check 'delay_on' (see line 476) Signed-off-by: Rui Miguel Sil

[PATCH] staging: greybus: light: check the correct value of delay_on

When checking the value of delay_on to set the channel as active, it was checked the pointer and not the value, as it should be. Fixes: cc43368a3c ("greybus: lights: Control runtime pm suspend/resume on AP side") Signed-off-by: Rui Miguel Silva --- drivers/staging/greybus/light.c | 2 +- 1 fil

Re: [PATCH 2/3] staging: greybus: light: fix attributes allocation

On Fri, Sep 30, 2016 at 06:24:06PM +0100, Rui Miguel Silva wrote: > Fix allocation of attributes with the correct size, this also fix smatch > warning: > > drivers/staging/greybus/light.c:293 channel_attr_groups_set() > warn: double check that we're allocating correct size: 8 vs 16 > > Signed-off

Re: [PATCH 2/3] staging: greybus: light: fix attributes allocation

HiDan, On Fri, Sep 30, 2016 at 09:04:30PM +0300, Dan Carpenter wrote: On Fri, Sep 30, 2016 at 06:24:06PM +0100, Rui Miguel Silva wrote: Fix allocation of attributes with the correct size, this also fix smatch warning: drivers/staging/greybus/light.c:293 channel_attr_groups_set() warn: double ch

[PATCH v2 0/3] staging: greybus: smatch warning fixes

Fix several warnings reported by the good tool smatch (another tool to add to the git pre-commit hook). They are related to the greybus sdio and light protocol drivers. Cheers, Rui v1 -> v2: Dan Carpenter: . use sizeof channel::attrs pointer instead of struct attribute itself. Rui Miguel S

[PATCH v2 2/3] staging: greybus: light: fix attributes allocation

Fix allocation of attributes with the correct size, this also fix smatch warning: drivers/staging/greybus/light.c:293 channel_attr_groups_set() warn: double check that we're allocating correct size: 8 vs 16 Signed-off-by: Rui Miguel Silva --- drivers/staging/greybus/light.c | 3 +-- 1 file chan

[PATCH v2 3/3] staging: greybus: light: check delay_{on|off} before use

Even though we trust leds core that the pointers should be valid, we are safer to check delay_{on|off} before use. Also, this avoid a smatch warning: drivers/staging/greybus/light.c:484 gb_blink_set() warn: variable dereferenced before check 'delay_on' (see line 476) Signed-off-by: Rui Miguel Sil

[PATCH v2 1/3] staging: greybus: sdio: fix cmd_flags check for none response

When checking for command flags field if response is not available we really need to compare it with the right define and not bitwise AND it. smatch warn: drivers/staging/greybus/sdio.c:481 gb_sdio_command() warn: bitwise AND condition is false here Reported-by: Dan Carpenter Sig

RE: [PATCH] hv: do not lose pending heartbeat vmbus packets

> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Thursday, September 29, 2016 2:22 AM > To: KY Srinivasan ; Long Li > Cc: Haiyang Zhang ; > de...@linuxdriverproject.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH] hv: do not lose pending heartbea

Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 *

On 28/09/16 08:40, Dan Carpenter wrote: On Tue, Sep 27, 2016 at 02:52:49PM -0300, Martin Alonso wrote: Change the type and uses of rx_rate. Signed-off-by: Martin Alonso --- drivers/staging/vt6656/dpc.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/stagin

[PATCH] Staging: rts5208: Fix indentation warnings

Fix code indentation warnings detected by checkpatch.pl Signed-off-by: Wayne Porter --- drivers/staging/rts5208/ms.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c index 9fc64da..f27df0b

Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 *

On Fri, Sep 30, 2016 at 07:53:00PM +0100, Malcolm Priestley wrote: > On 28/09/16 08:40, Dan Carpenter wrote: > >On Tue, Sep 27, 2016 at 02:52:49PM -0300, Martin Alonso wrote: > >>Change the type and uses of rx_rate. > >> > >>Signed-off-by: Martin Alonso > >>--- > >> drivers/staging/vt6656/dpc.c |

[PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

Fixed coding style issue. Signed-off-by: Nadim Almas --- drivers/staging/dgnc/dgnc_neo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index e794056..bc15584 100644 --- a/drivers/staging/dgnc/dgnc_neo.c +++

[PATCH] ion_test: remove extra line per checkpatch.pl

Cleanup extra line found by checkpatch.pl Signed-off-by: Wayne Porter --- drivers/staging/android/uapi/ion_test.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/uapi/ion_test.h b/drivers/staging/android/uapi/ion_test.h index ffef06f..480242e 100644 --- a/drivers/stag

[PATCH] staging: android: ion: fix checks found by checkpatch.pl

Alignment fixes Signed-off-by: Wayne Porter --- drivers/staging/android/ion/hisilicon/hi6220_ion.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c index 659aa71..a

[PATCH] staging: android: ion: fix warning found by checkpatch.pl

Fix checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Wayne Porter --- drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.