[PATCH 02/12] staging: wilc1000: remove function pointer wlan_start

From: Glen Lee This patch removes function pointer wlan_start and just call the function wilc_wlan_start. Remove static from the function also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wlan.c| 3 +--

[PATCH 07/12] staging: wilc1000: remove function pointer wlan_cleanup

From: Glen Lee This patch removes function pointer wlan_cleanup and just call the function wilc_wlan_cleanup. Remove static from the function also. After changing function pointer wlan_cleanup with wilc_wlan_cleanup, the define wilc_wlan_deinit will be like folowing. -define wilc_wlan_deinit(nic

[PATCH 03/12] staging: wilc1000: remove function pointer wlan_stop

From: Glen Lee This patch removes function pointer wlan_stop and just call the function wilc_wlan_stop. Remove static from the function also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 10 ++ drivers/staging/wilc1000/wilc_wlan.c|

[PATCH 05/12] staging: wilc1000: remove function pointer wlan_handle_tx_que

From: Glen Lee This patch removes function pointer wlan_handle_tx_que and just call the function wilc_wlan_handle_txq. Remove static from the function also. There is one function call wlan_handle_tx_que which does not have an argument and return value. So put txq_count as argument and ret for ret

[PATCH 06/12] staging: wilc1000: remove function pointer wlan_handle_rx_isr

From: Glen Lee This patch removes function pointer wlan_handle_rx_isr and just call the function wilc_handle_isr. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 5 + drivers/staging/wilc1000/wilc_wlan.c| 1 - drivers/staging/wilc1000/wilc

[PATCH 04/12] staging: wilc1000: remove function pointer wlan_add_to_tx_que

From: Glen Lee This patch removes function pointer wlan_add_to_tx_que and just call the function wilc_wlan_txq_add_net_pkt. Remove static from the function also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 7 +++ drivers/staging/wilc1000/w

[PATCH 01/12] staging: wilc1000: remove function pointer wlan_firmware_download

From: Glen Lee This patch removes function pointer wlan_firmware_download and just call the function wilc_wlan_firmware_download. Remove static from the function also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 3 ++- drivers/staging/wilc1000

[PATCH 08/12] staging: wilc1000: delete define ACTION and PROBE_REQ

From: Glen Lee The define ACTION and PROBE_REQ are duplicate. They are aleady defined in host_interface.h. Just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/wil

[PATCH 12/12] staging: wilc1000: remove function pointer wlan_add_mgmt_to_tx_que

From: Glen Lee This patch removes function pointer wlan_add_mgmt_to_tx_que and just call the function wilc_wlan_txq_add_mgmt_pkt. Remove structure wilc_wlan_oup_t also because no members in it. Since wilc_wlan_oup_t is deleted, it's variable, function parameters and related codes are also deleted

[PATCH 11/12] staging: wilc1000: remove function pointer wlan_cfg_get_value

From: Glen Lee This patch removes function pointer wlan_cfg_get_value and just call the function wilc_wlan_cfg_get_val. Remove static from the function also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 5 +++-- drivers/staging/wilc1000/lin

[PATCH 10/12] staging: wilc1000: remove function pointer wlan_cfg_get

From: Glen Lee This patch removes function pointer wlan_cfg_get and just call the function wilc_wlan_cfg_get. Remove static from the function also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 13 - drivers/staging/wilc1000/linu

[PATCH 09/12] staging: wilc1000: remove function pointer wlan_cfg_set

From: Glen Lee This patch removes function pointer wlan_cfg_set and just call the function wilc_wlan_cfg_set. Remove static from the function also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 14 +++-- drivers/staging/wilc1000/linux_wlan.c

[PATCH 1/3] staging: sm750fb: remove unneeded switch statement

The lynxfb_ops_check_var function has two switch statements, the first one checks for validity of var->bits_per_pixel and it is is immediatly followed by another one that sets parameters according to var->bits_per_pixel value. These switch statements can be merged into one. Signed-off-by: Mike Rap

[PATCH 0/3] staging: sm750fb: minor cleanups

Hi, These patches remove several empty functions and their usage. Mike Rapoport (3): staging: sm750fb: remove unneeded switch statement staging: sm750fb: remove proc_checkMode method from lynxfb_output staging: sm750fb: remove clear method from lynxfb_{crtc,output} drivers/staging/sm750fb

[PATCH 2/3] staging: sm750fb: remove proc_checkMode method from lynxfb_output

The proc_checkMode of lynxfb_output is set to function that always returns 0. Calling that function and checking for its return value is meaningless. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c| 6 +- drivers/staging/sm750fb/sm750.h| 1 - drivers/staging/sm750fb/

[PATCH 3/3] staging: sm750fb: remove clear method from lynxfb_{crtc, output}

The clear methods of lynxfb_crtc and lynxfb_output are empty and therefore they can be removed. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c| 5 - drivers/staging/sm750fb/sm750.h| 2 -- drivers/staging/sm750fb/sm750_hw.c | 12 drivers/staging/sm750f

[PATCH] staging: fbtft: add typecast in call to vfree()

Member screen_base in struct fb_info is declared __iomem causing a sparse warning as below when passed to vfree(). This adds typecast (__force void *) to silence the warning. fbtft-core.c:922:39: warning: incorrect type in argument 1 \ (different address spaces) fbtft-core.c:922:39:expected vo

[PATCH 1/1] staging: rtl8712: re-use mac_pton()

...instead of custom approach Cc: Joshua Clayton Signed-off-by: Andy Shevchenko --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 28 +-- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8

[PATCH 01/12] staging: wilc1000: remove wilc_platform.h

This patch removes wilc_platform.h file that is not used anywhere. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_platform.h | 28 1 file changed, 28 deletions(-) delete mode 100644 drivers/staging/wilc1000/wilc_platform.h diff --git a/drivers/stagin

[PATCH 02/12] staging: wilc1000: remove commented codes

This patch removes commented codes that is not used in this driver. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_wlan.c | 3 --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - drivers/staging/wilc1000/wilc_wlan.c | 4 drivers/staging/wilc1000/wilc_wl

[PATCH 03/12] staging: wilc1000: remove if defined codes of USE_OLD_SPI_SW

This patch removes if defined codes of USE_OLD_SPI_SW. This macro is deleted because it is commented out. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_spi.c | 125 1 file changed, 125 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_s

[PATCH 09/12] staging: wilc1000: set_channel: remove blank line after open brace

This patch removes blank line after open brace '{' found by checkpatch.pl CHECK: Blank lines aren't necessary after an open brace '{' drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:664: Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1

[PATCH 05/12] staging: wilc1000: remove #if 1 and #endif

This patch removes #if 1 and #endif, which is encapsulated some codes. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfg

[PATCH 08/12] staging: wilc1000: use s8 instead of int8_t

This patch replaces int8_t with s8 that is a preferred type. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/w

[PATCH 04/12] staging: wilc1000: fix indentation level

This patch removes unnecessary block braces and fix indentation. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_wlan.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/w

[PATCH 10/12] staging: wilc1000: set_channel: fix data type of s32Error

This patch changes data type of s32Error variable from s32 to int because return type of this function is int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_c

[PATCH 06/12] staging: wilc1000: remove unnecessary comment

This patch removes unnecessary comment. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 -- drivers/staging/wilc1000/host_interface.h | 16 drivers/staging/wilc1000/wilc_wfi_netdevice.h | 23 ++- drivers/staging/wilc

[PATCH 07/12] staging: wilc1000: use ARRAY_SIZE macro

This patch uses ARRAY_SIZE macro found by checkpatch.pl WARNING: Prefer ARRAY_SIZE(wb) drivers/staging/wilc1000/wilc_spi.c:400 drivers/staging/wilc1000/wilc_spi.c:402 Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

[PATCH 12/12] staging: wilc1000: rename u8CurrChannel

This patch replaces u8CurrChannel with curr_channel to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/driver

[PATCH 11/12] staging: wilc1000: set_channel: rename s32Error

This patch replaces s32Error with result to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000

Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile()

On Thu, Oct 01, 2015 at 09:11:31AM +0530, Ronit Halder wrote: > The existing dgap_parsefile() rejects invalid config file. > But before we know that config file is invalid a lot of memory leak > can happen. Removing the chances of memory leak won't heart anyone. > Why not just reject it earlier i

Re: [PATCH] mtd: nand: pass page number to ecc->write_xxx() methods

Hi Brian, On Mon, 24 Aug 2015 19:10:19 +0200 Boris Brezillon wrote: > The ->read_xxx() methods are all passed the page number the NAND controller > is supposed to read, but ->write_xxx() do not have such a parameter. > > This is a problem if we want to properly implement data > scrambling/rando

Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile()

> Why not just reject it earlier instead of allocating more data? I agree on your point. But we have to make different mechanism for that and my patch is only to fix the current code. regards ___ devel mailing list de...@linuxdriverproject.org http://dri

Re: [PATCH] staging: fbtft: add typecast in call to vfree()

On Thu, Oct 01, 2015 at 03:00:12PM +0200, Lars Svensson wrote: > Member screen_base in struct fb_info is declared __iomem causing > a sparse warning as below when passed to vfree(). This adds typecast > (__force void *) to silence the warning. > > fbtft-core.c:922:39: warning: incorrect type in ar

Re: [PATCH 08/12] staging: wilc1000: use s8 instead of int8_t

On Thu, Oct 01, 2015 at 10:43:55PM +0900, Chaehyun Lim wrote: > This patch replaces int8_t with s8 that is a preferred type. > It would be better to just use int. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driver

[PATCH 0/4] staging: unisys: visornic cleanup series

This patch series cleans up redundant variables and structures in visornic, and fixes a mistake in handling the return value from queue_delayed_work(). Benjamin Romer (1): staging: unisys: correctly handle return value from queue_delayed_work() David Kershner (3): staging: unisys: remove

[PATCH 1/4] staging: unisys: remove devdata->name use netdev->name

From: David Kershner The net device already has a name, so use that instead. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visornic/visornic_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b

[PATCH 2/4] staging: unisys: get rid of devnum pool and dev num

From: David Kershner devnum pool and devnum are no longer needed. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visornic/visornic_main.c | 26 - 1 file changed, 26 deletions(-) diff --git a/drivers/staging/unisys/visornic/visor

[PATCH 3/4] staging: unisys: get rid of list of devices

From: David Kershner We don't need the list of devices, we can loop through the one provided by the network api and filter on ours. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visornic/visornic_main.c | 13 - 1 file changed, 13 deletions(

[PATCH 4/4] staging: unisys: correctly handle return value from queue_delayed_work()

Properly handle the return value from queue_delayed_work() - it's a bool, not an int, so using a less than comparison isn't appropriate. This mistake was found by David Binderman . Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/periodic_work.c | 8 1 file changed, 4

[PATCH 02/13] staging: unisys: visorhid: remove unnecessary include of serio.h

From: Tim Sell No need for serio.h to be included. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorhid/visorhid.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/unisys/visorhid/visorhid.c b/drivers/staging/unisys/visorhid/visorhid.c i

[PATCH 04/13] staging: unisys: visorinput: subsume .h files directly into visorinput.c

From: Tim Sell keyboardchannel.h and mousechannel.h are now included within visorinput.c directly. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- .../staging/unisys/visorinput/keyboardchannel.h| 32 - drivers/staging/unisys/visorinput/mousechannel.h | 33 -

[PATCH 01/13] staging: unisys: visorhid: correctly map keys with extended scancodes

From: Tim Sell The most-noticed key that wasn't being mapped correctly was Right-Alt, which is the AltGr key on many non-US keyboards, used to select many extended characters. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorhid/visorhid.c | 10 +++---

[PATCH 05/13] staging: unisys: visorinput: re-order declarations for consistency

From: Tim Sell In order to be more consistent with kernel conventions used elsewhere, I have re-ordered declarations in visorinput.c to follow this general order (where possible): * #defines * struct/enum/union declarations * static declarations (const if possible for all of them) * forward funct

[PATCH 10/13] staging: unisys: visorinput: change input bus type to BUS_VIRTUAL (6)

From: Tim Sell BUS_HOST wasn't really appropriate, so I changed to BUS_VIRTUAL, which is what virtio uses. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorinput/visorinput.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s

[PATCH 07/13] staging: unisys: visorinput: make structs & arrays const where possible

From: Tim Sell This also gave me a warning with the assignment: visorinput_dev->keycode = visorkbd_keycode; because input_dev->keycode is NOT static but visorkbd_keycode now is, so I went ahead and also added logic to stash away non-static copies of visorkbd_keycode[] and visorkbd_ext_keyco

[PATCH 00/13] visorhid fixes series

This patch series contains a series of changes requested by Benjamin Tissoires from Red Hat, after he reviewed the module for us. Most importantly, the module is renamed from visorhid to visorinput, since it is not a HID driver. Tim Sell (13): staging: unisys: visorhid: correctly map keys with

[PATCH 12/13] staging: unisys: visorinput: remove extraneous mouse logic

From: Tim Sell Removes a cursor positioning hack that no longer seems to be required. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorinput/visorinput.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/unisys/visorinput/vis

[PATCH 08/13] staging: unisys: visorinput: correct code comments per kernel conventions

From: Tim Sell Multi-line comments were modified to conform to kernel conventions: /* * multi-line * comments */ doc-test /** */ for some comments was removed. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorinput/visorinput.c | 47 ++

[PATCH 06/13] staging: unisys: visorinput: add INPUT to dependent driver list

From: Tim Sell Add the renamed driver to the Kconfig. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorinput/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorinput/Kconfig b/drivers/staging/unisys/vis

[PATCH 09/13] staging: unisys: visorinput: comment tweaks - s/gizmo/input node/g

From: Tim Sell Just a simple search and replace in the comments. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorinput/visorinput.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/unisys/visorinput/visorinput.c b

[PATCH 03/13] staging: unisys: visorhid: rename to visorinput

From: Tim Sell This visorhid driver provides a Human Interface Device, but is not at all using HID, the protocol. It's a plain input driver, so for clarity, it is being renamed to visorinput. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/Documentation/overv

[PATCH 11/13] staging: unisys: visorinput: register & use input_dev open() and close()

From: Tim Sell Registration of visorinput_open() and visorinput_close() for each device allow us to eliminate unnecessary activity when nobody in user-land cares. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorinput/visorinput.c | 55

[PATCH 13/13] staging: unisys: visorinput: remove extraneous do_key function

From: Tim Sell do_key() is no longer needed. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorinput/visorinput.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/unisys/visorinput/visorinput.c b/drive

Re: [PATCH] mtd: nand: pass page number to ecc->write_xxx() methods

On Thu, Oct 01, 2015 at 05:07:43PM +0200, Boris Brezillon wrote: > On Mon, 24 Aug 2015 19:10:19 +0200 > Boris Brezillon wrote: > > > The ->read_xxx() methods are all passed the page number the NAND controller > > is supposed to read, but ->write_xxx() do not have such a parameter. > > > > This i

Re: [PATCH] mtd: nand: pass page number to ecc->write_xxx() methods

On Mon, Aug 24, 2015 at 07:10:19PM +0200, Boris Brezillon wrote: > The ->read_xxx() methods are all passed the page number the NAND controller > is supposed to read, but ->write_xxx() do not have such a parameter. > > This is a problem if we want to properly implement data > scrambling/randomizati

Re: [PATCH] staging: rtl8192e: rtl_wx: fix negative noise value

On 30.09.2015 14:12, Luis de Bethencourt wrote: > wstats->qual.noise is of type uint8, so it shouldn't be assigned a > negative number. Assigning it 0x100 - 100, which is the equivalent > to -100 dBm when IW_QUAL_DBM is set. > > Signed-off-by: Luis de Bethencourt > --- > drivers/staging/rtl8192e

[PATCH 01/17] staging: comedi: quatech_daqp_cs: there are 4 digital outputs

This board has 4 digital outputs not 1. Fix the subdevice init. The digital output lines are used for the external channel selection when the expansion mode is enabled. Add a comment about this. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/

[PATCH 00/17] staging: comedi: quatech_daqp_cs: cleanup driver

Following is the cleanup series for the comedi quatech_daqp_cs PCMCIA driver. H Hartley Sweeten (17): staging: comedi: quatech_daqp_cs: there are 4 digital outputs staging: comedi: quatech_daqp_cs: there are 4 digital inputs staging: comedi: quatech_daqp_cs: fix ai cmd timing staging: come

[PATCH 02/17] staging: comedi: quatech_daqp_cs: there are 4 digital inputs

This board has 4 digital inputs not 1. Fix the subdevice init. The digital input lines are shared with other functions. Add a comment about this. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 13 - 1 f

[PATCH 03/17] staging: comedi: quatech_daqp_cs: fix ai cmd timing

According to the users manual, the conversion timing (scanrate) is fixed to 100, 50, or 25 kHz. The pacer clock is then used to trigger each scan. Currently this driver tries to fake other conversion speeds by always sampling the inputs at 100 kHz and using the pacer clock to trigger each conversi

[PATCH 07/17] staging: comedi: quatech_daqp_cs: remove 'interrupt_mode'

The interrupt handler is now only used for the ai async command. Remove the unnecessary 'interrupt_mode' from the private data and tidy up the interrupt handler. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 70 +++

[PATCH 05/17] staging: comedi: quatech_daqp_cs: don't use interrupts for ai (*insn_read)

The comedi (*insn_read) functions are supposed to do simple one-shot reading of an analog input channel. Currently this driver enables interrupts and uses wait_for_completion_interruptible() to allow the interrupt routine to let the analog input (*insn_read) know that the end-of-conversion has occu

[PATCH 04/17] staging: comedi: quatech_daqp_cs: tidy up daqp_ai_set_one_scanlist_entry()

Clarify the scan list programming a bit by refactoring this function to program the entire scan list instead of just a single entry. Move the necessary reset of the scan list into this function. Rename the function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- dri

[PATCH 06/17] staging: comedi: quatech_daqp_cs: fix daqp_ai_cancel()

Make sure interrupts are disabled and the event flags are cleared when the analog input async command is canceled. Remove the unnecessary calls to stop any running conversions in the (*insn_read) and (*do_cmd) functions. The comedi core will only call these functions if the subdevice is not busy (

[PATCH 08/17] staging: comedi: quatech_daqp_cs: introduce daqp_ai_get_sample()

Introduce a helper function to get a two's complement sample from the FIFO and munge it to the offset binary format that comedi uses. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 23 --- 1 file

[PATCH 10/17] staging: comedi: quatech_daqp_cs: use comedi_timeout() in ao (*insn_write)

The data link between the D/A data port and the D/A converter is a serial link. The serial link requires about 8ms to complete a transfer. Use the comedi_timeout() helper to ensure that there is not a previous transfer still happening before trying to write new data to the channel. For aesthetics,

[PATCH 09/17] staging: comedi: quatech_daqp_cs: use comedi_offset_munge() in ao (*insn_write)

Use the comedi_offset_munge() helper to do the offset binary to two's complement conversion when writing a new analog output value. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 8 +++- 1 file changed, 3 insert

[PATCH 12/17] staging: comedi: quatech_daqp_cs: redefine pacer clock options

For aesthetics, define a macro for the pacer clock options and rename the CamelCase. Remove the unnecessary local variable in daqp_ai_cmd() used to set the control register. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_

[PATCH 11/17] staging: comedi: quatech_daqp_cs: spaces preferred around that '<<'

Fix the checkpatch.pl issues about: CHECK: spaces preferred around that '<<' (ctx:VxV) Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/s

[PATCH 13/17] staging: comedi: quatech_daqp_cs: introduce daqp_clear_events()

Introduce a helper function for the common code used to clear any pending interrupts. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 52 1 file changed, 25 insertions(+), 27 deletions(-) di

[PATCH 14/17] staging: comedi: quatech_daqp_cs: only hook up cmd support if we have an IRQ

Interrupts are only needed by this driver to support the analog input async commands. Don't hook up the command support if pcmcia_request_irq() fails instead of completely failing the (*auto_attach). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/com

[PATCH 17/17] staging: comedi: quatech_daqp_cs: tidy up register map defines

Reorder the register map defines so that each register define is followed by its bit defines. For aesthetics, change all the register offsets to hex values and use the BIT macro to define the register bits. Also for aesthetics, move the DAQP_FIFO_SIZE and private data definition after the registe

[PATCH 15/17] staging: comedi: quatech_daqp_cs: tidy up multi-line comments

Reformat the multi-line comments in the kernel CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 83 +++- 1 file changed, 37 insertions(+), 46 deletions(-) diff --git a/drivers/staging

[PATCH 16/17] staging: comedi: quatech_daqp_cs: handle shared interrupt

This is a PCMCIA driver and interrupts are always shared. Detect if the hardware did not produce the interrupt and return IRQ_NONE so that other drivers might handle it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c

[PATCH v2] mtd: nand: pass page number to ecc->write_xxx() methods

The ->read_xxx() methods are all passed the page number the NAND controller is supposed to read, but ->write_xxx() do not have such a parameter. This is a problem if we want to properly implement data scrambling/randomization in order to mitigate MLC sensibility to repeated pattern: to prevent bit

[PATCH] staging: comedi: 8255: prefer using the BIT macro

Fix the checkpatch.pl issues. Signed-off-by: H Hartley Sweeten --- drivers/staging/comedi/drivers/8255.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/8255.h b/drivers/staging/comedi/drivers/8255.h index 41823de..55a67af 100644 -

Re: [PATCH] mtd: nand: pass page number to ecc->write_xxx() methods

On Thu, 1 Oct 2015 10:17:50 -0700 Brian Norris wrote: > On Mon, Aug 24, 2015 at 07:10:19PM +0200, Boris Brezillon wrote: > > The ->read_xxx() methods are all passed the page number the NAND controller > > is supposed to read, but ->write_xxx() do not have such a parameter. > > > > This is a prob

Re: [PATCH v2] mtd: nand: pass page number to ecc->write_xxx() methods

Hi Boris, [auto build test results on next-20151001 -- if it's inappropriate base, please ignore] config: i386-randconfig-s1-201539 (attached as .config) reproduce: git checkout 425b29816a0dba028eef09be5cb531a187e256a1 # save the attached .config to linux build tree

Re: [PATCH 08/17] staging: comedi: quatech_daqp_cs: introduce daqp_ai_get_sample()

Hi Hartley, [auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore] reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/staging/comedi/drivers/

[RFC PATCH] staging: comedi: quatech_daqp_cs: daqp_ai_get_sample() can be static

Signed-off-by: Fengguang Wu --- quatech_daqp_cs.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c index 23c79e3..96471fc 100644 --- a/drivers/staging/comedi/drivers/qua

[PATCH 0/3] staging: comedi: pcm3724: cleanup driver

Some minor cleanup to the comedi pcm3724 PC/104 legacy driver. H Hartley Sweeten (3): staging: comedi: pcm3724: tidy up multi-line comments staging: comedi: pcm3724: tidy up register map defines staging: comedi: pcm3724: update the MODULE_DESCRIPTION drivers/staging/comedi/drivers/pcm3724.

[PATCH 1/3] staging: comedi: pcm3724: tidy up multi-line comments

Reformat the multi-line comments in the kernel CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcm3724.c | 44 ++-- 1 file changed, 19 insertions(+), 25 deletions(-) diff --git a/drivers/staging

[PATCH 3/3] staging: comedi: pcm3724: update the MODULE_DESCRIPTION

Change the MODULE_DESCRIPTION to something more usefull than the generic "Comedi low-level driver". Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcm3724.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/st

[PATCH 2/3] staging: comedi: pcm3724: tidy up register map defines

For aesthetics, rename the register map defines so they have namespace associated with the driver and use the BIT macro to define the bits. Add the missing defines for the registers and use them to remove the magic values from the driver. Add a comment about the extra registers to explain why thi

RE: [PATCH 08/17] staging: comedi: quatech_daqp_cs: introduce daqp_ai_get_sample()

On Thursday, October 01, 2015 11:38 AM, kbuild test robot wrote: > Hi Hartley, > > [auto build test results on v4.3-rc3 -- if it's inappropriate base, please > ignore] > > reproduce: > # apt-get install sparse > make ARCH=x86_64 allmodconfig > make C=1 CF=-D__CHECK_ENDIAN__

[RESEND PATCH v2] mtd: nand: pass page number to ecc->write_xxx() methods

The ->read_xxx() methods are all passed the page number the NAND controller is supposed to read, but ->write_xxx() do not have such a parameter. This is a problem if we want to properly implement data scrambling/randomization in order to mitigate MLC sensibility to repeated pattern: to prevent bit

Re: [PATCH v2] mtd: nand: pass page number to ecc->write_xxx() methods

On Thu, 1 Oct 2015 20:04:17 +0200 Boris Brezillon wrote: > The ->read_xxx() methods are all passed the page number the NAND controller > is supposed to read, but ->write_xxx() do not have such a parameter. > > This is a problem if we want to properly implement data > scrambling/randomization in

RE: [PATCH 0/3] scsi: Some miscellaneous fixes

> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, September 29, 2015 6:34 AM > To: James E.J. Bottomley ; KY Srinivasan > > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; > jbottom.

[PATCH 1/1] storvsc: get rid of bounce buffer

From: Vitaly Kuznetsov Storvsc driver needs to ensure there are no 'holes' in the presented sg list (all segments in the middle of the list need to be of PAGE_SIZE). When a hole is detected storvsc driver creates a 'bounce sgl' without holes and copies data over with copy_{to,from}_bounce_buffer(

Re: [PATCH 08/12] staging: wilc1000: use s8 instead of int8_t

On Fri, Oct 2, 2015 at 12:40 AM, Dan Carpenter wrote: > On Thu, Oct 01, 2015 at 10:43:55PM +0900, Chaehyun Lim wrote: >> This patch replaces int8_t with s8 that is a preferred type. >> > > It would be better to just use int. I always appreciate your comment. I've sent a patch before after changin

[PATCH v2 01/17] staging: comedi: quatech_daqp_cs: there are 4 digital outputs

This board has 4 digital outputs not 1. Fix the subdevice init. The digital output lines are used for the external channel selection when the expansion mode is enabled. Add a comment about this. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/

[PATCH v2 02/17] staging: comedi: quatech_daqp_cs: there are 4 digital inputs

This board has 4 digital inputs not 1. Fix the subdevice init. The digital input lines are shared with other functions. Add a comment about this. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 13 - 1 f

[PATCH v2 00/17] staging: comedi: quatech_daqp_cs: cleanup driver

Following is the cleanup series for the comedi quatech_daqp_cs PCMCIA driver. v2: fix patch 08/17 as pointed out by the kbuild test robot daqp_ai_get_sample() should be static H Hartley Sweeten (17): staging: comedi: quatech_daqp_cs: there are 4 digital outputs staging: comedi: quatech_da

[PATCH v2 04/17] staging: comedi: quatech_daqp_cs: tidy up daqp_ai_set_one_scanlist_entry()

Clarify the scan list programming a bit by refactoring this function to program the entire scan list instead of just a single entry. Move the necessary reset of the scan list into this function. Rename the function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- dri

[PATCH v2 03/17] staging: comedi: quatech_daqp_cs: fix ai cmd timing

According to the users manual, the conversion timing (scanrate) is fixed to 100, 50, or 25 kHz. The pacer clock is then used to trigger each scan. Currently this driver tries to fake other conversion speeds by always sampling the inputs at 100 kHz and using the pacer clock to trigger each conversi

[PATCH v2 06/17] staging: comedi: quatech_daqp_cs: fix daqp_ai_cancel()

Make sure interrupts are disabled and the event flags are cleared when the analog input async command is canceled. Remove the unnecessary calls to stop any running conversions in the (*insn_read) and (*do_cmd) functions. The comedi core will only call these functions if the subdevice is not busy (

[PATCH v2 05/17] staging: comedi: quatech_daqp_cs: don't use interrupts for ai (*insn_read)

The comedi (*insn_read) functions are supposed to do simple one-shot reading of an analog input channel. Currently this driver enables interrupts and uses wait_for_completion_interruptible() to allow the interrupt routine to let the analog input (*insn_read) know that the end-of-conversion has occu

[PATCH v2 08/17] staging: comedi: quatech_daqp_cs: introduce daqp_ai_get_sample()

Introduce a helper function to get a two's complement sample from the FIFO and munge it to the offset binary format that comedi uses. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- v2: as pointed out by the kbuild test robot (less than a hour after posting the se

[PATCH v2 07/17] staging: comedi: quatech_daqp_cs: remove 'interrupt_mode'

The interrupt handler is now only used for the ai async command. Remove the unnecessary 'interrupt_mode' from the private data and tidy up the interrupt handler. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 70 +++

  1   2   >