Re: [PATCH] staging: slicoss: remove unused variables

On Fri, Sep 04, 2015 at 11:13:00AM -0700, David Matlack wrote: > On Fri, Sep 4, 2015 at 6:23 AM, Sudip Mukherjee > wrote: > > These variables were only assigned some values but they were never used. > > > > Signed-off-by: Sudip Mukherjee > > --- > > - status = slic_upr_request(adapter, SLI

[PATCH 1/2] staging: dgnc: take lock when accessing to dgnc_poll_tick

poll_tick is declared global, so dgnc_driver_pollrate_* need to take the lock dgnc_poll_lock before accessing to this variable. dgnc_poll_lock the appropriate lock, since it is intended for poll scheduling and dgnc_poll_tick contains the poll rate. dgnc_poll_lock needs to be declared not static an

[PATCH 2/2] staging: dgnc: remove useless spinlock

dgnc_poll_stop is a local variable in dgnc_driver.c, so it is useless to take dgnc_poll_lock before accessing to this variable. Signed-off-by: Salah Triki --- drivers/staging/dgnc/dgnc_driver.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/s

[PATCH 3/3] staging: fbtft: use pr_fmt

Instead of defining DRVNAME and using it in all calls to pr_* family of macros lets start using pr_fmt. Signed-off-by: Sudip Mukherjee --- drivers/staging/fbtft/fbtft_device.c | 79 1 file changed, 35 insertions(+), 44 deletions(-) diff --git a/drivers/stagi

[PATCH 1/3] staging: fbtft: use strncpy instead of strcpy

Using strcpy() is a security risk as the destination buffer size is not checked and we may over-run the buffer. Use strncpy() instead, while mentioning the buffer size leaving place for the NULL termination. Signed-off-by: Sudip Mukherjee --- drivers/staging/fbtft/fbtft_device.c | 3 ++- 1 file

[PATCH 2/3] staging: fbtft: do not use magic numbers

Using magic numbers are not good coding practise. Use FBTFT_GPIO_NAME_SIZE as defined in the header files. Signed-off-by: Sudip Mukherjee --- drivers/staging/fbtft/fbtft_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/s

Re: [PATCHv4 1/2] staging: wilc1000: remove FREE_WILC_BUFFER()

2015-09-02 21:19 GMT-04:00 Greg Kroah-Hartman : > Turns out this file is never even built, you should just remove it :) You're right, although it seems that is one of the "To-dos" of that module, as the references I find about the config variable to allow the compiling of that file is the followin

Re: [PATCHv4 1/2] staging: wilc1000: remove FREE_WILC_BUFFER()

Oh well. Actually you did it. I answered while pulling the git... Sorry for that unuseful mail! :) 2015-09-05 12:25 GMT-04:00 Raphaël Beamonte : > 2015-09-02 21:19 GMT-04:00 Greg Kroah-Hartman : >> Turns out this file is never even built, you should just remove it :) > > You're right, although it

Re: [PATCH 02/18] staging: iio: hmc5843: Export missing SPI module alias information

On 01/09/15 00:09, Javier Martinez Canillas wrote: > Hello Jonathan, > > On 08/22/2015 07:59 PM, Jonathan Cameron wrote: >> On 20/08/15 08:07, Javier Martinez Canillas wrote: >>> The SPI core always reports the MODALIAS uevent as "spi:" >>> regardless of the mechanism that was used to register the

Re: [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

I resent it since no one responded to it for 10 days. From what I came to understand that is the common practice. If that is not the case I'm sorry (and please let me know so I don't do it again). Cheers, Anders Fridlund On Thu, Sep 3, 2015 at 6:41 PM, Greg KH wrote: > On Sat, Aug 29, 2015 at 01

[PATCH 02/15] Staging: rtl8291u: fix space-before-brace coding style issues in ieee80211_softmac_wx.c

This is a patch to the ieee80211_softmac_wx.c file that fixes up issues where absent spaces beofre braces were found by checkpatch.pl Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --gi

[PATCH 01/15] Staging: rtl8192u: fix ampersand coding style issues in ieee80211_softmac_wx.c

This is a patch to the ieee80211_softmac_wx.c file that fixes up unary & errors found by checkpatch.pl. Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee8

[PATCH 03/15] Staging: rtl8192u: fix space before close parenthesis style issues in ieee80211_softmac_wx.c

This is a patch to the ieee80211_softmac_wx.c file that removes superfluous spaces before closed parentheses as identified by checkpatch.pl Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 04/15] Staging: rtl8192u: fix close brace spacing issues in ieee80211_softmac_wx.c

This is a patch to the ieee80211_softmac_wx.c file that adds spaces after closed braces as identified by checkpatch.pl Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/stagi

[PATCH 05/15] Staging: rtl8192u: fix missing spaces before open parentheses in ieee80211_softmac_wx.c

This is a patch to the ieee80211_softmac_wx.c file that fixes up missing spaces before open parentheses as identified by checkpatch.pl. Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) di

[PATCH 06/15] Staging: rtl8192u: fix indentation for conditional statements in ieee80211_softmac_wx.c

This is a patch to the ieee80211_softmac_wx.c file that fixes up an indentation issue identified by checkpatch.pl Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl

[PATCH 07/15] Staging: rtl8192u: do not use C99 comments in ieee80211_softmac_wx.c

This is a patch to the ieee80211_softmac_wx.c file that replaces C99 comments with C89 comments as identified by checkpatch.pl Signed-off-by: Mike Dupuis --- .../rtl8192u/ieee80211/ieee80211_softmac_wx.c | 28 +++--- 1 file changed, 14 insertions(+), 14 deletions(-) diff -

[PATCH 08/15] Staging: rtl8192u: remove spaces at the start of lines in ieee80211_softmac_wx.c

This is a patch to the ieee_softmac_wx.c file that removes unnecessary spaces at the start of lines as identified by checkpatch.pl Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

[PATCH 09/15] Staging: rtl8192u: add spaces after commas in ieee80211_softmac_wx.c

This is a patch to the ieee80211_softmac_wx.c file that adds spaces after commas as identified by checkpatch.pl Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/i

[PATCH 10/15] Staging: rtl8192u: open braces should appear on the appropriate line in ieee80211_softmac_wx.c

This is a patch to the ieee80211_softmac_wx.c file that corrects instances where open braces appear on the incorrect line as identified by checkpatch.pl Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH 11/15] Staging: rtl8192u: remove unnecessary braces around conditionals in ieee80211_softmac_wx.c

This is a patch to the ieee80211_softmac_wx.c file that removes unnecessary braces around conditional statements as identified by checkpatch.pl Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) d

[PATCH 12/15] Staging: rt8192u: add spaces around assignment operators in ieee80211_softmac_wx.c

This is a patch to add spaces around assignment operators as identifed by checkpatch.pl Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee

[PATCH 13/15] Staging: rtl8192u: add spaces around == and || operators in ieee80211_softmac_wx.c

This is a patch to ieee80211_softmac_wx.c to add missing spacing around == and || operators as identified by checkpatch.pl Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 14/15] Staging: rtl8192u: fix brace placement issues in ieee80211_softmac_wx.c

This is a patch to fix up some brace placement issues in ieee80211_softmac_wx.c Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c

[PATCH 15/15] Staging: rtl8192u: add space before { in ieee80211_softmac_wx.c

This is a patch to ieee80211_softmac_wx.c that adds space before an open brace as identified by checkpatch.pl. This was overlooked in a previous patch. Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

On Sat, Sep 05, 2015 at 09:21:58PM +0200, Anders Fridlund wrote: > I resent it since no one responded to it for 10 days. From what I came > to understand that is the common practice. If that is not the case I'm > sorry (and please let me know so I don't do it again). That's fine to do, but at leas

Re: [PATCHv2 18/19] staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() code style issue

2015-09-03 13:00 GMT-04:00 Greg Kroah-Hartman : > You need to prove that they are aligned before I can take this patch :( Right! I looked at those structs using pahole. The structs used are net_device from include/linux/netdevice.h and sockaddr from include/linux/socket.h, in which we use the ele

Re: [PATCH 02/18] staging: iio: hmc5843: Export missing SPI module alias information

Hello Jonathan, On 09/05/2015 06:31 PM, Jonathan Cameron wrote: > On 01/09/15 00:09, Javier Martinez Canillas wrote: >> Hello Jonathan, >> >> On 08/22/2015 07:59 PM, Jonathan Cameron wrote: >>> On 20/08/15 08:07, Javier Martinez Canillas wrote: The SPI core always reports the MODALIAS uevent

Re: [PATCHv2 18/19] staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() code style issue

On Sat, Sep 05, 2015 at 06:16:16PM -0400, Raphaël Beamonte wrote: > 2015-09-03 13:00 GMT-04:00 Greg Kroah-Hartman : > > You need to prove that they are aligned before I can take this patch :( > > Right! > > I looked at those structs using pahole. The structs used are > net_device from include/lin

[PATCHv2] staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() code style issue

Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) The values used are stored as dev_addr in net_device (declared in include/linux/netdevice.h) and sa_data in sockaddr (declared in include/linux/socket.h). Both these elements are u16 aligned as shown by using pahole