On Fri, Aug 14, 2015 at 01:08:32PM -0400, Raphaël Beamonte wrote:
> Fix a macro with complex value coding style error.
>
This patch description is too vague.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.l
On 14/08/15 19:39, H Hartley Sweeten wrote:
Fix some minor checkpatch.pl issues and use the comedi_offset_munge()
helper to do the two's complement to offset binary munging.
v2: drop patch 4 from the orignal series
Ian Abbott did not want to add the mask to comedi_offset_munge()
v3: remove
On Sun, Aug 16, 2015 at 01:30:12AM -0400, Raphaël Beamonte wrote:
> #define MALLOC_WILC_BUFFER(name, size) \
> - exported_ ## name = kmalloc(size, GFP_KERNEL);\
> - if (!exported_ ## name) { \
> - printk("fail to alloc: %s memory\n", exported_ ## name); \
> -
On 14/08/15 22:29, H Hartley Sweeten wrote:
Move this check from the (*do_cmd) to the (*do_cmdtest).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfast.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
di
On 14/08/15 22:29, H Hartley Sweeten wrote:
The (*do_cmdtest) properly checks the MIN_SAMPLE_PERIOD. Remove the
redundant check in the (*do_cmd).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfast.c | 8
1 file chan
On 14/08/15 23:23, H Hartley Sweeten wrote:
Fix a couple minor checkpatch.pl issues and tidy up the driver a bit.
H Hartley Sweeten (6):
staging: comedi: usbdux: use preferred kernel types
staging: comedi: usbdux: add missing spaces
staging: comedi: usbdux: use common code path to check
On 14/08/15 22:35, H Hartley Sweeten wrote:
Tidy up this driver to remove the last checkpatch.pl issues.
H Hartley Sweeten (2):
staging: comedi: vmk80xx: cleanup multi-line comment
staging: comedi: vmk80xx: tidy up defines
drivers/staging/comedi/drivers/vmk80xx.c | 127 -
On 15/08/15 01:09, H Hartley Sweeten wrote:
Format the multi-line comments in the kernel CodingStyle.
Move the comment about the I/O ports in dnp_attach() to the start
of the function. This is typically where the resources are reserved.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg
On 15/08/15 01:31, H Hartley Sweeten wrote:
checkpatch.pl reports:
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
Change the error code to -ENOIOCTLCMD/
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/serial2002.c | 2 +
On Thu 2015-08-13 12:37:30, at...@opensource.altera.com wrote:
> From: Alan Tull
>
> New bindings document for simple fpga bus.
>
> Signed-off-by: Alan Tull
Acked-by: Pavel Machek
> + onchip_memory2_0: memory@0x0 {
> + d
On Thu 2015-08-13 12:37:32, at...@opensource.altera.com wrote:
> From: Alan Tull
>
> Add simple fpga bus. This is a bus that configures an fpga and its
> bridges before populating the devices below it. This is intended
> for use with device tree overlays.
>
> Note that FPGA bridges are seen as
On Thu 2015-08-13 12:37:27, at...@opensource.altera.com wrote:
> From: Alan Tull
>
> API to support programming FPGA.
I'd do s/fpga/FPGA/ in the comments, too. Otherwise looks ok to me.
Acked-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atr
On Thu 2015-08-13 12:37:29, at...@opensource.altera.com wrote:
> From: Alan Tull
>
> Add a document spelling out usage of the simple fpga bus.
>
> Signed-off-by: Alan Tull
Acked-by: Pavel Machek
Pavel
--
(englis
WILC_ErrNo is replaced by s32, then WILC_ErrNo typedef is removed.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_errorsupport.h | 2 --
drivers/staging/wilc1000/wilc_msgqueue.c | 12 ++--
drivers/staging/wilc1000/wilc_msgqueue.h | 8
drivers/staging/wil
The macros inside wilc_osconfig.h are not referenced anywhere,
so just delete it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_osconfig.h | 9 -
drivers/staging/wilc1000/wilc_oswrapper.h | 1 -
2 files changed, 10 deletions(-)
delete mode 100644 drivers/staging/wilc100
The macros in wilc_log.h are not referenced anywhere, so just delete it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_log.h | 47 ---
drivers/staging/wilc1000/wilc_oswrapper.h | 2 --
2 files changed, 49 deletions(-)
delete mode 100644 drivers
This patch uses -EINVAL for invalid argument checking instead of using
WILC_ERRORREPORT with WILC_INVALID_ARGUMENT.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_msgqu
On Mon, Aug 17, 2015 at 10:44:30PM +0900, Chaehyun Lim wrote:
> WILC_ErrNo is replaced by s32, then WILC_ErrNo typedef is removed.
>
s32 is a weirdo type. You should only specify the number of bit when it
is something required by the hardware. Just use int.
regards,
dan carpenter
On Fri, Aug 14, 2015 at 09:14:05PM +0200, Ondrej Zary wrote:
> Most probably yes.
>
> However, the driver will be useless soon as the Flash OFDM network is being
> decommissioned here in Slovakia. AFAIK, this technology is not used anywhere
> else in the world (the 2nd country was Finland). The
2015-08-17 5:08 GMT-04:00 Dan Carpenter :
> Pull it in one indent level... But actually this macro has a return in
> the middle of it, so it just introduces bugs all over the place like
> eating cookies in bed. We should just delete it instead.
You're right!
I'll clean those macro up and send a
From: Tim Sell
Update documentation (including TODO) to reflect the current state of
the drivers.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
.../Documentation/ABI/sysfs-platform-visorchipset | 2 +
drivers/staging/unisys/Documentation/overview.txt | 458 ++--
Since dgnc_poll_trick is a global variable.
Signed-off-by: Salah Triki
---
drivers/staging/dgnc/dgnc_sysfs.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c
b/drivers/staging/dgnc/dgnc_sysfs.c
index 44db870..fe14b7a 100644
-
On Sunday, August 16, 2015 11:16 PM, Sudip Mukherjee wrote:
> On Fri, Aug 14, 2015 at 11:34:07AM -0700, H Hartley Sweeten wrote:
>> +data[i] = comedi_offset_munge(s, val);;
> This introduces new checkpatch warning about double semicolon.
Yeah. I spotted that right after I posted the v2
Hi,
The first 3 patches of the following 5 are aimed to simplify the
wilc_exported_buf.c macros as well as correct a potential memory
leak from the use of the MALLOC_WILC_BUFFER one.
The next 2 patches are correcting two kind of checkpatch warning
reports in different files of the wilc1000 driver
It was just a wrapper around kfree(), so call that instead.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c
b/drivers/staging/wilc100
It was just a wrapper to initialize a variable. Initialize it
directly instead.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c
b/drivers
The MACRO_WILC_BUFFER() macro was using a return statement, and didn't
take care of possible memory leaks and subsequent bugs when it was failing
after succeeding some allocations. This patch corrects this behavior.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/host_interface.c| 4
drivers/staging/wilc1000/linux_wlan.c| 1 -
drivers/staging/wilc1000/wilc_exported_buf.c | 2 --
drivers/staging/wilc1000/wilc_wlan.c | 3 ---
drivers/staging/wilc1000/wilc_wlan_cfg.c |
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
drivers/staging/wilc1000/linux_wlan.c| 8 +++
drivers/staging/wilc1000/linux_wlan_common.h | 32 ++--
drivers/staging/wilc1000/linux_wlan_sdio.c | 2 +-
drivers/stag
On Mon, Aug 17, 2015 at 12:08:35PM -0400, Raphaël Beamonte wrote:
> The MACRO_WILC_BUFFER() macro was using a return statement, and didn't
> take care of possible memory leaks and subsequent bugs when it was failing
> after succeeding some allocations. This patch corrects this behavior.
>
> Signed
On Mon, Aug 17, 2015 at 12:08:34PM -0400, Raphaël Beamonte wrote:
> It was just a wrapper around kfree(), so call that instead.
>
> Signed-off-by: Raphaël Beamonte
> ---
> + kfree(exported_g_tx_buf);
> + exported_g_tx_buf = NULL;
No need to add these new NULL assignments. The module is
On Mon, Aug 17, 2015 at 12:08:36PM -0400, Raphaël Beamonte wrote:
> Signed-off-by: Raphaël Beamonte
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
> drivers/staging/wilc1000/linux_wlan.c| 8 +++
> drivers/staging/wilc1000/linux_wlan_common.h | 32
> ++---
On 08/17/15 03:55, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20150813:
>
on i386 (for several days now):
when CONFIG_KEXEC is not enabled:
arch/x86/built-in.o: In function `hv_machine_crash_shutdown':
mshyperv.c:(.text+0x2d9d4): undefined reference to
`native_machine_crash_shutdown
> -Original Message-
> From: Randy Dunlap [mailto:rdun...@infradead.org]
> Sent: Monday, August 17, 2015 10:35 AM
> To: Stephen Rothwell ; linux-n...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org; de...@driverdev.osuosl.org; KY Srinivasan
> ; Haiyang Zhang
> Subject: Re: linux-next:
2015-08-17 13:47 GMT-04:00 Dan Carpenter :
>> - printk("[Sendconfigpkt]Get Timed out\n");
>> + pr_debug("[Sendconfigpkt]Get Timed out\n");
>
>
> Possibly pr_err()?
Yep. My mistake. I'll do the same for Set Timed Out also!
>> -
On Mon, Aug 17, 2015 at 01:59:44PM -0400, Raphaël Beamonte wrote:
> 2015-08-17 13:47 GMT-04:00 Dan Carpenter :
> >> - printk("[Sendconfigpkt]Get Timed out\n");
> >> + pr_debug("[Sendconfigpkt]Get Timed out\n");
> >
> >
> > Possibly pr_err()?
>
): undefined reference to `netif_tx_wake_queue'
Signed-off-by: Randy Dunlap
Cc: Christian Gromm
Cc: Michael Fabry
Cc: Christian Gromm
---
drivers/staging/most/hdm-usb/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20150817.orig/drivers/staging/most/
On Mon, Aug 17, 2015 at 04:19:12PM +0100, Salah Triki wrote:
> Since dgnc_poll_trick is a global variable.
>
> Signed-off-by: Salah Triki
Does this changelog even mean?
Why is Mark not on the CC list? Use scripts/get_maintainer.pl.
I think there probably is a bug here, but access is still rac
The channel list should be checked in Step 5 of the (*do_cmdtest) not
as part of the (*do_cmd). Factor the check out of usbduxfast_ai_cmd().
Tidy up the factored out code. The channel number 'i' will never be
greater than NUMCHANNELS due to the subdevice setup and the checks
done in the code. The
Fix a couple minor checkpatch.pl issues.
Tidy up the ai (*do_cmdtest) and (*do_cmd) a bit.
v2: Address some issues pointed out by Ian Abbott and add a couple
more patches to remove some cruft.
1) Move the test in patch 6 to Step 3 as requested by Ian Abbott.
2) Add new patch 7 to sim
The analog input (*do_cmd) only supports channel lists of 1, 2, 3, or 16
channels. Add a check for this to usbduxfast_ai_check_chanlist() and remove
the check from usbduxfast_ai_cmd().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usb
The private data 'devpriv' is allocated in the (*auto_attach) before
the subdevices are initialized and the (*auto_attach) has to complete
successfully before the core will call any of the subdevice operations.
Because of this the (!devpriv) checks in the subdevice code can never
fail. Remove them.
This comment does not need to be multi-line. Fix it to remove the
checkpatch warning.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfast.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/com
As suggested by checkpatch.pl:
CHECK: Prefer kernel type 'u8' over 'uint8_t'
CHECK: Prefer kernel type 's8' over 'int8_t'
For consistency, also change the uint16_t and int16_t types to
u16 and s16.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/com
According to the code, and verified with the author Bernd Porr, the
TRIG_EXT trigger is only valid for the cmd->start_src. Remove this
trigger from the cmd->scan_begin_src and cmd->convert_src.
The only valid scan_begin_src is then TRIG_FOLLOW and the convert_src
is only TRIG_TIMER. Remove the re
Move this check from the (*do_cmd) to the (*do_cmdtest).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfast.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/usbdux
Cleanup the validation of the cmd->convert_arg to use the same calculation
in the (*do_cmdtest) and the (*do_cmd).
Remove the, then unnecessary, redundant check in the (*do_cmd).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfa
For aesthetics, use 'goto' and a common exit point in this function so
that the up of the semaphore is not overlooked.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfast.c | 21 +
1 file changed, 9 insertions
The semaphore down/up in usbduxfast_attach_common() is not necessary.
This function is only called as part of the (*auto_attach) and does
not talk to the USB device.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfast.c | 9 +
The analog inputs have 12-bit resoultion. The subdevice 'maxdata' is
a mask value for the resolution. Fix the value.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfast.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
The clearing of the private data members in the (*detatch) is not
necessary. The comedi core is going to kfree the private data as soon
as the (*detach) finishes.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfast.c | 6 --
This function is only called by the (*auto_attach) to do the final
setup of the analog input subdevice.
For aesthetics absorb it into usbduxfast_auto_attach() and reorder
the initialization of the subdevice to better follow the "norm" in
comedi drivers.
Signed-off-by: H Hartley Sweeten
Cc: Ian A
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
drivers/staging/wilc1000/linux_wlan.c| 8
drivers/staging/wilc1000/linux_wlan_common.h | 28 ++--
drivers/staging/wilc1000/linux_wlan_sdio.c | 2 +-
drivers/sta
The MACRO_WILC_BUFFER() macro was using a return statement, and didn't
take care of possible memory leaks and subsequent bugs when it was failing
after succeeding some allocations. This patch corrects this behavior.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c
It was just a wrapper around kfree(), so call that instead.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c
b/drivers/staging/wilc1000/wilc_
Hi,
Following comments from Dan Carpenter, please find the following
revised patches.
Raphaël
Raphaël Beamonte (5):
staging: wilc1000: remove void function return statements that are not
useful
staging: wilc1000: use pr_* instead of printk
staging: wilc1000: remove DECLARE_WILC_BUFFER
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/host_interface.c| 4
drivers/staging/wilc1000/linux_wlan.c| 1 -
drivers/staging/wilc1000/wilc_exported_buf.c | 4 +---
drivers/staging/wilc1000/wilc_wlan.c | 3 ---
drivers/staging/wilc1000/wilc_wlan_cfg.c
It was just a wrapper to initialize a variable. Initialize it
directly instead.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c
b/drivers/st
On Mon, Aug 17, 2015 at 10:44:29PM +0900, Chaehyun Lim wrote:
> The macros inside wilc_osconfig.h are not referenced anywhere,
> so just delete it.
>
> Signed-off-by: Chaehyun Lim
And I did this one also, again, sorry, I hadn't seen your email yet.
greg k-h
_
On Mon, Aug 17, 2015 at 10:44:28PM +0900, Chaehyun Lim wrote:
> The macros in wilc_log.h are not referenced anywhere, so just delete it.
Oops, I just did this same thing before I saw your email, sorry about
that.
greg k-h
___
devel mailing list
de...@li
On Mon, Aug 17, 2015 at 10:44:31PM +0900, Chaehyun Lim wrote:
> This patch uses -EINVAL for invalid argument checking instead of using
> WILC_ERRORREPORT with WILC_INVALID_ARGUMENT.
>
> Signed-off-by: Chaehyun Lim
> ---
> drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
> 1 file changed, 2 ins
On Mon, Aug 17, 2015 at 03:28:27PM -0400, Raphaël Beamonte wrote:
> Signed-off-by: Raphaël Beamonte
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
> drivers/staging/wilc1000/linux_wlan.c| 8
> drivers/staging/wilc1000/linux_wlan_common.h | 28
> ++--
On Mon, Aug 17, 2015 at 03:28:29PM -0400, Raphaël Beamonte wrote:
> It was just a wrapper around kfree(), so call that instead.
Someone else already did this, sorry.
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriv
I was going to clean up this driver but looking it over it has a
number of serious flaws. Also, Fastwell published an End-Of-Life
notification for the board on 24/Jan/2014 (End-of-sale 30/Jun/2014,
End-of-delivery 30/Dec/2014).
Since the driver has a comedi driver status of "unkown", lets just
rem
On Monday, August 17, 2015 4:52 AM, Ian Abbott wrote:
> On 15/08/15 01:31, H Hartley Sweeten wrote:
>> checkpatch.pl reports:
>> WARNING: ENOSYS means 'invalid syscall nr' and nothing else
>>
>> Change the error code to -ENOIOCTLCMD/
>>
>> Signed-off-by: H Hartley Sweeten
>> Cc: Ian Abbott
>> Cc:
Fix checkpatch issue: "CHECK: usleep_range is preferred over udelay;
see Documentation/timers/timers-howto.txt". Replace the udelay() with
usleep_range() with a reasonable upper limit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ser
Fix all the remaining checkpatch.pl issues.
v2: change errno in patch 3 to -ENOTTY
H Hartley Sweeten (3):
staging: comedi: serial2002: tidy up multi-line comments
staging: comedi: serial2002: usleep_range is preferred over udelay
staging: comedi: serial2002: use proper errno
drivers/stagi
Format the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/serial2002.c | 47 ++---
1 file changed, 23 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/c
checkpatch.pl reports:
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
Change the error code to -ENOTTY.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/serial2002.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
On Mon, Aug 17, 2015 at 09:26:15PM +0300, Dan Carpenter wrote:
> On Mon, Aug 17, 2015 at 04:19:12PM +0100, Salah Triki wrote:
> > Since dgnc_poll_trick is a global variable.
> >
> > Signed-off-by: Salah Triki
>
> Does this changelog even mean?
>
> Why is Mark not on the CC list? Use scripts/ge
On 08/17/15 03:55, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20150813:
>
Several items:
A: these and other similar errors:
In file included from ../drivers/staging/hfi1/chip.c:61:0:
../drivers/staging/hfi1/chip.c: In function â__hfi1_trace_LINKVERBâ:
../drivers/staging/hfi1/tra
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
drivers/staging/wilc1000/linux_wlan.c| 8
drivers/staging/wilc1000/linux_wlan_common.h | 28 ++--
drivers/staging/wilc1000/linux_wlan_sdio.c | 2 +-
drivers/sta
The MALLOC_WILC_BUFFER() macro was using a return statement, and didn't
take care of possible memory leaks and subsequent bugs when it was failing
after succeeding some allocations. This patch corrects this behavior.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.
2015-08-17 15:41 GMT-04:00 Arend van Spriel :
> Probable MACRO_WILC_BUFFER should be MALLOC_WILC_BUFFER here.
Good catch!
> There is really no need to print an error message here. kmalloc will blurb
> enough info when it fails.
Ok!
> So these buffers are globals? So does this driver support mul
On Mon, Aug 17, 2015 at 11:11:05PM +0100, Salah Triki wrote:
> On Mon, Aug 17, 2015 at 09:26:15PM +0300, Dan Carpenter wrote:
> > On Mon, Aug 17, 2015 at 04:19:12PM +0100, Salah Triki wrote:
> > > Since dgnc_poll_trick is a global variable.
> > >
> > > Signed-off-by: Salah Triki
> >
> > Does thi
On Mon, Aug 17, 2015 at 07:12:47PM -0400, Raphaël Beamonte wrote:
> The MALLOC_WILC_BUFFER() macro was using a return statement, and didn't
> take care of possible memory leaks and subsequent bugs when it was failing
> after succeeding some allocations. This patch corrects this behavior.
>
> Signe
This series cleans up all of the driver code except for the counter
subdevice. I still need to figure out how that subdevice works, right
now it looks like it might be a bit broken...
H Hartley Sweeten (18):
staging: comedi: s526: tidy up multi-line comments
staging: comedi: s526: refactor gpc
Format the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s526.c | 69 +--
1 file changed, 34 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/c
The S526 board has 4 general purpose counter/timers. The current
defines used for the registers of these devices do not provide much
clarity in what they are.
Refactor the code to add some clarity.
Replace the current register defines with macros that return the
correct offset based on the counte
Define this register and it's bits so that we can possibly support
it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s526.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/s526.
Define this register and it's bits so that we can possibly support
it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s526.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/s526.c
Define this register and its bits and remove the magic numbers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s526.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/s526.
Define this register and its bits and remove the magic numbers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s526.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/comedi/d
The same register is used for analog output and input data. Add defines
for both for added clarity.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s526.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drive
These registers use the same bit defines. Define both of them and
the bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s526.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/
Define this register and its bits and remove the magic numbers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s526.c | 28 +++-
1 file changed, 19 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/com
Define these registers and their bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s526.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/s526.c
b/drivers/staging/comedi/d
Define this register and its bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s526.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/s526.c
b/drivers/staging/comedi/drivers/s5
It's possible for the user to write more than one value to an analog
output channel with the (*insn_write) operation. Use comedi_timeout()
to check the interrupt status register to ensure that each data
conversion is complete before writing the next value.
Signed-off-by: H Hartley Sweeten
Cc: Ian
For aesthetics, add some whitespace to the subdevice initialization.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s526.c | 73 ++-
1 file changed, 38 insertions(+), 35 deletions(-)
diff --git a/driver
This (*insn_config) does not follow the comedi core API. It also
would not work as expected.
It appears to be trying to configure the analog input subdevice so
that the (*insn_read) would read multiple channels (data[0]) and
optionally enable the 15us delay (data[1]) needed for the multiplexor
to
Rename this function to follow the normal naming in comedi drivers.
Use the comedi_offset_munge() helper to munge the hardware two's
complement data to the comedi offset binary format.
Change the final return to insn->n to clarify the return value without
the need for the comment.
Signed-off-by:
This #if 0'ed out code is not necessary. It's actually just a copy
of the psuedo code in the S526 Hardware Manual that shows an example
of a counter application. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s526.c | 29 ---
Tidy up the block comments to fix the checkpatch.pl warnings.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s526.c | 57 +++
1 file changed, 31 insertions(+), 26 deletions(-)
diff --git a/drivers/stagi
Remove a couple unused defines,
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s526.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/s526.c
b/drivers/staging/comedi/driver
Hello Dan.
On 2015년 08월 13일 23:49, Dan Carpenter wrote:
On Thu, Aug 13, 2015 at 01:41:23PM +0900, Tony Cho wrote:
+static u32 get_id_from_handler(tstrWILC_WFIDrv *handler)
+{
+ u32 id;
+
+ if (!handler)
+ return 0;
+
+ for (id = 0; id < NUM_CONCURRENT_IFC; id++)
On Mon, Aug 17, 2015 at 07:06:40PM -0400, Raphaël Beamonte wrote:
> Signed-off-by: Raphaël Beamonte
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
> drivers/staging/wilc1000/linux_wlan.c| 8
> drivers/staging/wilc1000/linux_wlan_common.h | 28
> ++--
On Sat, Aug 15, 2015 at 09:33:58PM -0400, Raphaël Beamonte wrote:
> Fix multiple occurences of the need consistent spacing code style error
>
> Signed-off-by: Raphaël Beamonte
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 28 ++--
> 1 file changed, 14 insertions(+), 14
> -Original Message-
> From: Dexuan Cui
> Sent: Friday, August 7, 2015 3:27 AM
> To: KY Srinivasan ; David Miller
>
> Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com;
> driverdev-devel@linuxdriverproject.org; linux-ker...@vger.kernel.org;
> step...@networkplumber.org;
On Sat, Aug 15, 2015 at 09:34:02PM -0400, Raphaël Beamonte wrote:
> A missing struct keyword in variable declaration triggered a
> need consistent spacing around '*' code style error.
struct rtl8192_rx_info is typedef as rtl8192_rx_info. This same file is
having few more use of rtl8192_rx_info with
1 - 100 of 110 matches
Mail list logo
