[PATCH] staging: sm750fb: fix c99 comments

2015-06-12 Thread Juston Li
fixed all checkpatch.pl ERROR: do not use C99 // comments Any C99 comments used to comment out code are simply removed. Also some of the errors occur inside '#if 0' blocks which I might as well fix since checkpatch.pl caught them but the blocks themselves should probably be cleaned up later. Sign

[PATCH] staging: vt6655: Boolean tests don't need comparisons

2015-06-12 Thread Abdul, Hussain (H.)
From: Abdul Hussain This patch removes unwanted true from boolean tests. Signed-off-by: Abdul Hussain --- drivers/staging/vt6655/rxtx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 33c4aa4..53433

[PATCH] staging: wilc1000: remove oswrapper & type file

2015-06-12 Thread Dean Lee
remove OS Wrapper & Type files. now does not used os wrapper file. type file is included os wrapper file. so delete files and rework include method. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/coreconfigurator.h | 1 - drivers/staging/wilc1000/fifo_buffer.c | 1 - drivers/staging

Re: [PATCH 6/6] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs

2015-06-12 Thread Paul Bolle
Greg has already asked you to resend. So here follow a few remarks to take into account for that resend. On Thu, 2015-06-11 at 16:22 +, ja...@microsoft.com wrote: > --- a/drivers/pci/Kconfig > +++ b/drivers/pci/Kconfig > +config HYPERV_VPCI > +tristate "Hyper-V PCI Frontend" > +

Re: [PATCH] staging: wilc1000: remove oswrapper & type file

2015-06-12 Thread Konrad Zapalowicz
On 06/12, Dean Lee wrote: > remove OS Wrapper & Type files. > now does not used os wrapper file. > type file is included os wrapper file. > so delete files and rework include method. I do not understand the commit message and it does not parse well. - konrad > > Signed-off-by: Dean Lee > ---

Re: [PATCH] staging: sm750fb: fix c99 comments

2015-06-12 Thread Konrad Zapalowicz
On 06/12, Juston Li wrote: > fixed all checkpatch.pl ERROR: do not use C99 // comments > > Any C99 comments used to comment out code are simply removed. > Also some of the errors occur inside '#if 0' blocks which I > might as well fix since checkpatch.pl caught them but the blocks > themselves sho

Re: [PATCH] staging: wilc1000: remove oswrapper & type file

2015-06-12 Thread Konrad Zapalowicz
On 06/12, Dean.lee wrote: > > > On 2015년 06월 12일 18:17, Konrad Zapalowicz wrote: > >On 06/12, Dean Lee wrote: > >>remove OS Wrapper & Type files. > >>now does not used os wrapper file. > >>type file is included os wrapper file. > >>so delete files and rework include method. > >I do not understand

Re: [PATCH] staging: sm750fb: fix c99 comments

2015-06-12 Thread Juston Li
On Fri, Jun 12, 2015 at 2:21 AM, Konrad Zapalowicz wrote: >> diff --git a/drivers/staging/sm750fb/ddk750_chip.c >> b/drivers/staging/sm750fb/ddk750_chip.c >> index 8b47c1b..b2137c8 100644 >> --- a/drivers/staging/sm750fb/ddk750_chip.c >> +++ b/drivers/staging/sm750fb/ddk750_chip.c >> @@ -17,7 +17

Re: [PATCH v2] staging: wilc1000: remove oswrapper & type file

2015-06-12 Thread Dean . lee
On 2015년 06월 12일 19:03, Dean Lee wrote: remove OS Wrapper function(wilc_oswrapper.h) is in our plan. i try removed OS Wrapper function and it's done. and i found wilc_type.h file is does not used it. so i deleted them and modify #include line in another file. Signed-off-by: Dean Lee --- Chang

[PATCH v2] staging: sm750fb: fix c99 comments

2015-06-12 Thread Juston Li
fixed all checkpatch.pl ERROR: do not use C99 // comments Any C99 comments used to comment out code are simply removed. Also some of the errors occur inside '#if 0' blocks which I might as well fix since checkpatch.pl caught them but the blocks themselves should probably be cleaned up later. Chan

[PATCH] staging: wilc1000: remove warnings reported by checkpatch.pl.

2015-06-12 Thread Dean Lee
Remove the following warnings in the wilc_log.h: - unnecessary whitespace before a quoted newline - line over 80 characters - single statement macros should not use a do {} while (0) loop. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/wilc_log.h | 53 +

Re: [PATCH] staging: wilc1000: remove oswrapper & type file

2015-06-12 Thread Dean . lee
On 2015년 06월 12일 18:17, Konrad Zapalowicz wrote: On 06/12, Dean Lee wrote: remove OS Wrapper & Type files. now does not used os wrapper file. type file is included os wrapper file. so delete files and rework include method. I do not understand the commit message and it does not parse well.

[PATCH v3] staging: wilc1000: remove oswrapper & type file

2015-06-12 Thread Dean Lee
remove OS Wrapper function(wilc_oswrapper.h) is in our plan. i removed OS Wrapper function and it's done. and i found wilc_type.h file is does not used it. so i deleted them and modify #include line in another file. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/coreconfigurator.h | 1 -

[PATCH v2] staging: wilc1000: remove oswrapper & type file

2015-06-12 Thread Dean Lee
remove OS Wrapper function(wilc_oswrapper.h) is in our plan. i try removed OS Wrapper function and it's done. and i found wilc_type.h file is does not used it. so i deleted them and modify #include line in another file. Signed-off-by: Dean Lee --- Change modify commit message. --- drivers/stagi

[PATCH] staging: wilc1000: update TODO list

2015-06-12 Thread Dean Lee
remove complete OS wrapper functions. Signed-off-by: Dean Lee --- drivers/staging/wilc1000/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/TODO b/drivers/staging/wilc1000/TODO index 95199d8..e876008 100644 --- a/drivers/staging/wilc1000/TODO +++ b/drivers/staging

[PATCH v2 1/3] staging: rtl8188eu: remove unused enum and CONFIG

2015-06-12 Thread Sudip Mukherjee
The CONFIGs, the enum and the function declaration was not being used anywhere. Signed-off-by: Sudip Mukherjee --- drivers/staging/rtl8188eu/include/odm.h | 8 drivers/staging/rtl8188eu/include/odm_HWConfig.h | 3 --- 2 files changed, 11 deletions(-) diff --git a/drivers/stagi

[PATCH v2 3/3] staging: rtl8188eu: remove function which does nothing

2015-06-12 Thread Sudip Mukherjee
The function rtw_mfree_all_stainfo() is just holding the lock, traversing the list, and then unlocking. It is not doing anything else. So removed the function and modified the places from where it was called. Signed-off-by: Sudip Mukherjee --- drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 28 --

[PATCH v2 2/3] staging: rtl8188eu: remove unused variables

2015-06-12 Thread Sudip Mukherjee
These variables were being set but not used afterwards. Signed-off-by: Sudip Mukherjee --- drivers/staging/rtl8188eu/core/rtw_mlme.c| 3 --- drivers/staging/rtl8188eu/hal/phy.c | 10 ++ drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 -- drivers/staging/rtl818

Re: [PATCH] staging: wilc1000: update TODO list

2015-06-12 Thread Sudip Mukherjee
On Fri, Jun 12, 2015 at 07:23:11PM +0900, Dean Lee wrote: > remove complete OS wrapper functions. just a minor thing. It will be easy if you send your patches in series instead of separate patches. your patch "remove oswrapper & type file" is dependent on one of the previous patch that you have sen

Re: [PATCH] staging: wilc1000: pass gpio irq number using DT

2015-06-12 Thread Ravindran, Madhusudhanan (M.)
On Thu, Jun 11, 2015 at 09:15:13AM -0700, Greg Kroah-Hartman wrote: > On Thu, Jun 11, 2015 at 02:22:33PM +, Ravindran, Madhusudhanan (M.) wrote: > > From: Madhusudhanan Ravindran > > > > pass wlan irq gpio number in run time using DT as > > mentioned in the TODO list. > > > > Signed-off-by:

Re: [PATCH] staging: wilc1000: remove warnings reported by checkpatch.pl.

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 06:51:56PM +0900, Dean Lee wrote: > Remove the following warnings in the wilc_log.h: > - unnecessary whitespace before a quoted newline > - line over 80 characters > - single statement macros should not use a do {} while (0) loop. Those are different things, so this should

RE: [PATCH 6/6] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs

2015-06-12 Thread Jake Oshins
> -Original Message- > From: Paul Bolle [mailto:pebo...@tiscali.nl] > Sent: Friday, June 12, 2015 1:44 AM > To: Jake Oshins > Cc: gre...@linuxfoundation.org; KY Srinivasan; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; vkuzn...@redhat.c

Re: [PATCH v3] staging: wilc1000: remove oswrapper & type file

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 07:21:11PM +0900, Dean Lee wrote: > remove OS Wrapper function(wilc_oswrapper.h) is in our plan. > i removed OS Wrapper function and it's done. > and i found wilc_type.h file is does not used it. > so i deleted them and modify #include line in another file. You are also doi

Re: [PATCH] staging: wilc1000: update TODO list

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 07:23:11PM +0900, Dean Lee wrote: > remove complete OS wrapper functions. > > Signed-off-by: Dean Lee > --- > drivers/staging/wilc1000/TODO | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/wilc1000/TODO b/drivers/staging/wilc1000/TODO > index 95199

Re: [PATCH] staging: wilc1000: change WILC_Char to s8

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 02:39:08PM +0900, Dean Lee wrote: > change own data type(WILC_Char) to common data type(s8) Why not just 'char'? And you are using these in "strings", so why not u8? thanks, greg k-h ___ devel mailing list de...@linuxdriverproj

Re: [PATCH] staging: ste_rmi4: Add IRQF_ONESHOT flag

2015-06-12 Thread gre...@linuxfoundation.org
On Fri, Jun 12, 2015 at 06:47:25AM +, Abdul, Hussain (H.) wrote: > On Thursday 11 June 2015 08:06 PM, gre...@linuxfoundation.org wrote: > > On Thu, Jun 11, 2015 at 10:14:49AM +, Abdul, Hussain (H.) wrote: > >> This patch add IRQF_ONESHOT flag in threaded IRQs request without a > >> primary

[PATCH] staging: comedi: cb_pcimdas: fix handlers for DI and DO subdevices

2015-06-12 Thread Ian Abbott
Normally, low-level Comedi drivers set an `insn_bits` handler for digital input (DI), digital output (DO) and digital input/output (DIO) subdevice types to handle normal reading and writing of digital channels. The "cb_pcimdas" driver currently has an `insn_read` handler for the DI subdevice and a

RE: [HPDD-discuss] [PATCH 1/1] staging: lustre/lustre/llite: get rid of incorrect type warning

2015-06-12 Thread Simmons, James A.
>>On Wed, Jun 10, 2015 at 5:48 PM, Greg Kroah-Hartman > wrote: >> >> Are you sure all of these are correct? The kernel/user api for lustre >> is a complex beast, and just casting away the pointer types isn't >> usually the proper thing to do in order to resolve the issues here. >> >> thanks, >> >>

Re: [PATCH 6/6] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs

2015-06-12 Thread gre...@linuxfoundation.org
On Fri, Jun 12, 2015 at 03:11:14PM +, Jake Oshins wrote: > This driver is intended to support both full PCI Express device pass through > and also be the basis for SR-IOV networking on top of Hyper-V. These > functions would allow somebody trying to make their NIC driver work on top of > Hy

[PATCH 3/3] staging: unisys: Don't hold device responses until driver loads

2015-06-12 Thread Benjamin Romer
From: David Kershner Currently if a driver is not loaded for a device, we will not respond to the device create until it is done. This causes s-Par to not mark the partition running if the driver for the device is not loaded. Since there are several devices that could be assigned to a guest that

[PATCH 1/3] staging: unisys: Move phys_info to iochannel.h

2015-06-12 Thread Benjamin Romer
From: David Kershner This moves phys_info to iochannel.h. It is only used by iochannel.h and is not needed in vmcallinterfaces.h. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/iochannel.h| 7 +++ drivers/staging/unisys/visorbus/vmc

[PATCH 0/3] staging: unisys: visorbus fixes

2015-06-12 Thread Benjamin Romer
This series contains fixes for problems found while testing visorbus. David Kershner (3): staging: unisys: Move phys_info to iochannel.h staging: unisys: convert pack pragma to __packed staging: unisys: Don't hold device responses until driver loads drivers/staging/unisys/include/iochannel

[PATCH 2/3] staging: unisys: convert pack pragma to __packed

2015-06-12 Thread Benjamin Romer
From: David Kershner It was noticed that iochannel.h was still using pragmas to pack the datastructures, should be using __packed instead. Signed-off-by: David Kershner Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/iochannel.h | 45 +- 1 file cha

Re: [PATCH 5/7] staging: rtl8723au: issue_probersp(): remove unused parameter

2015-06-12 Thread Jes Sorensen
Luca Ceresoli writes: > The is_valid_p2p_probereq is never referenced in the function body. > > Signed-off-by: Luca Ceresoli > Cc: Greg Kroah-Hartman > Cc: Jes Sorensen > Cc: Larry Finger > --- > drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 8 +++- > 1 file changed, 3 insertions(+), 5

Re: [PATCH 2/3] staging: unisys: convert pack pragma to __packed

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 01:43:33PM -0400, Benjamin Romer wrote: > From: David Kershner > > It was noticed that iochannel.h was still using pragmas to > pack the datastructures, should be using __packed instead. > > Signed-off-by: David Kershner > Signed-off-by: Benjamin Romer > --- > drivers/

Re: [PATCH 2/3] staging: unisys: convert pack pragma to __packed

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 01:43:33PM -0400, Benjamin Romer wrote: > From: David Kershner > > It was noticed that iochannel.h was still using pragmas to > pack the datastructures, should be using __packed instead. > > Signed-off-by: David Kershner > Signed-off-by: Benjamin Romer > --- > drivers/

Re: [PATCH 1/3] staging: unisys: Move phys_info to iochannel.h

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 01:43:32PM -0400, Benjamin Romer wrote: > From: David Kershner > > This moves phys_info to iochannel.h. It is only > used by iochannel.h and is not needed in > vmcallinterfaces.h. > > Signed-off-by: David Kershner > Signed-off-by: Benjamin Romer > --- > drivers/staging

Re: [PATCH 3/3] staging: unisys: Don't hold device responses until driver loads

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 01:43:34PM -0400, Benjamin Romer wrote: > From: David Kershner > > Currently if a driver is not loaded for a device, we will not > respond to the device create until it is done. This causes > s-Par to not mark the partition running if the driver for the > device is not loa

Re: [PATCH 0/3] staging: unisys: visorbus fixes

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 01:43:31PM -0400, Benjamin Romer wrote: > This series contains fixes for problems found while testing visorbus. > > David Kershner (3): > staging: unisys: Move phys_info to iochannel.h > staging: unisys: convert pack pragma to __packed > staging: unisys: Don't hold de

RE: [PATCH 0/3] staging: unisys: visorbus fixes

2015-06-12 Thread Kershner, David A
Will do. Thanks. David Kershner > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Friday, June 12, 2015 2:11 PM > To: Romer, Benjamin M > Cc: jes.soren...@redhat.com; driverdev-devel@linuxdriverproject.org; *S- > Par-Maintainer > Subject: Re: [PATCH 0/3]

[PATCH] staging: comedi: replace ENOSYS by proper error codes

2015-06-12 Thread julien . dehee
From: Julien Dehee comedi/comedi_fops.c use ENODEV following open manual comedi/drivers.c use ENOTTY following ioctl manual drivers/serial2002.c use ENOTTY following ioctl manual Signed-off-by: Julien Dehee --- drivers/staging/comedi/comedi_fops.c| 2 +- drivers/staging/c

Re: [PATCH] staging: comedi: replace ENOSYS by proper error codes

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.de...@gmail.com wrote: > From: Julien Dehee > > comedi/comedi_fops.c > use ENODEV following open manual > > comedi/drivers.c > use ENOTTY following ioctl manual > > drivers/serial2002.c > use ENOTTY following ioctl manual What do you

[PATCH v2 1/3] staging: unisys: Move phys_info to iochannel.h

2015-06-12 Thread David Kershner
This moves phys_info to iochannel.h. It is only used by iochannel.h and is not needed in vmcallinterfaces.h. Signed-off-by: David Kershner --- drivers/staging/unisys/include/iochannel.h| 6 ++ drivers/staging/unisys/visorbus/vmcallinterface.h | 12 2 files changed, 6 in

[PATCH v2 3/3] staging: unisys: Don't hold device responses until driver loads

2015-06-12 Thread David Kershner
Currently if a driver is not loaded for a device, we will not respond to the device create until it is done. This causes s-Par to not mark the partition running if the driver for the device is not loaded. Since there are several devices that could be assigned to a guest that don't have an actual dr

[PATCH v2 0/3] staging: unisys: visorbus fixes

2015-06-12 Thread David Kershner
This series contains fixes for problems found while testing visorbus. v2 Updates: patch 1: made phys_info __packed coming into iochannel.h patch 2: Fixed up extra line and comments patch 3: Incorporated comments from gregkh. David Kershner (3): staging: unisys: Move p

[PATCH v2 2/3] staging: unisys: convert pack pragma to __packed

2015-06-12 Thread David Kershner
It was noticed that iochannel.h was still using pragmas to pack the datastructures, should be using __packed instead. Signed-off-by: David Kershner --- drivers/staging/unisys/include/iochannel.h | 45 -- 1 file changed, 18 insertions(+), 27 deletions(-) diff --git a/

Re: [PATCH] staging: comedi: replace ENOSYS by proper error codes

2015-06-12 Thread One Thousand Gnomes
On Fri, 12 Jun 2015 13:43:27 -0700 Greg KH wrote: > On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.de...@gmail.com wrote: > > From: Julien Dehee > > > > comedi/comedi_fops.c > > use ENODEV following open manual That should probably be ENXIO by a strict reading, but Linux has always used

[PATCH 0/6] staging: fbtft: style fixes

2015-06-12 Thread Anton Gerasimov
Several style patches (mostly breaking long lines and deleting line continuations). Anton Gerasimov (6): staging: fbtft: style fix on flexfb.c staging: fbtft: style fix on fb_tls8204.c staging: fbtft: style fix on fb_tinylcd.c staging: fbtft: style fix on fbtft_device.c staging: fbtft:

[PATCH 2/6] staging: fbtft: style fix on fb_tls8204.c

2015-06-12 Thread Anton Gerasimov
Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fb_tls8204.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fbtft/fb_tls8204.c b/drivers/staging/fbtft/fb_tls8204.c index 5ea73b5..3253a25 100644 --- a/drivers/staging/fbtft/fb_tls8204.c +++

[PATCH 1/6] staging: fbtft: style fix on flexfb.c

2015-06-12 Thread Anton Gerasimov
Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/flexfb.c | 281 ++--- 1 file changed, 209 insertions(+), 72 deletions(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c index ca39fe9..82c96fc 100644 --- a/drivers/staging/f

[PATCH 3/6] staging: fbtft: style fix on fb_tinylcd.c

2015-06-12 Thread Anton Gerasimov
Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fb_tinylcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c index c0b1a33..8ab177f 100644 --- a/drivers/staging/fbtft/fb_tinylcd.c +++ b/drivers/s

Re: [PATCH] staging: comedi: replace ENOSYS by proper error codes

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 10:06:16PM +0100, One Thousand Gnomes wrote: > On Fri, 12 Jun 2015 13:43:27 -0700 > Greg KH wrote: > > > On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.de...@gmail.com wrote: > > > From: Julien Dehee > > > > > > comedi/comedi_fops.c > > > use ENODEV following open

[PATCH 4/6] staging: fbtft: style fix on fbtft_device.c

2015-06-12 Thread Anton Gerasimov
Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fbtft_device.c | 54 +--- 1 file changed, 25 insertions(+), 29 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index df6cd77..211d504 100644 --- a/drive

[PATCH 5/6] staging: fbtft: style fix on fb_ra8875.c

2015-06-12 Thread Anton Gerasimov
Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fb_ra8875.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fbtft/fb_ra8875.c b/drivers/staging/fbtft/fb_ra8875.c index 2c4d4dc..54bc566 100644 --- a/drivers/staging/fbtft/fb_ra8875.c +++ b

[PATCH 6/6] staging: fbtft: style fix on fb_ili9320.c

2015-06-12 Thread Anton Gerasimov
Signed-off-by: Anton Gerasimov --- drivers/staging/fbtft/fb_ili9320.c | 118 +++-- 1 file changed, 88 insertions(+), 30 deletions(-) diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb_ili9320.c index 3a02edd..0301bd5 100644 --- a/drivers/s

Re: [PATCH] staging: comedi: replace ENOSYS by proper error codes

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 03:26:26PM -0700, Greg KH wrote: > On Fri, Jun 12, 2015 at 10:06:16PM +0100, One Thousand Gnomes wrote: > > On Fri, 12 Jun 2015 13:43:27 -0700 > > Greg KH wrote: > > > > > On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.de...@gmail.com wrote: > > > > From: Julien Dehee >

[PATCH 09/17] staging/lirc_serial: Remove TSC-based timing

2015-06-12 Thread Andy Lutomirski
It wasn't compiled in by default. I suspect that the driver was and still is broken, though -- it's calling udelay with a parameter that's derived from loops_per_jiffy. Cc: Jarod Wilson Cc: de...@driverdev.osuosl.org Cc: Greg Kroah-Hartman Signed-off-by: Andy Lutomirski --- drivers/staging/me

[PATCH v2 09/17] staging/lirc_serial: Remove TSC-based timing

2015-06-12 Thread Andy Lutomirski
It wasn't compiled in by default. I suspect that the driver was and still is broken, though -- it's calling udelay with a parameter that's derived from loops_per_jiffy. Cc: Jarod Wilson Cc: de...@driverdev.osuosl.org Cc: Greg Kroah-Hartman Signed-off-by: Andy Lutomirski --- drivers/staging/me

Re: [PATCH V2 01/10] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable

2015-06-12 Thread Greg KH
On Thu, Jun 04, 2015 at 04:26:07PM -0700, K. Y. Srinivasan wrote: > From: Vitaly Kuznetsov > > Loaded Hyper-V module will use these functions to disable CPU > hotplug under certain circumstances. Convert cpu_hotplug_disabled > to a counter (protected by cpu_add_remove_lock) to support e.g. > disa

Re: [PATCH] staging: comedi: cb_pcimdas: fix handlers for DI and DO subdevices

2015-06-12 Thread Greg Kroah-Hartman
On Fri, Jun 12, 2015 at 04:37:41PM +0100, Ian Abbott wrote: > Normally, low-level Comedi drivers set an `insn_bits` handler for > digital input (DI), digital output (DO) and digital input/output (DIO) > subdevice types to handle normal reading and writing of digital > channels. The "cb_pcimdas" dr

Re: [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 04:46:07PM -0400, David Kershner wrote: > It was noticed that iochannel.h was still using pragmas to > pack the datastructures, should be using __packed instead. > > Signed-off-by: David Kershner > --- > drivers/staging/unisys/include/iochannel.h | 45 > -

Re: [PATCH 1/6] staging: fbtft: style fix on flexfb.c

2015-06-12 Thread Greg KH
On Sat, Jun 13, 2015 at 01:06:41AM +0300, Anton Gerasimov wrote: > Signed-off-by: Anton Gerasimov I need a changelog body for this, and all of the other patches in this series. Describe what you are doing, "style fix" isn't very descriptive at all :( Please fix up all of these and resend. than

Re: [PATCH] staging: vt6656: Boolean tests don't need comparisons.

2015-06-12 Thread gre...@linuxfoundation.org
On Thu, Jun 11, 2015 at 09:36:58AM +, Abdul, Hussain (H.) wrote: > This patch remove true and false from boolean tests. > > Signed-off-by: Abdul Hussain > --- Please fix the From: issue :( ___ devel mailing list de...@linuxdriverproject.org http://

Re: [PATCH] staging: vt6655: Boolean tests don't need comparisons

2015-06-12 Thread gre...@linuxfoundation.org
On Fri, Jun 12, 2015 at 07:20:49AM +, Abdul, Hussain (H.) wrote: > From: Abdul Hussain > > This patch removes unwanted true from boolean tests. > > Signed-off-by: Abdul Hussain > --- > drivers/staging/vt6655/rxtx.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Someone fr

Re: [PATCH v4 0/7] staging: fsl-mc: New functionality to the MC bus driver

2015-06-12 Thread Greg KH
On Tue, Jun 09, 2015 at 04:59:01PM -0500, J. German Rivera wrote: > This patch series includes new functionality for the Freescale fsl-mc > bus driver. Why are people working on "new functionality" instead of working on getting this out of the staging tree? I really hate adding new functions to s

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

2015-06-12 Thread Greg Kroah-Hartman
On Thu, May 28, 2015 at 03:07:05PM +0300, Dmitry Kalinkin wrote: > This introduces a new dma device that provides a single ioctl call that > provides DMA read and write functionality to the user space. > > Signed-off-by: Dmitry Kalinkin > Cc: Igor Alekseev > --- > drivers/staging/vme/devices/vm

Re: [PATCHv3 16/16] vme: provide uapi header

2015-06-12 Thread Greg Kroah-Hartman
On Thu, May 28, 2015 at 03:07:13PM +0300, Dmitry Kalinkin wrote: > This separates VME related constants that are a part of both kernel and > user space API into a common uapi header. Why? We don't want non-userspace things in the uapi header file, that's not needed and just exports things to user

Re: [PATCHv3 00/16] vme DMA and user space driver improvements

2015-06-12 Thread Greg Kroah-Hartman
On Wed, Jun 10, 2015 at 04:09:19PM +0300, Dmitry Kalinkin wrote: > On Sun, May 31, 2015 at 6:06 AM, Greg Kroah-Hartman > wrote: > > On Thu, May 28, 2015 at 03:06:57PM +0300, Dmitry Kalinkin wrote: > >> The first item in this submission documents previously introduced > >> vme_master_mmap() call. F

Re: [PATCHv3 00/16] vme DMA and user space driver improvements

2015-06-12 Thread Dmitry Kalinkin
On Sat, Jun 13, 2015 at 3:31 AM, Greg Kroah-Hartman wrote: > On Wed, Jun 10, 2015 at 04:09:19PM +0300, Dmitry Kalinkin wrote: >> Also, there are some patches that IMO don't need any special VME >> subsystem expertise, namely: >> Documentation: mention vme_master_mmap() in VME API >> vme: ca91c

Re: [PATCHv3 00/16] vme DMA and user space driver improvements

2015-06-12 Thread Greg Kroah-Hartman
On Sat, Jun 13, 2015 at 05:04:28AM +0300, Dmitry Kalinkin wrote: > On Sat, Jun 13, 2015 at 3:31 AM, Greg Kroah-Hartman > wrote: > > On Wed, Jun 10, 2015 at 04:09:19PM +0300, Dmitry Kalinkin wrote: > >> Also, there are some patches that IMO don't need any special VME > >> subsystem expertise, namel

Re: [PATCHv3 00/16] vme DMA and user space driver improvements

2015-06-12 Thread Dmitry Kalinkin
> On 13 Jun 2015, at 05:24, Greg Kroah-Hartman > wrote: > > On Sat, Jun 13, 2015 at 05:04:28AM +0300, Dmitry Kalinkin wrote: >> On Sat, Jun 13, 2015 at 3:31 AM, Greg Kroah-Hartman >> wrote: >> I thought 12 was the most harmless out of the whole set. Am I wrong? > > You added a new userspace a

[PATCH] staging: unisys: cleanup iochannel includes

2015-06-12 Thread David Kershner
The iochannel.h file no longer needs to include conttrolvmchannel.h, vbuschannel.h and vmcallinterfaces.h. Signed-off-by: David Kershner --- drivers/staging/unisys/include/iochannel.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/unisys/include/iochannel.h b/drivers/s

[staging:staging-testing 787/862] arch/m68k/include/asm/irq.h:77:12: error: expected '=', ',', '; ', 'asm' or '__attribute__' before 'void'

2015-06-12 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 5c10439849f75e408112d5f1696623b2fae5a500 commit: 12c41f001015eb00fff6c677a2d83332cfd2c8b9 [787/862] staging:lustre: merge socklnd_lib-linux.h into socklnd.h config: m68k-allmodconfig (attached as .con

Re: [PATCHv3 00/16] vme DMA and user space driver improvements

2015-06-12 Thread Greg Kroah-Hartman
On Sat, Jun 13, 2015 at 05:30:09AM +0300, Dmitry Kalinkin wrote: > > > On 13 Jun 2015, at 05:24, Greg Kroah-Hartman > > wrote: > > > > On Sat, Jun 13, 2015 at 05:04:28AM +0300, Dmitry Kalinkin wrote: > >> On Sat, Jun 13, 2015 at 3:31 AM, Greg Kroah-Hartman > >> wrote: > >> I thought 12 was the

Re: [staging:staging-testing 787/862] arch/m68k/include/asm/irq.h:77:12: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'

2015-06-12 Thread Greg Kroah-Hartman
John, please send a fix for this. thanks, greg k-h On Sat, Jun 13, 2015 at 11:19:15AM +0800, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 5c10439849f75e408112d5f1696623b2fae5a500 > commit: 12c41f001015eb00fff6c6

[PATCH 2/2] staging: wilc1000: remove itypes.h

2015-06-12 Thread Chaehyun Lim
Remove itypes.h that is not needed. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 1 - drivers/staging/wilc1000/host_interface.c | 1 - drivers/staging/wilc1000/itypes.h | 39 - 3 files changed, 41 deletions(-) delete mod

[PATCH 1/2] staging: wilc1000: remove BOOL_T typedef

2015-06-12 Thread Chaehyun Lim
Remove BOOL_T typedef. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 6 +++--- drivers/staging/wilc1000/itypes.h | 9 - 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1