On Fri, Jun 12, 2015 at 01:43:32PM -0400, Benjamin Romer wrote:
> From: David Kershner <david.kersh...@unisys.com>
> 
> This moves phys_info to iochannel.h. It is only
> used by iochannel.h and is not needed in
> vmcallinterfaces.h.
> 
> Signed-off-by: David Kershner <david.kersh...@unisys.com>
> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com>
> ---
>  drivers/staging/unisys/include/iochannel.h        |  7 +++++++
>  drivers/staging/unisys/visorbus/vmcallinterface.h | 12 ------------
>  2 files changed, 7 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/unisys/include/iochannel.h 
> b/drivers/staging/unisys/include/iochannel.h
> index cbb5875..db7b332 100644
> --- a/drivers/staging/unisys/include/iochannel.h
> +++ b/drivers/staging/unisys/include/iochannel.h
> @@ -149,6 +149,13 @@ enum vdisk_mgmt_types {
>  
>  /* structs with pragma pack  */
>  
> +#pragma pack(push, 1)
> +struct phys_info {
> +     u64 pi_pfn;
> +     u16 pi_off;
> +     u16 pi_len;
> +};
> +#pragma pack(pop)

Use the __packed macro instead please, don't introduce something only to
fix it up later.  Especially when you are not following the rules in
this file as described on the next line:

>  /* ///////////// BEGIN PRAGMA PACK PUSH 1 ///////////////////////// */
>  /* ///////////// ONLY STRUCT TYPE SHOULD BE BELOW */

See?

Do it right the first time please.

thanks,

greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to