On Tue, Apr 07, 2015 at 11:19:53AM +0300, Dan Carpenter wrote:
> On Tue, Apr 07, 2015 at 11:17:48AM +0300, Dan Carpenter wrote:
> > This patch changes the lock ordering (behavior change) and it's not
> > described in the changelog. Please figure out which way is the correct
> > ordering and resend
both the misc_deregister(), parport_release() and
parport_unregister_device() is there in the module_exit function also.
detach is called from parport_unregister_driver() and by the time
detach executes misc_deregister(), parport_release() and
parport_unregister_device() has already executed markin
On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote:
> both the misc_deregister(), parport_release() and
> parport_unregister_device() is there in the module_exit function also.
> detach is called from parport_unregister_driver() and by the time
> detach executes misc_deregister(), parp
On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote:
> On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote:
>
> I hadn't looked at this driver much before. It sucks that
> parport_driver ->attach() functions can't fail...
then maybe, we can change the code of parport. curr
On Mon, Apr 06, 2015 at 10:02:27PM -0400, Nickolaus Woodruff wrote:
> This patch fixes the following sparse warning:
>
> CHECK drivers/staging/lustre/lustre/libcfs/hash.c
> drivers/staging/lustre/lustre/libcfs/hash.c:119:21: warning: symbol
> 'cfs_sched_rehash' was not declared. Should it be sta
On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote:
> On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote:
> > On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote:
> >
> > I hadn't looked at this driver much before. It sucks that
> > parport_driver ->attach() fu
On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote:
> On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote:
> > On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote:
> >
> > I hadn't looked at this driver much before. It sucks that
> > parport_driver ->attach() fu
On Tue, Apr 07, 2015 at 11:44:29AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote:
> > On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote:
> > > On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote:
> > >
> > > I hadn't look
On Tue, Apr 07, 2015 at 03:26:58PM +0530, Sudip Mukherjee wrote:
> On Tue, Apr 07, 2015 at 11:44:29AM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote:
> > > On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote:
> > > > On Tue, Apr 07, 20
kzalloc() could fail so add a check and return -ENOMEM if it does that gets
propogated to the pci layer
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_tty.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
On Tue, Apr 07, 2015 at 12:45:23PM +0300, Dan Carpenter wrote:
> On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote:
>
> If you write the patch then I will review it. :)
sure, I am on it.
>
> > lack of ppscsi.I mailed Tim Waugh, but he is not interested to work
> > with ppscsi any
On Tue, Apr 07, 2015 at 01:26:32PM +0300, Giedrius Statkevičius wrote:
> kzalloc() could fail so add a check and return -ENOMEM if it does that gets
> propogated to the pci layer
>
> Signed-off-by: Giedrius Statkevičius
> ---
> drivers/staging/dgnc/dgnc_tty.c | 2 ++
> 1 file changed, 2 insertio
On Tue, 7 Apr 2015, Sudip Mukherjee wrote:
> On Tue, Apr 07, 2015 at 01:26:32PM +0300, Giedrius Statkevičius wrote:
> > kzalloc() could fail so add a check and return -ENOMEM if it does that gets
> > propogated to the pci layer
> >
> > Signed-off-by: Giedrius Statkevičius
> > ---
> > drivers/st
If one of the allocations of memory for storing a channel information struct
fails then free all the successful allocations and return -ENOMEM that gets
propogated to the pci layer. Also, remove a bogus skipping in the next part of
the initiation if a previous memory allocation failed because we w
On Tue, Apr 07, 2015 at 03:40:17PM +0300, Giedrius Statkevičius wrote:
> If one of the allocations of memory for storing a channel information struct
> fails then free all the successful allocations and return -ENOMEM that gets
> propogated to the pci layer. Also, remove a bogus skipping in the ne
On Mon, Apr 6, 2015 at 2:40 AM, Simon Horman wrote:
> On Fri, Apr 03, 2015 at 02:41:58PM +0200, Geert Uytterhoeven wrote:
>> This reverts commit d13778d537a0ed6115d2a79a942af999cfb8eec6.
>>
>> Commit 13c11072536f2613 ("staging:board: remove unnecessary function")
>> fixed the build of drivers/stag
On Tue, 7 Apr 2015, Dan Carpenter wrote:
> On Tue, Apr 07, 2015 at 03:40:17PM +0300, Giedrius Statkevičius wrote:
> > If one of the allocations of memory for storing a channel information struct
> > fails then free all the successful allocations and return -ENOMEM that gets
> > propogated to the p
Hi Greg,
I saw that you have reveretd one commit
<6ad6b5ed3e2472b399b567a2f036006bf25df467>
"Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
I was trying to search for that patch, but it seems I am not able to
find that in my personal mails nor in lkml. can you please let me know
when it wa
On Tue, Apr 7, 2015 at 10:56 AM, Sudip Mukherjee
wrote:
> Hi Greg,
> I saw that you have reveretd one commit
> <6ad6b5ed3e2472b399b567a2f036006bf25df467>
> "Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
> I was trying to search for that patch, but it seems I am not able to
> find that in
On Tue, Apr 07, 2015 at 11:01:57AM -0300, Fabio Estevam wrote:
> On Tue, Apr 7, 2015 at 10:56 AM, Sudip Mukherjee
> wrote:
> > Hi Greg,
> > I saw that you have reveretd one commit
> > <6ad6b5ed3e2472b399b567a2f036006bf25df467>
> > "Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
> > I was
If one of the allocations of memory for storing a channel information struct
fails then free all the successful allocations and return -ENOMEM that gets
propogated to the pci layer. Also, remove a bogus skipping in the next part of
the initiation if a previous memory allocation failed because we w
On Tue, Apr 07, 2015 at 12:12:06PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 07, 2015 at 03:26:58PM +0530, Sudip Mukherjee wrote:
> > On Tue, Apr 07, 2015 at 11:44:29AM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote:
> > > > On Tue, Apr 0
On Tue, Apr 07, 2015 at 04:14:59PM +0200, Willy Tarreau wrote:
> > > > > now. do you think it is worth that i pick up the code and modify
> > > > > it for our latest kernel and submit to Greg ?
> > > >
> > > > If you have some parport hardware, and want to take it on, that would be
> > > > great.
On Tue, Apr 07, 2015 at 05:11:15PM +0300, Giedrius Statkevičius wrote:
> If one of the allocations of memory for storing a channel information struct
> fails then free all the successful allocations and return -ENOMEM that gets
> propogated to the pci layer. Also, remove a bogus skipping in the ne
This change was detected with the help of coccinelle tool.
It performs the same function as kzalloc amd memcpy.
Signed-off-by: Chaitanya Dhere
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core
On Tue, Apr 7, 2015 at 11:08 AM, Sudip Mukherjee
wrote:
>> Just run 'git show 6ad6b5ed3e247' in linux-next and you can see such commit.
> I have already seen the patch. But being the maintainer of that driver
> i hold myself responsible for missing a new file creation in a patch.
> So i was tryin
On Tue, Apr 07, 2015 at 11:24:43AM -0300, Fabio Estevam wrote:
> On Tue, Apr 7, 2015 at 11:08 AM, Sudip Mukherjee
> wrote:
>
> >> Just run 'git show 6ad6b5ed3e247' in linux-next and you can see such
> >> commit.
> > I have already seen the patch. But being the maintainer of that driver
> > i hol
On Tue, Apr 07, 2015 at 07:51:17PM +0530, Sudip Mukherjee wrote:
> On Tue, Apr 07, 2015 at 04:14:59PM +0200, Willy Tarreau wrote:
> > Not-so-old laptops used to have parport connectors for a while, and can be
> > found at a very cheap price or even for free by now with dead batteries.
> free laptop
On Tue, 7 Apr 2015, Sudip Mukherjee wrote:
> On Tue, Apr 07, 2015 at 05:11:15PM +0300, Giedrius Statkevičius wrote:
> > If one of the allocations of memory for storing a channel information struct
> > fails then free all the successful allocations and return -ENOMEM that gets
> > propogated to the
On Tue, Apr 07, 2015 at 12:12:06PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 07, 2015 at 03:26:58PM +0530, Sudip Mukherjee wrote:
> > On Tue, Apr 07, 2015 at 11:44:29AM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote:
> > > > On Tue, Apr 0
On Tue, Apr 07, 2015 at 07:26:53PM +0530, Sudip Mukherjee wrote:
> Hi Greg,
> I saw that you have reveretd one commit
> <6ad6b5ed3e2472b399b567a2f036006bf25df467>
> "Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
> I was trying to search for that patch, but it seems I am not able to
> find
You will need to update the subject to reflect the new patch.
The original code did check for kzalloc() failure but it had lots of
checks scattered around instead nicely at the point where the memory
was allocated.
The old code and the new code are both buggy though and will crash in
dgnc_tty_uni
If you send a patch series then it's ok that later patches depend on the
earlier patches.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Apr 07, 2015 at 04:34:54PM +0200, Greg KH wrote:
> On Tue, Apr 07, 2015 at 07:26:53PM +0530, Sudip Mukherjee wrote:
> > Hi Greg,
> > I saw that you have reveretd one commit
> > <6ad6b5ed3e2472b399b567a2f036006bf25df467>
> > "Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
> > I was
On Tue, Apr 07, 2015 at 08:31:44PM +0530, Sudip Mukherjee wrote:
> On Tue, Apr 07, 2015 at 04:34:54PM +0200, Greg KH wrote:
> > On Tue, Apr 07, 2015 at 07:26:53PM +0530, Sudip Mukherjee wrote:
> > > Hi Greg,
> > > I saw that you have reveretd one commit
> > > <6ad6b5ed3e2472b399b567a2f036006bf25df4
On Tue, 7 Apr 2015, Dan Carpenter wrote:
> You will need to update the subject to reflect the new patch.
>
> The original code did check for kzalloc() failure but it had lots of
> checks scattered around instead nicely at the point where the memory
> was allocated.
>
There are a lot missing too
On Tue, Apr 07, 2015 at 06:35:51PM +0300, Giedrius Statkevičius wrote:
> Well, the point of the patch is to put alloc and checks in one place to make
> the
> code less error and bug prone and fix some of bugs where ->channels[i] isn't
> checked.
Fine, fine. I can accept that. One patch is also
If you checked the code, you would see that it's used in
drivers/staging/lustre/lustre/libcfs/module.c too.
drivers/staging/lustre/lustre/libcfs/module.c:extern struct cfs_wi_sched
*cfs_sched_rehash;
drivers/staging/lustre/lustre/libcfs/module.c: rc,
&cfs_sched_rehash)
Check if kzalloc fails in dgnc_tty_init() and if it does then free all
previously allocated ->channels[i] and set them to NULL. This makes the code
less error/bug prone because instead of needing programmers attention to add
checks everywhere we do that in one place. Also, remove a bogus comment an
Remove checks that are redundant since we don't have boards with partially
initialized ->channels[i].
Signed-off-by: Giedrius Statkevičius
---
v4: splitted this from the one patch.
drivers/staging/dgnc/dgnc_cls.c | 4 ++--
drivers/staging/dgnc/dgnc_neo.c | 2 +-
2 files changed, 3 insertions(+)
Add a check if ->channels[i] is NULL because a NULL pointer may be dereferenced
in case one of the allocations failed
Reported-by: Dan Carpenter
Signed-off-by: Giedrius Statkevičius
---
v4: new patch that fixes a bug reported by Dan Carpenter
drivers/staging/dgnc/dgnc_tty.c | 8 ++--
1 fil
Signed-off-by: Marcus Folkesson
---
drivers/staging/fbtft/fbtft-core.c | 2 +-
drivers/staging/fbtft/fbtft-io.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/staging/fbtft/fbtft-core.c
index 37dcf7e..b82870b 100644
--- a/d
From: Haiyang Zhang
Date: Mon, 6 Apr 2015 15:22:52 -0700
> Signed-off-by: Haiyang Zhang
> Reviewed-by: K. Y. Srinivasan
Applied.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-d
From: Haiyang Zhang
Date: Mon, 6 Apr 2015 15:22:53 -0700
> The sum of RNDIS msg and PPI struct sizes is used in multiple places, so we
> define
> a macro for them.
>
> Signed-off-by: Haiyang Zhang
> Reviewed-by: K. Y. Srinivasan
Applied.
___
devel
From: Haiyang Zhang
Date: Mon, 6 Apr 2015 15:22:54 -0700
> In the two places changed, we now use netvsc_xmit_completion() which properly
> frees hv_netvsc_packet in or not in skb headroom.
>
> Signed-off-by: Haiyang Zhang
> Reviewed-by: K. Y. Srinivasan
Applied.
_
This series of patches fixes another set of checkpatch.pl warnings.
Most of the patches are trivial, with the exception of #8, #7 and #5;
Driver logic should not be affected.
Some of the patches cause LONG_LINE warnings, but fix has to wait until
I do more driver refactorings (It's hard to keep l
Reformat r8192E_phyreg.h to make checkpatch happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 1442 ++---
1 file changed, 721 insertions(+), 721 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h
b/drivers/
Both files have the same contents (with the exception of comments).
One of them will not survive future commits.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 92 ---
1 file changed, 65 insertions(+), 27 deletions(-)
diff --git a/d
Trivial fix - add newline in dm_InitializeTXPowerTracking_TSSI()
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index c99
r8192_priv structure had 2 big arrays with tx gain register values:
- cck_txbbgain_table
- cck_txbbgain_ch14_table
- txbbgain_table
This arrays were read-only - filled in driver init code and look
like firmware/chip-specific.
This patch removes them from r8192_priv and puts them in (global) varia
This file is not used and its contents are duplicated in r8192E_phyreg.h.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h | 908 --
1 file changed, 908 deletions(-)
delete mode 100644 drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h
- Replace ?: with min_t
- Remove condition that is always true
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c
b/drivers/staging/rtl8192e/rt
Separate parts of dm_TXPowerTrackingCallback_TSSI() into two new functions:
- dm_tx_update_tssi_weak_signal()
- dm_tx_update_tssi_strong_signal()
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 176 +++--
1 file changed, 93 insertions(+)
Fix several SPACING errors to make checkpatch happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +-
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 +++---
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 6 +++---
drivers/staging/rtl8192e/rtllib_
On Tue, Apr 07, 2015 at 03:16:54PM +0200, Geert Uytterhoeven wrote:
> On Mon, Apr 6, 2015 at 2:40 AM, Simon Horman wrote:
> > On Fri, Apr 03, 2015 at 02:41:58PM +0200, Geert Uytterhoeven wrote:
> >> This reverts commit d13778d537a0ed6115d2a79a942af999cfb8eec6.
> >>
> >> Commit 13c11072536f2613 ("s
On Tue, Apr 07, 2015 at 02:25:39PM +, Dhere, Chaitanya (C.) wrote:
> This change was detected with the help of coccinelle tool.
> It performs the same function as kzalloc amd memcpy.
>
> Signed-off-by: Chaitanya Dhere
your From: name and this name does not match.
regards
sudip
_
Вашият имейл квота е почти надхвърлен.
Като се започне от 05 април, ние мигриране
към нов имейл интерфейс. Така че ние сме в
момента прави поддръжката на нашия
сървър. Моля, кликнете на линка по-долу,
за да въведете и актуализирате профила
си и да се избегне загубата на вашата
пощенска кутия.
= >>
Some people like to put parenthesis around stuff. It's harmless here.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
This patch changes the lock ordering (behavior change) and it's not
described in the changelog. Please figure out which way is the correct
ordering and resend.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.
On Tue, Apr 07, 2015 at 11:17:48AM +0300, Dan Carpenter wrote:
> This patch changes the lock ordering (behavior change) and it's not
> described in the changelog. Please figure out which way is the correct
> ordering and resend.
Actually the original ordering was obviously correct. You can't tak
60 matches
Mail list logo
