Re: [PATCH 2/3 v2] hyperv: hyperv_fb.c: match wait_for_completion_timeout return type

2015-01-29 Thread Nicholas Mc Guire
On Mon, 26 Jan 2015, Tomi Valkeinen wrote: > Hi, > > On 25/01/15 16:47, Nicholas Mc Guire wrote: > > Signed-off-by: Nicholas Mc Guire > > --- > > > > v2: fixed subject line > > > > The return type of wait_for_completion_timeout is unsigned long not > > int. This patch fixes up the declarations

Re: [PATCH 2/3 v2] hyperv: hyperv_fb.c: match wait_for_completion_timeout return type

2015-01-29 Thread Dan Carpenter
On Thu, Jan 29, 2015 at 10:38:39AM +0100, Nicholas Mc Guire wrote: > On Mon, 26 Jan 2015, Tomi Valkeinen wrote: > > > Hi, > > > > On 25/01/15 16:47, Nicholas Mc Guire wrote: > > > Signed-off-by: Nicholas Mc Guire > > > --- > > > > > > v2: fixed subject line > > > > > > The return type of wait_

[PATCH 1/3] hv: hv_util: move vmbus_open() to a later place

2015-01-29 Thread Dexuan Cui
Before the line vmbus_open() returns, srv->util_cb can be already running and the variablies, like util_fw_version, are needed by the srv->util_cb. So we have to make sure the variables are initialized before the vmbus_open(). CC: "K. Y. Srinivasan" Signed-off-by: Dexuan Cui --- drivers/hv/hv_

[PATCH 2/3] hv: vmbus_post_msg: retry the hypercall on HV_STATUS_INVALID_CONNECTION_ID

2015-01-29 Thread Dexuan Cui
I got the hypercall error code on Hyper-V 2008 R2 when keeping running "rmmod hv_netvsc; modprobe hv_netvsc; rmmod hv_utils; modprobe hv_utils" in a Linux guest. Without the patch, the driver can occasionally fail to load. CC: "K. Y. Srinivasan" Signed-off-by: Dexuan Cui --- arch/x86/include/u

[PATCH 3/3] hv: vmbus_open(): reset the channel state on ENOMEM

2015-01-29 Thread Dexuan Cui
Without this patch, the state is put to CHANNEL_OPENING_STATE, and when the driver is loaded next time, vmbus_open() will fail immediately due to newchannel->state != CHANNEL_OPEN_STATE. CC: "K. Y. Srinivasan" Signed-off-by: Dexuan Cui --- drivers/hv/channel.c | 8 +--- 1 file changed, 5 in

Re: [PATCH 2/3] staging/nvec: reimplement on top of tegra i2c driver

2015-01-29 Thread Marc Dietrich
Am Donnerstag, 29. Januar 2015, 10:20:21 schrieb Andrey Danin: > Remove i2c controller related code and use tegra i2c driver in slave mode. the diff is hard to review. Maybe it would be better to first ifdef 0 the old code (isr and init) while adding the new code, and then remove the old code in

Re: [PATCH] staging/fwserial: use correct vendor/version IDs

2015-01-29 Thread Stefan Richter
On Jan 28 Clemens Ladisch wrote: > The driver was using the vendor ID 0xd00d1e from the FireWire core. > However, this ID was not registered, and invalid. > > Instead, use the vendor/version IDs that now are officially assigned to > firewire-serial: > https://ieee1394.wiki.kernel.org/index.php/IEE

RE: [PATCH v3 3/3] Drivers: hv: vmbus: serialize Offer and Rescind offer

2015-01-29 Thread Jason Wang
On Wed, Jan 28, 2015 at 7:57 PM, Dexuan Cui wrote: -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Tuesday, January 20, 2015 23:45 PM To: KY Srinivasan; de...@linuxdriverproject.org Cc: Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui; Jason Wa

RE: [PATCH v3 3/3] Drivers: hv: vmbus: serialize Offer and Rescind offer

2015-01-29 Thread Jason Wang
On Wed, Jan 28, 2015 at 8:51 PM, Dexuan Cui wrote: -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Wednesday, January 28, 2015 20:09 PM To: Dexuan Cui Cc: KY Srinivasan; de...@linuxdriverproject.org; Haiyang Zhang; linux- ker...@vger.kernel.org; Jas

Re: [PATCH v3 3/3] Drivers: hv: vmbus: serialize Offer and Rescind offer

2015-01-29 Thread Jason Wang
On Wed, Jan 28, 2015 at 9:09 PM, Vitaly Kuznetsov wrote: Dexuan Cui writes: -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Wednesday, January 28, 2015 20:09 PM To: Dexuan Cui Cc: KY Srinivasan; de...@linuxdriverproject.org; Haiyang Zhang; linux-

Re: [PATCH 2/3 v2] hyperv: hyperv_fb.c: match wait_for_completion_timeout return type

2015-01-29 Thread Nicholas Mc Guire
On Thu, 29 Jan 2015, Dan Carpenter wrote: > On Thu, Jan 29, 2015 at 10:38:39AM +0100, Nicholas Mc Guire wrote: > > On Mon, 26 Jan 2015, Tomi Valkeinen wrote: > > > > > Hi, > > > > > > On 25/01/15 16:47, Nicholas Mc Guire wrote: > > > > Signed-off-by: Nicholas Mc Guire > > > > --- > > > > > > >

Re: [PATCH RFC] staging: media: davinci_vpfe: drop condition with no effect

2015-01-29 Thread Lad, Prabhakar
On Mon, Jan 26, 2015 at 7:27 AM, Nicholas Mc Guire wrote: > As the if and else branch body are identical the condition has no effect and > can be dropped. > > Signed-off-by: Nicholas Mc Guire Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > --- > > As the if and the else branch of the inne

[PATCH 2/3 v3] hyperv: hyperv_fb.c: match wait_for_completion_timeout return type

2015-01-29 Thread Nicholas Mc Guire
The return type of wait_for_completion_timeout is unsigned long not int. This patch fixes up the declarations only. Signed-off-by: Nicholas Mc Guire --- v2: fixed subject line v3: fixed patch description as recommended by Dan Carpenter Patch was compile tested only for x86_64_defconfig + C

Re: [PATCH 2/3 v2] hyperv: hyperv_fb.c: match wait_for_completion_timeout return type

2015-01-29 Thread Tomi Valkeinen
On 29/01/15 11:38, Nicholas Mc Guire wrote: > On Mon, 26 Jan 2015, Tomi Valkeinen wrote: > >> Hi, >> >> On 25/01/15 16:47, Nicholas Mc Guire wrote: >>> Signed-off-by: Nicholas Mc Guire >>> --- >>> >>> v2: fixed subject line >>> >>> The return type of wait_for_completion_timeout is unsigned long n

Re: [PATCH 2/3 v2] hyperv: hyperv_fb.c: match wait_for_completion_timeout return type

2015-01-29 Thread Nicholas Mc Guire
On Thu, 29 Jan 2015, Tomi Valkeinen wrote: > On 29/01/15 11:38, Nicholas Mc Guire wrote: > > On Mon, 26 Jan 2015, Tomi Valkeinen wrote: > > > >> Hi, > >> > >> On 25/01/15 16:47, Nicholas Mc Guire wrote: > >>> Signed-off-by: Nicholas Mc Guire > >>> --- > >>> > >>> v2: fixed subject line > >>> > >

Re: [PATCH] staging: rtl8712: remove useless printing line

2015-01-29 Thread Dan Carpenter
On Wed, Jan 28, 2015 at 12:00:22PM +0200, Heba Aamer wrote: > This patch removes an unneeded call to printk. > Thanks. :) regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listi

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Dan Carpenter
On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote: > On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: > > On 01/28/2015 09:53 AM, Heba Aamer wrote: > > >This patch fixes the following checkpatch.pl warning: > > >Prefer ether_addr_copy() over memcpy() > > >if the Ethernet addr

Re: [PATCH v2 02/02] STAGING: Fix pcl818.c coding style issue: line over 80 characters

2015-01-29 Thread Ian Abbott
On 29/01/15 05:34, Simon Guo wrote: Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - line over 80 characters Signed-off-by: Simon Guo --- drivers/staging/comedi/drivers/pcl818.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) Reviewed-by: Ia

Re: [PATCH v2 01/02] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible

2015-01-29 Thread Ian Abbott
On 29/01/15 05:33, Simon Guo wrote: Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - code indent should use tabs where possible It is fixed by reformatting the comment block to usual comment style. And with the reformatting, following coding style problem is also fixed:

Re: [PATCH] staging: comedi: addi_apci_1500: fix array access out of bounds error

2015-01-29 Thread Ian Abbott
On 28/01/15 16:58, H Hartley Sweeten wrote: The private data 'pm', 'pt', and 'pp' array members hold the trigger mode parameters for ports A and B. Both ports are 8-bits and the arrays are 16-bits. Array index 0 defines the AND mode and index 1 the OR mode parameters for both ports. The valid tr

Re: [PATCH] staging: comedi: drivers: dt2814: Removed variables that is never used

2015-01-29 Thread Ian Abbott
On 28/01/15 22:33, Rickard Strandqvist wrote: Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/dr

Re: [PATCH] staging: comedi: drivers: dt2814: Removed variables that is never used

2015-01-29 Thread Ian Abbott
On 29/01/15 12:52, Ian Abbott wrote: On 28/01/15 22:33, Rickard Strandqvist wrote: Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strand

Re: [PATCH 2/3 v3] hyperv: hyperv_fb.c: match wait_for_completion_timeout return type

2015-01-29 Thread Vitaly Kuznetsov
Nicholas Mc Guire writes: > The return type of wait_for_completion_timeout is unsigned long not > int. This patch fixes up the declarations only. > > Signed-off-by: Nicholas Mc Guire I would be slightly better to remove ".c" from your subject like, anyway: Reviewed-by: Vitaly Kuznetsov > ---

Re: [PATCH 1/3] hv: hv_util: move vmbus_open() to a later place

2015-01-29 Thread Vitaly Kuznetsov
Dexuan Cui writes: > Before the line vmbus_open() returns, srv->util_cb can be already running > and the variablies, like util_fw_version, are needed by the srv->util_cb. > > So we have to make sure the variables are initialized before the vmbus_open(). > > CC: "K. Y. Srinivasan" > Signed-off-by

Re: [PATCH 3/3] hv: vmbus_open(): reset the channel state on ENOMEM

2015-01-29 Thread Vitaly Kuznetsov
Dexuan Cui writes: > Without this patch, the state is put to CHANNEL_OPENING_STATE, and when > the driver is loaded next time, vmbus_open() will fail immediately due to > newchannel->state != CHANNEL_OPEN_STATE. The patch makes sense, but I have one small doubt. We call vmbus_open from probe fun

Re: [PATCH 2/3] hv: vmbus_post_msg: retry the hypercall on HV_STATUS_INVALID_CONNECTION_ID

2015-01-29 Thread Vitaly Kuznetsov
Dexuan Cui writes: > I got the hypercall error code on Hyper-V 2008 R2 when keeping running > "rmmod hv_netvsc; modprobe hv_netvsc; rmmod hv_utils; modprobe hv_utils" > in a Linux guest. > > Without the patch, the driver can occasionally fail to load. > > CC: "K. Y. Srinivasan" > Signed-off-by:

Re: [PATCH] staging: comedi: drivers: dt2815: Removed variables that is never used

2015-01-29 Thread Ian Abbott
On 28/01/15 22:34, Rickard Strandqvist wrote: Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/dr

Re: [PATCH] staging: comedi: drivers: jr3_pci: Removed variables that is never used

2015-01-29 Thread Ian Abbott
On 28/01/15 22:35, Rickard Strandqvist wrote: Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/dr

Re: [PATCH] staging: comedi: drivers: mite: Removed variables that is never used

2015-01-29 Thread Ian Abbott
On 28/01/15 22:36, Rickard Strandqvist wrote: Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/dr

Re: [PATCH] staging: comedi: drivers: ni_atmio: Removed variables that is never used

2015-01-29 Thread Ian Abbott
On 28/01/15 22:37, Rickard Strandqvist wrote: Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/dr

Re: [PATCH] staging: comedi: drivers: ni_mio_cs: Removed variables that is never used

2015-01-29 Thread Ian Abbott
On 28/01/15 22:37, Rickard Strandqvist wrote: Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/dr

Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci3501: Removed variables that is never used

2015-01-29 Thread Ian Abbott
On 28/01/15 21:51, Rickard Strandqvist wrote: Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/dr

Re: [PATCH] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used

2015-01-29 Thread Ian Abbott
On 28/01/15 22:33, Rickard Strandqvist wrote: Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/dr

Re: [PATCH] staging: comedi: drivers: dyna_pci10xx: Removed variables that is never used

2015-01-29 Thread Ian Abbott
On 28/01/15 22:35, Rickard Strandqvist wrote: Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/dr

Re: [PATCH] staging: comedi: drivers: rtd520: Removed variables that is never used

2015-01-29 Thread Ian Abbott
On 28/01/15 22:38, Rickard Strandqvist wrote: Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/dr

Re: [PATCH] staging: comedi: drivers: usbduxsigma: Removed variables that is never used

2015-01-29 Thread Ian Abbott
On 28/01/15 22:39, Rickard Strandqvist wrote: Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/dr

Re: [PATCH] staging: comedi: drivers: usbduxsigma: Removed variables that is never used

2015-01-29 Thread Bernd Porr
Indeed. It can be completely removed. I was intending to speed up DIO reads during async acquisition but I decided against it because it would create unpredictable latencies. Thanks Ian for flagging it! /Bernd Ian Abbott wrote: On 28/01/15 22:39, Rickard Strandqvist wrote: Variable ar assig

[PATCH] staging: gdm724x: gdm_tty: Fix for possible null pointer dereference

2015-01-29 Thread Rickard Strandqvist
Fix a possible null pointer dereference, there is otherwise a risk of a possible null pointer dereference. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/gdm724x/gdm_tty.c |2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH] staging: lustre: include: lustre_update.h: Fix for possible null pointer dereference

2015-01-29 Thread Rickard Strandqvist
Fix a possible null pointer dereference, there is otherwise a risk of a possible null pointer dereference. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/lustre/lustre/include/lustre_update.h |4 +++- 1 file changed

[PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-29 Thread Rickard Strandqvist
Fix a possible null pointer dereference, there is otherwise a risk of a possible null pointer dereference. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/media/lirc/lirc_zilog.c |4 +--- 1 file changed, 1 insertion(

[PATCH] staging: rtl8192u: r8192U_core: Fix for possible null pointer dereference

2015-01-29 Thread Rickard Strandqvist
Fix a possible null pointer dereference, there is otherwise a risk of a possible null pointer dereference. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8192u/r8192U_core.c | 14 ++ 1 file changed, 10

[PATCH] staging: unisys: virtpci: virtpci: Fix for possible null pointer dereference

2015-01-29 Thread Rickard Strandqvist
Fix a possible null pointer dereference, there is otherwise a risk of a possible null pointer dereference. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/unisys/virtpci/virtpci.c | 20 ++-- 1 file chan

Re: [PATCH] staging: rtl8192u: r8192U_core: Fix for possible null pointer dereference

2015-01-29 Thread Rickard Strandqvist
2015-01-29 19:49 GMT+01:00 Rickard Strandqvist : > Fix a possible null pointer dereference, there is > otherwise a risk of a possible null pointer dereference. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/rt

[PATCH v2] staging: rtl8192u: r8192U_core: Fix for possible null pointer dereference

2015-01-29 Thread Rickard Strandqvist
Fix a possible null pointer dereference, there is otherwise a risk of a possible null pointer dereference. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8192u/r8192U_core.c |8 1 file changed, 4 inserti

[PATCH net] hyperv: Fix the error processing in netvsc_send()

2015-01-29 Thread Haiyang Zhang
The existing code frees the skb in EAGAIN case, in which the skb will be retried from upper layer and used again. Also, the existing code doesn't free send buffer slot in error case, because there is no completion message for unsent packets. This patch fixes these problems. (Please also include th

Re: [HPDD-discuss] [PATCH] staging: lustre: include: lustre_update.h: Fix for possible null pointer dereference

2015-01-29 Thread Frank Zago
On 01/29/2015 12:47 PM, Rickard Strandqvist wrote: Fix a possible null pointer dereference, there is otherwise a risk of a possible null pointer dereference. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/lustre/lust

Re: [HPDD-discuss] [PATCH] staging: lustre: include: lustre_update.h: Fix for possible null pointer dereference

2015-01-29 Thread Rickard Strandqvist
2015-01-29 20:40 GMT+01:00 Frank Zago : > On 01/29/2015 12:47 PM, Rickard Strandqvist wrote: >> >> Fix a possible null pointer dereference, there is >> otherwise a risk of a possible null pointer dereference. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off

Re: [HPDD-discuss] [PATCH] staging: lustre: include: lustre_update.h: Fix for possible null pointer dereference

2015-01-29 Thread Frank Zago
On 01/29/2015 01:47 PM, Rickard Strandqvist wrote: 2015-01-29 20:40 GMT+01:00 Frank Zago : On 01/29/2015 12:47 PM, Rickard Strandqvist wrote: Fix a possible null pointer dereference, there is otherwise a risk of a possible null pointer dereference. This was found using a static code analysis

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Aya Mahfouz
On Thu, Jan 29, 2015 at 02:51:57PM +0300, Dan Carpenter wrote: > On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote: > > On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: > > > On 01/28/2015 09:53 AM, Heba Aamer wrote: > > > >This patch fixes the following checkpatch.pl warning

Re: [HPDD-discuss] [PATCH] staging: lustre: include: lustre_update.h: Fix for possible null pointer dereference

2015-01-29 Thread Drokin, Oleg
Hello! On Jan 29, 2015, at 2:49 PM, Frank Zago wrote: @@ -165,12 +165,14 @@ static inline int update_get_reply_buf(struct update_reply *reply, void **buf, int result; ptr = update_get_buf_internal(reply, index, &size); + + LASSERT((ptr !=

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Larry Finger
On 01/29/2015 01:54 PM, Aya Mahfouz wrote: On Thu, Jan 29, 2015 at 02:51:57PM +0300, Dan Carpenter wrote: On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote: On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: On 01/28/2015 09:53 AM, Heba Aamer wrote: This patch fixes the f

[PATCH] staging: lustre: fid: lproc_fid: Improving error control

2015-01-29 Thread Rickard Strandqvist
Improving error checking by now use a return value from sscanf. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/lustre/lustre/fid/lproc_fid.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH] staging: emxx_udc: emxx_udc: Removed variables that is never used

2015-01-29 Thread Rickard Strandqvist
2015-01-29 3:37 GMT+01:00 Chris Rorvick : > On Wed, Jan 28, 2015 at 4:42 PM, Rickard Strandqvist > wrote: >> Variable ar assigned a value that is never used. >> I have also removed all the code that thereby serves no purpose. > > Each of these changes adds a warning ... > >> diff --git a/drivers/s

solo6x10: all interrupts for all cards handled by CPU0, no balancing - why?

2015-01-29 Thread Andrey Utkin
Hi, having another "card freeze" issue with linux-next (tag next-20150128) on a server running 3 solo6110 cards. The freeze happens after 3 days or so. Much better than 30 minutes, which was the case before the recent enhancement by Krzysztof Halasa. This is Ubuntu Trusty. There's /usr/sbin/irqbala

Re: [PATCH] staging: comedi: drivers: jr3_pci: Removed variables that is never used

2015-01-29 Thread Rickard Strandqvist
2015-01-29 15:26 GMT+01:00 Ian Abbott : > On 28/01/15 22:35, Rickard Strandqvist wrote: >> >> Variable ar assigned a value that is never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-o

[PATCH v2] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Heba Aamer
This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) pahole showed that the struct used pnetdev->dev_addr is aligned to u16. Moreover mac is a simple array, pdata is a pointer that starts from an even offset. Sign

[PATCH v2] staging: comedi: drivers: jr3_pci: Removed variables that is never used

2015-01-29 Thread Rickard Strandqvist
Variable was assigned a value that was never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/jr3_pci.c |2 -- 1 file changed, 2 de

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-29 Thread Valdis . Kletnieks
On Thu, 29 Jan 2015 19:48:08 +0100, Rickard Strandqvist said: > Fix a possible null pointer dereference, there is > otherwise a risk of a possible null pointer dereference. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drive

Re: [PATCH] staging: comedi: drivers: mite: Removed variables that is never used

2015-01-29 Thread Rickard Strandqvist
2015-01-29 15:39 GMT+01:00 Ian Abbott : > On 28/01/15 22:36, Rickard Strandqvist wrote: >> >> Variable ar assigned a value that is never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-o

[PATCH v2] staging: comedi: drivers: mite: Removed variables that is never used

2015-01-29 Thread Rickard Strandqvist
Variable was assigned a value that was never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/mite.c |2 -- 1 file changed, 2 delet

[PATCH v2] staging: comedi: drivers: addi-data: hwdrv_apci3501: Removed variables that is never used

2015-01-29 Thread Rickard Strandqvist
Variable was assigned a value that was never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c |3 +-- 1

Re: solo6x10: all interrupts for all cards handled by CPU0, no balancing - why?

2015-01-29 Thread Andrey Utkin
The host was rebooted and got back online. Without irqbalance daemon, all solo6x10 interrupts are still on CPU0. See https://gist.github.com/krieger-od/d1686243c67fbe3e14a5 Any ideas are strongly appreciated. -- Andrey Utkin ___ devel mailing list de..

[PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used

2015-01-29 Thread Rickard Strandqvist
Variable was assigned a value that was never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/addi_apci_3501.c |3 +-- 1 file chang

[PATCH v2] staging: comedi: drivers: dyna_pci10xx: Removed variables that is never used

2015-01-29 Thread Rickard Strandqvist
Variable was assigned a value that was never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/dyna_pci10xx.c |6 +- 1 file chan

[PATCH v2] staging: comedi: drivers: rtd520: Removed variables that is never used

2015-01-29 Thread Rickard Strandqvist
Variable was assigned a value that was never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/rtd520.c |4 1 file changed, 4 d

[PATCH v2] staging: comedi: drivers: usbduxsigma: Removed variables that is never used

2015-01-29 Thread Rickard Strandqvist
Variable was assigned a value that was never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/usbduxsigma.c |4 1 file changed

Re: [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf

2015-01-29 Thread Heba Aamer
On Wed, Jan 28, 2015 at 05:56:07PM -0800, Joe Perches wrote: > On Wed, 2015-01-28 at 16:05 +0200, Heba Aamer wrote: > > This patch fixes the following checkpatch.pl warning: > > Prefer seq_puts to seq_printf > > checkpatch is pretty stupid. > Please don't just do what it says. I checked checkpatc

[PATCH] staging: lustre: lustre: osc: modifying seq_printf statements

2015-01-29 Thread Heba Aamer
This patch modifies the seq_printf statements in drivers/staging/lustre/lustre/osc/lproc_osc.c file. It changes it to seq_puts and seq_putc wherever applicable. Signed-off-by: Heba Aamer --- drivers/staging/lustre/lustre/osc/lproc_osc.c | 20 ++-- 1 file changed, 10 insertions(

Re: [PATCH] staging: emxx_udc: emxx_udc: Removed variables that is never used

2015-01-29 Thread Chris Rorvick
On Thu, Jan 29, 2015 at 3:52 PM, Rickard Strandqvist wrote: > The last one was more interesting, se below. > But I can not really see how any error should be handled here? > Proposal to change to: > > if (kstrtol(tempbuf, 16, &num) == 0 && num == 0) That whole chunk of code looks odd. Why the

Re: [PATCH] lowmemorykiller: Avoid excessive/redundant calling of LMK

2015-01-29 Thread John Stultz
On Thu, Jan 15, 2015 at 9:03 AM, Michal Hocko wrote: > On Mon 12-01-15 21:49:14, Chintan Pandya wrote: >> The global shrinker will invoke lowmem_shrink in a loop. >> The loop will be run (total_scan_pages/batch_size) times. >> The default batch_size will be 128 which will make >> shrinker invoking

Re: [PATCH] staging: emxx_udc: emxx_udc: Removed variables that is never used

2015-01-29 Thread Chris Rorvick
On Thu, Jan 29, 2015 at 5:46 PM, Chris Rorvick wrote: > That whole chunk of code looks odd. Why the base 16 conversion when > we already know it's a decimal digit? Seems like this would work > without the hassle of the string conversion: Hmm, or probably even better to do this where the ep0 che

Re: [PATCH v2] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Larry Finger
On 01/29/2015 04:11 PM, Heba Aamer wrote: This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) pahole showed that the struct used pnetdev->dev_addr is aligned to u16. Moreover mac is a simple array, pdata is a po

Re: [PATCH] lowmemorykiller: Avoid excessive/redundant calling of LMK

2015-01-29 Thread Rom Lemarchand
On Thu, Jan 29, 2015 at 4:44 PM, John Stultz wrote: > On Thu, Jan 15, 2015 at 9:03 AM, Michal Hocko wrote: >> On Mon 12-01-15 21:49:14, Chintan Pandya wrote: >>> The global shrinker will invoke lowmem_shrink in a loop. >>> The loop will be run (total_scan_pages/batch_size) times. >>> The default

Re: [PATCH 2/3] hv: vmbus_post_msg: retry the hypercall on HV_STATUS_INVALID_CONNECTION_ID

2015-01-29 Thread Jason Wang
On Thu, Jan 29, 2015 at 7:02 PM, Dexuan Cui wrote: I got the hypercall error code on Hyper-V 2008 R2 when keeping running "rmmod hv_netvsc; modprobe hv_netvsc; rmmod hv_utils; modprobe hv_utils" in a Linux guest. Without the patch, the driver can occasionally fail to load. CC: "K. Y. Srini

RE: [PATCH v3 3/3] Drivers: hv: vmbus: serialize Offer and Rescind offer

2015-01-29 Thread Dexuan Cui
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, January 29, 2015 18:09 PM > To: Dexuan Cui > Cc: Vitaly Kuznetsov; KY Srinivasan; de...@linuxdriverproject.org; Haiyang > Zhang; > linux-ker...@vger.kernel.org; Radim Krčmář; Dan Carpenter > Subject: RE:

RE: [PATCH 1/3] hv: hv_util: move vmbus_open() to a later place

2015-01-29 Thread Dexuan Cui
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Thursday, January 29, 2015 21:13 PM > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@r

RE: [PATCH 3/3] hv: vmbus_open(): reset the channel state on ENOMEM

2015-01-29 Thread Dexuan Cui
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Thursday, January 29, 2015 21:22 PM > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@r

RE: [PATCH 2/3] hv: vmbus_post_msg: retry the hypercall on HV_STATUS_INVALID_CONNECTION_ID

2015-01-29 Thread Dexuan Cui
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Thursday, January 29, 2015 21:31 PM > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@r

RE: [PATCH 2/3] hv: vmbus_post_msg: retry the hypercall on HV_STATUS_INVALID_CONNECTION_ID

2015-01-29 Thread Dexuan Cui
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Friday, January 30, 2015 10:47 AM > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; KY > Srinivasan; Hai