On 28/01/15 22:35, Rickard Strandqvist wrote:
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
---
  drivers/staging/comedi/drivers/dyna_pci10xx.c |    5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c 
b/drivers/staging/comedi/drivers/dyna_pci10xx.c
index 1b6324c..8882423 100644
--- a/drivers/staging/comedi/drivers/dyna_pci10xx.c
+++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c
@@ -115,10 +115,9 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device 
*dev,
  {
        struct dyna_pci10xx_private *devpriv = dev->private;
        int n;
-       unsigned int chan, range;

-       chan = CR_CHAN(insn->chanspec);
-       range = range_codes_pci1050_ai[CR_RANGE((insn->chanspec))];
+       CR_CHAN(insn->chanspec);
+       range_codes_pci1050_ai[CR_RANGE((insn->chanspec))];

Both those lines produce compiler warnings, are not needed, don't belong here and should be removed. The AO subdevice has a single, fixed range.


        mutex_lock(&devpriv->mutex);
        for (n = 0; n < insn->n; n++) {



--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbo...@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to