On 2014-09-04 00:58, Chase Southwood wrote:
git-grep reveals that hwdrv_apci1500.c is the only file in comedi that uses
dev->hw_dev in calls to dev_{err,warn}(). The rest of the drivers pass
dev->class_dev to these macros instead. Switch the dev_warn() calls in
this driver to use dev->class_dev
There's a check for CONFIG_MACH_EMGR. But the Kconfig symbol MACH_EMGR
doesn't exist. Remove that check and the single #define it hides. Note
that this macro isn't used by this driver anyway.
Signed-off-by: Paul Bolle
---
Compile tested only (on x86_64).
drivers/staging/emxx_udc/emxx_udc.h | 4
Signed-off-by: Dipak Zope
---
drivers/staging/android/uapi/binder.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/uapi/binder.h
b/drivers/staging/android/uapi/binder.h
index 904adb7..dba4cef 100644
--- a/drivers/staging/android/uapi/binder.h
+++ b/dr
We try to call free_netvsc_device(net_device) when "net_device" is NULL.
It leads to an Oops.
Fixes: f90251c8a6d0 ('hyperv: Increase the buffer length for
netvsc_channel_cb()')
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index 5b5644a..977
On Mon, Sep 01, 2014 at 08:47:12AM -0400, Dipak Zope wrote:
you have not mentioned any commit message .
thanks
sudip
> Signed-off-by: Dipak Zope
> ---
> drivers/staging/android/uapi/binder.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/uapi
Fix the warning reported by sparse on
drivers/staging/lustre/lnet/lnet/router_proc.c
warning: incorrect type in argument 4 (different address spaces)
The correction is to annotate all user buffer variable by __user
Signed-off-by: LABBE Corentin
---
.../staging/lustre/include/linux/libcfs/libcfs
*** BLURB HERE ***
root (1):
Staging: rtl8192u: fix brace style coding issue in r819xU_firmware.c
This is a patch to the file r819xU_firmware.c that fixes a brace
warning found by checkpatch.pl tool
drivers/staging/rtl8192u/r819xU_firmware.c |5 ++---
1 file changed, 2 insertio
From: root
Signed-off-by: Chaitra Ramaiah
---
drivers/staging/rtl8192u/r819xU_firmware.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c
b/drivers/staging/rtl8192u/r819xU_firmware.c
index 671cbe6..40e1ef5 100644
--- a/drive
On Thu, Sep 04, 2014 at 07:39:11PM +0530, Chaitra Ramaiah wrote:
> *** BLURB HERE ***
No blurb???
:)
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Sep 04, 2014 at 07:39:12PM +0530, Chaitra Ramaiah wrote:
> From: root
I don't think that is your email address...
ALso, look at your subject, something went wrong here :(
Care to try again?
thanks,
greg k-h
___
devel mailing list
de...@linux
Read the first paragraph of Documentation/email-clients.txt.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
xilly_scan_idt() now returns an error status code, rather than being a void
function and hint the status through an entry in a data structure.
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c | 20
1 files changed, 8 ins
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_core.c
b/drivers/staging/xillybus/xillybus_core.c
index cacd560..61699fa 100644
--
"rc" is often used to hold the return value of a function call. This patch
removes unnecessary assignments to this variable, and makes a few related
execution flow improvements.
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c | 32 +++--
Rather than checking the wait condition, the return value of
wait_event_interruptible() and wait_event_interruptible_timeout() is
used.
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c | 38 +++---
1 files changed, 19
These patches are a result of Dan Carpenter's remarks after looking at the
driver. A huge thanks goes to him for taking the time to review the code,
and his clear and helpful comments.
A significant part of the corrections is my extrapolation of Dan's remarks
on similar cases. If something silly s
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_core.c
b/drivers/staging/xillybus/xillybus_core.c
index fc14b14..45dbf07 100
The -EAGAIN status is passed through an "rc" variable instead of a less
common flow.
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c | 16 +++-
1 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/xill
Responding to an interrupt while handling the "release" method can't end
well anyhow. In practical cases, this can force the user to wait up to
one second while flushing remaining data is attempted (a timeout on the flush
mechanism limits the time for flushing).
Suggested-by: Dan Carpenter
Signed
Replace devm_kzalloc where it applies.
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_core.c
b/drivers/staging/xillybu
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c | 13 -
1 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_core.c
b/drivers/staging/xillybus/xillybus_core.c
index 3050815..222457f 10
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c | 10 ++
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_core.c
b/drivers/staging/xillybus/xillybus_core.c
index 3e14198..3050815 10064
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_core.c
b/drivers/staging/xillybus/xillybus_core.c
index 65bbebb..c678b6c 100644
-
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c |8 +---
drivers/staging/xillybus/xillybus_pcie.c |4 ++--
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_core.c
b/drivers/staging/x
Trivial comments removed, and one comment clarified
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c | 15 ---
1 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_core.c
b/drivers/sta
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c | 29 +
1 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_core.c
b/drivers/staging/xillybus/xillybus_core.c
index 5
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c | 58 +++---
drivers/staging/xillybus/xillybus_pcie.c |2 +-
2 files changed, 30 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_core.c
b/drivers/staging/xillybu
* Blank lines between a function call and its return status check were
removed.
* Double blank lines were removed.
* Blank lines were added and removed as to silence checkpatch.pl --strict
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus.h |
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_core.c
b/drivers/staging/xillybus/xillybus_core.c
index 04c60c6..5ed89ce 100644
--- a/
Suggested-by: Dan Carpenter
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_core.c
b/drivers/staging/xillybus/xillybus_core.c
index 63c2c14..1b63197 100644
---
This is a patch to the file r819xU_firmware.c that fixes a brace
warning found by checkpatch.pl tool
drivers/staging/rtl8192u/r819xU_firmware.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--
1.7.9.5
___
devel mailing list
de
Signed-off-by: Chaitra Ramaiah
---
drivers/staging/rtl8192u/r819xU_firmware.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c
b/drivers/staging/rtl8192u/r819xU_firmware.c
index 671cbe6..40e1ef5 100644
--- a/drivers/staging/rt
Hello Dan.
I've just submitted the patches for the staging git tree (yourself
Cc'ed). I didn't have any objections on your comments, so there isn't
much to add -- except for thank you. :)
Regards,
Eli
On 01/09/14 15:13, Dan Carpenter wrote:
Pretty nice. This is very special purpose hard
On Thu, 2014-09-04 at 20:41 +0530, Chaitra Ramaiah wrote:
[]
> diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c
> b/drivers/staging/rtl8192u/r819xU_firmware.c
[]
> @@ -153,11 +153,10 @@ static bool CPUcheck_maincodeok_turnonCPU(struct
> net_device *dev)
> break;
>
Align the prototype of lprocfs_wr_uint() in the declaration with the one used
in the definition.
The prototype is:
int lprocfs_wr_uint(struct file *file, const char __user *buffer,
unsigned long count, void *data)
In obdclass/lprocfs_status.c
But in lustre/include/lp
On Thu, 2014-09-04 at 20:41 +0530, Chaitra Ramaiah wrote:
> Signed-off-by: Chaitra Ramaiah
Please put the commit log description from your
cover letter into this patch submission and only
send 1 email instead of than 2.
Rather than add these one-line-at-a-time type changes,
I'd just as soon see
On Wed, Sep 03, 2014 at 12:59:50PM +0300, Dan Carpenter wrote:
> On Wed, Sep 03, 2014 at 02:59:21PM +0530, Sudip Mukherjee wrote:
> > 1) removed unused variables
> > 2) fixed sparse warning of context imbalance in 'do_locked_client_insert'
> > different lock contexts for ba
fixed sparse warning : incorrect type in argument 1
(different address spaces)
Signed-off-by: Sudip Mukherjee
---
drivers/staging/iio/adc/mxs-lradc.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/iio/adc/mxs-lradc.c
b/driver
On 09/04/2014 06:45 PM, Sudip Mukherjee wrote:
fixed sparse warning : incorrect type in argument 1
(different address spaces)
Signed-off-by: Sudip Mukherjee
---
drivers/staging/iio/adc/mxs-lradc.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --g
please discard the patch. It generates additional sparse warning.
sorry for it.
thanks
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Sep 04, 2014 at 06:50:05PM +0200, Lars-Peter Clausen wrote:
> On 09/04/2014 06:45 PM, Sudip Mukherjee wrote:
> >fixed sparse warning : incorrect type in argument 1
> >(different address spaces)
> >
> >Signed-off-by: Sudip Mukherjee
> >---
> > drivers/staging/iio/adc/mx
The "br_port" local variables obtained through the rcu_dereference() calls are
not dereferenced in the rest of their function.
Therefore, it is recommended to use rcu_access_pointer() instead of
rcu_dereference().
This patch makes the replacements.
The first step to detect this was made with the f
On 09/04/2014 07:12 PM, Sudip Mukherjee wrote:
On Thu, Sep 04, 2014 at 06:50:05PM +0200, Lars-Peter Clausen wrote:
On 09/04/2014 06:45 PM, Sudip Mukherjee wrote:
fixed sparse warning : incorrect type in argument 1
(different address spaces)
Signed-off-by: Sudip Mukherjee
This member of the boardinfo is the same for all entries. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/a
This member of the boardinfo is the same for all entries. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/a
This member of the boardinfo is the same for all entries. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/comedi/
This member of the boardinfo is the same for all entries. Remove it.
Also, remove the initialization of the subdevice 'len_chanlist'. This
member is only used if the subdevice supports async commands.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/c
This member of the boardinfo is the same for all entries. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/a
Remove all the boardinfo members that are not used by the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci91
Remove all the unused information in the boardinfo and tidy it up.
Clenaup the attach of this driver a bit.
H Hartley Sweeten (21):
staging: comedi: adl_pci9118: remove unused boardinfo
staging: comedi: adl_pci9118: remove 'rangelist_ao' boardinfo
staging: comedi: adl_pci9118: remove 'ao_ma
The minimum convert time 'ai_ns_min' is based on the sampling rate of the A/D
converter. This driver supports boards that use different ADC chips for 16-bit
and 12-bit analog inputs. These chips have different sampling rates.
For aesthetics, move the 'ai_ns_min' member from the boardinfo to the pr
The pci_device_id 'driver_data' is passed as the 'context' when the
(*auto_attach)
mechanism is used to attach this driver. Add a boardid enum and index the
boardinfo
so that the "pci9118dg" boardinfo is automatically selected. This allow removing
the pci9118_find_boardinfo() helper.
Unfortunate
For aesthetics, add some whitespace to the digital output subdevice init.
Remove the SDF_GROUND and SDF_COMMON subdev_flags. These flags only apply
to analog subdevices.
Remove the 'len_chanlist' init, this subdevice member is only used with
subdevices that support async commands.
Signed-off-by:
For aesthetics, add some whitespace to the analog output subdevice init.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/c
The (*auto_attach) and legacy (*attach) both allocate the private data but
don't use it. For aesthetics, move the allocation into the common attach
code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 16 +--
This value can easily be calculated based on the minimum sampling rate,
'ai_ns_min', and the base clock speed of the timers. Do that instead and
remove the boardinfo.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 14 ++
This member of the boardinfo is the same for all entries. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/
For aesthetics, rename the struct used for the boardinfo so it has
namespace associated with the driver. Also, rename the local variable
used for the boardinfo pointer to simply 'board'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/a
The boards supported by this driver either have "normal" or "high gain"
analog input ranges.
For aesthetics, replace the 'rangelist_ai' member in the boardinfo with
a bit-field flag 'is_hg' to indicate the "high gain" range is used.
Refactor the subdevice init to use the flag to set the correct ra
This member of the boardinfo is the same for all entries. Remove it.
Also, remove the initialization of the subdevice 'len_chanlist'. This
member is only used if the subdevice supports async commands.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/c
The boards supported by this driver either have 12-bit or 16-bit analog
inputs. For aesthetics, replace the 'ai_maxdata' member in the boardinfo
with a bit-field flag, 'ai_is_16bit', and refactor the subdevice init to
use the new member.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg K
This member of the boardinfo is the same for all entries. It's also
half the subdevice 'n_chan'. Use that instead and remove the boardinfo.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 7 +--
1 file changed, 1 ins
For aesthetics, add some whitespace to the digital input subdevice init.
Remove the SDF_GROUND and SDF_COMMON subdev_flags. These flags only apply
to analog subdevices.
Remove the 'len_chanlist' init, this subdevice member is only used with
subdevices that support async commands.
Signed-off-by:
For aesthetics, add some whitespace to the analog input subdevice init.
Tidy up the subdevice n_chan initialization.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 31 +---
1 file changed, 14 ins
The (*auto_attach) in this driver will set the dev->board_name and the comedi
core
will set it when using the legacy (*attach). Remove the unnecessary
initialization
in pci9118_common_attach().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/
Align the prototype of lprocfs_wr_uint() in the declaration with the one used
in the definition.
The prototype is:
int lprocfs_wr_uint(struct file *file, const char __user *buffer,
unsigned long count, void *data)
In obdclass/lprocfs_status.c
But in lustre/include/lprocfs_sta
According to the PCI-9118 User's Manual, all registers are 32-bit. Fix a
couple of read/write operations that use 16-bit access.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 8
1 file changed, 4 insertions(+)
Rename the register map defines and remove all the CamelCase.
This series applies after:
[PATCH 00/21] staging: comedi: adl_pci9118: cleanup the boardinfo and attach
H Hartley Sweeten (19):
staging: comedi: adl_pci9118: all registers are 32-bit
staging: comedi: adl_pci9118: introduce pci9118_
The same register is used for both the digital inputs and outputs.
Reading the register returns the state of the 4 digtial input channels
and the 4 digital output channels. Writing to the register updates the
digital outputs.
Add some comments to clarify this and use a single define for the regist
For aesthetics, rename this define used for the analog input control
register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/driv
Replace the current defines with a macro that calculates the correct
register offset based on the channel.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 24 +---
1 file changed, 9 insertions(+), 15
This driver uses 32-bit instructions to write the 8254 timers so we
can't use the helper functions provided by 8253.h.
To clarify the code introduce a helper function to write to the timers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/driv
For aesthetics, rename the define used for the analog input fifo register
and tidy up its use in the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 20 +---
1 file changed, 9 insertions(+), 11 de
For aesthetics, rename this define used for the analog input burst
number register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/stagi
Rename the CamelCase defines used for the analog input status register
bits and convert them to bit shifts.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 24 +++-
1 file changed, 11 insertions(+), 1
For aesthetics, rename this define used for the analog input status
register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drive
Rename the CamelCase defines used for the analog input config register
bits and convert them to bit shifts.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 68 +++-
1 file changed, 26 insertions(+
This driver uses 32-bit instructions to write the 8254 timers so we
can't use the helper functions provided by 8253.h.
To clarify the code introduce a helper function to set the timer mode.
Remove the unnecessary commented out timer mode programming.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abb
For aesthetics, rename this define used for the analog input chanlist
programming register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/dri
Rename the CamelCase defines used for the analog input control register
bits and convert them to bit shifts.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 80 +++-
1 file changed, 31 insertions(
For aesthetics, rename this define used for the analog input auto scan
mode register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff -
Writing any value to the "software trigger" register generates a trigger
pulse to start an A/D conversion. Introduce a helper function to clarify
this. For aesthetics, rename the define used for the register.
According to the datasheet the extra delay is not needed after starting
the conversion. R
The register at offset 0x38 is the "interrupt control" register when written
and the "interrupt status" register when read. Both registers use the same
bit defines.
For aesthetics, use a common define for this register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
For aesthetics, rename this define used for the analog input function
config register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff
Rename the CamelCase defines used for the interrupt control/status register
bits and convert them to bit shifts.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 20 +---
1 file changed, 9 insertions(+), 1
Introduce a helper function to reset the analog input FIFO. For
aesthetics, rename the register used to reset the FIFO.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 20 +---
1 file changed, 13 insertio
This fixes "void function return statements are not generally useful"
warnings from checkpatch.pl.
Signed-off-by: Michał Bartoszkiewicz
---
drivers/staging/gs_fpgaboot/io.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/gs_fpgaboot/io.c b/drivers/staging/gs_fpgaboot/io.
On Thu, Sep 04, 2014 at 10:11:16PM +0530, Sudip Mukherjee wrote:
> On Wed, Sep 03, 2014 at 12:59:50PM +0300, Dan Carpenter wrote:
> > On Wed, Sep 03, 2014 at 02:59:21PM +0530, Sudip Mukherjee wrote:
> > > 1) removed unused variables
> > > 2) fixed sparse warning of context imbalance in 'do_locked_c
Fix checkpatch.pl "space required before that '*'" errors
Signed-off-by: Greg Donald
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 6 +++---
drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +-
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 8
drivers/staging/rtl8192u/r
Hello,
I cloned this:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
and after moved to staging-next branch, but in both cases, in
those files I don't find any use of rcu_dereference() call (the call
which I am looking for to modify).
Thank you,
Andreea
2014-08-30 23:42 GMT+03
Fix checkpatch.pl "space required before that '*'" errors
Signed-off-by: Greg Donald
---
drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.h | 6 +++---
drivers/staging/rtl8821ae/btcoexist/habtc8723a1ant.h | 6 +++---
drivers/staging/rtl8821ae/btcoexist/halbtc8192e1ant.h | 8
drivers
Okay, thank you.
Reviewed-by: Insop Song
On Thu, Sep 04, 2014 at 10:05:36PM +0200, Michał Bartoszkiewicz wrote:
> This fixes "void function return statements are not generally useful"
> warnings from checkpatch.pl.
>
> Signed-off-by: Michał Bartoszkiewicz
> ---
> drivers/staging/gs_fpgaboot/i
On 09/04/2014 03:58 PM, Andreea Bernat wrote:
Hello,
I cloned this:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
and after moved to staging-next branch, but in both cases, in
those files I don't find any use of rcu_dereference() call (the call
which I am looking for to modif
On Thu, Sep 04, 2014 at 11:58:36PM +0300, Andreea Bernat wrote:
> Hello,
>
> I cloned this:
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
>
> and after moved to staging-next branch, but in both cases, in
> those files I don't find any use of rcu_dereference() call (the call
>
> >
> > However, actual fpga programming method is well contained in io.c with
> > ifdef-ed CONFIG_B4860G100, now I think I might better to update
> > Kconfig to include CONFIG_B4860G100.
> >
> > Greg, what do you think? Any harm to add custom board CON
clude CONFIG_B4860G100 in Kconfig in original patch set,
> > > since programming FPGA method can vary in different system, and this
> > > was discussed during the review with Greg as well.
> > >
> > > However, actual fpga programming method is well contained
Looks good to me.
Olaf, Hannes - can I get another review for this (and the older hyperv
scanning patch set)?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Sep 04, 2014 at 07:16:11PM +0200, Lars-Peter Clausen wrote:
> On 09/04/2014 07:12 PM, Sudip Mukherjee wrote:
> >On Thu, Sep 04, 2014 at 06:50:05PM +0200, Lars-Peter Clausen wrote:
> >>On 09/04/2014 06:45 PM, Sudip Mukherjee wrote:
> >>>fixed sparse warning : incorrect type in argument 1
> >
98 matches
Mail list logo
