On Thu, Sep 04, 2014 at 06:50:05PM +0200, Lars-Peter Clausen wrote:
> On 09/04/2014 06:45 PM, Sudip Mukherjee wrote:
> >fixed sparse warning : incorrect type in argument 1
> > (different address spaces)
> >
> >Signed-off-by: Sudip Mukherjee <[email protected]>
> >---
> > drivers/staging/iio/adc/mxs-lradc.c | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> >diff --git a/drivers/staging/iio/adc/mxs-lradc.c
> >b/drivers/staging/iio/adc/mxs-lradc.c
> >index 468327f..d8d1fe1 100644
> >--- a/drivers/staging/iio/adc/mxs-lradc.c
> >+++ b/drivers/staging/iio/adc/mxs-lradc.c
> >@@ -1545,9 +1545,12 @@ static int mxs_lradc_probe(struct platform_device
> >*pdev)
> > /* Grab the memory area */
> > iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > lradc->dev = &pdev->dev;
> >- lradc->base = devm_ioremap_resource(dev, iores);
> >- if (IS_ERR(lradc->base))
> >- return PTR_ERR(lradc->base);
> >+ void *tempptr;
> >+
> >+ tempptr = devm_ioremap_resource(dev, iores);
> >+ if (IS_ERR(tempptr))
> >+ return PTR_ERR(tempptr);
> >+ lradc->base = tempptr;
>
> This makes no sense at all... devm_ioremap_resource() returns a
> iomem pointer lrdac->base is a iomem pointer.
sparse is giving warning for argument 1 of IS_ERR.
>
> Please make sure that you have the latest version of sparse
> installed on your system.
>
> >
> > lradc->clk = devm_clk_get(&pdev->dev, NULL);
> > if (IS_ERR(lradc->clk)) {
> >
>
thanks
sudip
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
