Hi Greg,
On Wed, Jun 11, 2014 at 7:00 PM, Geert Uytterhoeven
wrote:
> drivers/staging/lustre/lustre/llite/rw26.c: In function ‘ll_direct_IO_26’:
> drivers/staging/lustre/lustre/llite/rw26.c:388: warning: format ‘%zd’ expects
> type ‘signed size_t’, but argument 6 has type ‘long int’
> drivers/st
Using an else following a break or return can unnecessarily
indent code blocks.
This patch fixes coding style reported by checkpatch.pl, a part
of eudyptula challenge.
Signed-off-by: Hoang Tran
---
drivers/staging/goldfish/goldfish_audio.c | 10 +-
1 file changed, 5 insertions(+), 5 del
On Sun, Jun 15, 2014 at 09:32:27PM +0200, Sam Ravnborg wrote:
> diff --git a/expand.c b/expand.c
> index 0f6720c..4a96de4 100644
> --- a/expand.c
> +++ b/expand.c
> @@ -187,7 +187,7 @@ static int simplify_int_binop(struct expression *expr,
> struct symbol *ctype)
> return 0;
>
On Fri, Jun 13, 2014 at 12:11:51PM +0200, Martin Kepplinger wrote:
> Fix the sparse error: cast removes address space of expression.
> ---
> Is that even correct?
It's correct but not complete.
vt6655 impliment their own versions of ethtool_ioctl() when they should
be using the standard versions.
On Fri, Jun 13, 2014 at 12:23:43PM +0200, Martin Kepplinger wrote:
> Remove a totally unnecessary typedef. This is more readable now.
Choose a lower case name for the struct, otherwise we have to change all
these again in a while.
regards,
dan carpenter
__
Wrong description, doesn't apply, and breaks the build.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Jun 16, 2014 at 10:40:19AM +0300, Dan Carpenter wrote:
> On Sun, Jun 15, 2014 at 09:32:27PM +0200, Sam Ravnborg wrote:
> > diff --git a/expand.c b/expand.c
> > index 0f6720c..4a96de4 100644
> > --- a/expand.c
> > +++ b/expand.c
> > @@ -187,7 +187,7 @@ static int simplify_int_binop(struct ex
On Fri, Jun 13, 2014 at 10:04:35AM -0700, Greg KH wrote:
> On Fri, Jun 13, 2014 at 05:52:33PM +0200, Benedict Boerger wrote:
> > Fix a coding style issue found by checkpatch.pl.
> > Use ether_addr_copy instead of memcpy.
> >
> > Done to complete a eudyptula task.
> >
> > Signed-off-by: Benedict B
On Sat, Jun 14, 2014 at 02:04:38PM +0900, Seunghun Lee wrote:
> This patch fixes below warning.
>
> drivers/staging/ced1401/ced_ioc.c:703:30: warning: incorrect type in
> assignment (different address spaces)
> drivers/staging/ced1401/ced_ioc.c:703:30:expected void *[usertype]
> lpvBuf
On Sat, Jun 14, 2014 at 05:29:51PM +1000, Vitaly Osipov wrote:
> Joe Perches mentioned on driverdev-devel that memset after LIBCFS_ALLOC
> is not necessary as it is already done during LIBCFS_ALLOC_POST. This
> commit removes these unnecessary memsets. Based on the results of running
> a cocci pat
Office of the Honorable Minister of Finance
Federal Ministry of Finance (FMF)
FMF Annex Complex Building Garki, Abuja-Nigeria
Our Ref:CBN/FMF/CBX/021/07/014
Contract No: MAV.NNPC/FGN/MIN.
Attention,
I am Director Federal Ministry of Finance and was instructed by the President
Federal Republi
On 6 June 2014 09:05, wrote:
> From: Micky Ching
>
> Add support for non-blocking request, pre_req() runs dma_map_sg() and
> post_req() runs dma_unmap_sg(). This patch can increase card read/write
> speed, especially for high speed card and slow speed CPU.
>
> Test on intel i3(800MHz - 2.3GHz) p
On Sat, Jun 14, 2014 at 08:56:34PM +0200, Toralf Förster wrote:
> those characters breaks the html-formatter tool of Cppcheck
>
Cppcheck should be fixed.
> Signed-off-by: Toralf Förster
> ---
> drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c | 16
> 1 file changed, 8 ins
On 06/16/2014 04:42 PM, Ulf Hansson wrote:
@@ -36,7 +37,10 @@ struct realtek_pci_sdmmc {
> struct rtsx_pcr *pcr;
> struct mmc_host *mmc;
> struct mmc_request *mrq;
>+ struct workqueue_struct *workq;
>+#define SDMMC_WORKQ_NAME "rtsx_pci_sdmm
On Sun, Jun 15, 2014 at 07:20:57PM +0200, Rickard Strandqvist wrote:
> The same code regardless of the outcome of the if statement. This may of
> course be a miss and there should be a difference in the code.
> And clean up another duplicate line of code.
>
> This was partly found using a static c
On Mon, Jun 16, 2014 at 10:47:25AM +0100, Martyn Welch wrote:
> Nick,
>
> Sorry for the delay in responding.
>
> I'm staring at the manual for the ca91c142 and the relevant bits in
> the VSIx_CTL registers definitely need to be set to 0 for A16,
> likewise with the LM_CTL register. The pattern (3
On 06/06/14 20:41, Aaron Sierra wrote:
Add a "gto" parameter to this driver so that the VMEbus Global Timeout
value can be lowered from the default (8h -> 2048 us) or disabled
completely.
This patch also updates the TSI148_LCSR_VCTRL_GTO_* defines to match
the Tsi148 User Reference Manual, which
On 16/06/14 10:56, Dan Carpenter wrote:
On Mon, Jun 16, 2014 at 10:47:25AM +0100, Martyn Welch wrote:
Nick,
Sorry for the delay in responding.
I'm staring at the manual for the ca91c142 and the relevant bits in
the VSIx_CTL registers definitely need to be set to 0 for A16,
likewise with the LM
That new macro is needed by the imx_drm staging driver
for supporting the QVGA display of the eukrea-cpuimx51 board.
Signed-off-by: Denis Carikli
Acked-by: Mauro Carvalho Chehab
Acked-by: Laurent Pinchart
Acked-by: Philipp Zabel
---
ChangeLog v13->v14:
- None
ChangeLog v10->v13:
- No changes
We need a way to pass signal polarity informations
between DRM panels, and the display drivers.
To do that, a pol_flags field was added to drm_display_mode.
Signed-off-by: Denis Carikli
---
ChangeLog v13->v14:
- Fixed DRM_MODE_FLAG_POL_DE_HIGH's description.
ChangeLog v12->v13:
- Added Docbook
The imx-drm driver can't use the de-active and
pixelclk-active display-timings properties yet.
Instead the data-enable and the pixel data clock
polarity are hardcoded in the imx-drm driver.
So theses properties are now set to keep
the same behaviour when imx-drm will start
using them.
Signed-off
Signed-off-by: Denis Carikli
---
ChangeLog v13->v14:
- None
ChangeLog v12->v13:
- Added a note explaining why the size is zero in
the eukrea_mbimxsd51_dvi(s)vga structs.
ChangeLog v11->v12:
- Rebased: It now uses the new DRM_MODE_FLAG_POL_DE flags defines names
ChangeLog v10->v11:
- New patch.
The CMO-QVGA, DVI-SVGA and DVI-VGA are added.
Signed-off-by: Denis Carikli
---
ChangeLog v13->v14:
- None
ChangeLog v10->v13:
- Rebased
- Removed enable-active-high in reg_lcd_3v3: its GPIO
already has the GPIO_ACTIVE_HIGH flag.
Without this removal, the display was off at boot
and powerin
The previous hardware behaviour was kept if the
flags are not set.
Signed-off-by: Denis Carikli
---
ChangeLog v13->v14:
- Rebased
ChangeLog v12->v13:
- This patch doesn't need the DRM_MODE_FLAG_POL_*_PRESERVE flags anymore.
- code cleanup to improve readability:
- ENABLE_POL_PRESERVE is now go
The current BGR666 is not consistent with the other color mapings like BGR24.
BGR666 should be in the same byte order than BGR24.
Signed-off-by: Denis Carikli
Acked-by: Philipp Zabel
---
ChangeLog v13->v14:
- Rebased
ChangeLog v10->v13:
- Rebased
ChangeLog v9->v10:
- Rebased.
- Added Philipp Zab
Signed-off-by: Denis Carikli
Acked-by: Philipp Zabel
---
ChangeLog v13->v14:
- Rebased
ChangeLog v9->v13:
- Rebased
ChangeLog v8->v9:
- Rebased.
- Added Philipp Zabel's ack.
- Shortened the patch title.
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
- Rebased.
Signed-off-by: Denis Carikli
---
ChangeLog v13->v14:
- None
ChangeLog v11->v13:
- No changes
ChangeLog v9->v11:
- Now uses the drm-panel instead of the display-timings.
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
- The backlight is now on at boot.
ChangeLog
Signed-off-by: Denis Carikli
---
ChangeLog v13->v14:
- Rebased
ChangeLog 12->v13:
- No changes
ChangeLog 11->v12:
- Improved the define names to match the hardware:
ENABLE_POL is not a clock signal but instead an enable signal.
ChangeLog v9->v10:
- New patch which was splitted out from:
"stag
On Mon, Jun 16, 2014 at 12:11:15PM +0200, Denis Carikli wrote:
> That new macro is needed by the imx_drm staging driver
> for supporting the QVGA display of the eukrea-cpuimx51 board.
As I said probably around v10 time, I already have this patch queued,
and I was going to send it to Greg before
On Mon, Jun 16, 2014 at 12:11:16PM +0200, Denis Carikli wrote:
> Signed-off-by: Denis Carikli
> Acked-by: Philipp Zabel
As I said probably around v10 time, I already have this patch queued,
and I was going to send it to Greg before the previous merge window,
but due to the number of patches I wa
On Mon, Jun 16, 2014 at 12:11:17PM +0200, Denis Carikli wrote:
> The current BGR666 is not consistent with the other color mapings like BGR24.
> BGR666 should be in the same byte order than BGR24.
>
> Signed-off-by: Denis Carikli
> Acked-by: Philipp Zabel
As I said probably around v10 time, I a
Nick,
Sorry for the delay in responding.
I'm staring at the manual for the ca91c142 and the relevant bits in the
VSIx_CTL registers definitely need to be set to 0 for A16, likewise with
the LM_CTL register. The pattern (3<<16) would enable one of the
"reserved" address spaces.
Martyn
On 12
This patch fixes the sparse warnings in
drivers/staging/lustre/lustre/ptlrpc/sec_lproc.c:
sec_lproc.c:58:6: warning: symbol 'sec_flags2str' was not declared. Should it
be static?
Signed-off-by: Scott Weir
---
drivers/staging/lustre/lustre/ptlrpc/sec_lproc.c | 2 +-
1 file changed, 1 insertion(
Signed-off-by: Robin Schroer
---
drivers/staging/bcm/Misc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
index f2bc699..a0637eb 100644
--- a/drivers/staging/bcm/Misc.c
+++ b/drivers/staging/bcm/Misc.c
@@ -284,7 +
Signed-off-by: Robin Schroer
---
drivers/staging/bcm/Misc.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
index 7b2fa0f..f2bc699 100644
--- a/drivers/staging/bcm/Misc.c
+++ b/drivers/staging/bcm/Misc.c
@@ -28,6 +28,7 @@
Signed-off-by: Robin Schroer
---
drivers/staging/bcm/Misc.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
index a0637eb..a1c833c 100644
--- a/drivers/staging/bcm/Misc.c
+++ b/drivers/staging/bcm/Misc.c
@@ -21,7 +21,6 @@ static voi
> From: Micky Ching
>
> rtsx driver using a single function for transfer data, dma map/unmap are
> placed in one fix function. We need map/unmap dma in different place(for
> mmc async driver), so add three function for dma map, dma transfer and
> dma unmap.
>
> Signed-off-by: Micky Ching
> ---
On 06/16/2014 12:11 PM, Denis Carikli wrote:> + reg_lcd_3v3: lcd-en {
> + compatible = "regulator-fixed";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_reg_lcd_3v3>;
> + regulator-name = "lcd-3v3";
> + regulator-min-microvolt = <330>
On 16 June 2014 11:09, micky wrote:
> On 06/16/2014 04:42 PM, Ulf Hansson wrote:
>>>
>>> @@ -36,7 +37,10 @@ struct realtek_pci_sdmmc {
>>> > struct rtsx_pcr *pcr;
>>> > struct mmc_host *mmc;
>>> > struct mmc_request *mrq;
>>> >+ struct workqueue_s
- Original Message -
> From: "Martyn Welch"
> Sent: Monday, June 16, 2014 4:56:16 AM
> Subject: Re: [PATCH] vme_tsi148: Allow setting VMEbus Global Timeout
>
> On 06/06/14 20:41, Aaron Sierra wrote:
> > Add a "gto" parameter to this driver so that the VMEbus Global Timeout
> > value can
On Wed, Jun 11, 2014 at 5:17 AM, Russell King - ARM Linux
wrote:
> The problem here is that we need more inteligence from CCF in order to
> do that - we need it to be able to reprogram the dividers so that the
> IPU DI0 clock remains at 148.5MHz while increasing the output of
> pll5_video_div thr
On 16 June 2014 14:20, Lee Jones wrote:
>> From: Micky Ching
>>
>> rtsx driver using a single function for transfer data, dma map/unmap are
>> placed in one fix function. We need map/unmap dma in different place(for
>> mmc async driver), so add three function for dma map, dma transfer and
>> dma
Remove a totally unnecessary typedef and rename it to lowercase.
This is more readable now.
Signed-off-by: Martin Kepplinger
---
so in that way, one could change the more heavily used typedefs as well.
thanks for your review.
drivers/staging/vt6655/card.c |2 +-
drivers/staging/vt6655/de
Driver has code which does Network address translation (NAT), and
i don't see how this code is useful for driver.
navin patidar (9):
staging: rtl8188eu: Remove function rtw_br_client_tx()
staging: rtl8188eu: Remove unused functons defined in rtw_br_ext.c
staging: rtl8188eu: Remove function n
This patch removes some functions defined in rtw_br_ext.c, which have become
obsolete after removal of rtw_br_client_tx().
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_br_ext.c| 727
drivers/staging/rtl8188eu/include/usb_osintf.h |1 -
2 f
Value stored in pppoe_connection_in_progress isn't being
used by driver.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_mlme.c |7 ---
drivers/staging/rtl8188eu/include/drv_types.h |1 -
2 files changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/
We've removed the code which was responsible for building NAT table,
so no use of keeping nat_db_cleanup().
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_br_ext.c| 26
drivers/staging/rtl8188eu/core/rtw_cmd.c |3 +--
drivers/staging/
rtw_br_client_tx() pass tx packet to functions responsible for
building NAT table.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 135 -
1 file changed, 135 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
b/drivers/
netdev_br_init() tries to find MAC address of network interface named "br0",
then that MAC address is assigned to adapter->br_netdev and used by driver's
NAT implementation code.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/usb_osintf.h |1 -
drivers/staging/rtl8188eu/o
We've removed the code which was responsible for building NAT table,
so no use of keeping nat_db_expire().
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 11 ---
drivers/staging/rtl8188eu/include/usb_osintf.h |1 -
2 files changed, 12 deletions(-)
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/drv_types.h |8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
b/drivers/staging/rtl8188eu/include/drv_types.h
index 71b4af7..baafe33 100644
--- a/drivers/staging/rtl8188e
driver doesn't need rtw_br_ext.h any more.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_cmd.c |1 -
drivers/staging/rtl8188eu/include/drv_types.h |1 -
drivers/staging/rtl8188eu/include/rtw_br_ext.h | 64
drivers/staging/rtl8188eu/
functions defined in rtw_br_ext.c are not being used by driver anymore.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/Makefile |1 -
drivers/staging/rtl8188eu/core/rtw_br_ext.c | 365 ---
2 files changed, 366 deletions(-)
delete mode 100644 dri
comments were translated with https://translate.google.com/
this enables python to parse that file right
Signed-off-by: Toralf Förster
---
drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rt
On 06/16/2014 10:49 AM, Dan Carpenter wrote:
> On Sat, Jun 14, 2014 at 08:56:34PM +0200, Toralf Förster wrote:
>> those characters breaks the html-formatter tool of Cppcheck
>>
>
> Cppcheck should be fixed.
>
>> Signed-off-by: Toralf Förster
>> ---
>> drivers/staging/rtl8821ae/btcoexist/HalBtc8
On Mon, Jun 16, 2014 at 04:50:51PM +0200, Stephan Gabert wrote:
> As mentioned in net/core/dev.c register_netdev() explicitly returns a
> negative errno code on failure.
>
> So in case of failure, one should rather test whether ret is negative
> than just unlike 0.
No. In the kernel the normal w
On Sun, Jun 15, 2014 at 12:41:47AM +0200, Rickard Strandqvist wrote:
> Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
Generally in the kernel we allow strncpy() if people want to use it.
Let's not start doing sed replacements of these if it doesn't cause a
problem.
Als
On Mon, Jun 16, 2014 at 10:01:14PM +0300, Dan Carpenter wrote:
>
> No one calls U14DriverName() so just delete this function.
Oh. This is a userspace library or something? I'm not sure what to do.
How did you compile test this? Does your platform even provide
strlcpy()?
Anyway, don't delete
On Mon, Jun 16, 2014 at 11:13:02AM -0300, Fabio Estevam wrote:
> On Wed, Jun 11, 2014 at 5:17 AM, Russell King - ARM Linux
> wrote:
>
> > The problem here is that we need more inteligence from CCF in order to
> > do that - we need it to be able to reprogram the dividers so that the
> > IPU DI0 cl
2014-06-16 21:09 GMT+02:00 Dan Carpenter :
> On Mon, Jun 16, 2014 at 10:01:14PM +0300, Dan Carpenter wrote:
>>
>> No one calls U14DriverName() so just delete this function.
>
> Oh. This is a userspace library or something? I'm not sure what to do.
>
> How did you compile test this? Does your pla
On 06/16/2014 08:40 PM, Ulf Hansson wrote:
On 16 June 2014 11:09, micky wrote:
On 06/16/2014 04:42 PM, Ulf Hansson wrote:
@@ -36,7 +37,10 @@ struct realtek_pci_sdmmc {
struct rtsx_pcr *pcr;
struct mmc_host *mmc;
struct mmc_request *mrq;
+
On 06/16/2014 08:20 PM, Lee Jones wrote:
I don't see any glaring issues with this patch. Does it rely on the
first patch, or vise versa, or can it just be applied?
Hi Jones,
[PATCH 2/2] need function defined in [PATCH 1/2]，
so we provide interface in [mfd] and called in [mmc].
Best Regards.
m
Signed-off-by: Nicholas Krause
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
index 1a95d1f..11e915e 100644
--- a/drivers/stagi
On Mon, Jun 16, 2014 at 11:23:13PM -0400, Nicholas Krause wrote:
> Signed-off-by: Nicholas Krause
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> b/drivers/staging/rtl819
On Mon, Jun 16, 2014 at 09:07:45PM -0700, Greg KH wrote:
> On Mon, Jun 16, 2014 at 11:23:13PM -0400, Nicholas Krause wrote:
> > Signed-off-by: Nicholas Krause
> > ---
> > drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/d
On Tue, Jun 17, 2014 at 12:14:18AM +0200, Rickard Strandqvist wrote:
> 2014-06-16 21:09 GMT+02:00 Dan Carpenter :
> > On Mon, Jun 16, 2014 at 10:01:14PM +0300, Dan Carpenter wrote:
> >>
> >> No one calls U14DriverName() so just delete this function.
> >
> > Oh. This is a userspace library or somet
On Mon, Jun 16, 2014 at 11:23:13PM -0400, Nicholas Krause wrote:
> Signed-off-by: Nicholas Krause
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> b/drivers/staging/rtl819
67 matches
Mail list logo
