----- Original Message -----
> From: "Martyn Welch" <martyn.we...@ge.com>
> Sent: Monday, June 16, 2014 4:56:16 AM
> Subject: Re: [PATCH] vme_tsi148: Allow setting VMEbus Global Timeout
> 
> On 06/06/14 20:41, Aaron Sierra wrote:
> > Add a "gto" parameter to this driver so that the VMEbus Global Timeout
> > value can be lowered from the default (8h -> 2048 us) or disabled
> > completely.
> >
> > This patch also updates the TSI148_LCSR_VCTRL_GTO_* defines to match
> > the Tsi148 User Reference Manual, which shows these values to be 4-bits
> > instead of 3-bits.
> >
> > Signed-off-by: Aaron Sierra <asie...@xes-inc.com>
> 
> Hi Aaron,
> 
> Sorry for the delay.
> 
> Would it be worth at least warning the user that the GTO has not been
> set should they try to use an invalid GTO?

Yeah, I think that's a good idea. I'll make the change and resubmit.

> Other than that, looks good to me.
> 
> Martyn
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to