Re: [PATCH v2 5/5] staging: ft1000: ft1000-usb: ft1000_debug.c: Misc. fixes.

On Fri, Jun 06, 2014 at 08:02:18PM -0700, Thomas Wood wrote: > Remove initialization of static value. > Invert the empty if statement's test to replace the else statement. > Remove parentheses from a return statement. > Fix some code indentation. > > Signed-off-by: Thomas Wood > --- > > I'm pret

Re: [PATCH] Staging: comedi: check the return value of kobject_set_name

On 2014-06-07 14:56, Anton Protopopov wrote: Added a check of the return value of the kobject_set_name function. Signed-off-by: Anton Protopopov --- drivers/staging/comedi/comedi_fops.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) Reviewed-by: Ian Abbott -- -=( Ian Abbot

Re: [PATCH 2/2] Staging: speakup: ERROR: Fix macro parenthesis.

I made a stupid mistake, and I'm sorry. https://lkml.org/lkml/2014/6/8/53 2014-06-09 2:58 GMT+09:00 Dan Carpenter : > It looks like this patch is adding blank lines not parenthesis like the > subject says. > > regards, > dan carpenter > > On Sun, Jun 08, 2014 at 11:12:57PM +0900, Choi Gi-yong wrot

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

On 06/09/2014 01:18 AM, Ben Dooks wrote: On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote: On 05/30/2014 07:33 PM, David Daney wrote: On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe wrote: --- a/drivers/gpio/gpiolib.c +++

[PATCH 03/76] staging: rtl8723au: rtw_mlme.c: Convert rtw_get_wps_ie23a() to cfg80211_find_vendor_ie()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index b1fa5dc..76e1797 100644 ---

[PATCH 10/76] staging: rtl8723au: Declare rtw_get_wpa{2, }_cipher_suite() static

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 12 ++-- drivers/staging/rtl8723au/include/ieee80211.h | 2 -- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c b/drivers/s

[PATCH 06/76] staging: rtl8723au: Remove obsolete rtw_get_wps_ie23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 44 -- drivers/staging/rtl8723au/include/ieee80211.h | 1 - 2 files changed, 45 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c b/drivers/stag

[PATCH 32/76] staging: rtl8723au: rtw_check_bcn_info23a(): Use ether_addr_equal() to check BSSID

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c b/drivers/staging/rtl8723au/core/rtw_wlan_util.c index 3195b44..a2c249f 10

[PATCH 07/76] staging: rtl8723au: rtw_get_bcn_info23a(): Use cfg80211_* to obtain crypto info

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 29 +- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c b/drivers/staging/rtl8723au/core/rtw_ieee80211.c ind

[PATCH 20/76] staging: rtl8723au: Reference correct firmwarefiles with MODULE_FIRMWARE()

From: Jes Sorensen Add missing firmware references, and request the correct one. Reported-by: Larry Finger Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/os_intfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/os_dep/os_int

[PATCH 38/76] staging: rtl8723au: Allocate struct wlan_bssid_ex in collect_bss_info()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c| 52 drivers/staging/rtl8723au/include/rtw_mlme_ext.h | 3 -- 2 files changed, 25 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_e

[PATCH 05/76] staging: rtl8723au: rtw_ap.c: Convert from rtw_get_wps_ie23a() to cfg80211_find_vendor_ie()

From: Jes Sorensen Some of this is hackish, but so was the original code. This needs to be cleaned up eventually. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ap.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/stagi

[PATCH 17/76] staging: rtl8723au: issue_auth(): Convert to using struct ieee80211_mgmt

From: Jes Sorensen This reduces the dependency of rtw_set_fixed_ie23a() which is scheduled to go away. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 101 +++--- 1 file changed, 44 insertions(+), 57 deletions(-) diff --git a/drivers/staging

[PATCH 26/76] staging: rtl8723au: ioctl_cfg80211.c: Use struct ieee80211_mgmt to build mgmt frame

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 30 --- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211

[PATCH 30/76] staging: rtl8723au: Remove unused #defines WEP_KEY_LEN and MGMT_QUEUE_NUM

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/ieee80211.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723au/include/ieee80211.h b/drivers/staging/rtl8723au/include/ieee80211.h index cb3f4fa..7d22825 100644 --- a/drivers/stagi

[PATCH 15/76] staging: rtl8723au: Be consistent in how htpriv.ht_option is checked

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ap.c| 6 +++--- drivers/staging/rtl8723au/core/rtw_mlme.c | 2 +- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 6 +++--- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 4 ++-- 4 files change

[PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

From: Jes Sorensen Greg, Thanks for pushing my other changes to Linus. This set goes on top of the set I sent you on 2014/05/31 and the fix from 2014/06/03. If you prefer I go back and submit it all as one large set, let me know. This set contains a number of fixes, including getting rid of som

[PATCH 40/76] staging: rtl8723au: free_scanqueue(): Use _rtw_free_network23a()

From: Jes Sorensen Use _rtw_free_network23() so elements are freed in one place. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl872

[PATCH 13/76] staging: rtl8723au: Remove WMM_ defines

From: Jes Sorensen Only one is used, and only describes the size of an array defined in a local function. Use sizeof() in the local function to deobfuscate it. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 7 --- drivers/staging/rtl8723au/include/wifi.h | 7 -

[PATCH 09/76] staging: rtl8723au: Remove obsolete rtw_get_sec_ie23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 75 -- drivers/staging/rtl8723au/include/ieee80211.h | 2 - 2 files changed, 77 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c b/drivers/stag

[PATCH 36/76] staging: rtl8723au: rtw_survey_event_cb23a(): Use the correct types for the received arguments

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index 44a5249..639dfca 100644 --- a/drivers/s

[PATCH 12/76] staging: rtl8723au: OnAssocRsp23a(): Use cfg80211_* to parse IEs

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 66 +++ 1 file changed, 37 insertions(+), 29 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c index

[PATCH 14/76] staging: rtl8723au: Make struct ht_priv.ht_option a bool

From: Jes Sorensen Match the return type of rtw_restructure_ht_ie23a() accordingly Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c| 4 ++-- drivers/staging/rtl8723au/include/rtw_ht.h | 2 +- drivers/staging/rtl8723au/include/rtw_mlme.h | 4 ++-- 3 files changed,

[PATCH 11/76] staging: rtl8723au: Make WMM_param_handler23a() and HT_caps_handler23a() take a const u8 *

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 4 ++-- drivers/staging/rtl8723au/include/rtw_mlme_ext.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c b/drivers/stagi

[PATCH 02/76] staging: rtl8723au: rtw_mlme_ext.c: Convert rtw_get_wps_ie23a() to cfg80211_find_vendor_ie()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 15 +- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 40 +++--- drivers/staging/rtl8723au/include/ieee80211.h | 4 +-- 3 files changed, 34 insertions(+), 25 delet

[PATCH 04/76] staging: rtl8723au: ioctl_cfg80211.c: Convert rtw_get_wps_ie23a() to cfg80211_find_vendor_ie()

From: Jes Sorensen Given that the IE len is stored in a u8, there is no point having a 512 buffer to store it, nor check if the size exceeds this size. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/ieee80211.h | 2 +- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c |

[PATCH 37/76] staging: rtl8723au: Do not embed struct wlan_bssid_ex in struct survey_event

From: Jes Sorensen Instead allocate it separately and reference it from survey_event. This will allow for us to pass it on later without having to copy it. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 5 - drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 9

[PATCH 23/76] staging: rtl8723au: issue_action_BSSCoexistPacket(): Use struct ieee80211_mgmt

From: Jes Sorensen This gets rid of the rtw_set_fixed_ie23a() usage here. Note that this abuses ieee80211_mgmt.u.action.u.chan_switch for now, since the correct defines are currently missing, and this one matches. Need to fix up the definitions in ieee80211.h and afterwards fix it up here. Sign

[PATCH 27/76] staging: rtl8723au: issue_action_BA23a(): Use struct ieee80211_mgmt to build action frames

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 149 +- 1 file changed, 74 insertions(+), 75 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c index

[PATCH 08/76] staging: rtl8723au: rtw_wlan_util.c: Use cfg80211_* to determine crypto

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c b/drivers/staging/rtl8723au/core/rtw_wlan_util.c index 82904d0..043

[PATCH 19/76] staging: rtl8723au: Request correct firmware file for A-cut parts

From: Jes Sorensen The filename requested by the driver didn't match what we had sitting in /lib/firmware/ Reported-by: Ben Hutchings Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s

[PATCH 42/76] staging: rtl8723au: OnAuth23a(): Use ether_addr_copy()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c index 14193b4..bed7eb7 100644 --- a

[PATCH 25/76] staging: rtl8723au: Let cfg80211 handle public action management frames

From: Jes Sorensen The driver shouldn't be dealing with public action management frames. Let these go directly to the cfg80211 layer which can defer them to userland if needed. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 26 drivers/staging/rtl872

[PATCH 24/76] staging: rtl8723au: Do not xmit BSS Coexistence management action frames

From: Jes Sorensen The driver should not be issuing BSS Coexistence management action frames when scanning. This isn't required by the spec, and if needed, these should come from wpa_s instead. Recommended by Johannes Berg. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ml

[PATCH 43/76] staging: rtl8723au: Get rid of IW_ESSID_MAX_SIZE

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 3 ++- drivers/staging/rtl8723au/include/ieee80211.h | 2 -- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/driver

[PATCH 22/76] staging: rtl8723au: issue_action_spct_ch_switch23a(): Use struct ieee80211_mgmt

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 32 +++ 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c index

[PATCH 39/76] staging: rtl8723au: collect_bss_info(): Don't memset() what we just kzalloc()'d

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c index 02180fc..14193b4 100644 --- a/drivers/stagin

[PATCH 21/76] staging: rtl8723au: _issue_deauth(): Use struct ieee80211_mgmt to build frame

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c index

[PATCH 29/76] staging: rtl8723au: Remove duplicate defines of IEEE80211_HT_PARAM_CHA_SEC_*

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 10 -- drivers/staging/rtl8723au/include/ieee80211.h | 5 - 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c b/drivers

[PATCH 31/76] staging: rtl8723au: Remove some unused 80211 header parsing macros

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/ieee80211.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723au/include/ieee80211.h b/drivers/staging/rtl8723au/include/ieee80211.h index 7d22825..c2c57c7 100644 --- a/driv

[PATCH 28/76] staging: rtl8723au: Remove obsolete rtw_set_fixed_ie23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 8 drivers/staging/rtl8723au/include/ieee80211.h | 1 - 2 files changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c b/drivers/staging/rtl8723au/core/rt

[PATCH 18/76] staging: rtl8723au: issue_assocrsp(): Use struct ieee80211_mgmt instead of rtw_set_fixed_ie23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 33 +++ 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c index

[PATCH 01/76] staging: rtl8723au: rtw_get_wps_ie23a(): Remove unused dest pointer wps_ie

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ap.c | 7 +-- drivers/staging/rtl8723au/core/rtw_ieee80211.c| 7 +-- drivers/staging/rtl8723au/core/rtw_mlme.c | 2 +- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 6 ++

[PATCH 41/76] staging: rtl8723au: rtw_stadel_event_callback23a(): Remove superfluous memset()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index 7c99c37..bcc6893 100644 --- a/drivers/staging/rtl8723au/

[PATCH 54/76] staging: rtl8723au: rtw_do_join23a(): Use correct error return values

From: Jes Sorensen Don't mix true/fail with _SUCCESS/_FAIL as return value Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ioctl_set.c b/drivers/staging/rtl872

[PATCH 55/76] staging: rtl8723au: Minor debug message fixup

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index 2a0c43a..31cf1ac 100644 --- a/driver

[PATCH 68/76] staging: rtl8723au: Move rtw_do_join23a() to rtw_mlme.c and declare it static

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c| 33 drivers/staging/rtl8723au/core/rtw_mlme.c | 38 +-- drivers/staging/rtl8723au/include/rtw_ioctl_set.h | 1 - 3 files changed, 36 insertion

[PATCH 67/76] staging: rtl8723au: rtw_do_join23a(): Don't start scanning if network isn't found

From: Jes Sorensen Don't start running network scans if trying to connect to a network not in our cache. Let the 802.11 stack do it's job instead. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 85 -- 1 file changed, 13 insertions(+), 7

[PATCH 72/76] staging: rtl8723au: rtw_set_802_11_bssid23a_list_scan(): Use __func__ to print function name

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ioctl_set.c b/drivers/staging/rtl8723au/core/rtw_ioctl_set.c index b58cd9e..30287a

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

On 06/09/2014 01:29 PM, Lars-Peter Clausen wrote: > On 06/09/2014 01:18 AM, Ben Dooks wrote: >> On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote: >>> On 05/30/2014 07:33 PM, David Daney wrote: On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: > On Fri, May 30, 2014 at 1:3

[PATCH 56/76] staging: rtl8723au: Don't prepend debug console messages with 'ERROR '

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/rtw_debug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/include/rtw_debug.h b/drivers/staging/rtl8723au/include/rtw_debug.h index a69d6e2..b6b0173 100644 --- a

[PATCH 50/76] staging: rtl8723au: cfg80211_rtw_connect(): Simplify ssid preparation

From: Jes Sorensen Since we just matched sme->{ssid,ssid_len} to pnetwork->network.Ssid.{ssid,ssid_len} we can simplify the copy and move it to just before the call to rtw_set_ssid(). Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 11 --- 1 file cha

[PATCH 48/76] staging: rtl8723au: cfg80211_rtw_connect(): Clean up various bits

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 53 +-- 1 file changed, 20 insertions(+), 33 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211

[PATCH 52/76] staging: rtl8723au: rtw_set_ssid(): This is never called with _FW_UNDER_LINKING

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c index 2cb2c7e..3819368 100644 --- a/dr

[PATCH 76/76] staging: rtl8723au: rtw_cfg80211_set_wpa_ie(): Avoid pointless memcpy

From: Jes Sorensen There is no point copying a buffer, just to scan it and then free it again. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8723au/

[PATCH 60/76] staging: rtl8723au: rtw_surveydone_event_callback23a(): Remove superfluous memset()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index 4a146fb..77a0a4a 100644 --- a/drivers/staging/rtl8723au/

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

Russell, On Fri, Jun 6, 2014 at 10:56 AM, Russell King wrote: > The initial state at boot is assumed to be disconnected, and we hope > to receive an interrupt to update the status. Let's be more explicit > about the current state - reading the PHY status register tells us > the current level of

RE: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

From: Of Andrzej Hajda ... > > You can't error out on module unload, although that's not really relevant > > here. gpiochip_remove() is typically called when the device that registered > > the GPIO chip is unbound. And despite some remove() callbacks having a > > return type of int you can not abor

[PATCH 58/76] staging: rtl8723au: Introduce rtw_do_join_network()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 2 -- drivers/staging/rtl8723au/core/rtw_mlme.c | 46 -- drivers/staging/rtl8723au/include/rtw_mlme.h | 2 ++ 3 files changed, 30 insertions(+), 20 deletions(-)

[PATCH 66/76] staging: rtl8723au: rtw_set_ssid(): Use rtw_do_join_network()

From: Jes Sorensen We already have the wlan_network we wish to join, hence it's pointless to go back to the scanned_queue and pull it out of there, before running the join logic. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 25 +++ 1 f

[PATCH 73/76] staging: rtl8723au: Don't run regular scans in the driver, the stack handles that

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/Makefile| 1 - drivers/staging/rtl8723au/core/rtw_ioctl_set.c| 78 --- drivers/staging/rtl8723au/core/rtw_mlme.c | 21 -- drivers/staging/rtl8723au/include/rtw_ioctl

[PATCH 64/76] staging: rtl8723au: rtw_surveydone_event_callback23a(): We always set _FW_UNDER_LINKING

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index 06dc897..d2b38f7 100644 --- a/drivers/

[PATCH 69/76] staging: rtl8723au: rtw_get_cur_max_rate23a(): Remove duplicate fwstate checks

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ioctl_set.c b/drivers/staging/rtl8723au/core/rtw_ioctl_set.c index 77835fc..481f94c 100644 --- a/drivers/s

[PATCH 45/76] staging: rtl8723au: cfg80211_rtw_connect(): Check correct return value from rtw_set_802_11_ssid23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c index d4eb2a9..1168e7c

[PATCH 16/76] staging: rtl8723au: Make struct htpriv.ampdu_enable a bool

From: Jes Sorensen Be consistent in parsing it's value Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 5 ++--- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8723au/include/rtw_ht.h| 2 +- 3 files changed, 4 insertions(+), 5 deleti

[PATCH 53/76] staging: rtl8723au: rtw_cfg80211_add_wep(): Use WLAN_KEY_LEN_*

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c index 3819368..4506

[PATCH 71/76] staging: rtl8723au: Move rtw_get_cur_max_rate23a() to ioctl_cfg80211.c

From: Jes Sorensen This function has only one caller, so move it home and declare it static Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c| 63 --- drivers/staging/rtl8723au/include/rtw_ioctl_set.h | 1 - drivers/staging/rtl8723au/os_dep

[PATCH 59/76] staging: rtl8723au: rtw_do_join23a(): Use __func__ to get function name in debug messages

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ioctl_set.c b/drivers/staging/rtl8723au/core/rtw_ioctl_set.c index d2ed9d1..f3d

[PATCH 34/76] staging: rtl8723au: rtw_check_bcn_info23a(): Don't search for WPA/WPA2 info twice

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 63 ++ 1 file changed, 25 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c b/drivers/staging/rtl8723au/core/rtw_wlan_util.c ind

[PATCH 46/76] staging: rtl8723au: Fold rtw_set_802_11_authentication_mode23a() into cfg80211_rtw_connect()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c| 24 --- drivers/staging/rtl8723au/include/rtw_ioctl_set.h | 2 -- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 10 +++--- 3 files changed, 7 insertions(+), 29 d

[PATCH 75/76] staging: rtl8723au: Move FillH2CCmd() prototype to rtl8723a_cmd.h where it really belongs

From: Jes Sorensen As an added bonus, remove the now obsolete rtw_ioctl_set.h Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 1 - .../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 1 - drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 1 - drivers

[PATCH 63/76] staging: rtl8723au: to_join will no be true if _FW_LINKED is set

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index efb2161..06dc897 100644 ---

[PATCH 44/76] staging: rtl8723au: Make rtw_is_same_ibss23a() return bool

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 44 -- drivers/staging/rtl8723au/core/rtw_mlme.c | 6 ++-- drivers/staging/rtl8723au/include/rtw_mlme.h | 4 +-- 3 files changed, 33 insertions(+), 21 deletions(-

[PATCH 65/76] staging: rtl8723au: rtw_select_and_join_from_scanned_queue23a() never returns 2

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index d2b38f7..1557088 100644 --- a/drivers

[PATCH 74/76] staging: rtl8723au: Quiet unused variable warning when building with CONFIG_8723AU_AP_MODE=n

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c index 59047ad..0d52699 100644 --- a

[PATCH 61/76] staging: rtl8723au: Consolidate duplicate adhoc joining code into rtw_do_join_adhoc()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 40 +-- drivers/staging/rtl8723au/core/rtw_mlme.c | 93 ++ drivers/staging/rtl8723au/include/rtw_mlme.h | 1 + 3 files changed, 41 insertions(+), 93 deleti

[PATCH 33/76] staging: rtl8723au: rtw_check_bcn_info23a(): Don't make a local copy of beacon just to parse it

From: Jes Sorensen In addition be consistent with return values and parsing them. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 88 +- 2 files changed, 32 insertions(+), 58 deleti

[PATCH 47/76] staging: rtl8723au: Move rtw_set_802_11_ssid23a() to ioctl_cfg80211.c

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c| 135 -- drivers/staging/rtl8723au/include/rtw_ioctl_set.h | 2 - drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 134 - 3 files changed, 132 inser

[PATCH 62/76] staging: rtl8723au: Remove no-op rtw_get_encrypt_decrypt_from_registrypriv23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c| 7 --- drivers/staging/rtl8723au/include/rtw_mlme.h | 2 -- 2 files changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c

[PATCH 49/76] staging: rtl8723au: cfg80211_rtw_connect(): Remove obfuscating pointers

From: Jes Sorensen dst_ssid and dst_bssid were just obfuscating that we were in fact looking at pnetwork. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/

[PATCH 70/76] staging: rtl8723au: rtw_get_cur_max_rate23a(): We are in N mode if WLAN_EID_HT_CAPABILITY is present

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 63 -- 1 file changed, 29 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ioctl_set.c b/drivers/staging/rtl8723au/core/rtw_ioctl_set.c ind

[PATCH 35/76] staging: rtl8723au: Declare rtw_update_scanned_network() static

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c| 6 +++--- drivers/staging/rtl8723au/include/rtw_mlme.h | 2 -- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/

[PATCH 51/76] staging: rtl8723au: Pass a struct wlan_network to rtw_set_ssid()

From: Jes Sorensen There is no point copying the ssid out of struct wlan_network when we can just pass on the whole struct. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 32 +++ 1 file changed, 15 insertions(+), 17 deletions(-) diff --

[PATCH 57/76] staging: rtl8723au: Introduce rtw_select_candidate_from_queue()

From: Jes Sorensen This splits a portion of rtw_select_and_join_from_scanned_queue23a() into rtw_select_candidate_from_queue() Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

On Mon, Jun 09, 2014 at 10:44:14AM -0300, Fabio Estevam wrote: > Russell, > > On Fri, Jun 6, 2014 at 10:56 AM, Russell King > wrote: > > The initial state at boot is assumed to be disconnected, and we hope > > to receive an interrupt to update the status. Let's be more explicit > > about the cur

Re: [PATCH] staging: bcm: nvm.c: Cleaning up a array that is filled incompletely

On Sun, Jun 08, 2014 at 11:45:28PM +0200, Rickard Strandqvist wrote: > Array 'SigBuff' is filled incompletely. > Someone forget to multiply for the sizeof type. > > This was partly found using a static code analysis program called cppcheck. > I took a look at code which uses MAX_RW_SIZE and it's

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux wrote: > Please check the status in /sys/class/drm/card0-HDMI-A-1/status. This > should report the current state of the hotplug detection. /sys/class/drm/card0-HDMI-A-1/status returns the correct state for HDMI cable connection. > Remem

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

On Mon, Jun 09, 2014 at 11:29:28AM -0300, Fabio Estevam wrote: > On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux > wrote: > > > Please check the status in /sys/class/drm/card0-HDMI-A-1/status. This > > should report the current state of the hotplug detection. > > /sys/class/drm/card0-

[patch] VME: remove duplicate CA91CX42_DCTL_VDW_M define

The CA91CX42_DCTL_VDW_M define is cut and pasted twice so we can delete the second instance. Signed-off-by: Dan Carpenter diff --git a/drivers/vme/bridges/vme_ca91cx42.h b/drivers/vme/bridges/vme_ca91cx42.h index 02a7c79..d46b12d 100644 --- a/drivers/vme/bridges/vme_ca91cx42.h +++ b/drivers/vme

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Greg, > > Thanks for pushing my other changes to Linus. This set goes on top of > the set I sent you on 2014/05/31 and the fix from 2014/06/03. If you > prefer I go back and submit it all as one lar

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

On Mon, Jun 9, 2014 at 11:33 AM, Shawn Guo wrote: > On Mon, Jun 09, 2014 at 11:29:28AM -0300, Fabio Estevam wrote: >> On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux >> wrote: >> >> > Please check the status in /sys/class/drm/card0-HDMI-A-1/status. This >> > should report the current s

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

Greg KH writes: > On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote: >> From: Jes Sorensen >> >> Greg, >> >> Thanks for pushing my other changes to Linus. This set goes on top of >> the set I sent you on 2014/05/31 and the fix from 2014/06/03. If you >> prefer I go back an

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

On Mon, Jun 09, 2014 at 05:39:54PM +0200, Jes Sorensen wrote: > Greg KH writes: > > On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote: > >> From: Jes Sorensen > >> > >> Greg, > >> > >> Thanks for pushing my other changes to Linus. This set goes on top of > >> the set I sen

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

Greg KH writes: > On Mon, Jun 09, 2014 at 05:39:54PM +0200, Jes Sorensen wrote: >> Greg KH writes: >> > I don't feel comfortable justifying that to Linus or anyone about how >> > important it is to get into 3.16-final, sorry. >> > >> > So, can you split this out into "bugfixes/regressions" and "c

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

On 06/09/2014 10:39 AM, Jes Sorensen wrote: Greg KH writes: On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen Greg, Thanks for pushing my other changes to Linus. This set goes on top of the set I sent you on 2014/05/31 and the fix from 2014/06/03. I

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

On Mon, Jun 09, 2014 at 05:51:24PM +0200, Jes Sorensen wrote: > Greg KH writes: > > On Mon, Jun 09, 2014 at 05:39:54PM +0200, Jes Sorensen wrote: > >> Greg KH writes: > >> > I don't feel comfortable justifying that to Linus or anyone about how > >> > important it is to get into 3.16-final, sorry.

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

On Mon, Jun 09, 2014 at 10:54:46AM -0500, Larry Finger wrote: > On 06/09/2014 10:39 AM, Jes Sorensen wrote: > >Greg KH writes: > >>On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote: > >>>From: Jes Sorensen > >>> > >>>Greg, > >>> > >>>Thanks for pushing my other changes to Li

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

On Mon, Jun 09, 2014 at 11:29:28AM -0300, Fabio Estevam wrote: > On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux > wrote: > > > Please check the status in /sys/class/drm/card0-HDMI-A-1/status. This > > should report the current state of the hotplug detection. > > /sys/class/drm/card0-

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

On Mon, Jun 9, 2014 at 2:49 PM, Russell King - ARM Linux wrote: > On Mon, Jun 09, 2014 at 11:29:28AM -0300, Fabio Estevam wrote: >> On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux >> wrote: >> >> > Please check the status in /sys/class/drm/card0-HDMI-A-1/status. This >> > should report

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

On Mon, Jun 9, 2014 at 3:15 PM, Fabio Estevam wrote: >> I wonder if the problem is that HDMI and LVDS are interfering with each >> other wrt the required pixel clock, and LVDS is winning. If we have >> HDMI enabled, many HDMI sinks will only work if we set one of their >> supported modes (with th

  1   2   >