On Fri, Jun 06, 2014 at 08:02:18PM -0700, Thomas Wood wrote:
> Remove initialization of static value.
> Invert the empty if statement's test to replace the else statement.
> Remove parentheses from a return statement.
> Fix some code indentation.
> 
> Signed-off-by: Thomas Wood <tommyandr...@gmail.com>
> ---
> 
> I'm pretty sure that the indentation was caused by a mistake by me earlier on 
> in the patch set, so I'm fixing it now.
> 

No....  That's not the right thing.  If you cause the mistake earlier,
then redo the earlier patch.

Also I feel like fixing the indent here makes the patch into a "does too
many things in one go patch."  This patch is on the limit anyway.

regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to