Re: [PATCH 2/5] staging/iio: IIO_SIMPLE_DUMMY_BUFFER neds IIO_BUFFER

On 05/06/14 21:48, Arnd Bergmann wrote: An obviously missing 'select' statement, without this we get a link error Signed-off-by: Arnd Bergmann Cc: Jonathan Cameron Cc: linux-...@vger.kernel.org Applied to the fixes-togreg branch of iio.git Thanks, Jonathan --- drivers/staging/iio/Kconfig

Re: [PATCH v2 1/4] dma-mapping: Add devm_ interface for dma_map_single()

Hello Shuah, We agree that the streaming API was originally *intended* for short map-unmap DMA sessions, and that dma_alloc_noncoherent() was the *intended* API for those who want to hold the DMA during a device's lifetime. We also agree that on some platforms, DMA mappings are precious, an

[PATCH] Staging: comedi: check the return value of kobject_set_name

Added a check of the return value of the kobject_set_name function. Signed-off-by: Anton Protopopov --- drivers/staging/comedi/comedi_fops.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c in

[PATCHv3 2/3] list: Fix order of arguments for hlist_add_after(_rcu)

From: Ken Helias All other add functions for lists have the new item as first argument and the position where it is added as second argument. This was changed for no good reason in this function and makes using it unnecessary confusing. The name was changed to let old code generate a compile err

Re: [PATCH v2 0/5] staging: ft1000: ft1000-usb: ft1000_debug.c: Fix style errors and warnings.

On Fri, Jun 06, 2014 at 08:02:13PM -0700, Thomas Wood wrote: > Changes since v1: > * Made single patch into a patch set. > * Added better commit messages. > > Is this better, or do I still have to split up my first patch? At first glance, it looks fine, I'll queue this up after 3.16-rc1 is out

[PATCH linux-next] staging: r8192ee: Adapt flush function prototype

Commit 77be2c54c5bd 'mac80211: add vif to flush call' modifies the flush operation prototype. Update r8192ee function accordingly. This fixes the following compilation warnings: drivers/staging/rtl8192ee/core.c: At top level: drivers/staging/rtl8192ee/core.c:1599:2: warning: initialization fr

Re: [PATCH] staging: bcm: Fix out of bounds access in CmHosts.c

On Wed, Jun 04, 2014 at 07:04:30AM +0900, Masanari Iida wrote: > An array u8IPv6FlowLable[] is defined as 3 in cntrl_SignalingInterface.h. > But in CmHosts.c, the kernel accessed to clsRule.u8IPv6FlowLable[5]. > It's only used in debug code which is ifdefed out. It's a bit dangerous to change th

Re: [PATCH] staging: tidspbridge: pmgr: dspapi.c: Cleaning up uninitialized variable

On Wed, Jun 04, 2014 at 12:23:39AM +0200, Rickard Strandqvist wrote: > There is a risk that the variables will be used without being initialized. > Has also improved error handling, after an email proposal from Dan Carpenter. > > Signed-off-by: Rickard Strandqvist Looks ok. This fixes some info

Re: [PATCH linux-next] staging: r8192ee: Adapt flush function prototype

On 06/07/2014 12:39 PM, Vincent Stehlé wrote: Commit 77be2c54c5bd 'mac80211: add vif to flush call' modifies the flush operation prototype. Update r8192ee function accordingly. This fixes the following compilation warnings: drivers/staging/rtl8192ee/core.c: At top level: drivers/staging/r

Re: [PATCH] staging: tidspbridge: pmgr: dspapi.c: Cleaning up uninitialized variable

Hi Sure, no problem! Glad I could help, and additionally with more than just a two-line fix this time :-) Best regards Rickard Strandqvist 2014-06-07 21:44 GMT+02:00 Dan Carpenter : > On Wed, Jun 04, 2014 at 12:23:39AM +0200, Rickard Strandqvist wrote: >> There is a risk that the variables wil

[PATCH] staging: rtl8821ae: rtl8821ae: hw.c: Cleaning up if statement that always evaluates to false

I find a logical error in an if statement '(X & 0xfc) == 0x3' is always false After pointing this out, Larry Finger informed what would be the correct one. '(X & 0x3) == 0x3' Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8821ae/rtl8821ae/hw.c |2 +- 1 file changed, 1 insertion(+