Hi
On Mon, Dec 16, 2013 at 2:01 PM, Jiri Kosina wrote:
> On Fri, 27 Sep 2013, Joseph Salisbury wrote:
>
>> >> commit b1a1442a23776756b254b69786848a94d92445ba
>> >> Author: Jiri Kosina
>> >> Date: Mon Jun 3 11:27:48 2013 +0200
>> >>
>> >> HID: core: fix reporting of raw events
>> >>
>> >> Rev
On Thu, 19 Dec 2013, David Herrmann wrote:
> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> > index 253fe23..81eacd3 100644
> > --- a/drivers/hid/hid-core.c
> > +++ b/drivers/hid/hid-core.c
> > @@ -1334,7 +1334,7 @@ int hid_report_raw_event(struct hid_device *hid, int
> > type,
Hi
On Thu, Dec 19, 2013 at 10:59 AM, Jiri Kosina wrote:
> On Thu, 19 Dec 2013, David Herrmann wrote:
>
>> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
>> > index 253fe23..81eacd3 100644
>> > --- a/drivers/hid/hid-core.c
>> > +++ b/drivers/hid/hid-core.c
>> > @@ -1334,7 +1334,7 @
Hi
On Thu, Dec 19, 2013 at 11:08 AM, David Herrmann wrote:
> Hi
>
> On Thu, Dec 19, 2013 at 10:59 AM, Jiri Kosina wrote:
>> On Thu, 19 Dec 2013, David Herrmann wrote:
>>
>>> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
>>> > index 253fe23..81eacd3 100644
>>> > --- a/drivers/hid
This patch contains several whitespace cleanups for the beeceem driver that
have been reported by checkpatch.
Subsequent patches will fix other issues that checkpatch complains about and
which still remain after applying this patch.
Signed-off-by: Ralph Mueck
Signed-off-by: Matthias Oefelein
On Thu, 19 Dec 2013, David Herrmann wrote:
> As this thread doesn't really contain any oops message nor the exact
> driver name (except mentioning hyperv and magicmouse),
FWIW I recall the oopses being present somewhere in the ubuntu bug
tracker, referenced in this thread.
Thanks,
--
Jiri Ko
On Thu, Dec 19, 2013 at 12:13:14PM +0100, Ralph Mueck wrote:
> This patch contains several whitespace cleanups for the beeceem driver that
> have been reported by checkpatch.
Too ambigous.
> Subsequent patches will fix other issues that checkpatch complains about and
> which still remain after
From: Simon Schuster
This patch reduces the level of indentation in bssdb.c of the vt6656
driver by transforming nested conditions to a series of logical
conjunctions. E.g.
if (cond1) {
if (cond2) {
block();
}
}
is transformed to
if (cond1 && cond2) {
bl
This patch series reformats the bssdb.c file of the vt6656 driver in
staging. It resolves all errors and some warnings which checkpatch.pl
discovered.
However some occurrences of the following warnings are not patched:
- Lines over 80 characters
- Too many indentation levels
- printk should includ
This patch fixed trailing whitespace found by
checkpatch.pl within dgap_trace.c
Signed-off-by: Masanari Iida
---
drivers/staging/dgap/dgap_trace.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/dgap/dgap_trace.c
b/drivers/staging/dgap/dgap_t
On Thu, Dec 19, 2013 at 04:27:05PM +0100, Sebastian Rachuj wrote:
> From: Simon Schuster
>
> This patch reformats bssdb.c of the vt6656 driver (in staging) to
> conform to the linux coding guidelines.
>
> The indentation is adjusted to use tabs, the argument lists and
> conditions are aligned to
On Wed, 2013-12-18 at 14:21 -0800, Haiyang Zhang wrote:
> This feature allows multiple channels to be used by each virtual NIC.
> It is available on Hyper-V host 2012 R2.
[...]
> --- a/drivers/net/hyperv/netvsc.c
> +++ b/drivers/net/hyperv/netvsc.c
[...]
> @@ -525,15 +535,21 @@ int netvsc_send(stru
On 12/19/2013 07:36 PM, Haiyang Zhang wrote:
Thank you for the suggestions! I will re-write the send queue selection, enhance
the hash calculation, also fix the initialization sequence.
Btw, Toeplitz hash function should either go into lib/hash.c as well or
include/linux/hash.h to avoid ending
> -Original Message-
> From: Daniel Borkmann [mailto:dbork...@redhat.com]
> Sent: Thursday, December 19, 2013 1:45 PM
> To: Haiyang Zhang
> Cc: Ben Hutchings; da...@davemloft.net; net...@vger.kernel.org; KY
> Srinivasan; o...@aepfle.de; jasow...@redhat.com; linux-
> ker...@vger.kernel.org
> -Original Message-
> From: Ben Hutchings [mailto:bhutchi...@solarflare.com]
> Sent: Thursday, December 19, 2013 12:46 PM
> To: Haiyang Zhang
> Cc: da...@davemloft.net; net...@vger.kernel.org; KY Srinivasan;
> o...@aepfle.de; jasow...@redhat.com; linux-ker...@vger.kernel.org;
> driverdev
On Thu, 2013-12-19 at 13:43 -0800, Tom Herbert wrote:
> Patch is below. This version did most pre-computation of the variants
> I built, but results in largest table (40*256*4 bytes), This gives
> performance roughly comparable with jhash (roughly same as jhash for
> IPv4, about 30% more cycles for
From: Tom Herbert
Date: Thu, 19 Dec 2013 13:43:06 -0800
> + u32 v, r;
> + int off, rem;
> +
> + off = idx / 8;
> + rem = idx % 8;
> +
> + v = (((unsigned int)key[off]) << 24) +
> + (((unsigned int)key[off + 1]) << 16) +
> + (((unsigned int)key[off
The shared "Status" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 4 ++--
drivers/staging/comedi/
The "Mode" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 10 +-
drivers/staging/comedi/dri
The ni_tio module is used by the ni_atmio, ni_660x, ni_pcimio and ni_mio_cs
drivers to provide support functions for the NI General Purpose Counters.
The ni_tiocmd module is used by the ni_660x and ni_pcimio to support async
commands with the counters.
These boards that have different register ma
The "DMA Status" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio_internal.h | 16 +---
drivers/stagin
Change the parameters to ni_tio_insn_config() to make it a proper comedi
(*insn_config) function. This allows using it directly and removing the
wrapper functions in the ni_660x and ni_mio_common modules.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/stagin
The "LoadA" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 14 +++---
drivers/staging/comed
For aesthetics, move all the MODULE_* information to the end of the file.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 32 +++-
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/dr
The "Interrupt Enable" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 2 +-
drivers/staging/comedi
For aesthetics, move all the MODULE_* information to the end of the file.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tiocmd.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/
The "LoadB" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 14 +++---
drivers/staging/comed
The "Input Select" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 18 +-
drivers/st
The "SW Save" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 7 +++
drivers/staging/comedi/dri
The "Status" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Rename the define for the shared status register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c
Change the parameters to ni_tio_cmd() to make it a proper comedi
(*do_cmd) function.
The wrappers in the ni_660x and ni_mio_common modules are still needed
to request the mite channel and setup the device before actually doing
the command.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Gre
The "HW Save" registers are the only ones missing an access macro.
Add one for completness.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio_internal.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/dri
The 'extern' is not required, remove it.
Tidy up the function prototypes a bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.h | 57 +
1 file changed, 23 insertions(+), 34 deletions(-)
diff --
This inline helper function simply returns the s->private void *.
Remove the helper and just get the s->private void * directly where
needed.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 31 +++
The "Command" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 13 ++---
drivers/staging/come
As prefered by the CodingStyle, rename all the CamelCase labels of the
enum ni_gpct_register.
Cleanup all the helper functions in ni_tio_internal.h that used the enum.
The 'counter_index' parameter to all the functions is the ni_gpct_device
'counter_index' which is initialized when the subdevices
Change the parameters to ni_tio_winsn() to make it a proper comedi
(*insn_write) function. This allows using it directly and removing the
wrapper functions in the ni_660x and ni_mio_common modules.
For aesthetics, rename the function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kro
The "DMA Config" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 2 +-
drivers/staging/comedi/drive
Use a local variable for the 'counter->chip_index' to help shorten the
long lines and clarify the code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 43 ++--
1 file changed, 24 insertions(+), 1
Use a local variable for the 'counter->counter_index' to help shorten the
long lines and ugly line breaks.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 254 ++--
1 file changed, 107 insertions(+
The shared "Reset" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 2 +-
drivers/staging/comedi/dri
The "Counting Mode" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 12 ++--
drivers/staging
The counter->chip_index will always be < counters_per_chip due to the
initialization of the subdevices during the attach of the board.
The dma_selection_counter() helper just does a BUG_ON() check before
returning the original value. Just use the original value directly
in the caller and remove th
As prefered by the CodingStyle, rename this CamelCase enum and its labels.
Also, cleanup the ni_gpct_to_660x_register() helper function. Just return the
ni_660x_register for each ni_gpct_register and remove the unnecessary break
statements after the return statements.
Signed-off-by: H Hartley Swe
Change the parameters to ni_tio_rinsn() to make is a proper comedi
(*insn_read) function. This allows using it directly and removing the
wrapper functions in the ni_660x and ni_mio_common modules.
For aesthetics, rename the function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroa
> -Original Message-
> From: Tom Herbert [mailto:therb...@google.com]
> Sent: Thursday, December 19, 2013 4:43 PM
> To: Haiyang Zhang
> Cc: Daniel Borkmann; Ben Hutchings; da...@davemloft.net;
> net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de;
> jasow...@redhat.com; linux-ker...@vger.
> -Original Message-
> From: Tom Herbert [mailto:therb...@google.com]
> Sent: Thursday, December 19, 2013 2:59 PM
> To: Haiyang Zhang
> Cc: Daniel Borkmann; Ben Hutchings; da...@davemloft.net;
> net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de;
> jasow...@redhat.com; linux-ker...@vge
Originally, this driver created it's own allocating
function. This patch removes that function and calls
kzalloc directly.
This patch affects:
- driver.c
- driver.h
- fep5.c
- tty.c
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_driver.c | 18 ++
drivers/staging
The "ABZ" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 2 +-
drivers/staging/comedi/drivers/ni_t
The "AutoIncrement" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 6 +++---
drivers/staging/comed
Clean up the multi-line comment and tidy the function a bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/comedi/dri
The shared "Status2" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio_internal.h | 14 +-
drivers/stag
The shared "Status1" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio_internal.h | 14 +-
1 file chang
Change the parameters to ni_tio_cmdtest() to make it a proper comedi
(*do_cmdtest) function. This allows using it directly and removing the
wrapper functions in the ni_660x and ni_mio_common modules.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/com
The "Second Gate" registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio.c | 18 +-
drivers/sta
Use a local variable for the 'counter->counter_index' to help shorten the
long lines and ugly line breaks.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tiocmd.c | 69 --
1 file changed, 27 insertions(+)
The "Interrupt Acknowledge" registers are sequential in the enum
ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tio_internal.h | 16 +---
dr
From: Wei Yongjun
Add the missing destroy_workqueue() before return from
sep_crypto_setup() and sep_crypto_takedown().
Signed-off-by: Wei Yongjun
---
drivers/staging/sep/sep_crypto.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/sep/sep_crypto.c b/drivers/staging/sep/se
From: Wei Yongjun
In case of error, the function crypto_alloc_hash() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun
---
drivers/staging/lustre/lustre/obdclass/capa.c | 4 ++--
1 file changed, 2 inse
Because the original driver was designed to build for Windows, FreeBSD, and
Linux,
there are wrappers for many of the OS primitives. These patches remove a number
of them.
Signed-off-by: Larry Finger
Larry Finger (11):
staging: r8188eu: Remove pointless thread_exit macro
staging: r8188eu:
Some comment lines that mentioned spin_lock_bh() are also removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 38
drivers/staging/rtl8188eu/core/rtw_br_ext.c | 16 +++
drivers/staging/rtl8188eu/core/rtw_cmd.c | 12 ++---
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 8
drivers/staging/rtl8188eu
This wrapper does nothing on Linux. When calls to it were removed, a number of
routines became empty and could also be removed.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 -
drivers/staging/rtl8188eu/core/rtw_cmd.c | 1 -
drivers/staging/rtl8
Each instance may bre replaced by udelay
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +-
drivers/staging/rtl8188eu/hal/HalPwrSeqCmd.c | 6 +++---
drivers/staging/rtl8188eu/hal/odm.c| 10 -
drivers/staging/rtl8188eu/hal/od
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 16
drivers/staging/rtl8188eu/core/rtw_mp.c| 4 ++--
drivers
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 6 +++---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c| 4 ++--
drivers/staging/rtl8188eu/core/rtw_mlme.c | 14 +++---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 12 ++--
d
Again there are two - _exit_critical() and _exit_critical_ex().
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_xmit.c | 8
drivers/stagi
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mp.c| 4 ++--
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 10 +-
drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 12 ++--
drivers/staging/rtl8188eu/hal/odm_interface.c | 5 -
dr
There are two such wrappers - _enter_critical() and _enter_critical_ex().
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_xmit.c | 8
dri
The checking condition in 'validateFlash2xReadWrite()' is not sufficient.
A large number invalid would cause an integer overflow and pass
the condition, which could cause further integer overflows in
'Bcmchar.c:bcm_char_ioctl()'.
Signed-off-by: Wenliang Fan
---
drivers/staging/bcm/nvm.c | 4 +++-
On Thu, Dec 19, 2013 at 10:38:34PM -0600, Larry Finger wrote:
> Some comment lines that mentioned spin_lock_bh() are also removed.
>
> Signed-off-by: Larry Finger
> @@ -1509,10 +1509,6 @@ _func_enter_;
>
> rtw_p2p_set_state(pwdinfo, P2P_STATE_FIND_PHASE_SEARCH);
>
> - _enter_critica
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mp.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 2 --
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/co
72 matches
Mail list logo
