On Thu, Dec 19, 2013 at 10:38:34PM -0600, Larry Finger wrote: > Some comment lines that mentioned spin_lock_bh() are also removed. > > Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> > @@ -1509,10 +1509,6 @@ _func_enter_; > > rtw_p2p_set_state(pwdinfo, P2P_STATE_FIND_PHASE_SEARCH); > > - _enter_critical_bh(&pmlmepriv->lock, &irqL); > - _exit_critical_bh(&pmlmepriv->lock, &irqL); > - > - > _func_exit_; > }
This is a functionality change that slipped in. This is like spin_unlock_wait() where you want to wait until the lock is released. In this code it's probably unintended? But don't put these things into a patch without mentioning it. regards, dan carpenter _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
