On Tue, Oct 01, 2013 at 01:21:28AM +, Paul Zimmerman wrote:
> > From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> > Sent: Monday, September 30, 2013 6:09 PM
> >
> > Yeah. I guess it's fine... I was going to suggest adding the + 1 in a
> > different place but actually it doesn't matter.
On Tue, Oct 01, 2013 at 10:05:17AM +0300, Dan Carpenter wrote:
> On Tue, Oct 01, 2013 at 01:21:28AM +, Paul Zimmerman wrote:
> > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> > > Sent: Monday, September 30, 2013 6:09 PM
> > >
> > > Yeah. I guess it's fine... I was going to sugges
On Tue, Oct 01, 2013 at 09:51:07AM +0200, Matthijs Kooijman wrote:
> On Tue, Oct 01, 2013 at 10:05:17AM +0300, Dan Carpenter wrote:
> > On Tue, Oct 01, 2013 at 01:21:28AM +, Paul Zimmerman wrote:
> > > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> > > > Sent: Monday, September 30, 2
I'm looking for some Tested-by: or Acks on this before applying the series.
I got the impression from the comments on the previous version that the
series has now been reasonably thoroughly tested on both i.MX28 and i.MX23
boards.
This is not yet reflected in the sign off trail and in fact a coupl
On Thu, Sep 26, 2013 at 01:43:25PM +1000, Dave Chinner wrote:
> On Tue, Sep 24, 2013 at 09:20:50PM +0900, Akira Hayakawa wrote:
> > * Deferring ACK for barrier writes
> > Barrier flags such as REQ_FUA and REQ_FLUSH are handled lazily.
> > Immediately handling these bios badly slows down writeboost.
Hi Jonathan,
On Tuesday 01 October 2013 11:25:46 Jonathan Cameron wrote:
> a couple of the patch descriptions say that they are untested on i.MX28.
On Monday 23 September 2013 16:36:35 Juergen Beisert wrote:
> For battery driven systems it is a very bad idea to collect the touchscreen
> data with
On 10/01/13 10:28, Jürgen Beisert wrote:
> Hi Jonathan,
>
> On Tuesday 01 October 2013 11:25:46 Jonathan Cameron wrote:
>> a couple of the patch descriptions say that they are untested on i.MX28.
>
> On Monday 23 September 2013 16:36:35 Juergen Beisert wrote:
>> For battery driven systems it is a
On 09/24/13 08:50, Jürgen Beisert wrote:
> Hi Fabio,
>
> On Monday 23 September 2013 17:13:03 Fabio Estevam wrote:
>> On 09/23/2013 11:36 AM, Juergen Beisert wrote:
>>> + lradc->clk = devm_clk_get(&pdev->dev, NULL);
>>> + clk_prepare_enable(lradc->clk);
>>
>> clk_prepare_enable() may fail, so
On 09/23/13 15:36, Juergen Beisert wrote:
> The LRADC units in i.MX23 and i.MX28 differ and we need to distinguish both
> SoC variants in order to make the touchscreen work on i.MX23
>
> Signed-off-by: Juergen Beisert
> CC: linux-arm-ker...@lists.infradead.org
> CC: linux-in...@vger.kernel.org
>
On 09/23/13 15:36, Juergen Beisert wrote:
> In order to support i.MX23 and i.MX28 within one driver we need to separate
> the
> register definitions which differ in both SoC variants.
>
> Signed-off-by: Juergen Beisert
> CC: linux-arm-ker...@lists.infradead.org
> CC: linux-in...@vger.kernel.org
On 09/23/13 15:36, Juergen Beisert wrote:
> Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at least
> for the 4 wire touchscreen.
>
> Note: support for the remaining LRADC channels is not tested on an
> i.MX23 yet.
>
> Signed-off-by: Juergen Beisert
> CC: linux-arm-ker...@
On 09/23/13 15:36, Juergen Beisert wrote:
> Replace the individual register access by a few shared access function to
> make the
> code easier to read and in order to add the i.MX23 SoC in the next step.
>
> Signed-off-by: Juergen Beisert
> CC: linux-arm-ker...@lists.infradead.org
> CC: linux-in
On 10/01/13 11:51, Jonathan Cameron wrote:
> On 10/01/13 10:28, Jürgen Beisert wrote:
>> Hi Jonathan,
>>
>> On Tuesday 01 October 2013 11:25:46 Jonathan Cameron wrote:
>>> a couple of the patch descriptions say that they are untested on i.MX28.
>>
>> On Monday 23 September 2013 16:36:35 Juergen Bei
On 09/23/13 15:36, Juergen Beisert wrote:
> Signed-off-by: Juergen Beisert
> CC: linux-arm-ker...@lists.infradead.org
> CC: linux-in...@vger.kernel.org
> CC: de...@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio Estevam
> CC: Jonathan Cameron
Applied to the togreg branch of iio.git
Thanks,
>
On 09/23/13 15:36, Juergen Beisert wrote:
> This is an RFC for the new touchscreen properties.
>
> Signed-off-by: Juergen Beisert
> CC: linux-arm-ker...@lists.infradead.org
> CC: linux-in...@vger.kernel.org
> CC: de...@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio Estevam
> CC: Jonathan Ca
On 09/23/13 15:36, Juergen Beisert wrote:
> Some things have still to be done to the LRADC driver.
>
> Signed-off-by: Juergen Beisert
> CC: linux-arm-ker...@lists.infradead.org
> CC: linux-in...@vger.kernel.org
> CC: de...@driverdev.osuosl.org
> CC: Marek Vasut
> CC: Fabio Estevam
> CC: Jonatha
On 10/01/13 12:14, Jonathan Cameron wrote:
> On 09/23/13 15:36, Juergen Beisert wrote:
>> Some things have still to be done to the LRADC driver.
>>
>> Signed-off-by: Juergen Beisert
>> CC: linux-arm-ker...@lists.infradead.org
>> CC: linux-in...@vger.kernel.org
>> CC: de...@driverdev.osuosl.org
>>
On 10/01/13 12:21, Jonathan Cameron wrote:
> On 10/01/13 12:14, Jonathan Cameron wrote:
>> On 09/23/13 15:36, Juergen Beisert wrote:
>>> Some things have still to be done to the LRADC driver.
>>>
>>> Signed-off-by: Juergen Beisert
>>> CC: linux-arm-ker...@lists.infradead.org
>>> CC: linux-in...@vg
On 2013-10-01 01:55, H Hartley Sweeten wrote:
Each analog output channel is individually configurable. The current
analog output 'range_table' selection in this driver assumes that all
the channels are configured as either bipolar or unipolar. User option[2]
is then used during the attach to sele
On 2013-10-01 01:49, H Hartley Sweeten wrote:
Cleanup another comedi driver.
This series depends on:
staging: comedi: ni_at_ao: fix namespace clash of 'RSI' define
Patch 19/21 changes the names that are used to attach to the driver.
If Ian has issues with this it can be dropped.
The previous
Hi Dan,
On 10/1/13 3:23 AM, Dan Carpenter wrote:
On Tue, Oct 01, 2013 at 09:51:07AM +0200, Matthijs Kooijman wrote:
On Tue, Oct 01, 2013 at 10:05:17AM +0300, Dan Carpenter wrote:
On Tue, Oct 01, 2013 at 01:21:28AM +, Paul Zimmerman wrote:
From: Dan Carpenter [mailto:dan.carpen...@oracle.c
Hi Dinh,
> >Somehow I assumed that was fixed by the hardware, but I see now that you
> >are right. Yes, making the definition larger is better than moving the
> >+ 1.
> This was my original fix to the problem, but I thought that it would
> be confusing when reading the code. I also thought about
Dear Jonathan Cameron,
> I'm looking for some Tested-by: or Acks on this before applying the series.
> I got the impression from the comments on the previous version that the
> series has now been reasonably thoroughly tested on both i.MX28 and i.MX23
> boards. This is not yet reflected in the sig
Hi Matthijs,
On 10/1/13 6:08 AM, Matthijs Kooijman wrote:
Hi Dinh,
Somehow I assumed that was fixed by the hardware, but I see now that you
are right. Yes, making the definition larger is better than moving the
+ 1.
This was my original fix to the problem, but I thought that it would
be conf
Hi Matthijs,
On 10/1/13 6:08 AM, Matthijs Kooijman wrote:
Hi Dinh,
Somehow I assumed that was fixed by the hardware, but I see now that you
are right. Yes, making the definition larger is better than moving the
+ 1.
This was my original fix to the problem, but I thought that it would
be conf
On Tue, Oct 01, 2013 at 06:26:29AM -0500, Dinh Nguyen wrote:
> [resend]: previous reply didn't include Matthijs
>
He sets his Mail-Followup-To: so that we don't CC him on replies. I
assume it's deliberate because he only wants the copy from the mailing
list?
regards,
dan carpenter
Hey Dan, Dinh,
> > [resend]: previous reply didn't include Matthijs
> >
>
> He sets his Mail-Followup-To: so that we don't CC him on replies. I
> assume it's deliberate because he only wants the copy from the mailing
> list?
Exactly, I just set that for whatever mailing list I subscribe to.
How
Resolve all of the 'WARNING: space prohibited before semicolon'
checkpatch warnings for rtl8712.
Signed-off-by: Thomas Cort
---
drivers/staging/rtl8712/os_intfs.c| 2 +-
drivers/staging/rtl8712/rtl8712_cmd.c | 4 ++--
drivers/staging/rtl8712/rtl8712_efuse.c | 2 +-
driv
This patch removes this smatch warning:
unsigned '--un->un_open_count' is never less than zero
The code decremented the un_open_count variable
and tested to see if it was less than zero. Because
un_open_count is unsigned and can't be below zero,
this test didn't work.
Signed-off-by: Lidza Louina
This patch adds error handling to the
tty_driver allocations in dgap_tty_register.
Now the code handles the possibility of an
alloc_tty_driver, a tty_register_driver, and
a brd->SerialDriver->ttys or brd->PrintDriver->ttys
allocation failure.
Signed-off-by: Lidza Louina
---
drivers/staging/dgap
Hi,
Just wondering if anyone tried using a webcam with the DWC2 driver? The
webcam works great when plugged in directly to the USB port, but appears
to have alot of dropped frames when used with a HS hub.
I'll debug it of course, but just wondering if anyone has had a similar
experience?
Thanks,
On Tue, Oct 01, 2013 at 12:00:23PM -0400, Lidza Louina wrote:
> @@ -306,7 +316,16 @@ int dgap_tty_register(struct board_t *brd)
>
> DPR_INIT(("DGAP REGISTER TTY: MAJORS: %d %d\n",
> brd->SerialDriver->major,
> brd->PrintDriver->major));
> -
You need a "return 0;" here otherw
On Tue, Oct 1, 2013 at 12:09 PM, Dan Carpenter wrote:
> On Tue, Oct 01, 2013 at 12:00:23PM -0400, Lidza Louina wrote:
>> @@ -306,7 +316,16 @@ int dgap_tty_register(struct board_t *brd)
>>
>> DPR_INIT(("DGAP REGISTER TTY: MAJORS: %d %d\n",
>> brd->SerialDriver->major,
>> brd->P
This patch removes this smatch warning:
unsigned '--un->un_open_count' is never less than zero
The code decremented the un_open_count variable
and tested to see if it was less than zero. Because
un_open_count is unsigned and can't be below zero,
this test didn't work.
Signed-off-by: Lidza Louina
This patch adds error handling to the
tty_driver allocations in dgap_tty_register.
Now the code handles the possibility of an
alloc_tty_driver, a tty_register_driver, and
a brd->SerialDriver->ttys or brd->PrintDriver->ttys
allocation failure.
Signed-off-by: Lidza Louina
---
drivers/staging/dgap
On Mon, Sep 30, 2013 at 9:46 PM, Greg KH wrote:
> On Fri, Sep 27, 2013 at 07:11:47AM -0400, Lidza Louina wrote:
>> On Fri, Sep 27, 2013 at 5:50 AM, Sachin Kamat
>> wrote:
>> > This check is not required.
>> >
>> > Signed-off-by: Sachin Kamat
>> > Cc: Lidza Louina
>> > ---
>> > drivers/staging
On Tuesday, October 01, 2013 3:27 AM, Ian Abbott wrote:
> On 2013-10-01 01:55, H Hartley Sweeten wrote:
>> Each analog output channel is individually configurable. The current
>> analog output 'range_table' selection in this driver assumes that all
>> the channels are configured as either bipolar o
On Tue, Oct 01, 2013 at 12:32:06PM -0400, Lidza Louina wrote:
> On Tue, Oct 1, 2013 at 12:09 PM, Dan Carpenter
> wrote:
> > On Tue, Oct 01, 2013 at 12:00:23PM -0400, Lidza Louina wrote:
> >> @@ -306,7 +316,16 @@ int dgap_tty_register(struct board_t *brd)
> >>
> >> DPR_INIT(("DGAP REGISTER T
On Tue, Oct 01, 2013 at 12:54:21PM -0400, Lidza Louina wrote:
> This patch removes this smatch warning:
> unsigned '--un->un_open_count' is never less than zero
>
> The code decremented the un_open_count variable
> and tested to see if it was less than zero. Because
> un_open_count is unsigned and
Delete redudant flags parameter.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/cvmx-usb.c | 6 ++
drivers/staging/octeon-usb/cvmx-usb.h | 4 +---
drivers/staging/octeon-usb/octeon-hcd.c | 1 -
3 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/oc
Eliminate CVMX_PREFETCH_PREFX.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/cvmx-usb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usb.c
b/drivers/staging/octeon-usb/cvmx-usb.c
index d53daf7..9647deb 100644
--- a/driver
Make comments to fit into 80 columns.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/cvmx-usb.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usb.h
b/drivers/staging/octeon-usb/cvmx-usb.h
index a8ae8ca..7b7a542 10
Delete unused cvmx_read_csr / cvmx_write_csr macros.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/cvmx-usb.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usb.c
b/drivers/staging/octeon-usb/cvmx-usb.c
index 9647deb..4cf7b8b 100644
---
Hi,
Some cleanups for octeon-usb. No functional changes. Tested on EdgeRouter
Lite + USB mass storage.
Aaro Koskinen (12):
staging: octeon-usb: delete redundant flags from cvmx_usb_initialize()
staging: octeon-usb: delete cvmx_usb_isochronous_flags
staging: octeon-usb: delete redundant flag
Eliminate CVMX_PREFETCH_PREF0.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/cvmx-usb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usb.c
b/drivers/staging/octeon-usb/cvmx-usb.c
index c5e680d..d53daf7 100644
--- a/drivers/
Inline CVMX_PREFETCH0 macro.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/cvmx-usb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usb.c
b/drivers/staging/octeon-usb/cvmx-usb.c
index c57e798..b827e8d 100644
--- a/drivers/sta
Replace CVMX_CLZ macro with __fls().
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/cvmx-usb.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usb.c
b/drivers/staging/octeon-usb/cvmx-usb.c
index 3dd732e..c57e798 100644
---
Delete unused macro.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/cvmx-usb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usb.c
b/drivers/staging/octeon-usb/cvmx-usb.c
index b827e8d..c5e680d 100644
--- a/drivers/staging/octeon-usb/cvmx-usb.c
Delete unused flags.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/cvmx-usb.c | 9 ++---
drivers/staging/octeon-usb/cvmx-usb.h | 17 +
drivers/staging/octeon-usb/octeon-hcd.c | 1 -
3 files changed, 3 insertions(+), 24 deletions(-)
diff --git a/drivers/st
Make comments to fit into 80 columns.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/cvmx-usb.c | 149 --
1 file changed, 108 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usb.c
b/drivers/staging/octeon-usb/cvmx-usb.c
i
The function will always figure out the used clock internally, so delete
a redudant parameter and the flag.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/cvmx-usb.c | 52 +
drivers/staging/octeon-usb/cvmx-usb.h | 10 ++-
drivers/staging/octeo
Delete redundant flags parameter.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/cvmx-usb.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usb.c
b/drivers/staging/octeon-usb/cvmx-usb.c
index f9a6801..54b5c5c 100644
--- a/drivers/staging/oc
Cleanup another comedi driver.
H Hartley Sweeten (22):
staging: comedi: ni_6527: remove DRIVER_NAME define
staging: comedi: ni_6527: remove unused NI6527_*_SIZE defines
staging: comedi: ni_6527: remove unused DEBUG* defines
staging: comedi: ni_6527: remove extra probe noise
staging: come
These defines are not used in the driver. Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_6527.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_6527.c
b/drivers/staging/comedi/dr
These defines are not used in the driver. Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_6527.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_6527.c
b/drivers/staging/comedi/dr
To clarify the digital input subdevice (*insn_config) a bit, factor out the
code that sets the filter interval for deglitching the digital inputs.
Also, rename the CamelCase define used for the filter interval registers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
--
The dev_info() showing the board id is just extra noise.
Remove it but make sure the probed id is correct. Rename the CamelCase
define used for the id register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_6527.c | 7 ---
1 f
To clarify the digital input subdevice (*insn_config) a bit, factor out the
code that sets the filter enables to enable deglitching the digital inputs.
Also, rename the CamelCase define used for the filter enable registers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
The digital input and output ports are different. Split the CamelCase
Port_Register() define into separate NI6527_DI_REG() and NI6527_DO_REG()
defines to make this clear.
Tidy up the functions a bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/co
Rename the CamelCase defines used for the clear register.
To clarify the code a bit, add two new defines that group the bits needed
to clear the interrupts and reset the digital input deglitch filter.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/c
Rename the CamelCase defines used for the interrupt status register.
The NI6527_STATUS_IRQ bit will be set whenever the device is asserting
an interrupt. Modify the function a bit so this is the only requirement
for the interrupt to be IRQ_HANDLED. Currently an OVERFLOW interrupt is
not handled, t
The core will validate the insn->n value based on the actual instruction
(data[0]) that is being handled. Remove the sanity check and change the
instruction handling into a switch. This follows the normal format for
(*insn_config) functions and make adding additional instructions easier.
Signed-of
For aesthetics, use a local variable for the __iomem base address
used to write to the registers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_6527.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/driv
Rename the CamelCase defines used for the interrupt control register.
To clarify the code a bit, add two new defines to enable/disable the
interrupts.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_6527.c | 32 ++---
For aesthetics, use a local variable for the __iomem base address
used to write to the registers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_6527.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/
Handle the instruction (data[0]) with a switch to make it easier
to add additional instructions in the future.
To clarify the code, factor out the code that sets the rising/falling
edge detection.
Rename the CamelCase defines used for the rising/falling edge detection
registers.
Signed-off-by: H
The COMEDI_MITE driver is a wrapper for the National Instruments
PCI MITE ASIC. This driver includes the PCI boilerplate used to
remap the resources as well as the support code for bus mastered
DMA.
The ni_6527 does not support DMA and the COMEDI_MITE driver adds
unnecessary complexity.
Remove th
For aesthetics, allocate the private data memory before attempting
to enable the PCI device.
Add some whitespace to the subdevice init.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_6527.c | 38 +---
1
Factor the board reset code out of the (*attach). Do the reset as
soon as possible to ensure the interrupts are disabled.
For convienence, use the ni6257_reset() during the (*detach) instead
of just disabling the interrupts.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
For aesthetics, add some whitespace.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_6527.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_6527.c
b/drivers/staging/comed
On 10/1/13 4:42 PM, Matthijs Kooijman wrote:
The hardware offers a 4-bit register containing the number of host
channels. However, the values of these register mean 1-16 host channels,
not 0-15. Since the dwc2_hw_params struct stores the actual number of
host channels supported instead of the ra
Fixed a lot of warnings from checkpatch.pl about the 80 characters per line
limitation.
Signed-off-by: Mathieu Rhéaume
---
drivers/staging/android/binder.c | 520 ++-
1 file changed, 353 insertions(+), 167 deletions(-)
diff --git a/drivers/staging/android/bi
This patch changes seq_printf for seq_puts in binder.c.
It fixes the warnings emitted by checkpatch.pl.
Signed-off-by: Mathieu Rhéaume
---
drivers/staging/android/binder.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging
The request_irq() call should be using dev->board_name to better
identify the irq user.
Remove the DRIVER_NAME define and just open code the 'driver_name' in
the comedi_driver and the 'name' in the pci_driver declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
Change the MODULE_DESCRIPTION to something useful instead of the
generic "Comedi low-level driver".
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_6527.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/st
Do the request_irq() before setting up the subdevices. Only initialize
the interrupt subdevice if the irq is actually available.
Tidy up the whitespace in the subdevice init.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_6527.c |
Tidy up the multi-line comments to follow the CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_6527.c | 61
1 file changed, 31 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/
The comedi_subdevice in the interrupt handler is the dev->read_subdev
that was initialized during the attach. Use that instead of accessing
the dev->subdevices[] array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_6527.c
Changes since v2:
* Fixed the indent problems (2 tab and 1 space) by Joe Perches.
* Found more calls to convert from seq_printf to seq_puts
>8--8<
This patch changes seq_printf for seq_puts in binder.c.
It fixes the warnings emitted by checkpa
On Tue, 2013-10-01 at 21:39 -0400, Mathieu Rhéaume wrote:
> Fixed a lot of warnings from checkpatch.pl about the 80 characters per line
> limitation.
I'd prefer
s/binder_user_error/binder_user_err/
or
s/binder_user_error/binder_err/
without doing the strange wrapping
checkpatch
On Tue, Oct 01, 2013 at 06:46:44PM -0700, Joe Perches wrote:
> On Tue, 2013-10-01 at 21:39 -0400, Mathieu Rhéaume wrote:
> > Fixed a lot of warnings from checkpatch.pl about the 80 characters per line
> > limitation.
>
> I'd prefer
> s/binder_user_error/binder_user_err/
> or
> s/binde
Changes since v2:
* Fixed the indent in the method calls that had too many tab.
>8--8<
This patch changes seq_printf for seq_puts in binder.c.
It fixes the warnings emitted by checkpatch.pl.
Signed-off-by: Mathieu Rhéaume
---
drivers/staging
On 02/10/13 11:57, Mathieu Rhéaume wrote:
> This patch changes seq_printf for seq_puts in binder.c.
> It fixes the warnings emitted by checkpatch.pl.
>
> Signed-off-by: Mathieu Rhéaume
> ---
> drivers/staging/android/binder.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> dif
On Wed, 2013-10-02 at 01:02 -0400, Mathieu Rhéaume wrote:
> Changes since v2:
> * Fixed the indent in the method calls that had too many tab.
>
> >8--8<
>
> This patch changes seq_printf for seq_puts in binder.c.
> It fixes the warnings emitted
84 matches
Mail list logo
