Re: [PATCH 2/3] staging: dwc2: add NAK holdoff patch from downstream Pi kernel

Hi Paul, > Add the NAK holdoff patch from the downstream Raspberry Pi kernel. > This allows the transfer scheduler to better handle "cheeky devices > that just hold off using NAKs". > @@ -365,6 +366,7 @@ struct dwc2_hsotg { > u8 otg_port; > u32 *frame_list; > dma_addr_t frame_li

Re: [PATCH 3/3] staging: dwc2: add microframe scheduler from downstream Pi kernel

Hi Paul & Dom, I haven't got time to look closely right now, but at first glance most of my comments have been resolved. One thing that is still in there, is this piece of code for which I'm not sure if it is really related to the topic of the patch: > @@ -780,6 +784,10 @@ static void dwc2_assig

Re: [PATCH 0/3] staging: dwc2: 2nd try at uframe scheduler patch

Hi Paul, > Matthijs' concern about periodic endpoints with bInterval=1 seems > to be unfounded. I tried a webcam, which uses a bInterval=1 isoc > endpoint, on my PCI-based dev board, and it still works fine with > this patch applied. For the record, I still think this concern actually exists, but

Re: [PATCH 3/3] staging: dwc2: add microframe scheduler from downstream Pi kernel

On Sun, Aug 11, 2013 at 12:50:19PM -0700, Paul Zimmerman wrote: > +static int dwc2_find_single_uframe(struct dwc2_hsotg *hsotg, struct dwc2_qh > *qh) > +{ > + unsigned short utime = qh->usecs; > + int done = 0; > + int i = 0; > + int ret = -1; > + > + while (!done) { I don't c

Re: [PATCH 2/6] Staging: winbond: wb35reg: white space deleted

On Mon 2013-08-05 11:58:28, Iker Pedrosa wrote: > White space deleted before a semicolon. > > Signed-off-by: Iker Pedrosa ACK. > --- > drivers/staging/winbond/wb35reg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/winbond/wb35reg.c > b/drivers/stag

Re: [PATCH 1/6] Staging: winbond: wb35reg: changed sleep function from msleep to usleep

On Mon 2013-08-05 11:58:27, Iker Pedrosa wrote: > Changed sleep function from msleep to usleep according to the documentation. > > Signed-off-by: Iker Pedrosa Can you explain why this is good idea? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.

Re: [PATCH 4/6] Staging: winbond: mds: fixed some lines over 80 characters

On Mon 2013-08-05 11:58:30, Iker Pedrosa wrote: > Fixed some coding style issues > > Signed-off-by: Iker Pedrosa ACK. > --- > drivers/staging/winbond/mds.c | 56 > +-- > 1 file changed, 33 insertions(+), 23 deletions(-) > > diff --git a/drivers/staging

Re: [PATCH 3/6] Staging: winbond: wb35reg: avoided use of extern function

On Mon 2013-08-05 11:58:29, Iker Pedrosa wrote: > Prototype of a function added to the header to avoid the use of extern. > > Signed-off-by: Iker Pedrosa ACK. > --- > drivers/staging/winbond/phy_calibration.h | 1 + > drivers/staging/winbond/wb35reg.c | 3 +-- > 2 files changed, 2 inse

Re: [PATCH 6/6] Staging: winbond: mds_f: deleted extern function

On Mon 2013-08-05 11:58:32, Iker Pedrosa wrote: > Deleted an extern function that wasn't used in this driver. > > Signed-off-by: Iker Pedrosa ACK. > --- > drivers/staging/winbond/mds_f.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/winbond/mds_f.h b/drivers/staging/

Re: [PATCH 5/6] Staging: winbond: mds_f: fixed lines over 80 characters

On Mon 2013-08-05 11:58:31, Iker Pedrosa wrote: > Fixed some coding style issues. > > Signed-off-by: Iker Pedrosa ACK. > --- > drivers/staging/winbond/mds_f.h | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/winbond/mds_f.h b/drivers/stagin

[PATCH] staging: lustre: re-use kbasename() common helper

To get the name of a file from a pathname we may use kbasename() helper. Signed-off-by: Andy Shevchenko --- drivers/staging/lustre/lustre/libcfs/tracefile.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/libcfs/tracefile.c b/drivers/staging

RE: [PATCH 3/3] staging: dwc2: add microframe scheduler from downstream Pi kernel

> From: popcornmix [mailto:popcorn...@gmail.com] > Sent: Monday, August 12, 2013 6:39 AM > > On Mon, Aug 12, 2013 at 8:40 AM, Matthijs Kooijman wrote: > > > Paul, did you try the patch without this hunk? > > Dom, can you tell use why this hunk is needed? > > The microframe patch originally came

Re: [PATCH 3/3] staging: dwc2: add microframe scheduler from downstream Pi kernel

On Mon, Aug 12, 2013 at 06:18:00PM +, Paul Zimmerman wrote: > > From: popcornmix [mailto:popcorn...@gmail.com] > > Sent: Monday, August 12, 2013 6:39 AM > > > > On Mon, Aug 12, 2013 at 8:40 AM, Matthijs Kooijman > > wrote: > > > > > Paul, did you try the patch without this hunk? > > > Dom,

Re: [PATCH v2] staging: dgnc - adds dgnc digi driver

On Mon, Aug 12, 2013 at 02:39:54PM -0400, Lidza Louina wrote: > I've just realized I made a mistake by adding the Makefile.inc. Oops, I missed that. > Is it possible for me to make a fresh set of patches (adding the files, > building it into the kernel, and fixing the errors and warnings)? Basica

Re: [PATCH v2] staging: dgnc - adds dgnc digi driver

On Mon, Aug 12, 2013 at 02:39:54PM -0400, Lidza Louina wrote: > I've just realized I made a mistake by adding the Makefile.inc. > > Is it possible for me to make a fresh set of patches (adding the files, > building it into the kernel, and fixing the errors and warnings)? Basically > forget about t

Re: [PATCH v2] staging: dgnc - adds dgnc digi driver

On Mon, Aug 12, 2013 at 2:49 PM, Greg KH wrote: > On Mon, Aug 12, 2013 at 02:39:54PM -0400, Lidza Louina wrote: >> I've just realized I made a mistake by adding the Makefile.inc. > > Oops, I missed that. > >> Is it possible for me to make a fresh set of patches (adding the files, >> building it in

Re: [PATCH v2] staging: dgnc - adds dgnc digi driver

On Mon, Aug 12, 2013 at 2:50 PM, Dan Carpenter wrote: > On Mon, Aug 12, 2013 at 02:39:54PM -0400, Lidza Louina wrote: >> I've just realized I made a mistake by adding the Makefile.inc. >> >> Is it possible for me to make a fresh set of patches (adding the files, >> building it into the kernel, and

Re: [PATCH V2 2/2] staging: iio: replace strict_strto*() with kstrto*()

On 07/24/13 06:36, Jingoo Han wrote: > The usage of strict_strto*() is not preferred, because > strict_strto*() is obsolete. Thus, kstrto*() should be > used. > > Previously, there were only strict_strtol(), strict_strtoul(), > strict_strtoull(), and strict_strtoll(). Thus, when converting > to the

[PATCH 0/9] staging: dgnc: builds this driver into the kernel

This series of patches builds the DGNC driver into the kernel and fixes small problems caused by the new tty layer's API. The DGNC driver is a TTY Serial Port Driver for the Digi International Neo and Classic PCI based product line by Digi International . Lidza Louina (9):

[PATCH 1/9] staging: dgnc: removes Makefile.inc

Signed-off-by: Lidza Louina --- drivers/staging/dgnc/Makefile.inc | 133 -- 1 file changed, 133 deletions(-) delete mode 100644 drivers/staging/dgnc/Makefile.inc diff --git a/drivers/staging/dgnc/Makefile.inc b/drivers/staging/dgnc/Makefile.inc deleted file

[PATCH 9/9] staging: dgnc: fixes warning: unused variable ‘buf’

Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_tty.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 299453f..f155c8f 100644 --- a/drivers/staging/dgnc/dgnc_tty.c +++ b/drivers/staging/dgnc/dgnc_tty.c @@ -683,7

[PATCH 8/9] staging: dgnc: removes read_cnt, real_raw and rawreadok

Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_tty.c | 154 +++- 1 file changed, 43 insertions(+), 111 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 1fbd09f..299453f 100644 --- a/drivers/staging/dg

[PATCH 4/9] staging: dgnc: fixes error: invalid type argument of ‘->’ (have ‘struct ktermios’)

Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_tty.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 461e881..63b80e2 100644 --- a/drivers/staging/dgnc/dgnc_tty.c

[PATCH 7/9] staging: dgnc: fixes warning: initialization from incompatible pointer type

Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_tty.c | 37 ++--- 1 file changed, 2 insertions(+), 35 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 1e22b4b..1fbd09f 100644 --- a/drivers/staging/dgnc/dgn

[PATCH 2/9] staging: dgnc: builds into kernel

Signed-off-by: Lidza Louina --- drivers/staging/Kconfig | 1 + drivers/staging/Makefile | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig index 57d8b34..d461590 100644 --- a/drivers/staging/Kconfig +++ b/drivers/staging/Kconfig @@ -142,4 +142

[PATCH 3/9] staging: dgnc: removes proc code

Signed-off-by: Lidza Louina --- drivers/staging/dgnc/Makefile |2 +- drivers/staging/dgnc/dgnc_driver.c |9 - drivers/staging/dgnc/dgnc_proc.c | 1551 3 files changed, 1 insertion(+), 1561 deletions(-) delete mode 100644 drivers/staging/dgnc/dg

[PATCH 5/9] staging: dgnc: fixes error: expected ‘struct tty_port *’ but argument is of type ‘struct tty_struct *’

Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_tty.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 63b80e2..a00fe2b 100644 --- a/drivers/staging/dgnc/dgnc_tty.c +++ b/drivers/st

[PATCH 6/9] staging: dgnc: fixes error: incompatible types when assigning to type ‘struct ktermios *’ from type ‘struct ktermios’

Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index a00fe2b..1e22b4b 100644 --- a/drivers/staging/dgnc/dgnc_tty.c +++ b/drivers/staging/dgnc/dgnc

Re: [PATCH] Staging: olpc_dcon: more big endian conformity

On Sun, Aug 04, 2013 at 11:04:16PM +0200, Jens Frederich wrote: > Using an int which is casted to unsigned char as inbuf is messy. > The code won't work on big endian systems. The patch should fix > this. > > Signed-off-by: Jens Frederich This patch doesn't apply at all, can you refresh it agai

Re: [PATCH 2/9] staging: dgnc: builds into kernel

On Mon, Aug 12, 2013 at 05:05:06PM -0400, Lidza Louina wrote: > Signed-off-by: Lidza Louina > --- > drivers/staging/Kconfig | 1 + > drivers/staging/Makefile | 1 + > 2 files changed, 2 insertions(+) If I apply this patch, the build breaks, right? This should be the last patch in your series.

Re: [PATCH 3/9] staging: dgnc: removes proc code

On Mon, Aug 12, 2013 at 05:05:07PM -0400, Lidza Louina wrote: > Signed-off-by: Lidza Louina Why? You need to supply a "why this patch is needed" type of a description for something that is non-obvious, like this. thanks, greg k-h ___ devel mailing li

Re: [PATCH 4/9] staging: dgnc: fixes error: invalid type argument of ‘->’ (have ���struct ktermios’)

On Mon, Aug 12, 2013 at 05:05:08PM -0400, Lidza Louina wrote: > Signed-off-by: Lidza Louina Odd characters in the Subject: line :( Care to write a bit more in the body of the changelog entry that describes this? thanks, greg k-h ___ devel mailing lis

Re: [PATCH 1/9] staging: dgnc: removes Makefile.inc

On Mon, Aug 12, 2013 at 05:05:05PM -0400, Lidza Louina wrote: > Signed-off-by: Lidza Louina > --- > drivers/staging/dgnc/Makefile.inc | 133 > -- > 1 file changed, 133 deletions(-) > delete mode 100644 drivers/staging/dgnc/Makefile.inc Don't you need some of

Re: [PATCH 5/9] staging: dgnc: fixes error: expected ‘struct tty_port *’ but argument is of type ‘struct tty_struct *’

On Mon, Aug 12, 2013 at 05:05:09PM -0400, Lidza Louina wrote: > Signed-off-by: Lidza Louina > --- A bit more information here as well is needed. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.o

Re: [PATCH 6/9] staging: dgnc: fixes error: incompatible types when assigning to type ‘struct ktermios *’ from type ‘struct ktermios’

On Mon, Aug 12, 2013 at 05:05:10PM -0400, Lidza Louina wrote: > Signed-off-by: Lidza Louina > --- > drivers/staging/dgnc/dgnc_tty.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Actually all of these need some kind of text in the changelog area. I'll just stop now on reviewing these, a

Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote: > This patch fixes crash issue when there is quick cycle of > de-enumeration & enumeration due to loss of wireless link. > > It is found that sometimes new device (or coming back device) > returns very fast, even before USB core read o

Re: [PATCH] Staging:BCM:DDRInit.c:Replacing __FUNCTION__

On Wed, Aug 07, 2013 at 06:11:54PM +0100, Paul McQuade wrote: > > >From 5b6fbb6496ddc4e428f5dd0950b0617faed6596b Mon Sep 17 00:00:00 2001 > From: Paul McQuade > Date: Wed, 7 Aug 2013 16:21:16 +0100 > Subject: [PATCH] Staging:BCM:DDRInit.c:Replacing __FUNCTION__ > > __func__ replaces __Function_

Re: Review [2/2] Staging: BCM: Removed more whitespace/Errors

On Thu, Aug 08, 2013 at 06:35:32PM +0100, Paul McQuade wrote: > From 9f6231ce16996e35545e20ce1d91abc058f2a6fb Mon Sep 17 00:00:00 2001 > From: Paul McQuade > Date: Thu, 8 Aug 2013 17:49:22 +0100 > Subject: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors Why is this duplicated here? Just

Re: [PATCH v2 0/4] staging: comedi: tidy up dio subdevice (*insn_config) boilerplate

On Tue, Aug 06, 2013 at 09:30:33AM -0700, H Hartley Sweeten wrote: > All the comedi drivers that have DIO subdevices implement a (*insn_config) > callback. This callback always handles the INSN_CONFIG_DIO_{INPUT,OUTPUT} > instructions to configure the DIO channels. They also always handle the > INS

RE: [PATCH 2/3] staging: dwc2: add NAK holdoff patch from downstream Pi kernel

> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Monday, August 12, 2013 12:36 AM > To: Paul Zimmerman > Cc: gre...@linuxfoundation.org; linux-...@vger.kernel.org; > de...@linuxdriverproject.org; > swar...@wwwdotorg.org; gordon.hollingwo...@gmail.com; sk...@netbsd.org; Dom > Cobley >

Re: [PATCH 2/9] staging: dgnc: builds into kernel

On Mon, Aug 12, 2013 at 5:10 PM, Greg KH wrote: > On Mon, Aug 12, 2013 at 05:05:06PM -0400, Lidza Louina wrote: >> Signed-off-by: Lidza Louina >> --- >> drivers/staging/Kconfig | 1 + >> drivers/staging/Makefile | 1 + >> 2 files changed, 2 insertions(+) > > If I apply this patch, the build bre

Re: [PATCH 3/9] staging: dgnc: removes proc code

On Mon, Aug 12, 2013 at 5:11 PM, Greg KH wrote: > On Mon, Aug 12, 2013 at 05:05:07PM -0400, Lidza Louina wrote: >> Signed-off-by: Lidza Louina > > Why? > > You need to supply a "why this patch is needed" type of a description > for something that is non-obvious, like this. Alrighty, I'll add a d

Re: [PATCH 1/9] staging: dgnc: removes Makefile.inc

On Mon, Aug 12, 2013 at 5:13 PM, Greg KH wrote: > On Mon, Aug 12, 2013 at 05:05:05PM -0400, Lidza Louina wrote: >> Signed-off-by: Lidza Louina >> --- >> drivers/staging/dgnc/Makefile.inc | 133 >> -- >> 1 file changed, 133 deletions(-) >> delete mode 100644