This patch removes some repeated words in code comments.
Signed-off-by: Klemen Košir
---
drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/drivers/staging/unisys/visornic
Sequence Number api provides interfaces for unsigned atomic up counters
leveraging atomic_t and atomic64_t ops underneath. Convert it to use
seqnum_ops.
atomic_t variable used for error_count are atomic counters. Convert it to
use seqnum_ops.
Signed-off-by: Shuah Khan
---
.../staging/unisys
s. No change to the behavior with
this change.
Signed-off-by: Shuah Khan
---
.../staging/unisys/visorhba/visorhba_main.c | 37 ++-
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
b/drivers/staging/unisys/vis
. values. No change to the behavior with
> this change.
>
> Signed-off-by: Shuah Khan
> ---
> .../staging/unisys/visorhba/visorhba_main.c | 37 ++-
> 1 file changed, 19 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/staging/unisys/vi
guard resource lifetimes, device usage and
open counts that control state changes, and pm states.
atomic_t variables used for error_count and ios_threshold are atomic
counters and guarded by max. values. No change to the behavior with
this change.
Signed-off-by: Shuah Khan
---
.../staging/unisys/vis
rs/staging/unisys/visorhba/visorhba_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
b/drivers/staging/unisys/visorhba/visorhba_main.c
index 99c57ceeb357..7ae5306b92fe 100644
--- a/drivers/staging/unisys/visorhba/visor
Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva
---
drivers/staging/unisys/visorinput/visorinput.c | 2 +-
1 file changed, 1
-by: Christophe JAILLET
---
drivers/staging/unisys/visornic/visornic_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/drivers/staging/unisys/visornic/visornic_main.c
index 9d4f1dab0968..40dd573e73c3 100644
--- a/drivers/
-by: Christophe JAILLET
---
drivers/staging/unisys/visornic/visornic_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/drivers/staging/unisys/visornic/visornic_main.c
index 9d4f1dab0968..40dd573e73c3 100644
--- a/drivers/
Commit e99e88a9d2b06 ("treewide: setup_timer() -> timer_setup()") has
updated the parameters of 'poll_for_irq()' but not the comment above the
function.
Update the comment and fix a typo.
s/visronic/visornic/
Signed-off-by: Christophe JAILLET
---
drivers/staging/unisys/v
rg
Cc: Greg Kroah-Hartman
Acked-by: Greg Kroah-Hartman
Reviewed-by: Christoph Hellwig
Reviewed-by: Bart Van Assche
Signed-off-by: Ming Lei
---
drivers/staging/unisys/visorhba/visorhba_main.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/vis
The patch itsel looks good, but another case of buggy kmap it seems:
Reviewed-by: Christoph Hellwig
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
rg
Cc: Greg Kroah-Hartman
Acked-by: Greg Kroah-Hartman
Signed-off-by: Ming Lei
---
drivers/staging/unisys/visorhba/visorhba_main.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
b/drivers/staging/unisys/vis
e-allocated one
> isn't enough for the whole request.
>
> Cc: de...@driverdev.osuosl.org
> Cc: Greg Kroah-Hartman
> Signed-off-by: Ming Lei
> ---
> drivers/staging/unisys/visorhba/visorhba_main.c | 9 -
> 1 file changed, 4 insertions(+),
rg
Cc: Greg Kroah-Hartman
Signed-off-by: Ming Lei
---
drivers/staging/unisys/visorhba/visorhba_main.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
b/drivers/staging/unisys/visorhba/visorhba_main.c
index 2dad36a
On Thu, 2019-06-13 at 12:16 +0200, Greg Kroah-Hartman wrote:
> On Thu, Jun 13, 2019 at 06:04:11PM +0800, Ming Lei wrote:
> > On Thu, Jun 13, 2019 at 11:52:14AM +0200, Greg Kroah-Hartman wrote:
> > > On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote:
> > > > The current way isn't safe for cha
On Thu, Jun 13, 2019 at 06:04:11PM +0800, Ming Lei wrote:
> On Thu, Jun 13, 2019 at 11:52:14AM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote:
> > > The current way isn't safe for chained sgl, so use sg helper to
> > > operate sgl.
> >
> > I can not m
On Thu, Jun 13, 2019 at 06:04:11PM +0800, Ming Lei wrote:
> On Thu, Jun 13, 2019 at 11:52:14AM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote:
> > > The current way isn't safe for chained sgl, so use sg helper to
> > > operate sgl.
> >
> > I can not m
On Thu, Jun 13, 2019 at 11:52:14AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote:
> > The current way isn't safe for chained sgl, so use sg helper to
> > operate sgl.
>
> I can not make any sense out of this changelog.
>
> What "isn't safe"? What is
On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote:
> The current way isn't safe for chained sgl, so use sg helper to
> operate sgl.
I can not make any sense out of this changelog.
What "isn't safe"? What is a "sgl"?
Can this be applied "out of order"?
confused,
greg k-h
___
The current way isn't safe for chained sgl, so use sg helper to
operate sgl.
Cc: de...@driverdev.osuosl.org
Cc: Greg Kroah-Hartman
Signed-off-by: Ming Lei
---
drivers/staging/unisys/visorhba/visorhba_main.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/dr
On Wed, May 22, 2019 at 10:35:30PM +0530, Hariprasad Kelam wrote:
> As per below information
>
> GFP_KERNEL FLAG
>
> This is a normal allocation and might block. This is the flag to use in
> process context code when it is safe to sleep.
>
> GFP_ATOMIC FLAG
>
> The allocation is high-priority
other situations where you
cannot sleep
And we can take advantage of GFP_KERNEL , as when system is in low
memory chances of getting success is high compared to GFP_ATOMIC.
As visornic_probe is in process context we can use GPF_KERNEL.
Signed-off-by: Hariprasad Kelam
---
drivers/staging/unisys
- Resolve the following warning from the Kconfig,
"WARNING: prefer 'help' over '---help---' for new help texts"
Signed-off-by: Moses Christopher
---
drivers/staging/unisys/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dr
On Sat, Apr 20, 2019 at 11:46:46AM +, MosesChristopher wrote:
> From: Moses Christopher
>
Could you Fix your email From header so this isn't required?
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.lin
On Sat, Apr 20, 2019 at 11:46:46AM +, MosesChristopher wrote:
> From: Moses Christopher
>
> - Resolve the following warning from the Kconfig,
> "WARNING: prefer 'help' over '---help---' for new help texts"
>
> Signed-off-by: Moses Chri
From: Moses Christopher
- Resolve the following warning from the Kconfig,
"WARNING: prefer 'help' over '---help---' for new help texts"
Signed-off-by: Moses Christopher
---
drivers/staging/unisys/Kconfig | 2 +-
drivers/staging/unisys/viso
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li
---
drivers/staging/unisys/visorhba/visorhba_main.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
b/drivers/staging/unisys
of lines of code that are
not needed.
Cc: David Kershner
Cc: Tim Sell
Cc: David Binder
Cc: Sameer Wadgaonkar
Cc: Charles Daniels
Cc: sparmaintai...@unisys.com
Signed-off-by: Greg Kroah-Hartman
---
.../staging/unisys/visornic/visornic_main.c | 23 +--
1 file changed, 6
The driver no longer needs to include drivers/staging/unisys/include, so we
can get rid of it.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/visorinput/Makefile
b
Checkpatch was giving errors about an open parenthesis being the last thing
on a line. This patch cleans up some names and removes the checkpatch
warnings.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/visorinput.c | 19 +--
1 file
Miscellaneous patches to the visorinput driver.
David Kershner (5):
staging: unisys: visorinput: Clean up Makefile includes
staging: unisys: visorinput: remove duplicate comments
staging: unisys: visorinput: combine ultrainputreport.h with visorinput.c
staging: unisys: visorinput: Fix
-by: David Kershner
---
drivers/staging/unisys/visorinput/Kconfig | 2 +-
drivers/staging/unisys/visorinput/visorinput.c | 43 +--
2 files changed, 32 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/unisys/visorinput/Kconfig
b/drivers/staging/unisys/visorinput
Comments were based on individual entries, if we group the entries, we can
get rid of duplicate comments.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/ultrainputreport.h | 16 +
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git
Several of the comments in the code were not using the full 80 characters
of the screen. This patch combines the lines to make full use of the
screen.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/visorinput.c | 64 ---
1 file changed
The file ultrainputreport.h was just being used by visorinput.c. Move the
definitions into visorinput.c and get rid of the file.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/ultrainputreport.h | 55 +-
drivers/staging/unisys/visorinput
bly did that for
>> a purpose and one driver shouldn't be changing that.
>>
>> Signed-off-by: Randy Dunlap
>> Cc: David Kershner
>> Cc: sparmaintai...@unisys.com (Unisys internal)
>> Cc: de...@driverdev.osuosl.org
>> Cc: Greg Kroah-Hartman
>&g
changing that.
>
> Signed-off-by: Randy Dunlap
> Cc: David Kershner
> Cc: sparmaintai...@unisys.com (Unisys internal)
> Cc: de...@driverdev.osuosl.org
> Cc: Greg Kroah-Hartman
> ---
> drivers/staging/unisys/Kconfig |3 +--
> 1 file changed, 1 insertion(+), 2 dele
sys.com (Unisys internal)
Cc: de...@driverdev.osuosl.org
Cc: Greg Kroah-Hartman
---
drivers/staging/unisys/Kconfig |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- lnx-415-rc8.orig/drivers/staging/unisys/Kconfig
+++ lnx-415-rc8/drivers/staging/unisys/Kconfig
@@ -4,8 +4,7 @@
menuco
Combine the include files visorchannel.h and visorbus.h so that only one
include file is needed for the .c files.
Reported-by: Christoph Hellwig
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 2 +-
drivers/staging/unisys/include
Remove the dependency that the drivers are not built during UML.
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/Kconfig b/drivers
The Kconfig file for UNISYSSPAR uses select ACPI and select PCI instead of
depends on ACPI. This patch fixes the problem.
Reported-by: Greg Kroah-Hartman
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions
(4):
staging: unisys: fix dependencies with UNISYSSPAR Kconfig flag
staging: unisys: remove !UML flag
staging: unisys: combine visorchannel.h and visorbus.h
staging: unisys: move dependencies from UNISYSSPAR to VISORBUS
drivers/staging/unisys/Kconfig | 3 -
drivers
The Kconfig flag UNISYSSPAR depended on ACPI and X86, these dependencies
really belong to visorbus, so move them there.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/Kconfig | 2 --
drivers/staging/unisys/visorbus/Kconfig | 1 +
2 files changed, 1
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -581,7 +581,8 @@ static void *parser_name_get(struct parser_context *ctx)
> struct visor_controlvm_parameters_header *phdr;
>
> phdr = &ctx-&
by: Dan Carpenter
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorchipset.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus/visorchipset.c
the GPL license text. And there's unneeded stuff
like the address (sometimes incorrect) for the FSF which is never
needed.
No copyright headers or other non-license-description text was removed.
Cc: David Kershner
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/unisys/include/iochan
It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.
Update the drivers/staging/unisys files files with the correct SPDX
license identifier based on the license text in the file itself. The
SPDX identifier is a legally binding shor
/staging/unisys/include/iochannel.h| 2 +-
drivers/staging/unisys/include/visorchannel.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/include/iochannel.h
b/drivers/staging/unisys/include/iochannel.h
index bac5a04a9c28..6fc40f9cc768 100644
--- a/drivers
On Mon, Nov 06, 2017 at 04:56:40PM +0300, Dan Carpenter wrote:
> On Mon, Nov 06, 2017 at 07:17:11PM +1100, Tobin C. Harding wrote:
> > > > @@ -260,9 +261,10 @@ int visorchannel_signalremove(struct visorchannel
> > > > *channel, u32 queue,
> > > > void *msg)
> > > > {
On Mon, Nov 06, 2017 at 07:17:11PM +1100, Tobin C. Harding wrote:
> > > @@ -260,9 +261,10 @@ int visorchannel_signalremove(struct visorchannel
> > > *channel, u32 queue,
> > > void *msg)
> > > {
> > > int rc;
> > > - unsigned long flags;
> > >
> > > if (channel->need
ng?
> > > >
> > > > I think your html email got rejected by the list :(
> > > >
> > > > > The files include:
> > > > > /drivers/staging/unisys/visorbus/
> > > > > /drivers/staging/unisys/i
ner, David A wrote:
> > > > Hey Greg, we think the code for visorbus is ready to be moved out
> > > > of staging, can you review it to see if we have missed anything?
> > >
> > > I think your html email got rejected by the list :(
> > >
>
moved out
> > > of staging, can you review it to see if we have missed anything?
> >
> > I think your html email got rejected by the list :(
> >
> > > The files include:
> > > /drivers/staging/unisys/visorbus/
>
g?
>
> I think your html email got rejected by the list :(
>
> > The files include:
> > /drivers/staging/unisys/visorbus/
> > /drivers/staging/unisys/include/visorchannel.h
> > /drivers/staging/unisys/include/visorbus.h
drivers/staging/unisys/visorbus/visorchipset.c
588 static void *parser_name_get(struct parser_context *ctx)
589 {
590 struct visor_controlvm_parameters_header *phdr;
591
592 phdr = &ctx->data;
593 if (phdr->name_offset + phdr->name
Kroah-Hartman
> ; Sameer Wadgaonkar
> ; Sell, Timothy C
>
> Cc: LKML ; kernel-janit...@vger.kernel.org
> Subject: [PATCH] staging: unisys: visorchipset: Use common error handling
> code in setup_crash_devices_work_queue()
>
> From: Markus Elfring
> Date: Fri, 3 Nov 2017 20:37:
Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/unisys/visorbus/visorchipset.c | 36 --
1 file changed, 16 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus/visorchips
g?
>
> I think your html email got rejected by the list :(
>
> > The files include:
> > /drivers/staging/unisys/visorbus/
> > /drivers/staging/unisys/include/visorchannel.h
> > /drivers/staging/unisys/include/visorbus.h
Cc: David Kershner
Cc: Tim Sell
Cc: Sameer Wadgaonkar
Cc: David Binder
Signed-off-by: Greg Kroah-Hartman
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/unisys/visorbus/visorbus_main.c
index 2f1e8d36aedf..b604d0cccef1 100644
--- a/drivers/staging/unisy
s include:
> /drivers/staging/unisys/visorbus/
> /drivers/staging/unisys/include/visorchannel.h
> /drivers/staging/unisys/include/visorbus.h
>
> The directories staging/drivers/unisys/visornic, visorhba, and visorinput
> are not part of the review as
On Wed, Sep 27, 2017 at 01:14:50PM -0400, David Kershner wrote:
> Clean up unneeded parenthesis reported by checkpatch.pl.
>
> Signed-off-by: David Kershner
> Reviewed-by: Tim Sell
> ---
> drivers/staging/unisys/visornic/visornic_main.c | 6 +++---
> 1 file change
On Wed, Sep 27, 2017 at 01:14:49PM -0400, David Kershner wrote:
> Clean up unneeded parenthesis reported by checkpatch.pl.
>
> Signed-off-by: David Kershner
> Reviewed-by: Tim Sell
> ---
> drivers/staging/unisys/visorhba/visorhba_main.c | 8
> 1 file change
On Wed, Sep 27, 2017 at 01:14:43PM -0400, David Kershner wrote:
> From: Sameer Wadgaonkar
>
> Validate that the channel contents match the channel type that we are
> matching.
>
What are the user visible effects of this change? Does it have security
implications? Does it prevent a crash? Is
On Wed, Sep 27, 2017 at 01:14:38PM -0400, David Kershner wrote:
> + if (chipset_dev->poll_jiffies != POLLJIFFIES_CONTROLVM_SLOW)
> + chipset_dev->poll_jiffies = POLLJIFFIES_CONTROLVM_SLOW;
> + } else {
> + if (chipset_dev->poll_jiffies != POLLJIFFIES_
ompson, Bryan E.
> ; *S-Par-Maintainer
> ; de...@driverdev.osuosl.org; linux-
> ker...@vger.kernel.org
> Subject: [PATCH] staging: unisys/visorbus: add __init/__exit annotations
>
> gcc-4.6 causes a harmless warning about the init function:
>
> WARNING: vmlinux.o(.text+
Clean up unneeded () that are being reported by checkpatch.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a
Clean up unneeded parenthesis reported by checkpatch.pl.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/drivers
From: Sameer Wadgaonkar
Validate that the channel contents match the channel type that we are
matching.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 11 ++-
drivers/staging/unisys/visorhba
From: Sameer Wadgaonkar
This patch fixes some comments and spacings in the file visorbus.h
to make it more uniform.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 12 +---
1 file changed, 5
From: Sameer Wadgaonkar
This patch fixes some comments in the file vbuschannel.h to make
it more uniform.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/vbuschannel.h | 9 -
1 file changed, 4 insertions(+), 5
Clean up unneeded parenthesis reported by checkpatch.pl.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorhba/visorhba_main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
b
From: Sameer Wadgaonkar
This patch fixes two checkpatch issues of line over 80 characters
in visorchipset.c.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 6 --
1 file changed, 4 insertions(+), 2
Cleans up parameter formatting in visorbus.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
drivers/staging/unisys/visorbus/visorchipset.c | 17 -
2 files changed, 9 insertions(+), 10 deletions(-)
diff --git a
Shrinks the name of POLLJIFFIES_CONTORLVMCHANNEL_FAST and
POLLJIFFIES_CONTROLVMCHANNEL_SLOW to just POLLJIFFIES_CONTROLVM_.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 20
1 file changed, 8 insertions(+), 12
Found several more useless initializations in visorchipset.c get rid of
them.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/unisys
From: David Binder
Removes unused enum that pertains to s-Par diagnostics capabilities.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 20
1 file changed, 20 deletions(-)
diff --git a
/staging/unisys/visorbus/visorbus_private.h | 4 +---
drivers/staging/unisys/visorbus/visorchannel.c | 23 +-
drivers/staging/unisys/visorbus/visorchipset.c | 15 +++---
3 files changed, 14 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/unisys/visorbus
From: David Binder
Removes unnecessary SIGNATURE_16 macro used to generate a simple 32-bit
signature.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorchannel.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions
/staging/unisys/include/iochannel.h | 2 +-
drivers/staging/unisys/include/visorbus.h| 2 +-
drivers/staging/unisys/include/{channel.h => visorchannel.h} | 6 +++---
drivers/staging/unisys/visorbus/controlvmchannel.h | 2 +-
drivers/staging/uni
/unisys/include/visorbus.h | 2 --
drivers/staging/unisys/visorbus/visorbus_main.c| 37 +-
drivers/staging/unisys/visorbus/visorbus_private.h | 2 ++
drivers/staging/unisys/visorbus/visorchipset.c | 35
4 files changed, 38 insertions(+), 38
The include file visorbus.h has a forward declaration of visor_device.
A simple reorder of the file removed the need for the forward
declaration.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 125 +++---
1 file
The header file visorbus.h included several linux headers that were
used by the source files that include it. Move the includes to the
files that actually use them.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 2 --
drivers/staging
If you can't find the dev, it is an error. Indent for the error, instead
of the success.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/u
Remove signature_32 since it was only being referenced in one location.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/include/channel.h
b/drivers
Use all 80 characters of the line to consolidate a comment.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/include/iochannel.h
b/drivers
Channel.h was including io.h and not using it. Remove the #include.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/include/channel.h
b/drivers/staging/unisys/include
Remove extraneous blank lines and get consistency of blank lines.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 98 +-
1 file changed, 3 insertions(+), 95 deletions(-)
diff --git a/drivers/staging/unisys
Don't include ctypes in vbuschannel.h, it isn't used by ctypes, but it is
used by visorbus_main.c so include it there.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/controlvmchannel.h | 1 +
drivers/staging/unisys/visorbus/vbuschannel.
Simplify debugfs statement so it is clearer and more compact.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers
The field debugfs_client_bus_info can be reduced to debugfs_bus_info.
The word client is extraneous in this context.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 2 +-
drivers/staging/unisys/visorbus/visorbus_main.c | 20
Don't compute value of offset during initialization. Assigning a value to
offset should happen after we have verified all of its components.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 14 +++---
1 file changed, 7 inser
The function publish_vbus_dev_info was doing a memcmp of guids. It should
be using the kernel provided guid_equal function instead.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions
Removes several extraneous blank lines in visorbus_main.c.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 44 ++---
1 file changed, 3 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/unisys/visorbus
The macros to_visor_device and to_visor_driver are fairly small; move them
up to the declaration block to save some space.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 14 --
1 file changed, 4 insertions(+), 10 deletions
Remove extraneous blank lines and add some lines that are needed. General
philosophy -- declaration, space, pre-conditions (if needed), space, then
rest of function.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchannel.c | 28
A NULL pending_msg_hdr is not an error, it just means that the firmware
does not want an error response for that message.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 3 ++-
drivers/staging/unisys/visorbus/visorchipset.c | 13
The function parser_string_get was writing its own strnlen function, use
the kernel version instead.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 24
1 file changed, 4 insertions(+), 20 deletions(-)
diff
Remvoe several unneeded blank lines.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_private.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_private.h
b/drivers/staging/unisys/visorbus
Here are some more updates to clean up the code.
David Binder (3):
staging: unisys: include: Rename channel.h to visorchannel.h
staging: unisys: include: Remove unnecessary macro to generate
signature
staging: unisys: include: Remove unused enum
David Kershner (37):
staging: unisys
1 - 100 of 3355 matches
Mail list logo
