On Sat, Mar 12, 2016 at 05:10:29PM -0800, Gavin O'Leary wrote:
> Signed-off-by: Gavin O'Leary
> ---
> drivers/staging/dgap/dgap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
>
On Sat, Mar 12, 2016 at 05:03:01PM -0800, Gavin O'Leary wrote:
> Signed-off-by: Gavin O'Leary
I can't take a patch without a changelog entry.
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/l
Signed-off-by: Gavin O'Leary
---
drivers/staging/dgap/dgap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 9e07a39..7845516 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -4
Signed-off-by: Gavin O'Leary
---
drivers/staging/dgap/dgap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index bad3551..9e07a39 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -4
2016-03-10 17:21 GMT+09:00 Tanvi Surana :
> I have modified the file dgap.c ,making changes to the multiline
> comments,thus making them appear presentable
>
> Signed-Off-By: Tanvi Surana
> ---
> drivers/staging/dgap/dgap.c | 59
> +-
I have modified the file dgap.c ,making changes to the multiline comments,thus
making them appear presentable
Signed-Off-By: Tanvi Surana
---
drivers/staging/dgap/dgap.c | 59 +
1 file changed, 33 insertions(+), 26 deletions(-)
diff --git a/drivers
>From 60b1e6e5d9401f10f584928d4feeb8a3b72b46a9 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Mon, 29 Feb 2016 11:04:02 +0900
Subject: [PATCH 2/2] staging: dgap: use tty_alloc_driver instead of kcalloc
the tty_alloc_driver() can allocate memory for ttys and termios.
And also it can rele
. This patch introduces the wait_for_fep_cmds_limit()
> function which is will be called from these functions to prevent
> code duplication.
>
> Signed-off-by: Alexander Kuleshov
> ---
> Forgot Signed-off-by line
>
> drivers/staging/dgap/dgap.c | 103
> ---
On Thu, Nov 26, 2015 at 12:26 PM, Sudip Mukherjee
wrote:
> Signed-off-by ?
Hello Sudip,
I've put it in the v2 (https://lkml.org/lkml/2015/11/25/650)
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/lis
On Wed, Nov 25, 2015 at 07:10:30PM +0600, Alexander Kuleshov wrote:
> The dgap driver contains three functions: dgap_cmdb(), dgap_cmdw()
> and dgap_cmdw_exit which are contain duplicated code which waits
> if necessary before updating the pointer to limit outstanding
> commands. This patch introduc
these functions to prevent
code duplication.
Signed-off-by: Alexander Kuleshov
---
Forgot Signed-off-by line
drivers/staging/dgap/dgap.c | 103
1 file changed, 37 insertions(+), 66 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging
these functions to prevent
code duplication.
---
drivers/staging/dgap/dgap.c | 103
1 file changed, 37 insertions(+), 66 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index bad3551..0a20253 100644
--- a/drivers/staging
On Mon, Oct 05, 2015 at 12:46:43PM +0300, Dan Carpenter wrote:
> On Sun, Oct 04, 2015 at 09:19:20PM +0530, Sudip Mukherjee wrote:
> > The IO configuration was not used to configure the board. It was only
> > read from the configuration file. Stop reading it and also remove the
> > other related var
On Sun, Oct 04, 2015 at 09:19:20PM +0530, Sudip Mukherjee wrote:
> The IO configuration was not used to configure the board. It was only
> read from the configuration file. Stop reading it and also remove the
> other related variables defined for it.
>
> Signed-off-by: Sudip Mukherjee
But say so
The IO configuration was not used to configure the board. It was only
read from the configuration file. Stop reading it and also remove the
other related variables defined for it.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgap/dgap.c | 21 -
drivers/staging/dgap
> Why not just reject it earlier instead of allocating more data?
I agree on your point.
But we have to make different mechanism for that and my patch is only
to fix the current code.
regards
___
devel mailing list
de...@linuxdriverproject.org
http://dri
On Thu, Oct 01, 2015 at 09:11:31AM +0530, Ronit Halder wrote:
> The existing dgap_parsefile() rejects invalid config file.
> But before we know that config file is invalid a lot of memory leak
> can happen. Removing the chances of memory leak won't heart anyone.
>
Why not just reject it earlier i
The existing dgap_parsefile() rejects invalid config file.
But before we know that config file is invalid a lot of memory leak
can happen. Removing the chances of memory leak won't heart anyone.
regards,
Ronit Halder
___
devel mailing list
de...@linuxdri
On Wed, Sep 30, 2015 at 11:39:45AM +0530, Ronit Halder wrote:
> In dgap_parsefile() char pointers are set with kstrdup()
> without checking that some string is allocated to that
> char pointer before.
Why would this happen? Wouldn't it be better to reject the invalid
config file?
regards,
dan ca
In dgap_parsefile() char pointers are set with kstrdup()
without checking that some string is allocated to that
char pointer before. This patch frees the memory if already allocated
and then set the poniter with kstrdup().
Signed-off-by: Ronit halder
---
drivers/staging/dgap/dgap.c | 12
On Thu, Sep 10, 2015 at 05:24:59PM +0530, Sudip Mukherjee wrote:
> Removed them but kept one call to ioread8() as it might affect the
> hardware.
Just leave the extra variable until someone has the hardware and can
verify the right fix. Static checker warnings are good, don't silence
them just to
On Tue, Sep 22, 2015 at 08:38:43AM +0200, Javier Martinez Canillas wrote:
> Hello Sudip,
>
> On 09/22/2015 06:52 AM, Sudip Mukherjee wrote:
> > On Tue, Sep 22, 2015 at 02:39:36AM +0200, Javier Martinez Canillas wrote:
> >> The driver is using -1 instead of the -ENOMEM defined macro to specify
> >>
Hello Sudip,
On 09/22/2015 06:52 AM, Sudip Mukherjee wrote:
> On Tue, Sep 22, 2015 at 02:39:36AM +0200, Javier Martinez Canillas wrote:
>> The driver is using -1 instead of the -ENOMEM defined macro to specify
>> that a buffer allocation failed. Since the error number is propagated,
>> the caller
On Tue, Sep 22, 2015 at 02:39:36AM +0200, Javier Martinez Canillas wrote:
> The driver is using -1 instead of the -ENOMEM defined macro to specify
> that a buffer allocation failed. Since the error number is propagated,
> the caller will get a -EPERM which is the wrong error condition.
Just a littl
: returning -1 instead of -ENOMEM is sloppy
Signed-off-by: Javier Martinez Canillas
---
drivers/staging/dgap/dgap.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 303d97023ccb
On Wed, Sep 16, 2015 at 10:30:37AM +0530, Sudip Mukherjee wrote:
> On Tue, Sep 15, 2015 at 06:05:29AM -0700, Greg Kroah-Hartman wrote:
> > On Tue, Sep 15, 2015 at 08:56:10AM -0400, Mark Hounschell wrote:
>
> > >
> > > Signed-off-by: Mark Hounschell
> > > Cc: Greg Kroah-Hartman
> > > Cc: Ben Hut
On Tue, Sep 15, 2015 at 06:05:29AM -0700, Greg Kroah-Hartman wrote:
> On Tue, Sep 15, 2015 at 08:56:10AM -0400, Mark Hounschell wrote:
> >
> > Signed-off-by: Mark Hounschell
> > Cc: Greg Kroah-Hartman
> > Cc: Ben Hutchings
> > ---
> > MAINTAINERS | 1 -
> > 1 file changed, 1 deletion(-)
>
>
On 09/15/2015 09:05 AM, Greg Kroah-Hartman wrote:
On Tue, Sep 15, 2015 at 08:56:10AM -0400, Mark Hounschell wrote:
Removes myself from the MAINTAINERS file for the dgap driver.
There appears to be no way to get the firmware files required
by the dgap driver into the linux-firmware tree. The dgap
On Tue, Sep 15, 2015 at 08:56:10AM -0400, Mark Hounschell wrote:
> Removes myself from the MAINTAINERS file for the dgap driver.
> There appears to be no way to get the firmware files required
> by the dgap driver into the linux-firmware tree. The dgap
> driver is useless wihtout this firmware. Thi
Removes myself from the MAINTAINERS file for the dgap driver.
There appears to be no way to get the firmware files required
by the dgap driver into the linux-firmware tree. The dgap
driver is useless wihtout this firmware. This product is
considered an obsolete product by Digi. They will not respon
gt; ---
> drivers/staging/dgap/dgap.c | 2 ++
> 1 file changed, 2 insertions(+)
While this change is all nice and fine, this driver is totally abusing
the firmware kernel interface to read in a "configuration file" and then
parse it within the driver. That's not ok at all, no tt
The provides strpbrk() function that does
the same that the dgap_sindex(). Let's use already defined
function instead of writing custom.
Signed-off-by: Alexander Kuleshov
---
drivers/staging/dgap/dgap.c | 24 +---
1 file changed, 1 insertion(+), 23 deletions(-)
diff
The return pointer from dgap_getword() is used in strcmp() where it is
dereferenced. But dgap_getword() can return NULL.
Lets put a check there and return 0 as error.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgap/dgap.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers
These variables were assigned some values but they were never used.
Removed them but kept one call to ioread8() as it might affect the
hardware.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgap/dgap.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers
Signed-off-by: Panos Vlachos
---
drivers/staging/dgap/dgap.c | 84 -
1 file changed, 52 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 9112dd2..1cacd18 100644
--- a/drivers/staging/dgap
On Fri, Jul 17, 2015 at 03:57:21PM +0530, Sudip Mukherjee wrote:
> On Fri, Jul 17, 2015 at 01:05:55PM +0300, Dan Carpenter wrote:
> > On Fri, Jul 17, 2015 at 03:21:28PM +0530, Sudip Mukherjee wrote:
> > > On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote:
> > > > I don't think I like th
On Fri, Jul 17, 2015 at 01:05:55PM +0300, Dan Carpenter wrote:
> On Fri, Jul 17, 2015 at 03:21:28PM +0530, Sudip Mukherjee wrote:
> > On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote:
> > > I don't think I like these at all. remove_one has always been buggy in
> > > that it removes ev
On Fri, Jul 17, 2015 at 03:21:28PM +0530, Sudip Mukherjee wrote:
> On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote:
> > I don't think I like these at all. remove_one has always been buggy in
> > that it removes everything. We should fix it to only remove one instead
> > of formalizi
On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote:
> I don't think I like these at all. remove_one has always been buggy in
> that it removes everything. We should fix it to only remove one instead
> of formalizing the currect terrible behavior.
Its already applied.
I thought after th
I don't think I like these at all. remove_one has always been buggy in
that it removes everything. We should fix it to only remove one instead
of formalizing the currect terrible behavior.
regards,
dan carpenter
___
devel mailing list
de...@linuxdrive
Mukherjee
---
drivers/staging/dgap/dgap.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 8956228..4f07a0c 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -7004,7 +7004,7 @@ static
Remove the duplicate code of dgap_remove_one() and dgap_stop().
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgap/dgap.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 4f07a0c..b344e03
Relocate the function dgap_stop() so that in a later patch we can remove
the duplicate codes between dgap_stop() and dgap_remove_one().
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgap/dgap.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff
was sent. I am not able to find that discussion in
lkml.org
drivers/staging/dgap/dgap.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 26b0446..3a783bf 100644
--- a/drivers/staging/dgap/dgap.c
+++ b
On Wed, Jun 10, 2015 at 10:11:37AM +0300, Dan Carpenter wrote:
> I mean, yes, it doesn't seem to make much sense to continue polling
> after all the hardware has been removed. The problem is that we pass a
> pci_dev pointer to dgap_remove_one() and it ignores it and removes
> everything.
>
> Othe
On Wed, Jun 10, 2015 at 10:11:37AM +0300, Dan Carpenter wrote:
>
> Also this driver has active maintainers but somehow we have CC'd the
> ATMEL people who maintain a different staging driver...
The original patch had put the maintainers of WILC1000 WIFI DRIVER in the
cc list. Now ccing the actual
I mean, yes, it doesn't seem to make much sense to continue polling
after all the hardware has been removed. The problem is that we pass a
pci_dev pointer to dgap_remove_one() and it ignores it and removes
everything.
Otherwise, I would probably suggest that it start polling when the first
hardwa
On Wed, Jun 10, 2015 at 04:54:47AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> From: Hari Prasath Gujulan Elango
>
> @@ -7159,8 +7144,9 @@ err_stop:
> */
> static void dgap_cleanup_module(void)
> {
> - if (dgap_numboards)
> - pci_unregister_driver(&dgap_driver);
> +
Gujulan Elango
> > ---
> > drivers/staging/dgap/dgap.c | 4
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
> > index 185e9e5..03153d8 100644
> > --- a/drivers/staging/dgap/dgap
From: Hari Prasath Gujulan Elango
This patch deletes the comments secion which is obvious and outdated
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Addrressed Dan carpenter review comments to remove the entire
comments section as its outdated and obvious.
---
drivers/staging/dgap
review comment on unregistering the
driver based on dgap_numboards in the module exit routine.Registration
of the PCI driver is not dependent on this and hence unregister also
shouldn't depend on this varaible.
---
drivers/staging/dgap/dgap.c | 20 +++-
1 file changed, 3 inser
; > allocated in the driver module init.The cleanup is moved from remove
> > function to module exit as appropriate.
> >
> > Signed-off-by: Hari Prasath Gujulan Elango
> > ---
> > drivers/staging/dgap/dgap.c | 17 ++---
> > 1 file changed, 2 in
On Tue, Jun 09, 2015 at 05:27:00PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> From: Hari Prasath Gujulan Elango
>
> Deleting obvious comments
>
> Signed-off-by: Hari Prasath Gujulan Elango
> ---
> drivers/staging/dgap/dgap.c | 4
> 1 file changed, 4 deleti
module exit as appropriate.
>
> Signed-off-by: Hari Prasath Gujulan Elango
> ---
> drivers/staging/dgap/dgap.c | 17 ++---
> 1 file changed, 2 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
> index
From: Hari Prasath Gujulan Elango
Deleting obvious comments
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/dgap/dgap.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 185e9e5..03153d8 100644
--- a/drivers
From: Hari Prasath Gujulan Elango
The driver remove function is not the right place to cleanup resources
allocated in the driver module init.The cleanup is moved from remove
function to module exit as appropriate.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/dgap/dgap.c | 17
On Tue, Jun 09, 2015 at 04:41:33PM +0300, Dan Carpenter wrote:
> On Tue, Jun 09, 2015 at 10:54:02AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > On Tue, Jun 09, 2015 at 03:32:20PM +0530, Sudip Mukherjee wrote:
> > > On Tue, Jun 09, 2015 at 09:27:22AM +, Gujulan Elango, Hari Prasath
>
On Tue, Jun 09, 2015 at 04:51:02PM +0300, Dan Carpenter wrote:
> No. See my other email.
>
> Also this is super ugly and your instinct should have told you that ugly
> things are normally wrong.
>
> regards,
> dan carpenter
>
Dan,I guess functionality wise this also does the job.Maybe this is
No. See my other email.
Also this is super ugly and your instinct should have told you that ugly
things are normally wrong.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/list
On Tue, Jun 09, 2015 at 10:54:02AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> On Tue, Jun 09, 2015 at 03:32:20PM +0530, Sudip Mukherjee wrote:
> > On Tue, Jun 09, 2015 at 09:27:22AM +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > From: Hari Prasath Gujulan Elango
> > >
> > > Cl
---
drivers/staging/dgap/dgap.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 26b0446..3a783bf 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -7133,8 +7133,10 @@ static int
better. But you just can not remove that as dgap_stop() has to be
> called if pci_register_driver() fails. maybe something like this:
>
> diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
> index 26b0446..cbb971d 100644
> --- a/drivers/staging/d
; dgap_stop() are invoked in succession.Going by your argument,should we
> remove the redundant cleanup done in the dgap_stop() function.
yes, better. But you just can not remove that as dgap_stop() has to be
called if pci_register_driver() fails. maybe something like this:
diff --git a/drivers/stag
On Tue, Jun 09, 2015 at 03:32:20PM +0530, Sudip Mukherjee wrote:
> On Tue, Jun 09, 2015 at 09:27:22AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > Cleanup the device entry,device class & unregister the character device
> > in the module exit.All
On Tue, Jun 09, 2015 at 09:27:22AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> From: Hari Prasath Gujulan Elango
>
> Cleanup the device entry,device class & unregister the character device
> in the module exit.All this cleanup is done already in the dgap_stop()
> function.We need to call t
ging/dgap/dgap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 26b0446..b6fa486 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -7161,6 +7161,7 @@ static void dgap_cleanup_module(void)
{
Fixed comment spelling errors
Signed-off-by: Colin Cronin
---
drivers/staging/dgap/dgap.c | 2 +-
drivers/staging/dgap/dgap.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 6766d5a..0691729 100644
--- a
On Fri, May 15, 2015 at 02:11:40AM -0700, Colin Cronin wrote:
> Fixed comment spelling errors
>
> Signed-off-by Colin Cronin
this is wrong. should be Signed-off-by:
regards
sudip
> ---
___
devel mailing list
de...@linuxdriverproject.org
http://driverd
Fixed comment spelling errors
Signed-off-by Colin Cronin
---
drivers/staging/dgap/dgap.c | 2 +-
drivers/staging/dgap/dgap.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 6766d5a..0691729 100644
--- a
dgap_sindex() is being only called from dgap_getword() which searches
for either ' ' or '\t' or '\n'. this part of the code with '^' at the
beginning is never used.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgap/dgap.c | 21 --
will be left in an inconsistent state.
So moved the cleanups in the remove callback and since there was no
reference of dgap_driver in remove_one(), so had to define the
pci_driver in the function.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgap/dgap.c | 49
move the cleanup function before the remove call as the next patch of
the series is going to use that.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgap/dgap.c | 61 ++---
1 file changed, 30 insertions(+), 31 deletions(-)
diff --git a/drivers
Building for ARM64 leads to the following build warning:
In file included from drivers/staging/dgap/dgap.c:66:0:
drivers/staging/dgap/dgap.h:124:0: warning: "PCI_IO_SIZE" redefined
#define PCI_IO_SIZE 0x0020
^
In file included from ./arch/arm64/include/asm/p
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/dgap/dgap.c |5 +
1 file changed, 1 insertion
cppcheck warning:
(warnning) Logical disjunction always evaluates to true
Reported-by: David Binderman
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap
Hi,
2015-01-22 19:14 GMT+09:00 Dan Carpenter :
>
> On Thu, Jan 22, 2015 at 10:05:53AM +, David Binderman wrote:
>> Hello there,
>>
>> [linux-3.19-rc5/drivers/staging/dgap/dgap.c:981]: (warning) Logical
>> disjunction always evaluates to true: conc_type != 65 ||
Hello there,
> On Thu, Jan 22, 2015 at 10:20:44AM +, David Binderman wrote:
>> I used the static analyser cppcheck to find these two bugs, but
>> you might be able to find similar problems by using gcc compiler
>> flag -Wlogical-op.
>
> I turned it on,
On Thu, Jan 22, 2015 at 10:20:44AM +, David Binderman wrote:
> I used the static analyser cppcheck to find these two bugs, but
> you might be able to find similar problems by using gcc compiler
> flag -Wlogical-op.
I turned it on, but GCC 4.7.2 doesn't find anything for me.
It complains about
Hello there,
Thanks for the confirmation. More of the same in the same file:
[linux-3.19-rc5/drivers/staging/dgap/dgap.c:1022]: (warning) Logical
disjunction always evaluates to true: module_type != 68 || module_type != 73.
Source code is
if (module_type == 0 || module_type
On Thu, Jan 22, 2015 at 10:05:53AM +, David Binderman wrote:
> Hello there,
>
> [linux-3.19-rc5/drivers/staging/dgap/dgap.c:981]: (warning) Logical
> disjunction always evaluates to true: conc_type != 65 || conc_type != 66.
>
> Source code is
>
>
Hello there,
[linux-3.19-rc5/drivers/staging/dgap/dgap.c:981]: (warning) Logical disjunction
always evaluates to true: conc_type != 65 || conc_type != 66.
Source code is
if (conc_type == 0 || conc_type != CX ||
conc_type != EPC) {
Suggest code rework.
Regards
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 30 +++---
1 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index bdb5317..518ab56 100644
--- a/drivers/staging/dgap/dgap.c
+++ b
use find_board_by_major function instead of getting a brd from static
arrary. Becasue tty's major number doesn't start zero and we can
find a brd from dgap_board[].
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 28 +---
1 files changed, 17
The board_t has a tty_struct(serial_driver and print_driver)
that has a major number. When major number is compared in
dgap_tty_open(), just use brd->serial_driver{print_driver}->major.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |9 ++---
drivers/staging/dgap/
The tty_struct of serial_driver and print_driver were getting
allocated twice. One is allocated in tty_alloc_driver(), the other
is in dgap_tty_register(). So remove these in dgap_tty_register().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 16
1 files
tty's flags can be set by calling tty_alloc_driver().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index aa393d2..6418cc5 100644
The dgap_init_global() initialize the dgap_board
that is a global variable as static and dgap_poll_timer.
But init_timer() is called twice in dgap_start() and dgap_board
doesn't need to be initialized to NULL.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |
On Tue, Nov 04, 2014 at 08:07:01AM +0900, DaeSeok Youn wrote:
> Greg,
>
> check this patch, please.
> This patch was rebased on staging-testing tree.
>
> Thanks.
>
> regards,
> Daeseok Youn
>
>
> 2014-10-31 10:20 GMT+09:00 Daeseok Youn :
3 days after sending this? Please give me a chance, I
Hi,
2014-10-31 5:33 GMT+09:00 Greg KH :
> On Thu, Oct 30, 2014 at 12:14:00PM +0900, Daeseok Youn wrote:
>> Re-arrange the functions for removing forward declarations.
>>
>> Tested-by: Mark Hounschell
>> Signed-off-by: Daeseok Youn
>> Tested-by: Mark Hounschell
>> ---
>> V2: this patch is rebase
On Thu, Oct 30, 2014 at 12:14:00PM +0900, Daeseok Youn wrote:
> Re-arrange the functions for removing forward declarations.
>
> Tested-by: Mark Hounschell
> Signed-off-by: Daeseok Youn
> Tested-by: Mark Hounschell
> ---
> V2: this patch is rebased on staging-next branch.
Still doesn't apply :(
Hi,
2014-10-29 18:22 GMT+09:00 Greg KH :
> On Sun, Oct 26, 2014 at 11:08:54AM +0900, Daeseok Youn wrote:
>> Re-arrange the functions for removing forward declarations.
>>
>> Tested-by: Mark Hounschell
>> Signed-off-by: Daeseok Youn
>> ---
>> RESEND: This patch is tested all by Mark.
>> It is g
On 10/29/2014 05:22 AM, Greg KH wrote:
On Sun, Oct 26, 2014 at 11:08:54AM +0900, Daeseok Youn wrote:
Re-arrange the functions for removing forward declarations.
Tested-by: Mark Hounschell
Signed-off-by: Daeseok Youn
---
RESEND: This patch is tested all by Mark.
It is good to merge. Greg, chec
On Sun, Oct 26, 2014 at 11:08:54AM +0900, Daeseok Youn wrote:
> Re-arrange the functions for removing forward declarations.
>
> Tested-by: Mark Hounschell
> Signed-off-by: Daeseok Youn
> ---
> RESEND: This patch is tested all by Mark.
> It is good to merge. Greg, check please.
It doesn't apply
On 10/14/2014 08:01 AM, Mark Hounschell wrote:
On 10/13/2014 10:04 PM, Greg KH wrote:
On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote:
On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
Hi,
2014-10-13 12:25 GMT+09:00 Greg KH :
On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok
On Mon, Oct 13, 2014 at 07:19:38PM -0700, Joe Perches wrote:
> I don't know of a way to compare objects when functions are
> rearranged in the source file.
>
> Anyone else?
I have a perl script that I use to review function movement. It barfed
on the DaeSeok's original patch so I re-wrote it, bu
On 10/13/2014 10:04 PM, Greg KH wrote:
On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote:
On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
Hi,
2014-10-13 12:25 GMT+09:00 Greg KH :
On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:
Re-arrange the functions for remov
Hi,
2014-10-14 11:19 GMT+09:00 Joe Perches :
> On Tue, 2014-10-14 at 04:04 +0200, Greg KH wrote:
>> On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote:
>> > On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
>> > > 2014-10-13 12:25 GMT+09:00 Greg KH :
>> > > > On Mon, Oct 13, 2014 at
On Tue, 2014-10-14 at 04:04 +0200, Greg KH wrote:
> On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote:
> > On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
> > > 2014-10-13 12:25 GMT+09:00 Greg KH :
> > > > On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:
> > > >> Re-ar
On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote:
> On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
> > Hi,
> >
> > 2014-10-13 12:25 GMT+09:00 Greg KH :
> > > On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:
> > >> Re-arrange the functions for removing forward declar
Hi,
2014-10-13 23:56 GMT+09:00 Joe Perches :
> On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
>> Hi,
>>
>> 2014-10-13 12:25 GMT+09:00 Greg KH :
>> > On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:
>> >> Re-arrange the functions for removing forward declarations.
>> >>
>> >> S
1 - 100 of 720 matches
Mail list logo
