On Fri, Jul 17, 2015 at 03:21:28PM +0530, Sudip Mukherjee wrote: > On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote: > > I don't think I like these at all. remove_one has always been buggy in > > that it removes everything. We should fix it to only remove one instead > > of formalizing the currect terrible behavior. > Its already applied. > I thought after the full series the code became a little better than the > original one.
It looks nicer but it's wrong. > Now dgap_stop() is being called from dgap_remove_one(). How do you suggest > it should be? dgap_remove_one() should mirror dgap_init_one(). dgap_stop() should only be called from dgap_cleanup_module(). dgap_cleanup_module() should mirror dgap_init_module(). regards, dan carpenter _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
