net/wireless/realtek/rtlwifi/rtl8821ae/fw.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/fw.c
[]
> @@ -162,8 +161,8 @@ static int _rtl8821ae_fw_free_to_go(struct ieee80211_hw
> *hw)
> goto exit;
> }
>
> - RT_TRACE(rtlpriv, COMP_FW, DBG_EMERG,
>
sent, and remove the
module name from the format. It is already specified by a pr_fmt().
---
.../net/wireless/realtek/rtlwifi/rtl8821ae/dm.c| 3 +-
.../net/wireless/realtek/rtlwifi/rtl8821ae/fw.c| 11 ++
.../net/wireless/realtek/rtlwifi/rtl8821ae/hw.c| 15 +++-
.../net
This is a step toward eliminating the RT_TRACE macros. Those calls that
have DBG_EMERG as the level are always logged, and they represent error
conditions, thus they are replaced with pr_err().
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
---
.../net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
This is a step toward eliminating the RT_TRACE macros. Those calls that
have DBG_EMERG as the level are always logged, and they represent error
conditions, thus they are replaced with pr_err().
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
---
.../net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
The driver for RTL8821AE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
V3 - No changes.
This patch requires ("rtlwifi: Add mi
The driver for RTL8821AE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
V2 - Fixes bug found after V1 was submitted.
This patch requires ("rtlwifi: Add missing newlines to RT_
The driver for RTL8821AE chips is converted to use the common routine
for getting the hardware information.
Reported-by: Arnd Bergmann
Signed-off-by: Larry Finger
Cc: Arnd Bergmann
---
.../net/wireless/realtek/rtlwifi/rtl8821ae/hw.c| 84 +++---
1 file changed, 11
Andrianov
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
index 17a6817..35c6f8a 100644
--- a/drivers/net/wireless/realtek/rtlwifi
Smatch reports the following:
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:1960
rtl8812ae_dm_txpower_tracking_callback_thermalmeter() warn: inconsistent
indenting
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8821ae/trx.c
> When driver rtl8821ae is loaded but not connected to any AP, it logs
> a "firmware not ready to run" message roughly once a minute. To
> eliminate logging this massage under normal debug conditions, the
> degug level needed to print this message is increased.
>
>
49 during the conversion.
Signed-off-by: Larry Finger
---
Kalle,
This material is for kernel 4.6.
Larry
.../net/wireless/realtek/rtlwifi/rtl8821ae/hw.c| 18 ---
.../net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 27 +-
drivers/net/wireless/realtek/rtlw
When driver rtl8821ae is loaded but not connected to any AP, it logs
a "firmware not ready to run" message roughly once a minute. To
eliminate logging this massage under normal debug conditions, the
degug level needed to print this message is increased.
Signed-off-by: Larry Finger
> Recently, it has been reported that D-Link DWA-582 cards, which use an
> RTL8812AE chip are not able to scan for 5G networks. The problems started
> with kernel 4.2, which is the first version that had commit d10101a60372
> ("rtlwifi: rtl8821ae: Fix problem with regulatory in
lwifi: rtl8821ae: Fix problem with regulatory information"). With this
patch, the driver went from setting a default channel plan to using
the value derived from EEPROM.
Bug reports at https://bugzilla.kernel.org/show_bug.cgi?id=111031 and
https://bugzilla.redhat.com/show_bug.cgi?id=1279653 are e
Larry Finger writes:
> Recently, it has been reported that D-Link DWA-582 cards, which use an
> RTL8812AE chip are not able to scan for 5G networks. The problems started
> with kernel 4.2, which is the first version that had commit d10101a60372
> ("rtlwifi: rtl8821ae: Fix proble
Recently, it has been reported that D-Link DWA-582 cards, which use an
RTL8812AE chip are not able to scan for 5G networks. The problems started
with kernel 4.2, which is the first version that had commit d10101a60372
("rtlwifi: rtl8821ae: Fix problem with regulatory information"). With
of the parameters.
Signed-off-by: Larry Finger
Cc: Stable
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c
b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae
> In commit 54328e64047a5 ("rtlwifi: rtl8821ae: Fix system lockups on boot"),
> an attempt was made to fix a regression introduced in commit 1277fa2ab2f9
> ("rtlwifi: Remove the clear interrupt routine from all drivers").
> Unfortunately, there were logic err
On 11/12/2015 01:54 PM, Kalle Valo wrote:
Larry Finger writes:
In commit 54328e64047a5 ("rtlwifi: rtl8821ae: Fix system lockups on boot"),
an attempt was made to fix a regression introduced in commit 1277fa2ab2f9
("rtlwifi: Remove the clear interrupt routine from all drivers&q
Larry Finger writes:
> In commit 54328e64047a5 ("rtlwifi: rtl8821ae: Fix system lockups on boot"),
> an attempt was made to fix a regression introduced in commit 1277fa2ab2f9
> ("rtlwifi: Remove the clear interrupt routine from all drivers").
> Unfortunately,
In commit 54328e64047a5 ("rtlwifi: rtl8821ae: Fix system lockups on boot"),
an attempt was made to fix a regression introduced in commit 1277fa2ab2f9
("rtlwifi: Remove the clear interrupt routine from all drivers").
Unfortunately, there were logic errors in that patch that prev
> In commit 1277fa2ab2f9 ("rtlwifi: Remove the clear interrupt routine from all
> drivers"), the code that cleared all interrupt enable bits before setting them
> was removed for all PCI drivers. This fixed an issue that caused TX to be
> blocked for 3-5 seconds. On some
In commit 1277fa2ab2f9, the code that cleared all interrupt enable
bits before setting them was removed for all PCI drivers. This fixed an
issue that caused TX to be blocked for 3-5 seconds. On some RTL8821AE units,
this change causes soft lockups to occur on boot. For that reason, the portion
of
This patch fixes the following sparse warnings:
drivers/staging/rtl8821ae/pci.c:52:4: warning: symbol '_rtl_mac_to_hwqueue' was
not declared. Should it be static?
drivers/staging/rtl8821ae/pci.c:365:6: warning: symbol
'rtl_pci_check_buddy_priv' was not declared. Should i
Several pointer declaration syntax have been fixed to match the coding style.
Signed-off-by: Fabien Malfoy
---
drivers/staging/rtl8821ae/efuse.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8821ae/efuse.c
b/drivers/staging/rtl8821ae
Several pointer declaration syntax have been fixed to match the coding style.
Signed-off-by: Fabien Malfoy
---
drivers/staging/rtl8821ae/efuse.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8821ae/efuse.c
b/drivers/staging/rtl8821ae
Fix checkpatch.pl '"(foo*)" should be "(foo *)"' errors
Signed-off-by: Greg Donald
---
drivers/staging/rtl8821ae/base.h | 26 +++---
drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c | 8 +++----
drivers/staging/rtl8821ae
Signed-off-by: Andreas Schlick
---
drivers/staging/rtl8821ae/rtl8821ae/hw.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hw.c
b/drivers/staging/rtl8821ae/rtl8821ae/hw.c
index 1aa1661..0539105 100644
--- a/drivers/staging
Fix checkpatch.pl "space required before that '*'" errors
Signed-off-by: Greg Donald
---
drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.h | 6 +++---
drivers/staging/rtl8821ae/btcoexist/habtc8723a1ant.h | 6 +++---
drivers/staging/rtl8821ae/btcoexist/h
Add a missing blank line after declaration to fix coding style issue.
Signed-off-by: An Ha
---
drivers/staging/rtl8821ae/base.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8821ae/base.c b/drivers/staging/rtl8821ae/base.c
index 4a36da0..dbf28ce 100644
--- a/drivers
Signed-off-by: An Ha
---
.../staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c| 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
index 13cc5ba..d587072 100644
-
Fix pointer placement coding style issue, where using "foo *" is
preferable over "foo*".
Signed-off-by: An Ha
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae
Fix coding style issue which requires a blank line after declarations.
Signed-off-by: An Ha
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
b/drivers/staging/rtl8821ae/rtl8821ae
a quoted newline.
Signed-off-by: An Ha
---
.../staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 84 +++---
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
index cff30
Fix commenting style from C99 comments to C89 comments
Signed-off-by: An Ha
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
b/drivers/staging/rtl8821ae/rtl8821ae
On Tue, Sep 02, 2014 at 07:22:12AM -0400, An Tuan Ha wrote:
> I see, thanks, I will fix it, I was just worried about the subjects
> being too long so I just stuck with the same subject; is there a
> character limit on how long the subject line should be? Or as long as
> it's reasonable, it'll be fi
I see, thanks, I will fix it, I was just worried about the subjects
being too long so I just stuck with the same subject; is there a
character limit on how long the subject line should be? Or as long as
it's reasonable, it'll be fine?
On Tue, Sep 02, 2014 at 12:19:40PM +0300, Dan Carpenter wrote:
Hm... Now you've broken it into *too* many separate patches. Also the
subjects are the same. Also the subjects are too vague. Which coding
style issue is addressed?
It should be something like:
patch 1: comments
patch 2: add/remove spaces
patch 3: fix quoted text
patch 4: braces
patch 5: add a
Fix coding style issue where the open curly brace '{' should be on
the same line as the if statement.
Signed-off-by: An Ha
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae
Fix pointer placement coding style issue, where using "foo *" is
preferable over "foo*".
Signed-off-by: An Ha
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae
Remove unnecessary whitespace before a quoted newline.
Signed-off-by: An Ha
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
b/drivers/staging/rtl8821ae
Fix coding style issue which requires a blank line after declarations.
Signed-off-by: An Ha
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
b/drivers/staging/rtl8821ae/rtl8821ae
Fix coding style issue which requires a space before the open
curly brace '{'.
Signed-off-by: An Ha
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
Fix coding style issue where the else conditional statement should
follow the closing curly brace '}'.
Signed-off-by: An Ha
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae
Fix coding style issue which requires a space after the equal sign '='.
Signed-off-by: An Ha
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
b/drive
Fix coding style issue where the if statement unnecessarily uses curly
braces for one line statements.
Signed-off-by: An Ha
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8821ae
Fix commenting style from C99 comments to C89 comments
Signed-off-by: An Ha
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
b/drivers/staging/rtl8821ae/rtl8821ae
Fix coding style issue which requires a space after the open
parenthesis '('.
Signed-off-by: An Ha
---
.../staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 50 +++---
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/rtl8821ae
Fix coding style issue which requires a space after a comma.
Signed-off-by: An Ha
---
.../staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 26 +++---
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
b/drivers
Remove whitespace after open parenthesis '('.
Signed-off-by: An Ha
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
b/drivers/staging/rtl8821ae
On Sat, Aug 30, 2014 at 02:10:52PM -0400, An Ha wrote:
> Fix coding style issues, these changes include:
> -Add space between "if" and brackets
> -Add space after comma in an argument
> -Add space between equal sign to separate the variable and the assignment
> -Remove unnecessary curly braces arou
On Sat, Aug 23, 2014 at 10:55:51AM +0800, Hoang Tran wrote:
> This patch fixes the following sparse warnings in rtl8821ae/stats.c
>
> drivers/staging/rtl8821ae/stats.c:62:6: warning: symbol 'rtl_translate_todbm'
> was not declared. Should it be static?
> drivers/stagin
ts to C89 comments
Signed-off-by: An Ha
---
.../staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 102 ++---
1 file changed, 49 insertions(+), 53 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
On Mon, 2014-08-25 at 06:35 -0500, Greg Donald wrote:
> Fix checkpatch.pl spaces required around that '?' errors
It'd be better to convert all parts of the
ternary at the same time.
> diff --git a/drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c
> b/drivers/sta
On Mon, 2014-08-25 at 08:51 -0500, Greg Donald wrote:
> On Mon, Aug 25, 2014 at 8:15 AM, Joe Perches wrote:
> > On Mon, 2014-08-25 at 06:35 -0500, Greg Donald wrote:
> >> Fix checkpatch.pl spaces required around that '?' errors
> >
> > It'd be better to convert all parts of the
> > ternary at the
On Mon, Aug 25, 2014 at 8:15 AM, Joe Perches wrote:
> On Mon, 2014-08-25 at 06:35 -0500, Greg Donald wrote:
>> Fix checkpatch.pl spaces required around that '?' errors
>
> It'd be better to convert all parts of the
> ternary at the same time.
Wouldn't "at the same time" be in direct conflict with
Fix checkpatch.pl spaces required around that '?' errors
Signed-off-by: Greg Donald
---
.../staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c | 33 +++---
.../staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.h | 2 +-
.../staging/rtl8821ae/btcoexist/habtc8723a1ant.c | 12 ++---
.
Fix checkpatch.pl spaces required around that '<' errors
Signed-off-by: Greg Donald
---
drivers/staging/rtl8821ae/btcoexist/halbtc8723b2ant.c | 2 +-
drivers/staging/rtl8821ae/rtl8821ae/phy.c | 18 +-
drivers/staging/rtl8821ae/rtl8821ae/rf.c
This patch fixes the following sparse warnings in rtl8821ae/stats.c
drivers/staging/rtl8821ae/stats.c:62:6: warning: symbol 'rtl_translate_todbm'
was not declared. Should it be static?
drivers/staging/rtl8821ae/stats.c:101:6: warning: symbol 'rtl_process_ui_rssi'
was not de
On Aug 20, 2014 at 06:19am, Greg Kroah-Hartman wrote:
> On Wed, Aug 20, 2014 at 04:53:22PM +0800, Hoang Tran wrote:
> > This patch fixes the following sparse warnings in rtl8821ae/stats.c
> >
> > drivers/staging/rtl8821ae/stats.c:62:6: warning: symbol
> > 'rtl_t
This patch fixes the following sparse warnings in rtl8821ae/stats.c
drivers/staging/rtl8821ae/stats.c:62:6: warning: symbol 'rtl_translate_todbm'
was not declared. Should it be static?
drivers/staging/rtl8821ae/stats.c:101:6: warning: symbol 'rtl_process_ui_rssi'
was not de
On Wed, Aug 20, 2014 at 04:53:22PM +0800, Hoang Tran wrote:
> This patch fixes the following sparse warnings in rtl8821ae/stats.c
>
> drivers/staging/rtl8821ae/stats.c:62:6: warning: symbol 'rtl_translate_todbm'
> was not declared. Should it be static?
> drivers/stagin
This patch fixes the following sparse warnings in rtl8821ae/stats.c
drivers/staging/rtl8821ae/stats.c:62:6: warning: symbol 'rtl_translate_todbm'
was not declared. Should it be static?
drivers/staging/rtl8821ae/stats.c:101:6: warning: symbol 'rtl_process_ui_rssi'
was not de
This patch fixes the following sparse warnings in rtl8821ae/stats.c
drivers/staging/rtl8821ae/stats.c:62:6: warning: symbol 'rtl_translate_todbm'
was not declared. Should it be static?
drivers/staging/rtl8821ae/stats.c:101:6: warning: symbol 'rtl_process_ui_rssi'
was not de
On Wed, Aug 13, 2014 at 01:06:16AM +0530, Himangi Saraogi wrote:
> Hi,
>
> In the file, I see the code:
>
> void rtl8821ae_dm_set_tx_ant_by_tx_
> info(...) {
> ...
> if ((rtlefuse->antenna_div_type == CG_TRX_HW_ANTDIV) ||
> (rtlefuse->antenna_div_type == CG_TRX_HW_ANTDIV)){
> SET_T
Signed-off-by: Hans Wennborg
---
drivers/staging/rtl8821ae/pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8821ae/pci.c b/drivers/staging/rtl8821ae/pci.c
index 26d7b2f..b818788 100644
--- a/drivers/staging/rtl8821ae/pci.c
+++ b/drivers/staging
Fixed a coding style issue.
Signed-off-by: Sylvain Calador
---
drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.h
b/drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.h
ior starts as soon as Linux is booted and logged in. Saw same behavior
>> on
>> 13.32 and earlier kernel versions. Using the latest bios upgrade.
>>
>> Keywords: RTL8821AE, TX201LA, Asus Trio
>>
>> In addition to the environment info below, I include a copy o
behavior on
> 13.32 and earlier kernel versions. Using the latest bios upgrade.
>
> Keywords: RTL8821AE, TX201LA, Asus Trio
>
> In addition to the environment info below, I include a copy of dmesg which
> shows the behavior.
>
> Linux version 3.15.6-031506-generic (apw
On 07/15, Kevin Folz wrote:
> Hello,
>
>
>
> I noticed you two have worked on the staging rtl8821ae driver.
>
>
>
> I wrote to the mailing list last month, but have yet to receive a
> response.
>
> http://permalink.gmane.org/gmane.linux.kernel.wire
This is a patch to the cam.c file that removes some unneeded lines of
commented-out code
Signed-off-by: Joerg C. Meyer
---
drivers/staging/rtl8821ae/cam.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8821ae/cam.c b/drivers/staging/rtl8821ae/cam.c
index 3bc6b3d
On Mon, Jul 14, 2014 at 04:09:26PM +0200, Joerg C. Meyer wrote:
> This is a patch to the cam.c file that removes some obsolete C99 style
> comments
>
> Signed-off-by: Joerg C. Meyer
4 copies of the same patch?
Anyway, this text doesn't match what the patch actually does (deleted
unneeded lines
This is a patch to the cam.c file that removes some obsolete C99 style comments
Signed-off-by: Joerg C. Meyer
---
drivers/staging/rtl8821ae/cam.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8821ae/cam.c b/drivers/staging/rtl8821ae/cam.c
index 3bc6b3d..6185ea4
On Mon, Jul 14, 2014 at 11:42:33AM +0200, Joerg C. Meyer wrote:
> This is a patch to the cam.c file that fix a coding style error (do not use
> C99 // comments)
> Signed-off-by: Joerg C. Meyer
Minor nit, you need a blank line between these two lines...
> ---
> drivers/staging/
This is a patch to the cam.c file that fix a coding style error (do not use C99
// comments)
Signed-off-by: Joerg C. Meyer
---
drivers/staging/rtl8821ae/cam.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8821ae/cam.c b/drivers/staging
On Sun, Jul 13, 2014 at 11:47:57PM +0200, Joerg C. Meyer wrote:
> Signed-off-by: Joerg C. Meyer
Your changelog body ended up in the Subject: line (that happens if you
don't put a blank line after the first line in your git commit.
Also, you don't say _what_ issues you fixed here, please be speci
Signed-off-by: Joerg C. Meyer
---
drivers/staging/rtl8821ae/cam.c | 57 +++--
1 file changed, 27 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/rtl8821ae/cam.c b/drivers/staging/rtl8821ae/cam.c
index 3bc6b3d..835bc3b 100644
--- a/drivers/staging
On Sun, Jul 6, 2014 at 5:01 AM, Sami Laine wrote:
> From: Sami Laine
>
> Sparse warning corrections for:
>
> drivers/staging/rtl8821ae/base.c:1370:16: warning: symbol
> 'rtl_make_smps_action' was not declared. Should it be static?
> drivers/staging/rtl8821ae
On Sun, Jul 06, 2014 at 12:05:53PM +0300, Sami Laine wrote:
> From: Sami Laine
>
> Sparse warning correction:
>
> vers/staging/rtl8821ae/debug.c:80:23: warning: symbol 'proc_topdir' was
> not declared. Should it be static?
>
> Signed-off-by: Sami Laine
&g
On Sun, Jul 06, 2014 at 12:01:11PM +0300, Sami Laine wrote:
> From: Sami Laine
>
> Sparse warning corrections for:
>
> drivers/staging/rtl8821ae/base.c:1370:16: warning: symbol
> 'rtl_make_smps_action' was not declared. Should it be static?
> drivers/staging/r
On Wed, Jul 09, 2014 at 02:34:12AM +0200, Mario wrote:
> linux-next.git-v3.14-drivers-staging rtl8821ae "in conjunction with their"
>
> linux-firmware-4c7327a35767c2133600376380c867dff3cbaa1c-rtlwifi "
>
> It went wonderfully with uname-r (3.14.3-200.fc20.x86_64)
From: Sami Laine
Sparse warning correction:
vers/staging/rtl8821ae/debug.c:80:23: warning: symbol 'proc_topdir' was
not declared. Should it be static?
Signed-off-by: Sami Laine
---
diff --git a/drivers/staging/rtl8821ae/debug.c b/drivers/staging/rtl8821ae/debug
index 8aefbf1..e4a1
From: Sami Laine
Sparse warning corrections for:
drivers/staging/rtl8821ae/base.c:1370:16: warning: symbol
'rtl_make_smps_action' was not declared. Should it be static?
drivers/staging/rtl8821ae/base.c:1543:6: warning: symbol 'rtl_find_221_ie' was
not declared. Should i
struct rtl_stats is rather huge (152 bytes), and since
rtl8812ae_rx_command_packet_handler() does not modify it, it might as
well be passed by const reference.
Reported by Coverity: CID 1167285
Signed-off-by: Rasmus Villemoes
---
drivers/staging/rtl8821ae/pci.c | 2 +-
drivers/staging
Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required
Cc: Greg Kroah-Hartman
Cc: Sarah Sharp
Cc: de...@driverdev.osuosl.org
Signed-off-by: Fabian Frederick
---
drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
This is all #if 0'ed out, and it contains some rather weird stuff
(post-increment of a bool, for example). Nuke it.
Signed-off-by: Rasmus Villemoes
---
drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/rtl8
e, so this obviously doesn't change anything.
> >
> > How about just deleting all the #if 0 code out entirely so no one has to
> > worry about it anymore?
>
> Fine by me. Like this?
>
> From: Rasmus Villemoes
> Subject: [PATCH] drivers/staging/rtl8821ae/rtl882
e #if 0 code out entirely so no one has to
> worry about it anymore?
Fine by me. Like this?
From: Rasmus Villemoes
Subject: [PATCH] drivers/staging/rtl8821ae/rtl8821ae: Remove dead code
This is all #if 0'ed out, and it contains some rather weird stuff
(post-increment of a bool, for ex
On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote:
> All of the code is #if 0'd out, and the change just replaces a
> space with a newline, so this obviously doesn't change anything.
How about just deleting all the #if 0 code out entirely so no one has to
worry about it anymore?
th
sing -- is equivalent to flipping it).
Signed-off-by: Rasmus Villemoes
---
drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c
b/drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c
ind
On 06/20/2014 02:20 AM, Greg KH wrote:
> On Mon, Jun 16, 2014 at 07:35:34PM +0200, Toralf Förster wrote:
>> comments were translated with https://translate.google.com/
>> this enables python to parse that file right
>
> This patch fails to apply :(
>
>
seems, that the CR at line 3741 is a the cu
On Mon, Jun 16, 2014 at 07:35:34PM +0200, Toralf Förster wrote:
> comments were translated with https://translate.google.com/
> this enables python to parse that file right
This patch fails to apply :(
___
devel mailing list
de...@linuxdriverproject.org
On Sat, Jun 14, 2014 at 07:36:31PM +0200, Toralf Förster wrote:
> The html formatter of the static checker Cppcheck stumbles over that file. In
> fact, even this small python snippet :
>
> #!/usr/bin/env python
>
> import io
>
> source_filename = "./driver
The html formatter of the static checker Cppcheck stumbles over that file. In
fact, even this small python snippet :
#!/usr/bin/env python
import io
source_filename = "./drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c";
try:
with io.open(source_filename, 'r&
On Sun, Jun 08, 2014 at 01:37:43PM -0700, David Rientjes wrote:
> > drivers/staging/rtl8821ae/rtl8821ae/hw.c |2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hw.c
> > b/drivers/staging/rtl8
On Wed, Jun 04, 2014 at 07:45:45PM +0200, Remi Pommarel wrote:
> This removes stack arrays of variable length and use kmalloc() instead, thus
> removing the sparse warnings "Variable length array is used".
>
> Signed-off-by: Remi Pommarel
> ---
> drivers/st
I find a logical error in an if statement '(X & 0xfc) == 0x3' is always false
After pointing this out, Larry Finger informed what would be the correct one.
'(X & 0x3) == 0x3'
Signed-off-by: Rickard Strandqvist
---
drivers/staging/rtl8821ae/rtl8821ae/hw.c |2 +-
This removes stack arrays of variable length and use kmalloc() instead, thus
removing the sparse warnings "Variable length array is used".
Signed-off-by: Remi Pommarel
---
drivers/staging/rtl8821ae/efuse.c | 38 +++---
1 file changed, 31 insert
This commit fixes the following sparse warnings in ps.c:
- 702: warning: symbol 'rtl_p2p_noa_ie' was not declared. Should it be static?
- 802: warning: symbol 'rtl_p2p_action_ie' was not declared. Should it be
static?
Signed-off-by: Marcus Farkas
---
drivers/stagin
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/stats.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/stats.c
b/drivers/staging/rtl8821ae/stats.c
index
1 - 100 of 204 matches
Mail list logo
