Re: [PATCHv2] staging: rts5208: remove variable and check directly

2015-06-01 Thread Gujulan Elango, Hari Prasath (H.)
On Mon, Jun 01, 2015 at 02:02:06PM +0300, Dan Carpenter wrote: > On Mon, Jun 01, 2015 at 10:27:35AM +, Gujulan Elango, Hari Prasath (H.) > wrote: > > On Mon, Jun 01, 2015 at 01:12:18PM +0300, Dan Carpenter wrote: > > > On Mon, Jun 01, 2015 at 09:41:52AM +, Gujulan Elango, Hari Prasath > >

Re: [PATCHv2] staging: rts5208: remove variable and check directly

2015-06-01 Thread Dan Carpenter
On Mon, Jun 01, 2015 at 10:27:35AM +, Gujulan Elango, Hari Prasath (H.) wrote: > On Mon, Jun 01, 2015 at 01:12:18PM +0300, Dan Carpenter wrote: > > On Mon, Jun 01, 2015 at 09:41:52AM +, Gujulan Elango, Hari Prasath (H.) > > wrote: > > > From: Hari Prasath Gujulan Elango > > > > > > This

Re: [PATCHv2] staging: rts5208: remove variable and check directly

2015-06-01 Thread Gujulan Elango, Hari Prasath (H.)
On Mon, Jun 01, 2015 at 01:12:18PM +0300, Dan Carpenter wrote: > On Mon, Jun 01, 2015 at 09:41:52AM +, Gujulan Elango, Hari Prasath (H.) > wrote: > > From: Hari Prasath Gujulan Elango > > > > This trivial patch removes temporary variable to check return value of > > a function and checks ret

Re: [PATCHv2] staging: rts5208: remove variable and check directly

2015-06-01 Thread Dan Carpenter
On Mon, Jun 01, 2015 at 09:41:52AM +, Gujulan Elango, Hari Prasath (H.) wrote: > From: Hari Prasath Gujulan Elango > > This trivial patch removes temporary variable to check return value of > a function and checks return value directly. > This isn't an improvement. We want to adopt normal