Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

2017-02-16 Thread SIMRAN SINGHAL
I didn't mean what you get. I just want to say I am a beginner and like to contribute to Linux kernel. But at present, I am in learning mode. I never mean that I am doing this for learning C or C++ but yes for contributing to Linux kernel in every possible way. And, would be very happy if you gui

Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

2017-02-16 Thread Greg KH
On Wed, Feb 15, 2017 at 01:48:13PM +0530, SIMRAN SINGHAL wrote: > On Wed, Feb 15, 2017 at 9:01 AM, Joe Perches wrote: > > On Wed, 2017-02-15 at 08:52 +0530, SIMRAN SINGHAL wrote: > >> Yes, I totally agree with joe. > >> > >> But as there is no coding style issue in this patch. > > > > Style is mor

Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

2017-02-15 Thread Joe Perches
On Wed, 2017-02-15 at 13:48 +0530, SIMRAN SINGHAL wrote: > Joe, I am new to Linux kernel and just have basic knowledge of > C and C++. > For doing more than checkpatches I need to explore Linux kernel more, > so please suggest me some tasks that help me in exploring > Linux kernel, which helps me

Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

2017-02-15 Thread SIMRAN SINGHAL
On Wed, Feb 15, 2017 at 9:01 AM, Joe Perches wrote: > On Wed, 2017-02-15 at 08:52 +0530, SIMRAN SINGHAL wrote: >> Yes, I totally agree with joe. >> >> But as there is no coding style issue in this patch. > > Style is more than just checkpatch conformity. > >> So, do I have to resend the complete p

Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

2017-02-14 Thread Joe Perches
On Wed, 2017-02-15 at 08:52 +0530, SIMRAN SINGHAL wrote: > Yes, I totally agree with joe. > > But as there is no coding style issue in this patch. Style is more than just checkpatch conformity. > So, do I have to resend the complete patch series again? I'm not applying any of these so that's en

Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

2017-02-14 Thread SIMRAN SINGHAL
Yes, I totally agree with joe. But as there is no coding style issue in this patch. So, do I have to resend the complete patch series again? On Wed, Feb 15, 2017 at 1:53 AM, Joe Perches wrote: > On Wed, 2017-02-15 at 01:44 +0530, simran singhal wrote: > [] >> diff --git a/drivers/staging/rtl819

Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

2017-02-14 Thread Joe Perches
On Wed, 2017-02-15 at 01:44 +0530, simran singhal wrote: [] > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c > b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c [] > @@ -150,14 +150,15 @@ static inline char *rtl819x_translate_scan(struct > ieee80211_device *ieee, >

[PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

2017-02-14 Thread simran singhal
fixed errors and warnings: ERROR: spaces required around that '=' ERROR: spaces required around that '<' ERROR: space required before the open parenthesis '(' CHECK: spaces preferred around that '&' CHECK: spaces preferred around that '<<' ERROR: space required after that ',' ERROR: spaces required