On Wed, Oct 28, 2020 at 07:39:58PM -0400, Sven Van Asbroeck wrote:
> On Tue, Oct 27, 2020 at 2:34 PM Andy Shevchenko
> wrote:
> >
> > + return snprintf(buf, max_size, "%pM\n", response.addr);
>
> Judging from a few Outreachy patches that have hit my inbox, snprintf() is
> considered unsafe
Hi Andy, thank you for the patch !
On Tue, Oct 27, 2020 at 2:34 PM Andy Shevchenko
wrote:
>
> + return snprintf(buf, max_size, "%pM\n", response.addr);
Judging from a few Outreachy patches that have hit my inbox, snprintf() is
considered unsafe in a sysfs_get callback. It should be replace
Convert to %pM instead of using custom code.
Signed-off-by: Andy Shevchenko
---
v2: dropped struct removal (Sven), rebased on top of v5.10-rc1
drivers/staging/fieldbus/anybuss/hms-profinet.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/fieldbus/anybuss/
