Hi Andy, thank you for the patch !

On Tue, Oct 27, 2020 at 2:34 PM Andy Shevchenko
<andriy.shevche...@linux.intel.com> wrote:
>
> +       return snprintf(buf, max_size, "%pM\n", response.addr);

Judging from a few Outreachy patches that have hit my inbox, snprintf() is
considered unsafe in a sysfs_get callback. It should be replaced by
scnprintf() or even better, sysfs_emit(), which was recently introduced
to address sprintf-variant issues in sysfs callbacks.
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to