RE: [PATCH net-next 1/1] hyperv: Properly handle checksum offload

2014-04-25 Thread KY Srinivasan
..@vger.kernel.org; jasow...@redhat.com; linux- > ker...@vger.kernel.org; sta...@kernel.org; a...@canonical.com; > de...@linuxdriverproject.org; da...@davemloft.net > Subject: RE: [PATCH net-next 1/1] hyperv: Properly handle checksum offload > > > > > -Original Message

RE: [PATCH net-next 1/1] hyperv: Properly handle checksum offload

2014-04-25 Thread KY Srinivasan
...@aepfle.de; > a...@canonical.com; jasow...@redhat.com; sta...@kernel.org > Subject: Re: [PATCH net-next 1/1] hyperv: Properly handle checksum offload > > On Fri, 2014-04-25 at 17:43 -0700, Stephen Hemminger wrote: > > On Fri, 25 Apr 2014 11:45:14 -0700 > > "K. Y.

RE: [PATCH net-next 1/1] hyperv: Properly handle checksum offload

2014-04-25 Thread KY Srinivasan
...@aepfle.de; > a...@canonical.com; jasow...@redhat.com; sta...@kernel.org > Subject: Re: [PATCH net-next 1/1] hyperv: Properly handle checksum offload > > On Fri, 25 Apr 2014 11:45:14 -0700 > "K. Y. Srinivasan" wrote: > > > @@ -474,6 +477,9 @@ static int netvsc_star

Re: [PATCH net-next 1/1] hyperv: Properly handle checksum offload

2014-04-25 Thread Eric Dumazet
On Fri, 2014-04-25 at 17:43 -0700, Stephen Hemminger wrote: > On Fri, 25 Apr 2014 11:45:14 -0700 > "K. Y. Srinivasan" wrote: > > > @@ -474,6 +477,9 @@ static int netvsc_start_xmit(struct sk_buff *skb, > > struct net_device *net) > > csum_info = (struct ndis_tcp_ip_checksum_info *)((void *)pp

Re: [PATCH net-next 1/1] hyperv: Properly handle checksum offload

2014-04-25 Thread Stephen Hemminger
On Fri, 25 Apr 2014 11:45:14 -0700 "K. Y. Srinivasan" wrote: > @@ -474,6 +477,9 @@ static int netvsc_start_xmit(struct sk_buff *skb, struct > net_device *net) > csum_info = (struct ndis_tcp_ip_checksum_info *)((void *)ppi + > ppi->ppi_offset); > > + ip_hdr(skb)-

[PATCH net-next 1/1] hyperv: Properly handle checksum offload

2014-04-25 Thread K. Y. Srinivasan
Do checksum offload only if the client of the driver wants checksum to be offloaded. Also Windows hosts support ip header checksum offload as well - take advantage of that. This patch fixes a bug that is exposed in gateway scenarios. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang C